| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-17 | |||
| 02:00:21 | melwitt | s/funny/finally/ | |
| 07:11:07 | gibi | lyarwood: hi! regarding https://review.opendev.org/c/openstack/nova/+/796523 I'm sure I asked this before but forgot. Where do we have now the evacuation test coverage? | |
| 07:18:13 | opendevreview | Merged openstack/nova stable/rocky: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/c/openstack/nova/+/747612 | |
| 07:18:37 | opendevreview | Merged openstack/nova stable/wallaby: Neutron fixture: don't clobber profile and vif_details if empty https://review.opendev.org/c/openstack/nova/+/792233 | |
| 07:18:50 | opendevreview | Merged openstack/nova stable/wallaby: Test SRIOV port move operations with PCI conflicts https://review.opendev.org/c/openstack/nova/+/790710 | |
| 07:31:09 | opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 07:31:10 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 07:31:10 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 07:43:53 | lyarwood | melwitt: awesome :) I'll +1 only as I modified it | |
| 07:44:21 | lyarwood | gibi: it's part of the live migration jobs | |
| 07:44:32 | lyarwood | gibi: runs in the post playbook | |
| 07:45:32 | lyarwood | gibi: https://github.com/openstack/nova/tree/master/roles/run-evacuate-hook is the role we use | |
| 07:45:46 | lyarwood | gibi: https://github.com/openstack/nova/blob/master/playbooks/nova-live-migration/post-run.yaml is where it's called | |
| 07:46:10 | lyarwood | gibi: the logic being that we didn't want to stand up another multinode env every run to test evacuation | |
| 07:46:39 | lyarwood | gibi: doing it in post was easier as we didn't need to copy and paste any of the tempest playbook logic into Nova | |
| 07:50:13 | lyarwood | gibi: so for that review evacuation is tested from here https://zuul.opendev.org/t/openstack/build/057093756ca64ef994584e2cae50f537/log/job-output.txt#64392 | |
| 07:50:41 | opendevreview | Merged openstack/nova stable/victoria: Reproduce bug 1897528 https://review.opendev.org/c/openstack/nova/+/791767 | |
| 08:03:14 | gibi | lyarwood: thanks | |
| 08:03:22 | gibi | I hope I will not foget this again :) | |
| 08:14:00 | lyarwood | ^_^ | |
| 09:01:07 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 09:01:07 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 09:01:08 | opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 09:01:09 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 09:01:10 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 09:02:40 | opendevreview | Merged openstack/nova stable/victoria: Ignore PCI devices with 32bit domain https://review.opendev.org/c/openstack/nova/+/791768 | |
| 09:03:42 | yonglihe | rebase to fix dependency problem, that's weird. | |
| 09:19:39 | lyarwood | yonglihe: A pip dependency problem? We've seen loads that make no sense recently. | |
| 09:21:25 | stephenfin | lyarwood: it's a cache issue, I think | |
| 09:21:41 | lyarwood | oh the limestone thing? | |
| 09:21:44 | stephenfin | yeah, I think so | |
| 09:22:51 | lyarwood | wonderful | |
| 09:22:59 | stephenfin | it's failing with e.g. dep a requesting >=1.2 and upper constraints requesting == 3.0, which would pass unless 3.0 wasn't available | |
| 09:24:48 | stephenfin | hmm, maybe not actually - the error message I get locally is different | |
| 09:25:08 | lyarwood | ack thanks | |
| 09:25:19 | lyarwood | that makes sense now if the cache is borked | |
| 09:26:24 | stephenfin | yonglihe: the failure on https://review.opendev.org/c/openstack/nova/+/758944/ looks real? | |
| 09:26:33 | stephenfin | if vnic_type in network_model.VNIC_TYPES_ACCELERATOR: | |
| 09:26:33 | stephenfin | AttributeError: module 'nova.network.model' has no attribute 'VNIC_TYPES_ACCELERATOR' | |
| 09:26:37 | stephenfin | (from https://zuul.opendev.org/t/openstack/build/e08dc74546d34d9a8ee67e597ade8fb2) | |
| 09:28:37 | stephenfin | elodilles: lyarwood: Care to keep working through this backport series? The victoria patches have landed now and this is another clean backport https://review.opendev.org/q/topic:%2522bug/1897528%2522+branch:stable/ussuri | |
| 09:29:37 | lyarwood | ack looking | |
| 09:30:21 | lyarwood | elodilles: https://review.opendev.org/c/openstack/nova/+/796626 - can you also take a look at this on master if you get a chance, moving the cherry-pick script out of pep8. | |
| 09:32:55 | elodilles | sure, looking at the patches :) | |
| 09:42:49 | gibi | lyarwood, stephenfin: yesterday infra turned off limestone due to the pip cache issue | |
| 09:43:09 | gibi | so we should not see these nonsensical req conflicts | |
| 09:43:13 | gibi | any more today | |
| 09:45:51 | yonglihe | stephenfin, that's because that patch lost the decency to second patch, fixed. | |
| 09:45:53 | lyarwood | wonderful | |
| 09:46:26 | lyarwood | gibi: https://bugs.launchpad.net/cinder/+bug/1932287 just caught this if you see any random volume creation failures today | |
| 09:47:30 | gibi | lyarwood: thanks, I haven't seen that issue yet | |
| 09:47:31 | opendevreview | Merged openstack/nova stable/rocky: Remove allocations before setting vm_status to SHELVED_OFFLOADED https://review.opendev.org/c/openstack/nova/+/771985 | |
| 09:48:35 | stephenfin | elodilles: Yeah, as lyarwood said, we need to move the cherry-pick change out of the pep8 job. I hadn't seen that failure | |
| 09:50:31 | gibi | lyarwood: with the exit code 139 lvs complains about missing devices and that I saw before | |
| 09:50:56 | lyarwood | yeah https://review.opendev.org/c/openstack/cinder/+/783660 fixed it elsewhere | |
| 09:51:01 | lyarwood | just not in this path | |
| 09:51:44 | gibi | lyarwood: cool, then we have a way forward | |
| 09:51:55 | opendevreview | Stephen Finucane proposed openstack/nova stable/ussuri: Reproduce bug 1897528 https://review.opendev.org/c/openstack/nova/+/791770 | |
| 09:51:56 | opendevreview | Stephen Finucane proposed openstack/nova stable/ussuri: Ignore PCI devices with 32bit domain https://review.opendev.org/c/openstack/nova/+/791771 | |
| 09:52:06 | stephenfin | elodilles: lyarwood: fixed the pep8 failure ^ | |
| 09:52:58 | gibi | lyarwood: I'm hitting https://bugs.launchpad.net/nova/+bug/1912310 many times now and almost always in the test_volume_backed_live_migration tempest test. Wondering if it worth to disable that test until ovsdbapp fix lands | |
| 09:53:06 | opendevreview | Stephen Finucane proposed openstack/nova stable/train: Reproduce bug 1897528 https://review.opendev.org/c/openstack/nova/+/792116 | |
| 09:53:07 | opendevreview | Stephen Finucane proposed openstack/nova stable/train: Ignore PCI devices with 32bit domain https://review.opendev.org/c/openstack/nova/+/792117 | |
| 09:53:22 | stephenfin | and the train ones are updated now too | |
| 09:57:33 | lyarwood | gibi: ack lets do it, I'll disable them now | |
| 10:04:22 | opendevreview | Lee Yarwood proposed openstack/nova master: zuul: Skip volume backed LM tests until bug #1912310 is resolved https://review.opendev.org/c/openstack/nova/+/796813 | |
| 10:04:29 | lyarwood | gibi: ^ hopefully that's enough, if it isn't then we might want to move the LM jobs to non-voting | |
| 10:11:15 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Reintroduce validation of shadow table schema https://review.opendev.org/c/openstack/nova/+/796814 | |
| 10:11:39 | stephenfin | lyarwood: gibi: one final one, as requested ^ | |
| 10:12:38 | gibi | lyarwood: thanks | |
| 10:13:05 | elodilles | stephenfin: actually i was surprised that pep8 is failing in ussuri because of py27/six problem as py27 should be supported only up until train :-o | |
| 10:13:43 | stephenfin | elodilles: yeah, we simply weren't aggressive enough in dropping the no-longer relevant hacking checks | |
| 10:13:54 | elodilles | oh, i see | |
| 10:15:02 | stephenfin | I would personally like to backport the patch that dropped the check, but I don't know what you think about that. I can't imagine that would violate stable policy since it's nothing to do with production code | |
| 10:15:26 | stephenfin | (commit 9dca0d186f834c38d0d06e226b18ab3ae717c140 fwiw) | |
| 10:17:42 | lyarwood | Yup I assumed we would tbh | |
| 10:18:02 | lyarwood | no reason to leave it just on >=stable/xena | |
| 10:21:52 | elodilles | stephenfin: well, it formally violates, as it is a blueprint o:) ... anyway, I would stick to backporting only bug fixes... but... given that py27 is not supported in ussuri anymore... anyway I'm a bit unsure... o:) | |
| 10:24:12 | lyarwood | oh sorry I thought we were talking about the cherry-pick script | |
| 10:35:35 | elodilles | lyarwood: actually I've missed that discussion :X Are you planning to move out the cherry-pick-check from pep8? | |
| 10:36:19 | elodilles | lyarwood: nevermind, i'm just a bit slow today :D | |
| 10:36:31 | lyarwood | elodilles: https://review.opendev.org/c/openstack/nova/+/796626 yeah that's the idea, make it non-voting in check and only voting in the gate | |
| 10:36:47 | elodilles | lyarwood: yeah, sorry :X | |
| 10:45:11 | sean-k-mooney | lyarwood: instead of skiping the test https://review.opendev.org/c/openstack/nova/+/796813 why not just use the old driver | |
| 10:45:32 | sean-k-mooney | the stalling issue only happens if you use the native driver | |
| 10:45:44 | sean-k-mooney | the vsctl one wont have that problem | |
| 10:50:34 | lyarwood | We could but unless that's done in devstack across all jobs we end up with a mixed set of jobs | |
| 10:51:07 | sean-k-mooney | is that a bad thing | |
| 10:51:42 | sean-k-mooney | with the current patch your just reducing coverage | |
| 10:51:56 | sean-k-mooney | but the issue can still happen | |
| 10:52:21 | sean-k-mooney | im fine with makeing that change in devstack tempeorally | |
| 10:52:56 | lyarwood | kk if you could post that we can yank or revert this | |
| 10:53:40 | sean-k-mooney | i left a -1 on the patch already but would you like me to do the devstack change | |
| 10:54:12 | sean-k-mooney | jsut finishing an email but i can do it then | |
| 10:56:23 | lyarwood | sean-k-mooney: ack | |
| 10:56:30 | lyarwood | stephenfin: can you yank the +W on https://review.opendev.org/c/openstack/nova/+/796813 | |
| 10:56:45 | lyarwood | stephenfin: sean-k-mooney is going to work around this in devstack | |
| 10:56:52 | stephenfin | sure, done | |
| 10:56:55 | lyarwood | ta | |
| 11:05:05 | lyarwood | noice, the FIPS fallout doesn't look that bad | |