| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-13 | |||
| 08:47:23 | opendevreview | Jorhson Deng proposed openstack/nova master: remove the redundantcode for attach interface https://review.opendev.org/c/openstack/nova/+/796208 | |
| 08:54:13 | opendevreview | Jorhson Deng proposed openstack/nova master: remove the redundant code for attach interface https://review.opendev.org/c/openstack/nova/+/796208 | |
| 08:57:23 | opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | |
| 09:05:50 | opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | |
| 09:07:05 | opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | |
| 09:12:32 | opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful reference: https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L2897 https://review.opendev.org/c/openstack/nova/+/796209 | |
| #openstack-nova - 2021-06-14 | |||
| 05:16:49 | gibi | good morning | |
| 05:16:57 | gibi | early cores, can we turn on mypy now https://review.opendev.org/c/openstack/nova/+/795973 ? | |
| 05:17:17 | gibi | the missing requirement for mpyp 0.9 has been merged over the weekend | |
| 07:47:38 | bauzas | gibi: I could do it but... | |
| 07:47:47 | gibi | but? :) | |
| 07:47:52 | gibi | ahh, you are the author | |
| 07:47:55 | bauzas | ;) | |
| 07:48:03 | gibi | you tricked me :) | |
| 07:48:05 | bauzas | gibi: just do a fast approval | |
| 07:48:23 | gibi | I think stephenfin will be up soon | |
| 07:49:52 | bauzas | well ok | |
| 08:37:59 | lyarwood | +W'd | |
| 08:38:18 | lyarwood | looking at https://bugs.launchpad.net/nova/+bug/1931716 now btw | |
| 08:41:59 | opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380 | |
| 08:42:41 | opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | |
| 08:43:32 | opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | |
| 08:44:18 | opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | |
| 08:44:52 | gibi | lyarwood: thanks. I pushed a small patch with debug log to see what is the error code libvirt sends https://review.opendev.org/c/openstack/nova/+/796043 | |
| 08:48:44 | kashyap | Hmm, it's this disk not found thing ... I have a deja vu of this w/ device-detach | |
| 08:49:43 | gibi | kashyap: yes, it is totally deja vus | |
| 08:50:16 | gibi | morning | |
| 08:52:56 | lyarwood | I called out some commits in https://review.opendev.org/c/openstack/nova/+/741561 that seemed to show we were using VIR_ERR_DEVICE_MISSING now so I'm slightly confused by this | |
| 08:53:04 | lyarwood | unless someone reverted some of this in libvirt | |
| 08:53:31 | lyarwood | https://libvirt.org/git/?p=libvirt.git;a=blobdiff;f=src/qemu/qemu_hotplug.c;h=5be3e0659ad749e7e8a3585f6b98e2f218f34059;hp=a62dbe79e5650b051f02bb059afbd251b296b899;hb=126db34a81bc9f9f9710408f88cceaa1e34bbbd7;hpb=bb189c8e8c93f115c13fa3bfffdf64498f3f0ce1 for example | |
| 08:55:07 | gibi | lyarwood: I think we can wait until I can reproduce the problem with the extra debug log to is what is the error code, then after that I can add that code to the handler in nova | |
| 08:55:24 | gibi | s/to is/to see/ | |
| 08:57:12 | lyarwood | ack yeah and I'll have a quick look at the libvirt code to see what's changed if anything | |
| 08:57:22 | gibi | ack, thanks | |
| 09:03:32 | lyarwood | https://github.com/libvirt/libvirt/blob/55ea45acc99c549c7757efe954aacc33ad30a8ef/src/qemu/qemu_hotplug.c#L5324-L5328 yeah it didn't change all the paths | |
| 09:03:35 | lyarwood | gah! | |
| 09:03:43 | lyarwood | that's the one I'm assuming we are hitting here tbh | |
| 09:10:07 | gibi | jepp, that could be the case | |
| 09:10:18 | gibi | then I will prepare a commit adding handler for it | |
| 10:10:46 | opendevreview | Jorhson Deng proposed openstack/nova master: remove the redundant code for attach interface https://review.opendev.org/c/openstack/nova/+/796208 | |
| 10:13:50 | opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful reference: https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L2897 https://review.opendev.org/c/openstack/nova/+/796209 | |
| 10:14:54 | opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | |
| 10:19:41 | lyarwood | gibi: https://listman.redhat.com/archives/libvir-list/2021-June/msg00337.html FWIW | |
| 10:20:30 | gibi | lyarwood: awesome | |
| 10:20:33 | gibi | thanks | |
| 10:20:49 | gibi | I'm just writing the unit test for the nova patch | |
| 10:35:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Handle OPERATION_FAILED error during detach https://review.opendev.org/c/openstack/nova/+/796255 | |
| 10:41:03 | gibi | lyarwood: ^^ | |
| 10:41:10 | lyarwood | ack looking | |
| 10:45:01 | lyarwood | LGTM | |
| 11:00:16 | opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796257 | |
| 11:00:17 | opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/796258 | |
| 11:01:01 | opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796259 | |
| 11:01:02 | opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/796260 | |
| 11:05:26 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796262 | |
| 11:05:27 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/c/openstack/nova/+/796263 | |
| 11:05:28 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/796264 | |
| 11:09:39 | stephenfin | lyarwood: elodilles_afk: Could you folks stick https://review.opendev.org/c/openstack/os-vif/+/765967 and its relatives on the stable review list for this week? | |
| 11:09:47 | lyarwood | ack | |
| 11:09:51 | stephenfin | ta | |
| 11:10:16 | lyarwood | didn't we say that the os-vif cores were going to end up as stable cores? | |
| 11:10:31 | lyarwood | ah lunch is ready, I'll get to this afterwards brb | |
| 11:10:37 | stephenfin | I thought we did but we haven't made the change yet | |
| 11:10:40 | stephenfin | nw | |
| 11:18:58 | elodilles | stephenfin: sure, will review as soon as I get there :) | |
| 11:39:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | |
| 11:39:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | |
| 11:39:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | |
| 11:39:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | |
| 11:40:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | |
| 11:44:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | |
| 11:46:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | |
| 11:48:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | |
| 11:49:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | |
| 11:49:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | |
| 11:52:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208 | |
| 11:53:27 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 11:54:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | |
| 11:54:53 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 11:55:34 | gibi | lyarwood: are you working on adding a retry to nova.virt.libvirt.storage.lvm.get_volume_group_info due to https://bugs.launchpad.net/nova/+bug/1931710 ? If not then I can jump on that (I just so that error again in a fresh run)( | |
| 11:56:01 | lyarwood | gibi: I haven't started so if you have the time please go ahead :) | |
| 11:56:08 | gibi | then I go and do it | |
| 11:56:11 | gibi | :) | |
| 12:17:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Retry volume group query https://review.opendev.org/c/openstack/nova/+/796269 | |
| 12:17:11 | gibi | lyarwood: here it is ^^ | |
| 12:37:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Retry lvm volume and volume group query https://review.opendev.org/c/openstack/nova/+/796269 | |
| 12:38:30 | gibi | realized that I saw failures both in case of lvs and vgs queries | |
| 12:40:05 | lyarwood | Yeah indeed sorry the UI didn't refresh in time | |
| 12:40:53 | lyarwood | fun | |
| 12:41:23 | lyarwood | ^ in nova-multi-cell | |
| 12:41:27 | lyarwood | and | |
| 12:41:41 | lyarwood | in tox-py-36 | |
| 12:42:33 | gibi | oh nice | |
| 12:42:48 | gibi | it was release monday out there it seems :D | |
| 12:44:17 | gibi | but what is the conflict in the stevedore case? stevedore >=1.20.0 and stevedore === 3.3.0 are not conflicting | |
| 12:44:27 | gibi | or am I missing something? | |
| 12:44:39 | lyarwood | tbh both are confusing | |
| 12:50:15 | lyarwood | yeah I can't reproduce the numpy websockify one | |
| 13:06:36 | sean-k-mooney | lyarwood: how are you finding the matix bridge? i likke the way image sharing work on the irc side | |
| 13:07:06 | sean-k-mooney | its nicer on the matrix side of cource since its inline but the urls work well for irc users too | |