| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-08 | |||
| 10:45:47 | slaweq | kashyap I actually can't check it like that in the zuul ci jobs | |
| 10:45:47 | sean-k-mooney | kashyap: this is running on upshift which is hosted by vexhost using i would guess there new amd eypc zen2 servers | |
| 10:47:29 | sean-k-mooney | assuming they are all the same then they are second gen epyc cpus from 2 years ago but nehalem is ~8-11 years old so it should be emulatable on anything that is still in production today | |
| 10:47:43 | kashyap | I see | |
| 10:53:50 | stephenfin | lyarwood: took me a bit but +2 on https://review.opendev.org/c/openstack/nova/+/794639 now. sean-k-mooney might be interested if they've time | |
| 10:55:47 | sean-k-mooney | i can re review it now | |
| 10:56:50 | stephenfin | lyarwood: also, can you send an email to openstack-discuss RE: https://review.opendev.org/c/openstack/nova/+/794252. They're likely totally useless but we've always done it historically | |
| 10:57:04 | sean-k-mooney | stephenfin: well | |
| 10:57:12 | sean-k-mooney | for PCI passthrough attach, from '_attach_direct_passthrough_ports': not relevant since these clearly can't be virtio devices | |
| 10:57:17 | sean-k-mooney | they can | |
| 10:57:28 | sean-k-mooney | oh _attach_direct_passthrough_ports | |
| 10:57:50 | stephenfin | Really? That doesn't make much sense to me | |
| 10:57:58 | sean-k-mooney | i was going to say macvtap and vdpa sriov interface will be virtio | |
| 10:58:03 | stephenfin | Other types of "passthrough", sure | |
| 10:58:04 | stephenfin | Yeah | |
| 10:58:18 | sean-k-mooney | if that is just direct then ya | |
| 10:58:46 | stephenfin | Would be good to double check. I think it is but I might have missed something | |
| 10:59:27 | sean-k-mooney | im checking now but it shoudl be fine | |
| 10:59:45 | stephenfin | in other news, /me has a briar thorn stuck in his fingertip that he can't remove which is making typing extremely uncomfortable today :-D | |
| 10:59:53 | sean-k-mooney | attach_interface is the entrypoint that would handel all sriov attach anyway | |
| 11:00:14 | sean-k-mooney | ouch | |
| 11:01:13 | sean-k-mooney | stephenfin: so right now it should be ok https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4821-L4840 | |
| 11:01:43 | sean-k-mooney | i have worked with prototype nics that expsoed virtio-net-pci devices as VFsd though in the past | |
| 11:08:23 | sean-k-mooney | with the caveat the i woudl silll like the sev atibetes fo the nices to be handeled in vif.py eventualy im +1 on that change | |
| 11:13:08 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Replace 'nova boot' with 'openstack server create' https://review.opendev.org/c/openstack/nova/+/794007 | |
| 11:13:14 | gibi | kashyap: ack, I've added to the agenda | |
| 11:13:59 | stephenfin | gibi: lyarwood: if you've time this week, could I get your eyes on this follow-up series for the RPC 6.0 change from last cycle. bauzas is +2 on pretty much all of it now https://review.opendev.org/q/topic:"compute_rpc_6.0"+status:open | |
| 11:20:13 | sean-k-mooney | stephenfin: is that removing the proxy? | |
| 11:20:35 | stephenfin | no, just removing references to instance_type (in favour of flavour) | |
| 11:20:51 | sean-k-mooney | ah ok | |
| 12:10:21 | gibi | stephenfin: queued up | |
| 14:47:53 | sean-k-mooney | lyarwood: so looking at the patch to not destroy secrets on hard reboot i still dont see a test asserting that wehn we do hard reboot that we then pass destroy_secrets=False | |
| 14:47:59 | sean-k-mooney | you added https://review.opendev.org/c/openstack/nova/+/793463/4..5/nova/tests/unit/virt/libvirt/test_driver.py#19352 | |
| 14:48:04 | sean-k-mooney | in the most recent version | |
| 14:48:12 | sean-k-mooney | but that is calling clean up directly | |
| 14:48:46 | sean-k-mooney | i was asking you to call hard reboot and assert it called cleanup with destroy_secrets=False | |
| 15:00:22 | sean-k-mooney | when is the nova team meeting is it now or in an hour? | |
| 15:02:06 | sean-k-mooney | lyarwood: never mind it is caugt by nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_hard_reboot | |
| 15:02:21 | gibi | sean-k-mooney: https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 15:02:26 | gibi | sean-k-mooney: 16:00 UTC | |
| 15:02:33 | gibi | sean-k-mooney: wich is 1 hour from now | |
| 15:02:45 | sean-k-mooney | yep i need to add that to my calandar | |
| 15:03:26 | sean-k-mooney | thanks | |
| 15:05:06 | sean-k-mooney | got the ical form here https://meetings.opendev.org/#Nova_Team_Meeting | |
| 15:06:52 | sean-k-mooney | stephenfin: https://review.opendev.org/c/openstack/nova/+/793463 contains a virt driver api change im not sure we are allwowed to backport that | |
| 15:07:03 | sean-k-mooney | stephenfin: at least if we wanted too we would have to mofify the patch | |
| 15:07:19 | sean-k-mooney | so that if the virt driver did not supprot it we would invoke the api without the new parmater | |
| 15:07:50 | sean-k-mooney | sorry https://review.opendev.org/c/openstack/nova/+/794252/1 | |
| 15:10:31 | stephenfin | yeah, we need to discuss that. On one hand, it's breaking a stable API. On the other hand, we've clearly said the API isn't actually stable :) | |
| 15:11:12 | sean-k-mooney | well we basically said out of tree driver are not supproted | |
| 15:11:27 | sean-k-mooney | ane the patch fixes the in tree ones. | |
| 15:11:41 | sean-k-mooney | but we know out of tree driver are used by vmware for one | |
| 15:13:46 | sean-k-mooney | stephenfin: i guess if thes apis are only called in the virt driver it would be ok | |
| 15:14:19 | sean-k-mooney | it would only be an issue if destroy and cleanup are called in the compute manager | |
| 15:15:10 | sean-k-mooney | we would be overloading on the number of keyword arguments | |
| 15:15:21 | sean-k-mooney | i cant remember if python allows that now or not | |
| 15:16:00 | kashyap | gibi: Afraid, I might not be able to stay for the full meeting - if it lasts longer than 15 min, as I need to run an errand around 18:30 CET... | |
| 15:16:33 | gibi | kashyap: then we will start with your topic | |
| 15:17:01 | kashyap | gibi: Thank you! :) | |
| 15:17:16 | kashyap | gibi: And BTW, I agree on moving the meeting to -nova | |
| 15:17:24 | gibi | kashyap: thanks for the input | |
| 15:31:20 | bauzas | gibi: others: for what it's worth, I'll be on PTO tomorrow | |
| 15:31:36 | gibi | bauzas: ack. | |
| 15:31:40 | gibi | bauzas: enjoy | |
| 15:31:56 | bauzas | thanks | |
| 15:46:36 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing https://review.opendev.org/c/openstack/nova/+/794863 | |
| 15:50:35 | gibi | nova meeting starts in 10 minutes in #openstack-meeting-3 | |
| 16:33:43 | opendevreview | Luigi Toscano proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | |
| 20:40:14 | opendevreview | Luigi Toscano proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | |
| 22:22:09 | opendevreview | Merged openstack/nova master: Remove references to 'instance_type' https://review.opendev.org/c/openstack/nova/+/778546 | |
| 23:21:37 | opendevreview | Merged openstack/nova stable/victoria: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794674 | |
| 23:32:24 | opendevreview | melanie witt proposed openstack/nova stable/victoria: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787252 | |
| 23:34:14 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Initialize global data separately and run_once in WSGI app init https://review.opendev.org/c/openstack/nova/+/785059 | |
| #openstack-nova - 2021-06-09 | |||
| 00:23:58 | opendevreview | Merged openstack/nova master: Remove unnecessary mocks from unit test https://review.opendev.org/c/openstack/nova/+/794637 | |
| 00:24:37 | opendevreview | Merged openstack/nova master: docs: Address TODO https://review.opendev.org/c/openstack/nova/+/792363 | |
| 00:54:37 | opendevreview | Merged openstack/nova master: Create a fixture around fake_notifier https://review.opendev.org/c/openstack/nova/+/758446 | |
| 00:55:10 | opendevreview | Merged openstack/nova master: Use NotificationFixture for legacy notifications too https://review.opendev.org/c/openstack/nova/+/758448 | |
| 01:20:20 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794675 | |
| 01:20:21 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/c/openstack/nova/+/795432 | |
| 01:20:22 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/c/openstack/nova/+/795433 | |
| 01:22:12 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | |
| 01:35:24 | opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794686 | |
| 01:35:25 | opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/c/openstack/nova/+/795435 | |
| 01:35:26 | opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/c/openstack/nova/+/795436 | |
| 06:06:14 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 06:06:15 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 06:06:16 | opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 06:06:16 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 06:06:17 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 07:02:20 | gibi | lyarwood: hi! Please file a bp for https://review.opendev.org/c/openstack/nova-specs/+/794799 then I will +2 | |
| 07:17:43 | opendevreview | Merged openstack/nova-specs master: Re-propose Unified Limits in Nova https://review.opendev.org/c/openstack/nova-specs/+/789585 | |
| 07:19:30 | opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | |
| 07:35:27 | lyarwood | gibi: yup will do shortly | |
| 07:40:47 | gibi | thanks | |
| 07:45:09 | lyarwood | I shouldn't say shortly, I'm currently stuck in standing traffic after the school run. \o/ | |
| 07:49:05 | gibi | lyarwood: ohh. no worries. | |
| 07:49:30 | gibi | bauzas: I left a suggestion in the mdev spec https://review.opendev.org/c/openstack/nova-specs/+/792796 about trait support. | |
| 07:49:38 | gibi | (I know bauzas is on PTO) | |
| 08:00:42 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: Fix the bp link in the cyborg admin token spec https://review.opendev.org/c/openstack/nova-specs/+/795493 | |
| 08:21:10 | opendevreview | Wenping Song proposed openstack/nova stable/train: Change get console auth token policy to RULE_ADMIN_OR_OWNER https://review.opendev.org/c/openstack/nova/+/795496 | |