| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-03 | |||
| 17:35:53 | sean-k-mooney | and pass host, flavor, image_meta and conf | |
| 17:36:47 | sean-k-mooney | anyway i guess leave it for now | |
| 17:37:07 | sean-k-mooney | at some point we really need to get ride of the desginer.py as well | |
| 17:37:32 | lyarwood | tbh this is the first time I've really looked at it | |
| 17:37:58 | sean-k-mooney | the designer.py has always been a pet pev of mine | |
| 17:38:04 | sean-k-mooney | i want driver.py to be smaller | |
| 17:38:12 | sean-k-mooney | but designer.py does not relaly add value today | |
| 17:38:13 | lyarwood | brb baby bedtime | |
| 17:38:47 | sean-k-mooney | it would be beter to merge it with config.py | |
| 17:39:57 | sean-k-mooney | it was seperated out so that config.py could just be the xml object creation and designer.py woudl have the logic to do some of the compostion | |
| 17:40:23 | sean-k-mooney | but we never too the xml logic out of vif.py or the volume modules | |
| 17:40:34 | sean-k-mooney | so really designer just complicated things | |
| 17:42:05 | opendevreview | Merged openstack/nova stable/wallaby: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/790836 | |
| 18:04:59 | opendevreview | melanie witt proposed openstack/nova stable/victoria: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/794624 | |
| 18:31:31 | melwitt | fix for intermittent unit test failure if anyone interested https://review.opendev.org/c/openstack/nova/+/794396 | |
| 18:53:01 | sean-k-mooney | melwitt: oh it was somethime slow an now did not match? | |
| 18:53:32 | sean-k-mooney | or something like that that change the behavior of _refresh_associations | |
| 18:53:37 | melwitt | sean-k-mooney: yeah, learned of it cause it hit my patch heh https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b0d/794186/1/check/openstack-tox-py38/b0dd1dd/testr_results.html | |
| 18:53:58 | sean-k-mooney | that was going to be my next question good catch | |
| 18:55:03 | melwitt | after awhile I realized it's because refresh associations records the time at which it ran, and the test was relying on the fact that that time would be sufficiently soon enough after "now" was recorded prior | |
| 18:56:28 | sean-k-mooney | that looks like now = time.time() was previously unused | |
| 18:56:37 | sean-k-mooney | oh i guess its later in the test | |
| 18:56:53 | sean-k-mooney | ya it is | |
| 18:57:02 | melwitt | no yeah it's used | |
| 18:57:46 | sean-k-mooney | part of me wishes there was a clearn helper funciton or somthing for this but ya this looks correct to me | |
| 18:58:19 | sean-k-mooney | for example mocking time.time via a decorator at the top of the function | |
| 18:59:47 | melwitt | oh yeah, I guess that would work without needing reset of the mocks throughout, cause all you'd change is the return_value and not asserting calls | |
| 18:59:48 | sean-k-mooney | e.g. @mock.patch.object(time, 'time', return_value=time.time()) | |
| 19:00:08 | sean-k-mooney | yep | |
| 19:00:27 | sean-k-mooney | you could still reset the time mock if needed | |
| 19:00:45 | sean-k-mooney | but they dont check that as far as i can see | |
| 19:01:04 | melwitt | yeah. I was hoping to not though | |
| 19:01:18 | sean-k-mooney | i dont think you need too | |
| 19:01:25 | melwitt | yeah, agree | |
| 19:01:54 | sean-k-mooney | @mock.patch.object(time, 'time', return_value=time.time())/def test_refresh_associations_time(self, log_mock,time_mock): | |
| 19:01:56 | sean-k-mooney | shoudl fix it | |
| 19:02:53 | sean-k-mooney | return_value=time.time() shoudl be evaluated before the mock is appied and resovled into a what time.time() returns | |
| 19:05:04 | melwitt | I'll give it a go | |
| 19:28:18 | opendevreview | melanie witt proposed openstack/nova master: Make test_refresh_associations_* deterministic https://review.opendev.org/c/openstack/nova/+/794396 | |
| 19:30:10 | opendevreview | melanie witt proposed openstack/nova master: Make test_refresh_associations_* deterministic https://review.opendev.org/c/openstack/nova/+/794396 | |
| 19:33:54 | opendevreview | melanie witt proposed openstack/nova stable/victoria: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794674 | |
| 19:37:32 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794675 | |
| 23:53:54 | opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794686 | |
| 23:57:08 | opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794686 | |
| 23:59:36 | melwitt | sigh | |
| 23:59:44 | opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794686 | |
| #openstack-nova - 2021-06-04 | |||
| 07:05:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove unnecessary mocks from unit test https://review.opendev.org/c/openstack/nova/+/794637 | |
| 08:43:26 | kashyap | lyarwood: Mornin'. When you're about, it's not entirley clear to me if the grenade-multinode time-out is your patch's problem: https://review.opendev.org/c/openstack/nova/+/794639/ | |
| 08:43:43 | kashyap | Invalid volume + request time-out | |
| 08:50:27 | lyarwood | it's not | |
| 08:50:43 | lyarwood | this looks like another detach timeout issue | |
| 08:52:12 | lyarwood | so much nicer to debug this now thanks to gibi's rewrite | |
| 08:52:33 | lyarwood | :) | |
| 08:53:12 | lyarwood | so I think we need to add a dump of the instance console when we fail to detach | |
| 08:53:28 | lyarwood | as this might be an issue within the guestOS but without that it's impossible to say | |
| 08:53:41 | lyarwood | n-cpu and libvirt appear to be doing the correct things at the correct time | |
| 08:57:22 | kashyap | Hm | |
| 09:21:50 | lyarwood | kashyap: https://review.opendev.org/c/openstack/tempest/+/794757 I'll try some runs with this to see what the guest is up to | |
| 09:23:43 | kashyap | lyarwood: Nice; that's quick! | |
| 09:56:49 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/794639 | |
| 09:56:50 | opendevreview | Lee Yarwood proposed openstack/nova master: DNM testing tempest volume detach failure capture of console https://review.opendev.org/c/openstack/nova/+/794766 | |
| 10:18:58 | opendevreview | Merged openstack/placement master: Add 'cryptography' package to test-requirements.txt https://review.opendev.org/c/openstack/placement/+/787289 | |
| 10:20:03 | opendevreview | Merged openstack/nova master: Fix RequestLevelParams persistence handling in RequestSpec https://review.opendev.org/c/openstack/nova/+/791502 | |
| 12:40:55 | kashyap | sean-k-mooney: Hey, I'm trying to add a new video device model ... "bochs" display | |
| 12:41:19 | kashyap | sean-k-mooney: It is recommended by the QEMU folks for UEFI guests as a safe alternative | |
| 12:41:59 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Allow 'bochs' as a display device option https://review.opendev.org/c/openstack/nova/+/794796 | |
| 12:42:28 | kashyap | sean-k-mooney: --^ When you get a minute, let me know what is missing there :) | |
| 12:42:54 | sean-k-mooney | sure | |
| 12:43:03 | kashyap | sean-k-mooney: A blueprint is an overkill for this; shall I just file a bug? | |
| 12:43:35 | sean-k-mooney | no this is a feature | |
| 12:43:52 | kashyap | sean-k-mooney: I think I also need to bump the hash for ImageMetaProps? | |
| 12:43:54 | sean-k-mooney | when i added virtio i had to actully do a spec if i recal | |
| 12:44:02 | sean-k-mooney | you need to do a few thing | |
| 12:44:03 | kashyap | sean-k-mooney: Okay, I'll just file a blueprint. | |
| 12:44:12 | sean-k-mooney | you need to create a new trait in os-traits | |
| 12:44:39 | sean-k-mooney | you will alos need to update i think the notification objects but i have not reviewed the patch yet | |
| 12:44:40 | kashyap | Oh, trait too | |
| 12:44:57 | kashyap | (I haven't added the notification object) | |
| 12:45:14 | sean-k-mooney | https://github.com/openstack/os-traits/blob/master/os_traits/compute/graphics.py#L15 | |
| 12:45:30 | sean-k-mooney | os just MODEL_BOCHS | |
| 12:45:33 | opendevreview | Lee Yarwood proposed openstack/nova-specs master: Add attachmentId to responses of the os-volume_attachments API https://review.opendev.org/c/openstack/nova-specs/+/794799 | |
| 12:46:08 | sean-k-mooney | kashyap: we have a placement prefilter that allows you to schdule to nodes that have support for the model | |
| 12:47:06 | kashyap | sean-k-mooney: Wouldn't all nodes have support for the model in a given deployment, given that min_libvirt_version satisifes that requirement? | |
| 12:47:56 | opendevreview | Lee Yarwood proposed openstack/nova-specs master: Add attachmentId to responses of the os-volume_attachments API https://review.opendev.org/c/openstack/nova-specs/+/794799 | |
| 12:49:43 | sean-k-mooney | oh and technially a change to glance https://review.opendev.org/c/openstack/glance/+/647735 but that is more a nice to have | |
| 12:49:56 | kashyap | sean-k-mooney: Got a link to your virtio-gpu patch? | |
| 12:50:04 | sean-k-mooney | kashyap: this is how i added virtio-gpu https://review.opendev.org/c/openstack/nova/+/647733 | |
| 12:50:05 | kashyap | sean-k-mooney: Noted on the Glance part | |
| 12:51:41 | sean-k-mooney | technially i just added all the video moeles that were not already supported when i did that change not just virtio but you could be able to just follow the same steps | |
| 12:55:22 | kashyap | sean-k-mooney: So, here we go, the specless-bp: https://blueprints.launchpad.net/nova/+spec/add-bochs-display-device | |
| 12:55:40 | sean-k-mooney | kashyap: do you need to add a test for uefi fo this model type | |
| 12:55:54 | sean-k-mooney | e.g. hw_fireware_type=uefi | |
| 12:56:24 | sean-k-mooney | we proably should assuming it wont work with a bios boot | |
| 12:57:05 | kashyap | sean-k-mooney: For BIOS boot, "this device might be useable as well" is what the QEMU dev writes | |
| 12:57:14 | sean-k-mooney | kashyap: ack on the blueprint that hsould be more or less enough we can disucss it at the meeting on tueday | |
| 12:57:23 | kashyap | Okido | |
| 12:57:36 | sean-k-mooney | kashyap: ok so we dont need to put a gard in place at the api | |
| 12:58:02 | sean-k-mooney | in valdiate_falvor_image_nostatus | |
| 12:58:03 | kashyap | sean-k-mooney: BTW, a silly question: what are the hashes based on, when bumping the ImageMetaPros? | |
| 12:58:45 | sean-k-mooney | they are computed based in the filed defintions of the the object by olso.versioned.objects | |