Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-06-03
13:18:14 sean-k-mooney but if you want ot update the description please feel free too
13:18:27 kashyap sean-k-mooney: Yeah, good idea to update the description; /me goes to do it :)
13:19:04 kashyap sean-k-mooney: Mind if I also touch up a few typos?
13:19:44 sean-k-mooney go for it
13:20:42 kashyap sean-k-mooney: One clarif:
13:20:46 kashyap In this bit: "When the emulator thread is spawned on core 1 since it has less priority then the vcpu thread it will only run if the guest vcpu idels resulting in the iablity for qemu to process device attach"
13:21:08 kashyap sean-k-mooney: Can you pleease rephrase the last part? The "idels and "iability" are ambigious to parse for me
13:29:02 kashyap sean-k-mooney: Added the "Workaround" section at the end of the description; please double-check.
13:32:18 dansmith sean-k-mooney: no I don't know
13:41:10 ozzzo Sean has helped me a lot so I've gotten pretty good at translating Seanglish: "guest vcpu idles resulting in the inability"
13:42:30 kashyap ozzzo: Ah, thanks. I'm mostly pretty good at parsing him, sometimes I miss the mark :)
13:46:13 kashyap sean-k-mooney: Disregard my above question (thx to ozzzo); updated the bug.
13:47:53 sean-k-mooney ozzzo: hehe seanspeak is a select dialect :)
14:00:55 opendevreview Merged openstack/nova stable/queens: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761825
14:32:47 gmann melwitt: no, it was by mistake. thanks for catching it. fixing it now
14:46:39 opendevreview Ghanshyam proposed openstack/nova master: Improve policy doc for supported scope info https://review.opendev.org/c/openstack/nova/+/762013
14:47:15 gmann melwitt: stephenfin updated ^^
14:59:42 gmann we move the IRC channel to OFTC network, please join there https://docs.openstack.org/contributors/common/irc.html
14:59:46 gmann moved
15:47:57 gibi FYI: I will be mostly off on Monday and Tuesday next week, but I will chair the nova meeting on Tuesday
16:06:07 opendevreview Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618
16:06:08 opendevreview Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619
16:06:08 opendevreview Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620
16:08:08 opendevreview Balazs Gibizer proposed openstack/placement master: Add support for RP re-parenting and orphaning https://review.opendev.org/c/openstack/placement/+/784020
16:08:55 opendevreview Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503
16:12:26 opendevreview Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504
16:13:19 bauzas gibi: ack, and thanks for chairing
16:13:34 bauzas last time I did, I felt the breath of the loneliness :p
16:13:48 opendevreview Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505
16:15:15 gibi bauzas: ahh I remember that meeting, I sit in the inner park of the hospital waiting my turn in the CT. It was a bit surreal both in IRC space and in real space too :)
16:15:20 opendevreview Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208
16:16:41 bauzas gibi: :D
16:16:47 opendevreview Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506
16:16:48 opendevreview Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394
16:18:29 gibi this time I will be off to the lake during the weekend + Monday. But I need to be back in the city on Tuesday so I can do the meeting
16:18:53 gibi (or I could do the meeting from the lake side but meh :D)_
16:19:31 opendevreview Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621
16:20:20 sean-k-mooney gibi: you you know one of us could run the meeting for you and you could relax
16:20:42 gibi sean-k-mooney: thanks, yes. but no need this time
16:21:00 gibi sean-k-mooney: the original plan was that we are back on Wednesday morning, and then I would ask somebody to run it
16:21:15 gibi sean-k-mooney: but turned out that we have to get back on Tuesday morning
16:22:28 gibi so I think I will use Tuesday to do some chores and meeting fits well to that list :)
16:31:15 melwitt gibi: easy test-requirements update for placement, dunno if you also ran into this when running func tests the first time https://review.opendev.org/c/openstack/placement/+/787289
16:35:58 opendevreview Balazs Gibizer proposed openstack/nova master: Remove unnecessary mocks from unit test https://review.opendev.org/c/openstack/nova/+/794637
16:36:42 gibi melwitt: I don't remember I saw it but the change itself does not hurt
16:37:58 gibi could be that I have that package already locally
16:39:13 gibi yepp, I have it already that package installed globally in my dev machine
16:39:18 gibi that is why I did not see it
16:49:04 opendevreview Lee Yarwood proposed openstack/nova master: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/794639
16:51:45 lyarwood ^ should be WIP, I'll finish it up later with volume attach tests
16:51:52 lyarwood and maybe a seperate functional test
17:04:26 sean-k-mooney lyarwood: the set_driver_iommu_for_device should be called form vif_driver.get_config more then likely
17:06:02 sean-k-mooney lyarwood: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L560
17:06:17 lyarwood sean-k-mooney: I'm assuming that wasn't done originally to ensure *all* devices end up with it set not just when disks and vifs we define
17:07:27 sean-k-mooney lyarwood: well curently you are just alwasy checkign it without considering the vif model correct
17:07:57 lyarwood sean-k-mooney: no that's checked in the designer
17:08:04 lyarwood sean-k-mooney: at least that it's virtio
17:08:16 sean-k-mooney ya just looked at that now
17:09:13 sean-k-mooney i dont see any reason not to put it in get config other then we will need to store the config and then return it
17:09:59 sean-k-mooney although you probably could do it here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L528
17:11:07 sean-k-mooney we really need to get rid of the non os-vif code path
17:11:33 lyarwood sean-k-mooney: I'd rather do this explicitly in both hot plug flows first and then refactor the vif part later if you think it's worth it
17:12:03 lyarwood sean-k-mooney: we can't do this in the volume drivers as we don't pass in the instance so it would be weird to change this just for vifs IMHO
17:12:05 sean-k-mooney well i dont like spreading out the config genration like that
17:12:40 sean-k-mooney i dont think that the attach or detach function should have to care about this explictly
17:13:21 sean-k-mooney to me that is a poor speeration of concerns
17:15:15 lyarwood Yup I agree but the original SEV code was already doing this during spawn
17:15:40 lyarwood how about we fix this and then refactor both sets of config generation to do this correctly
17:16:19 lyarwood I really don't want to do that as part of the bugfix we need to backport
17:16:20 sean-k-mooney we could yes by passing the flavor/image metadata to _get_volume_config
17:16:33 sean-k-mooney and then moving this into vif_driver.get_config
17:16:44 lyarwood right I'm not going to do that in the backportable change
17:16:47 lyarwood someone else can
17:17:01 sean-k-mooney well honestly its not really a big change is it
17:17:04 lyarwood but to me that's something that can follow on master
17:18:25 lyarwood _get_volume_config isn't generating the actual config so if we were to do the same thing as vifs we'd be passing that down into the volume drivers right?
17:18:47 lyarwood otherwise there's no difference to what the change is already doing in attach_volume
17:19:51 sean-k-mooney there is a change presumable _get_volume_config is used for every operation that gets the confi for a volume
17:20:05 sean-k-mooney as vif_driver.get_config is
17:20:46 sean-k-mooney so if we put the if and call to the desinger in _get_volume_config and vif_driver.get_config
17:20:51 sean-k-mooney we can never forget to do it
17:21:13 sean-k-mooney what i dislike about your current patch is that it leave open the need to do this on all relevent code paths
17:21:58 lyarwood the original did that
17:22:29 lyarwood anyway let me respin and see what the fallout is
17:22:29 sean-k-mooney did what
17:22:32 lyarwood nvm
17:24:53 sean-k-mooney for get_volume config its just passing the info and doing the if here right https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1887
17:25:31 lyarwood right I thought you were suggesting changing the actual get_config methods in the volume drivers
17:25:56 lyarwood this is still going to cause test fallout that I'd rather avoid for backports but I'll give it a go
17:25:56 sean-k-mooney no
17:26:08 sean-k-mooney and for vif.py its just replaceing the returns here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L578-L601
17:26:23 sean-k-mooney with an asignment to conf and dong the if then returning
17:26:55 sean-k-mooney lyarwood: the rest of the approch im ok with
17:27:49 sean-k-mooney lyarwood: due to the changing of the signiture of an privete funcion _get_volume_config
17:28:22 sean-k-mooney i would hope the fallout from tha twould be relitivly minimal
17:28:26 lyarwood sean-k-mooney: what about get_base_config for the vif?
17:28:40 sean-k-mooney you dont need to modify that
17:28:53 sean-k-mooney you could but you cna do it in get_config
17:29:29 sean-k-mooney lyarwood: that said https://github.com/openstack/nova/blob/cd084aeeb8a2110759912c1b529917a9d3aac555/nova/virt/libvirt/vif.py#L180
17:29:47 sean-k-mooney it has the flaovr and image_meta

Earlier   Later