| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-05-25 | |||
| 14:04:50 | sean-k-mooney | so how you do that will cahnge soon ish | |
| 14:05:36 | masterpe | That will get into the master branch and not Train ? | |
| 14:06:02 | gibi | bauzas: you are right, PUT /resource_providers/{uuid} is not RESTFul as it allows partial update today. This is very unfortunate :/ | |
| 14:06:53 | gibi | the parent_uuid not need to be passed, and the uuid field is not part of the body just part of the url | |
| 14:07:52 | gibi | the current PUT is very pretty close to PATCH now | |
| 14:23:26 | gibi | stephenfin: we need you on https://review.opendev.org/c/openstack/nova-specs/+/783827 | |
| 14:23:29 | gibi | :0 | |
| 14:23:55 | stephenfin | I'm needed? How wonderful | |
| 14:24:00 | stephenfin | * stephenfin looks | |
| 14:24:22 | gibi | it is your spec where sean-k-mooney has some comments making it pending | |
| 14:36:11 | sean-k-mooney | stephenfin: my main question is do we need OS-EXT-SRV-ATTR:hostname anymore and shoudl we just have hostname instead | |
| 14:36:57 | stephenfin | ah, that point | |
| 14:37:03 | stephenfin | I did see that and thought I had replied | |
| 14:37:54 | stephenfin | I'm easy. Changing it is more work, both on the server side (code and docs) and client (SDK, OSC, novaclient) side | |
| 14:37:55 | sean-k-mooney | we could adress that point in a follow up which is why im currently +1 | |
| 14:38:15 | stephenfin | but on the other hand, it's certainly a saner response | |
| 14:38:17 | sean-k-mooney | it would be but i think it would be a nice UX improvemnt | |
| 14:38:28 | sean-k-mooney | changing it in the futrue woudl need another micorversion bump | |
| 14:38:51 | sean-k-mooney | so basically i we ever want to change it i think it would be nice to do it now ihn this change | |
| 14:39:10 | stephenfin | what about the rest of those prefixed options though? | |
| 14:39:18 | stephenfin | if we do one, shouldn't we do them all | |
| 14:39:20 | stephenfin | ? | |
| 14:39:30 | sean-k-mooney | well im open to that also | |
| 14:40:22 | sean-k-mooney | im ok wiht elevating my +1 to a +w and we can dicuss that in a followup patch? although it really was just hostname that i wanted to chagne in this case | |
| 14:40:35 | sean-k-mooney | some of the other prefixed fiels are admin only | |
| 14:41:07 | sean-k-mooney | so im not really sure it there is merrit in renaming those form a UX point of view | |
| 14:44:08 | stephenfin | I would be tempted to do all or nothing, personally | |
| 14:44:29 | sean-k-mooney | let me look at the list. not sure what the otehrs are fully | |
| 14:44:41 | sean-k-mooney | the prefix was form when we had extentions | |
| 14:44:52 | gibi | is this prefixing comes from the time when we had api plugins? | |
| 14:44:53 | sean-k-mooney | to show that they were optional and could not be replied on to be in all clouds | |
| 14:44:54 | gmann | sean-k-mooney: stephenfin left comment there. agree to improve the name | |
| 14:45:03 | sean-k-mooney | gibi: yes | |
| 14:45:15 | gibi | so they can be relied on now | |
| 14:45:20 | sean-k-mooney | yep | |
| 14:45:22 | gibi | so we can drop all the prefix :) | |
| 14:45:32 | gibi | lets do that in a separate microversion. :) | |
| 14:45:35 | sean-k-mooney | we can. that sound like a seperate mini spec so | |
| 14:45:38 | gmann | in past we left these prefix as it is not worth to do with all prefix rename but as in some other microvesion change we should definitely improver them | |
| 14:45:58 | gmann | gibi: we abandon that idea in past | |
| 14:46:02 | gmann | let me check the spec | |
| 14:46:13 | gibi | bottom line, I'm OK with stephenfin's spec as is, and we can have a separate discussion if and when we drop all the prefixes | |
| 14:46:39 | stephenfin | yes, I do think we should treat this separately. Microversions are (relatively) cheap | |
| 14:47:01 | sean-k-mooney | ok in that case ill upgrade my +1 to +w and refrence this irc log | |
| 14:47:16 | sean-k-mooney | unless gibi gmann you want me to wait? | |
| 14:47:30 | openstackgerrit | masterpe proposed openstack/nova master: WIP: Fixes missing indexes on column deleted_at at the different tables. https://review.opendev.org/c/openstack/nova/+/792989 | |
| 14:47:30 | gibi | sean-k-mooney: go for it | |
| 14:47:40 | gibi | but wait for gmann | |
| 14:47:47 | gibi | as he said he reads the spec | |
| 14:48:03 | gmann | gibi: stephenfin sean-k-mooney item#3 in https://etherpad.opendev.org/p/nova-api-cleanup | |
| 14:48:08 | sean-k-mooney | ok in that case ill leave teh +w to gmann | |
| 14:49:07 | sean-k-mooney | ah yes i tought that had come up before now | |
| 14:49:08 | gibi | gmann: ack. microversion make us safe against breaking clients. | |
| 14:49:21 | gibi | gmann: but I'm fine both ways about the prefixes | |
| 14:49:29 | gibi | gmann: are you OK with the rest of stephenfin's proposal? | |
| 14:50:07 | gmann | gibi: you mean stephenfin spec or proposal of removing all prefix with one microversion ? | |
| 14:50:12 | gibi | spec | |
| 14:50:22 | gibi | the prefix removal an be taken separately from the spec | |
| 14:51:14 | sean-k-mooney | gmann: i think gibi was refering to stephenfin current spec | |
| 14:52:05 | gibi | yepp, this one https://review.opendev.org/c/openstack/nova-specs/+/783827 | |
| 14:52:11 | gibi | I want to get it merged :) | |
| 14:52:54 | gibi | gmann: is it OK to you we we skip the renaming now/ | |
| 14:52:55 | gibi | ? | |
| 14:55:22 | gmann | gibi: stephenfin sean-k-mooney sorry, give me some time, stick in two meeting in parallel | |
| 14:56:03 | sean-k-mooney | gmann: no worries, we have time | |
| 14:56:25 | gibi | gmann: sure, no worries | |
| 14:57:14 | bauzas | sean-k-mooney: can't see your comments on https://review.opendev.org/c/openstack/nova-specs/+/792796/1/specs/xena/approved/generic-mdevs.rst | |
| 14:57:25 | bauzas | replying for the moment to gibi | |
| 14:57:52 | sean-k-mooney | you cant? | |
| 14:58:13 | sean-k-mooney | can you refersh? | |
| 14:58:50 | sean-k-mooney | that is strang i cant see you replies | |
| 14:59:55 | sean-k-mooney | i see i my comments on mulitipel browser even when im logged out so i assume you are looking at a cached copy? | |
| 15:00:12 | gibi | I see sean-k-mooney's comments too | |
| 15:00:40 | sean-k-mooney | if you go to the commit message and go back tothe spec you should see them too | |
| 15:08:04 | bauzas | sean-k-mooney: gibi: oh, now I see those | |
| 15:08:07 | bauzas | weirdo | |
| 15:08:12 | gmann | gibi: stephenfin sean-k-mooney on https://review.opendev.org/c/openstack/nova-specs/+/783827 | |
| 15:09:05 | ozzzo | after upgrading compute hosts from centos 7-8, I can't migrate VMs to them. This is the error in the scheduler log: | |
| 15:09:05 | ozzzo | https://paste.ubuntu.com/p/5vqpFnb4ZZ/ | |
| 15:09:13 | ozzzo | When I look at the hypervisors, I see different cpu_info on the upgraded ones | |
| 15:09:16 | sean-k-mooney | bauzas: i just left 1 or 30 :) most are minor nits/word choice issues though so dont be scared by the number | |
| 15:09:19 | gmann | gibi: stephenfin sean-k-mooney it seems it is related to decide on prefix as we will end up different name for single field in request and response. ``hostname`` in request and ``OS-EXT-SRV-ATTR:hostname`` in response | |
| 15:09:26 | ozzzo | the old ones have "| cpu_info | {"vendor": "Intel", "model": "Skylake-Server-IBRS", " | |
| 15:09:26 | ozzzo | the new ones have "| cpu_info | {"arch": "x86_64", "model": "Cascadelake-Server-noTSX", " | |
| 15:09:31 | ozzzo | is that why VMs won't migrate? How can I change it? | |
| 15:09:56 | gmann | if we want to leave the prefix in response now then OS-EXT-SRV-ATTR:hostname in request make it consistent | |
| 15:10:17 | sean-k-mooney | ozzzo: i assume you are not pinning to a specific cpu_model today | |
| 15:10:24 | ozzzo | I have this in the flavors: | properties | hw:cpu_policy='dedicated', hw:cpu_sockets='1', hw:numa_nodes='1' | | |
| 15:10:45 | sean-k-mooney | ozzzo: if the live migration was rejected it typically means the destination is missign a cpu flag that is present on the source node but not the dest | |
| 15:10:48 | gmann | and removing all prefix together has negative feedback from team users in train PTG so i am not 100% sure if that can happen - http://lists.openstack.org/pipermail/openstack-discuss/2019-May/005824.html | |
| 15:11:00 | sean-k-mooney | ozzzo: the cpu model is set in the nova.conf not the flavor | |
| 15:11:12 | sean-k-mooney | ozzzo: i would gess the issue is TSX | |
| 15:11:31 | ozzzo | I kept the same nova.conf | |
| 15:11:41 | ozzzo | Is it possible that centos 8 recognizes the CPU differently from 7? | |
| 15:12:15 | sean-k-mooney | did it have cascade lake cpus before the upgrade | |
| 15:12:43 | sean-k-mooney | if so then host-model would have selected the clost named model which could have been Skylake-Server-IBRS | |
| 15:12:57 | gibi | gmann: so you see an asymetry between the request and the response due the the prefix in the response. | |
| 15:13:01 | sean-k-mooney | but as part of the upgrade if you cahnge the cpu/libvirt verion then it could now have a new cascadelake model | |
| 15:13:02 | gibi | gmann: that is a good point | |
| 15:13:11 | gmann | gibi: yeah | |