Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-05-14
11:35:34 sean-k-mooney stephenfin: https://review.opendev.org/c/openstack/nova/+/791135/1/nova/compute/manager.py#8616 you told me not to use save_and_reraise_exception() anymore at one point right?
11:35:34 sean-k-mooney stephenfin: https://review.opendev.org/c/openstack/nova/+/791135/1/nova/compute/manager.py#8616 you told me not to use save_and_reraise_exception() anymore at one point right?
11:35:39 sean-k-mooney or am i imaginging that
11:35:39 sean-k-mooney or am i imaginging that
11:37:00 stephenfin yeah, it's generally not necessary
11:37:00 stephenfin yeah, it's generally not necessary
11:38:34 stephenfin the only reason to use it is if you're doing some complicated things that might raise their own exception
11:38:34 stephenfin the only reason to use it is if you're doing some complicated things that might raise their own exception
11:38:55 stephenfin but even then there's a way to make sure you raise the correct thing
11:38:55 stephenfin but even then there's a way to make sure you raise the correct thing
11:39:01 stephenfin I don't recall off the top of my head though
11:39:02 stephenfin I don't recall off the top of my head though
11:42:31 sean-k-mooney ok the instance.save im doing could raise so i guess i should use it sicne i dont really feel like wrapign that in a try except
11:42:31 sean-k-mooney ok the instance.save im doing could raise so i guess i should use it sicne i dont really feel like wrapign that in a try except
11:43:07 sean-k-mooney i have generally been avoiding using it thoug when doing simple things like logging
11:43:07 sean-k-mooney i have generally been avoiding using it thoug when doing simple things like logging
11:58:05 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1928063 https://review.opendev.org/c/openstack/nova/+/790658
11:58:07 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1928063 https://review.opendev.org/c/openstack/nova/+/790658
11:58:07 openstack bug 1928063 in OpenStack Compute (nova) "SEV enabled instance unable to hard reboot" [Undecided,In progress] https://launchpad.net/bugs/1928063 - Assigned to Lee Yarwood (lyarwood)
11:58:07 openstackgerrit Lee Yarwood proposed openstack/nova master: image_meta: Provide image_ref as the id when fetching from instance https://review.opendev.org/c/openstack/nova/+/790659
11:58:07 openstackgerrit Lee Yarwood proposed openstack/nova master: hardware: Use image_meta.id within get_mem_encryption_constraint https://review.opendev.org/c/openstack/nova/+/790660
11:58:07 openstack bug 1928063 in OpenStack Compute (nova) "SEV enabled instance unable to hard reboot" [Undecided,In progress] https://launchpad.net/bugs/1928063 - Assigned to Lee Yarwood (lyarwood)
12:48:04 openstackgerrit Merged openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/c/openstack/nova/+/676209
12:48:05 openstackgerrit Merged openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/c/openstack/nova/+/676209
13:16:32 openstackgerrit Lee Yarwood proposed openstack/nova stable/wallaby: Add regression test for bug #1922053 https://review.opendev.org/c/openstack/nova/+/791477
13:16:33 openstackgerrit Lee Yarwood proposed openstack/nova stable/wallaby: api: Reject requests to force up computes when `done` evacuation records exist https://review.opendev.org/c/openstack/nova/+/791478
13:16:34 openstackgerrit Lee Yarwood proposed openstack/nova stable/wallaby: Add regression test for bug #1922053 https://review.opendev.org/c/openstack/nova/+/791477
13:16:34 openstack bug 1922053 in OpenStack Compute (nova) "Operators can force up compute services with `done` evacuation migration records still active against the host" [Medium,Fix released] https://launchpad.net/bugs/1922053 - Assigned to Lee Yarwood (lyarwood)
13:16:34 openstackgerrit Lee Yarwood proposed openstack/nova stable/wallaby: api: Reject requests to force up computes when `done` evacuation records exist https://review.opendev.org/c/openstack/nova/+/791478
13:31:44 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: Remove self.server dependency form _evacuate_server https://review.opendev.org/c/openstack/nova/+/791480
13:31:44 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: Remove self.server dependency form _evacuate_server https://review.opendev.org/c/openstack/nova/+/791480
13:31:45 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: Use _evacuate_server helper in func test https://review.opendev.org/c/openstack/nova/+/791481
13:31:45 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: Use _evacuate_server helper in func test https://review.opendev.org/c/openstack/nova/+/791481
13:31:46 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: Add regression test for bug #1922053 https://review.opendev.org/c/openstack/nova/+/791482
13:31:47 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: Add regression test for bug #1922053 https://review.opendev.org/c/openstack/nova/+/791482
13:31:47 openstack bug 1922053 in OpenStack Compute (nova) "Operators can force up compute services with `done` evacuation migration records still active against the host" [Medium,Fix released] https://launchpad.net/bugs/1922053 - Assigned to Lee Yarwood (lyarwood)
13:31:47 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: api: Reject requests to force up computes when `done` evacuation records exist https://review.opendev.org/c/openstack/nova/+/791483
13:31:48 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: api: Reject requests to force up computes when `done` evacuation records exist https://review.opendev.org/c/openstack/nova/+/791483
13:31:48 openstack bug 1922053 in OpenStack Compute (nova) "Operators can force up compute services with `done` evacuation migration records still active against the host" [Medium,Fix released] https://launchpad.net/bugs/1922053 - Assigned to Lee Yarwood (lyarwood)
14:45:01 openstackgerrit melanie witt proposed openstack/nova master: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/791297
14:45:01 openstackgerrit melanie witt proposed openstack/nova master: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/791297
14:55:49 melwitt gibi, dansmith: added a reno ^ I didn't know if/how I should use fancy markup in it so I didn't
14:55:49 melwitt gibi, dansmith: added a reno ^ I didn't know if/how I should use fancy markup in it so I didn't
14:56:36 gibi melwitt: thanks, will check back soon
14:56:36 gibi melwitt: thanks, will check back soon
14:58:03 melwitt ty
14:58:03 melwitt ty
14:59:43 dansmith melwitt: seems alright to me.. will let gibi +W if he's around and wants to review
14:59:43 dansmith melwitt: seems alright to me.. will let gibi +W if he's around and wants to review
14:59:44 dansmith but otherwise I'd be fine with it
14:59:44 dansmith but otherwise I'd be fine with it
15:00:17 melwitt sounds cool, thanks
15:00:18 melwitt sounds cool, thanks
15:11:24 openstackgerrit Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205
15:11:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206
15:11:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208
15:11:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix RequestLevelParams persistence handling in RequestSpec https://review.opendev.org/c/openstack/nova/+/791502
15:11:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503
15:11:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504
15:11:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505
15:11:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506
15:20:11 openstackgerrit Merged openstack/osc-placement master: Add functional-py39 tox target https://review.opendev.org/c/openstack/osc-placement/+/760912
15:20:11 openstackgerrit Merged openstack/osc-placement master: Add functional-py39 tox target https://review.opendev.org/c/openstack/osc-placement/+/760912
15:22:02 openstackgerrit Merged openstack/osc-placement master: Use TOX_CONSTRAINTS_FILE https://review.opendev.org/c/openstack/osc-placement/+/760710
15:22:02 openstackgerrit Merged openstack/osc-placement master: Use TOX_CONSTRAINTS_FILE https://review.opendev.org/c/openstack/osc-placement/+/760710
15:22:14 openstackgerrit Merged openstack/osc-placement master: Add py38 package metadata https://review.opendev.org/c/openstack/osc-placement/+/756985
15:22:14 openstackgerrit Merged openstack/osc-placement master: Add py38 package metadata https://review.opendev.org/c/openstack/osc-placement/+/756985
15:22:19 openstackgerrit Merged openstack/osc-placement master: Verify result for inventory set --dry-run https://review.opendev.org/c/openstack/osc-placement/+/680295
15:22:19 openstackgerrit Merged openstack/osc-placement master: Verify result for inventory set --dry-run https://review.opendev.org/c/openstack/osc-placement/+/680295
15:22:22 openstackgerrit Merged openstack/osc-placement master: Add "--resource-class" to allocation unset https://review.opendev.org/c/openstack/osc-placement/+/697620
15:22:22 openstackgerrit Merged openstack/osc-placement master: Add "--resource-class" to allocation unset https://review.opendev.org/c/openstack/osc-placement/+/697620
15:25:22 gibi melwitt: is it OK for you if I touch the reno a bit to add some formatting?
15:25:22 gibi melwitt: is it OK for you if I touch the reno a bit to add some formatting?
15:25:34 melwitt gibi: sure, go ahead
15:25:34 melwitt gibi: sure, go ahead
15:25:43 gibi OK
15:25:43 gibi OK
15:28:37 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/791297
15:28:37 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/791297
15:44:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix RequestLevelParams persistence handling in RequestSpec https://review.opendev.org/c/openstack/nova/+/791502
15:44:45 openstackgerrit Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205
15:46:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206
15:46:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503
15:46:18 openstackgerrit Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504
15:48:57 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505
15:49:00 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506
15:50:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208
16:32:35 openstackgerrit Merged openstack/os-vif master: Creating oslo.config.opts entry_points for plugins https://review.opendev.org/c/openstack/os-vif/+/789645
16:32:35 openstackgerrit Merged openstack/os-vif master: Creating oslo.config.opts entry_points for plugins https://review.opendev.org/c/openstack/os-vif/+/789645
16:32:39 openstackgerrit Merged openstack/os-vif master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/os-vif/+/789734
16:32:39 openstackgerrit Merged openstack/os-vif master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/os-vif/+/789734
21:03:47 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Regression test for changing the MTU during a live migration https://review.opendev.org/c/openstack/nova/+/791235
21:08:22 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Regression test for changing the MTU during a live migration https://review.opendev.org/c/openstack/nova/+/791235
21:08:22 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Don't update the MTU during a live migration https://review.opendev.org/c/openstack/nova/+/791553
21:08:22 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Regression test for changing the MTU during a live migration https://review.opendev.org/c/openstack/nova/+/791235
21:08:22 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Don't update the MTU during a live migration https://review.opendev.org/c/openstack/nova/+/791553
21:08:37 artom sean-k-mooney, you're probably off by now, but ^^ is proof that we suck
21:08:37 artom sean-k-mooney, you're probably off by now, but ^^ is proof that we suck
21:20:35 sean-k-mooney artom: not really its not ment to be updated
21:20:35 sean-k-mooney artom: not really its not ment to be updated

Earlier   Later