Earlier  
Posted Nick Remark
#openstack-nova - 2021-04-30
12:45:44 lyarwood damiandabrowski: I don't think we had to fix that as the libvirt devs eventually stopped enforcing that
12:46:02 lyarwood damiandabrowski: which base OS is this?
12:46:03 lyarwood damiandabrowski: which base OS is this?
12:47:30 damiandabrowski <lyarwood "damiandabrowski: which base OS i"> ubuntu 18.04, libvirt 6.0.0-0ubuntu8.8~cloud0
12:47:30 damiandabrowski <lyarwood "damiandabrowski: which base OS i"> ubuntu 18.04, libvirt 6.0.0-0ubuntu8.8~cloud0
12:48:00 lyarwood kashyap: ^ the libvirt devs eventually removed that right?
12:48:00 lyarwood kashyap: ^ the libvirt devs eventually removed that right?
12:48:14 kashyap * kashyap reads
12:48:52 kashyap lyarwood: Yes, I recall; but I need to find trhe right commit
12:48:52 kashyap lyarwood: Yes, I recall; but I need to find trhe right commit
12:49:19 kashyap * kashyap digs up
13:08:52 kashyap damiandabrowski: lyarwood: There we go: "Allow format probing under special circumstances": https://github.com/libvirt/libvirt/commit/ae9e6c2a2b
13:08:52 kashyap damiandabrowski: lyarwood: There we go: "Allow format probing under special circumstances": https://github.com/libvirt/libvirt/commit/ae9e6c2a2b
13:09:02 kashyap damiandabrowski: lyarwood: That's the libvirt commit that relaxes the restriction
13:09:02 kashyap damiandabrowski: lyarwood: That's the libvirt commit that relaxes the restriction
13:09:50 lyarwood so you need >=6.1.0
13:09:51 lyarwood so you need >=6.1.0
13:09:53 kashyap damiandabrowski: That should be in 6.1.0 and above. (I checked via `git tag --contains`)
13:09:53 kashyap damiandabrowski: That should be in 6.1.0 and above. (I checked via `git tag --contains`)
13:09:56 kashyap lyarwood: Yep
13:09:56 kashyap lyarwood: Yep
13:10:31 lyarwood kashyap: I guess we could write a known issues releasenote about that
13:10:31 lyarwood kashyap: I guess we could write a known issues releasenote about that
13:11:06 kashyap lyarwood: Yeah; that's reasonable. I can volunteer to write one.
13:11:06 kashyap lyarwood: Yeah; that's reasonable. I can volunteer to write one.
13:13:54 lyarwood kashyap: awesome thanks
13:13:54 lyarwood kashyap: awesome thanks
13:16:31 damiandabrowski thanks a lot for the input!
13:16:31 damiandabrowski thanks a lot for the input!
13:16:40 kashyap I'd call it a "resolved known issue" :-)
13:16:40 kashyap I'd call it a "resolved known issue" :-)
14:09:39 dansmith gibi: but we should be checking for the *last* victoria version to determine if something is victoria, right?
14:09:39 dansmith gibi: but we should be checking for the *last* victoria version to determine if something is victoria, right?
14:12:59 noonedeadpunk hey there!
14:12:59 noonedeadpunk hey there!
14:13:48 gibi dansmith: when we says that Wallaby controller supports Victoria compute, doesn't that means it supports even first Victoria service version?
14:13:48 gibi dansmith: when we says that Wallaby controller supports Victoria compute, doesn't that means it supports even first Victoria service version?
14:14:30 gibi ~ the oldest thing we support is the oldest Victoria pieces
14:14:30 gibi ~ the oldest thing we support is the oldest Victoria pieces
14:15:03 noonedeadpunk We've faced nasty thing on bionic, regarding libvirt virStorageFileGetMetadataRecurse. While new images are created properly thanks to https://review.opendev.org/c/openstack/nova/+/710790/ I'm not sure about the way forward for existing ones
14:15:03 noonedeadpunk We've faced nasty thing on bionic, regarding libvirt virStorageFileGetMetadataRecurse. While new images are created properly thanks to https://review.opendev.org/c/openstack/nova/+/710790/ I'm not sure about the way forward for existing ones
14:15:20 noonedeadpunk as once VM stopps, it can't be started anymore
14:15:20 noonedeadpunk as once VM stopps, it can't be started anymore
14:16:06 noonedeadpunk I believe I'm not the first who comes with this, but yeah :(
14:16:06 noonedeadpunk I believe I'm not the first who comes with this, but yeah :(
14:16:24 dansmith gibi: that's not how we've ever done it for RPC, for example, but I guess it's fair.. it's just confusing though,
14:16:24 dansmith gibi: that's not how we've ever done it for RPC, for example, but I guess it's fair.. it's just confusing though,
14:16:38 lyarwood noonedeadpunk: it was discussed earlier in the channel, you need libvirt >= 6.1.0
14:16:39 lyarwood noonedeadpunk: it was discussed earlier in the channel, you need libvirt >= 6.1.0
14:16:45 dansmith because from the perspective of someone trying to figure out what it's looking for, the numbers don't match up
14:16:45 dansmith because from the perspective of someone trying to figure out what it's looking for, the numbers don't match up
14:16:46 lyarwood noonedeadpunk: we don't workaround this in nova
14:16:46 lyarwood noonedeadpunk: we don't workaround this in nova
14:16:56 dansmith gibi: but if that's the goal, then I guess it's okay
14:16:56 dansmith gibi: but if that's the goal, then I guess it's okay
14:17:26 noonedeadpunk lyarwood: yeah, I see that, but libvirt 6.1.0 is smth that seems needs to be built manually I guess
14:17:26 noonedeadpunk lyarwood: yeah, I see that, but libvirt 6.1.0 is smth that seems needs to be built manually I guess
14:17:32 noonedeadpunk as UCA doesn't provide that :(
14:17:32 noonedeadpunk as UCA doesn't provide that :(
14:17:40 lyarwood noonedeadpunk: then raise a bug with the UCA folks
14:17:40 lyarwood noonedeadpunk: then raise a bug with the UCA folks
14:18:01 gibi dansmith: at least it is documented in the code comment above the alias https://github.com/openstack/nova/blob/dab4ec1a534d4774e61a24cdace0f3491788e4e7/nova/objects/service.py#L206 so the intention is clear for the reader
14:18:01 gibi dansmith: at least it is documented in the code comment above the alias https://github.com/openstack/nova/blob/dab4ec1a534d4774e61a24cdace0f3491788e4e7/nova/objects/service.py#L206 so the intention is clear for the reader
14:18:10 noonedeadpunk I believe there were solid reasons not to workaround in nova?
14:18:10 noonedeadpunk I believe there were solid reasons not to workaround in nova?
14:18:27 dansmith gibi: okay :)
14:18:27 dansmith gibi: okay :)
14:18:29 lyarwood noonedeadpunk: yeah it would require us to rebase the disks at launch
14:18:29 lyarwood noonedeadpunk: yeah it would require us to rebase the disks at launch
14:18:38 noonedeadpunk Just thinking if it make sense to look into this direction or not
14:18:38 noonedeadpunk Just thinking if it make sense to look into this direction or not
14:18:41 gibi dansmith: :)
14:18:41 gibi dansmith: :)
14:18:56 noonedeadpunk yeah, that's exactly how I'm fixing at atm
14:18:56 noonedeadpunk yeah, that's exactly how I'm fixing at atm
14:19:13 gibi dansmith: I was positively suprised that deployers look at the warning we emit from the compute version check
14:19:13 gibi dansmith: I was positively suprised that deployers look at the warning we emit from the compute version check
14:19:44 dansmith some will ignore it I'm sure
14:19:44 dansmith some will ignore it I'm sure
14:21:16 noonedeadpunk eventually it's pretty straightforward fix for nova I guess? or some consideration why not to run rebase when we're failing as fallback?
14:21:16 noonedeadpunk eventually it's pretty straightforward fix for nova I guess? or some consideration why not to run rebase when we're failing as fallback?
14:21:36 lyarwood noonedeadpunk: it's just extra overhead we didn't want to carry when the fix in libvirt is already available
14:21:36 lyarwood noonedeadpunk: it's just extra overhead we didn't want to carry when the fix in libvirt is already available
14:21:46 lyarwood noonedeadpunk: el distros were quick to pick it up
14:21:46 lyarwood noonedeadpunk: el distros were quick to pick it up
14:22:03 noonedeadpunk yeah, as libvirt is el thing....
14:22:03 noonedeadpunk yeah, as libvirt is el thing....
14:22:22 lyarwood it's not like it's closed source :)
14:22:22 lyarwood it's not like it's closed source :)
14:22:40 noonedeadpunk * noonedeadpunk wishes el was picking up other stuff as fast (like py38 libselinux bindings)
14:22:57 noonedeadpunk ok, gotcha, thanks
14:22:57 noonedeadpunk ok, gotcha, thanks
16:51:43 openstackgerrit Balazs Gibizer proposed openstack/nova master: Adapt to SQLAlchemy 1.4 https://review.opendev.org/c/openstack/nova/+/788471
17:56:23 openstackgerrit Merged openstack/nova stable/ussuri: Rebase qcow2 images when unshelving an instance https://review.opendev.org/c/openstack/nova/+/785625
17:56:23 openstackgerrit Merged openstack/nova stable/ussuri: Rebase qcow2 images when unshelving an instance https://review.opendev.org/c/openstack/nova/+/785625
17:59:48 openstackgerrit Merged openstack/nova stable/ussuri: Update image_base_image_ref during rebuild. https://review.opendev.org/c/openstack/nova/+/787943
17:59:48 openstackgerrit Merged openstack/nova stable/ussuri: Update image_base_image_ref during rebuild. https://review.opendev.org/c/openstack/nova/+/787943
18:12:52 openstackgerrit Merged openstack/nova master: Consolidate device detach error handling https://review.opendev.org/c/openstack/nova/+/778978
18:12:52 openstackgerrit Merged openstack/nova master: Consolidate device detach error handling https://review.opendev.org/c/openstack/nova/+/778978
18:45:16 outbrito Good day folks! I'm working on the StarlingX Openstack project and I just found a problem with one of nova's dependencies and I'd like to get youe feedback about how I'm thinking about fixing it

Earlier   Later