| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-04-22 | |||
| 09:04:42 | stephenfin | \o/ | |
| 09:04:42 | stephenfin | \o/ | |
| 09:04:44 | stephenfin | thanks | |
| 09:15:39 | gibi | stephenfin: hi! there are two followups for the device detach series that would need a second set of eyes https://review.opendev.org/c/openstack/nova/+/778918 | |
| 09:15:39 | gibi | stephenfin: hi! there are two followups for the device detach series that would need a second set of eyes https://review.opendev.org/c/openstack/nova/+/778918 | |
| 09:54:05 | stephenfin | gibi: comments on https://review.opendev.org/c/openstack/nova/+/778918 | |
| 09:54:05 | stephenfin | gibi: comments on https://review.opendev.org/c/openstack/nova/+/778918 | |
| 09:56:58 | gibi | stephenfin: thanks, will look in a bit | |
| 09:56:58 | gibi | stephenfin: thanks, will look in a bit | |
| 09:58:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Remove 'kwargs' from 'get_instance_nw_info' https://review.opendev.org/c/openstack/nova/+/744872 | |
| 09:58:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Remove 'kwargs' from 'get_instance_nw_info' https://review.opendev.org/c/openstack/nova/+/744872 | |
| 09:58:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Remove unused 'affect_auto_assigned' parameter https://review.opendev.org/c/openstack/nova/+/744871 | |
| 09:58:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Remove unused 'affect_auto_assigned' parameter https://review.opendev.org/c/openstack/nova/+/744871 | |
| 09:58:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Add type hints for various allocate functions https://review.opendev.org/c/openstack/nova/+/744870 | |
| 09:58:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Add type hints for deallocate functions https://review.opendev.org/c/openstack/nova/+/787516 | |
| 09:58:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: More allocate, deallocate type hints https://review.opendev.org/c/openstack/nova/+/787517 | |
| 09:58:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Add type hints for attach, detach functions https://review.opendev.org/c/openstack/nova/+/787518 | |
| 10:21:19 | sean-k-mooney | gibi: just added you to https://review.opendev.org/q/topic:%22review-priority%22+(status:open%20OR%20status:merged) | |
| 10:21:19 | sean-k-mooney | gibi: just added you to https://review.opendev.org/q/topic:%22review-priority%22+(status:open%20OR%20status:merged) | |
| 10:21:48 | sean-k-mooney | some of the placement repos do not have the correct acls defiend so i added those as a copy of the placment repos config in the second patch | |
| 10:21:48 | sean-k-mooney | some of the placement repos do not have the correct acls defiend so i added those as a copy of the placment repos config in the second patch | |
| 10:28:41 | openstackgerrit | Balazs Gibizer proposed openstack/placement stable/wallaby: Add a reproduction test for bug story/2008831 https://review.opendev.org/c/openstack/placement/+/787525 | |
| 10:28:56 | openstackgerrit | Balazs Gibizer proposed openstack/placement stable/wallaby: Make sure the policy upgrade check get a valid config https://review.opendev.org/c/openstack/placement/+/787526 | |
| 10:47:51 | gibi | stephenfin: replied in https://review.opendev.org/c/openstack/nova/+/778918 I agree with your comment. I will respin | |
| 10:47:51 | gibi | stephenfin: replied in https://review.opendev.org/c/openstack/nova/+/778918 I agree with your comment. I will respin | |
| 11:27:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move instance power state check to _detach_with_retry https://review.opendev.org/c/openstack/nova/+/778918 | |
| 11:27:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move instance power state check to _detach_with_retry https://review.opendev.org/c/openstack/nova/+/778918 | |
| 11:27:59 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consolidate device detach error handling https://review.opendev.org/c/openstack/nova/+/778978 | |
| 11:27:59 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consolidate device detach error handling https://review.opendev.org/c/openstack/nova/+/778978 | |
| 11:28:09 | gibi | stephenfin: fixed your comments ^^ | |
| 11:28:09 | gibi | stephenfin: fixed your comments ^^ | |
| 11:28:15 | gibi | sean-k-mooney: thanks, I will check them | |
| 11:28:15 | gibi | sean-k-mooney: thanks, I will check them | |
| 11:40:10 | openstackgerrit | Merged openstack/nova-specs master: trivial: Fix spelling, formatting of vDPA spec https://review.opendev.org/c/openstack/nova-specs/+/781260 | |
| 11:40:10 | openstackgerrit | Merged openstack/nova-specs master: trivial: Fix spelling, formatting of vDPA spec https://review.opendev.org/c/openstack/nova-specs/+/781260 | |
| 11:40:28 | Dmitrii-Sh | o/ Looking for some input on a spec: https://review.opendev.org/c/openstack/nova-specs/+/787458. If there is interest, I am open for discussion during the remaining PTG time (via meetpad.opendev.org or other means) or afterwards via gerrit/IRC/email etc. Any feedback would be much appreciated. I added this as a topic to the Nova etherpad | |
| 11:40:28 | Dmitrii-Sh | https://etherpad.opendev.org/p/nova-xena-ptg - hopefully there will be some time left to discuss it. | |
| 11:40:28 | Dmitrii-Sh | o/ Looking for some input on a spec: https://review.opendev.org/c/openstack/nova-specs/+/787458. If there is interest, I am open for discussion during the remaining PTG time (via meetpad.opendev.org or other means) or afterwards via gerrit/IRC/email etc. Any feedback would be much appreciated. I added this as a topic to the Nova etherpad | |
| 11:40:28 | Dmitrii-Sh | https://etherpad.opendev.org/p/nova-xena-ptg - hopefully there will be some time left to discuss it. | |
| 11:41:15 | openstackgerrit | Merged openstack/nova master: docs: Follow up for SEV doc https://review.opendev.org/c/openstack/nova/+/783830 | |
| 11:41:15 | openstackgerrit | Merged openstack/nova master: docs: Follow up for SEV doc https://review.opendev.org/c/openstack/nova/+/783830 | |
| 11:42:06 | sean-k-mooney | looking at it quickly but form the title this sound complex | |
| 11:42:06 | sean-k-mooney | looking at it quickly but form the title this sound complex | |
| 11:45:40 | openstackgerrit | Merged openstack/nova master: docs: Correct typos in 'nova-manage db' docs https://review.opendev.org/c/openstack/nova/+/784067 | |
| 11:45:40 | openstackgerrit | Merged openstack/nova master: docs: Correct typos in 'nova-manage db' docs https://review.opendev.org/c/openstack/nova/+/784067 | |
| 11:46:15 | sean-k-mooney | Dmitrii-Sh: we are planning to discuss tracking pci device in placement but im not conviced that what you are suggestign is compatiable with the direction we wanted to take | |
| 11:46:15 | sean-k-mooney | Dmitrii-Sh: we are planning to discuss tracking pci device in placement but im not conviced that what you are suggestign is compatiable with the direction we wanted to take | |
| 11:47:56 | sean-k-mooney | Dmitrii-Sh: you have clearly put a lot of tought into this by the way form the lenght of the spec so this will take some time to digest | |
| 11:47:56 | sean-k-mooney | Dmitrii-Sh: you have clearly put a lot of tought into this by the way form the lenght of the spec so this will take some time to digest | |
| 11:48:23 | Dmitrii-Sh | sean-k-mooney: I see, I could find ways to adjust it such that it is compatible with the effort to track pci devices in the placement DB. | |
| 11:48:23 | Dmitrii-Sh | sean-k-mooney: I see, I could find ways to adjust it such that it is compatible with the effort to track pci devices in the placement DB. | |
| 11:48:47 | Dmitrii-Sh | As such, part of what I am suggesting for the Nova DB is only there to build the Placement DB state. | |
| 11:48:47 | Dmitrii-Sh | As such, part of what I am suggesting for the Nova DB is only there to build the Placement DB state. | |
| 11:50:24 | sean-k-mooney | we were going to suggest tracking each PF as an RP and having inventories of VF,PF and pci devices | |
| 11:50:24 | sean-k-mooney | we were going to suggest tracking each PF as an RP and having inventories of VF,PF and pci devices | |
| 11:50:29 | Dmitrii-Sh | So I could place the right state into the Placement DB right away but that's to be seen | |
| 11:50:29 | Dmitrii-Sh | So I could place the right state into the Placement DB right away but that's to be seen | |
| 11:50:45 | sean-k-mooney | the pci_devices tabel would still be used to track the slecect of the specific pci device | |
| 11:50:45 | sean-k-mooney | the pci_devices tabel would still be used to track the slecect of the specific pci device | |
| 11:51:19 | sean-k-mooney | we dont want to actully have placment select a specifc VF for example | |
| 11:51:19 | sean-k-mooney | we dont want to actully have placment select a specifc VF for example | |
| 11:52:48 | artom | Dmitrii-Sh, I saw you post the spec last night. I think your biggest problem is that only youself and sean-k-mooney understand any of the hardware bits :P | |
| 11:52:48 | artom | Dmitrii-Sh, I saw you post the spec last night. I think your biggest problem is that only youself and sean-k-mooney understand any of the hardware bits :P | |
| 11:53:15 | Dmitrii-Sh | sean-k-mooney: I see. Do you plan to replace InstancePCIRequests with placement resource requests? | |
| 11:53:15 | Dmitrii-Sh | sean-k-mooney: I see. Do you plan to replace InstancePCIRequests with placement resource requests? | |
| 11:53:36 | artom | Dmitrii-Sh, I think a sort of "smartnic for dummies" paragraph (or section) might be useful, just to give the rest of use context on what this thing even is | |
| 11:53:36 | artom | Dmitrii-Sh, I think a sort of "smartnic for dummies" paragraph (or section) might be useful, just to give the rest of use context on what this thing even is | |
| 11:55:07 | Dmitrii-Sh | artom: ty. I tried to make it largely agnostic of a specific vendor and target a class of devices: off-path SmartNICs with a separate (mostly ARM) CPU. There are several vendors out there that follow this pattern. | |
| 11:55:07 | Dmitrii-Sh | artom: ty. I tried to make it largely agnostic of a specific vendor and target a class of devices: off-path SmartNICs with a separate (mostly ARM) CPU. There are several vendors out there that follow this pattern. | |
| 11:55:34 | Dmitrii-Sh | but I can add a paragraph discussing it, or even better, a reference to an overview about those | |
| 11:55:34 | Dmitrii-Sh | but I can add a paragraph discussing it, or even better, a reference to an overview about those | |
| 11:55:52 | artom | I don't want to speak for everyone here, but you have a whole bunch of vocabulary there that isn't accessible to most of us ("switchdev-capable", "off-path") | |
| 11:55:52 | artom | I don't want to speak for everyone here, but you have a whole bunch of vocabulary there that isn't accessible to most of us ("switchdev-capable", "off-path") | |
| 11:56:12 | Dmitrii-Sh | I guess I should link this then https://netdevconf.info/0x14/pub/slides/39/Netdev%200x14%20--%20Taking%20Control%20of%20your%20SmartNIC%20v1.pdf | |
| 11:56:12 | Dmitrii-Sh | I guess I should link this then https://netdevconf.info/0x14/pub/slides/39/Netdev%200x14%20--%20Taking%20Control%20of%20your%20SmartNIC%20v1.pdf | |
| 11:56:25 | sean-k-mooney | Dmitrii-Sh: not replace them no but we would also claime resouces in placment for them | |
| 11:56:25 | sean-k-mooney | Dmitrii-Sh: not replace them no but we would also claime resouces in placment for them | |
| 11:56:44 | artom | Dmitrii-Sh, yeah, any kind of introduction or reference to what this hardware is and how it's different from the PCI devices that we're used to would be very useful. For me, at least. | |
| 11:56:44 | artom | Dmitrii-Sh, yeah, any kind of introduction or reference to what this hardware is and how it's different from the PCI devices that we're used to would be very useful. For me, at least. | |
| 11:56:54 | artom | Hopefully for other non-sean-mooney reviewers too | |
| 11:56:54 | artom | Hopefully for other non-sean-mooney reviewers too | |
| 11:57:25 | sean-k-mooney | Dmitrii-Sh: im not really trielled with nova calling neutron as part fo vif plugging as a clinet | |
| 11:57:25 | sean-k-mooney | Dmitrii-Sh: im not really trielled with nova calling neutron as part fo vif plugging as a clinet | |
| 11:57:31 | Dmitrii-Sh | artom: ack, will do. I understand that it's a lot of info to process | |
| 11:57:31 | sean-k-mooney | even if that was doen via os-vif | |
| 11:57:31 | Dmitrii-Sh | artom: ack, will do. I understand that it's a lot of info to process | |
| 11:57:31 | sean-k-mooney | even if that was doen via os-vif | |
| 11:58:07 | sean-k-mooney | Dmitrii-Sh: have you spoken to the cyborg team about this by the way | |
| 11:58:07 | sean-k-mooney | Dmitrii-Sh: have you spoken to the cyborg team about this by the way | |
| 11:58:34 | sean-k-mooney | they were tryign to enable reprogrambel smart nics via a different approch | |
| 11:58:34 | sean-k-mooney | they were tryign to enable reprogrambel smart nics via a different approch | |
| 11:58:50 | Dmitrii-Sh | sean-k-mooney: I've seen their specs but they seem to be targeting FPGA-based on-path NICs (Intel IIRC) | |
| 11:58:50 | Dmitrii-Sh | sean-k-mooney: I've seen their specs but they seem to be targeting FPGA-based on-path NICs (Intel IIRC) | |
| 11:59:10 | Dmitrii-Sh | and the approach there is to program NICs from the hypervisor host itself | |
| 11:59:10 | Dmitrii-Sh | and the approach there is to program NICs from the hypervisor host itself | |
| 11:59:11 | sean-k-mooney | Dmitrii-Sh: primarally | |
| 11:59:11 | sean-k-mooney | Dmitrii-Sh: primarally | |
| 11:59:26 | sean-k-mooney | i just wanted to make sure you were aware of it | |
| 11:59:26 | sean-k-mooney | i just wanted to make sure you were aware of it | |
| 11:59:27 | Dmitrii-Sh | where as here there is a security boundary between the hypervisor host and the SmartNIC host | |