| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-04-14 | |||
| 15:07:40 | lyarwood | ack thanks :) | |
| 15:07:40 | lyarwood | ack thanks :) | |
| 15:08:10 | noonedeadpunk | sean-k-mooney: well, today I learned, and pushed https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/786258 to use templates. Better late, then never... | |
| 15:08:10 | noonedeadpunk | sean-k-mooney: well, today I learned, and pushed https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/786258 to use templates. Better late, then never... | |
| 15:08:30 | gibi | lyarwood: btw, I went back to the libvirt detach patch series. I hope I can push some update today | |
| 15:08:30 | gibi | lyarwood: btw, I went back to the libvirt detach patch series. I hope I can push some update today | |
| 15:09:37 | lyarwood | gibi: oh cool, I've had my head downstream all day with internal escalations | |
| 15:09:37 | lyarwood | gibi: oh cool, I've had my head downstream all day with internal escalations | |
| 15:10:08 | gibi | lyarwood: sounds bad | |
| 15:10:08 | gibi | lyarwood: sounds bad | |
| 15:18:36 | openstackgerrit | Johannes Kulik proposed openstack/nova master: vmware: Handle empty list attributes on vSphere objects https://review.opendev.org/c/openstack/nova/+/786262 | |
| 15:18:36 | openstackgerrit | Johannes Kulik proposed openstack/nova master: vmware: Handle empty list attributes on vSphere objects https://review.opendev.org/c/openstack/nova/+/786262 | |
| 15:29:44 | gibi | woot http://lists.openstack.org/pipermail/openstack-announce/2021-April/002047.html | |
| 15:29:44 | gibi | woot http://lists.openstack.org/pipermail/openstack-announce/2021-April/002047.html | |
| 15:30:00 | lyarwood | \o/ | |
| 16:32:16 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246 | |
| 16:32:16 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move instance power state check to _detach_with_retry https://review.opendev.org/c/openstack/nova/+/778918 | |
| 16:33:40 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consolidate device detach error handling https://review.opendev.org/c/openstack/nova/+/778978 | |
| 16:35:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move the guest.get_disk test to test_guest https://review.opendev.org/c/openstack/nova/+/777151 | |
| 16:35:40 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable mypy on libvirt/guest.py https://review.opendev.org/c/openstack/nova/+/777155 | |
| 16:36:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Follow up type hints for a634103 https://review.opendev.org/c/openstack/nova/+/777159 | |
| 16:36:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: Remove dead error handling code https://review.opendev.org/c/openstack/nova/+/779704 | |
| 16:54:32 | openstackgerrit | Merged openstack/nova master: docs: Document options for remaining nova-* commands https://review.opendev.org/c/openstack/nova/+/726195 | |
| 16:54:32 | openstackgerrit | Merged openstack/nova master: docs: Document options for remaining nova-* commands https://review.opendev.org/c/openstack/nova/+/726195 | |
| 16:55:12 | openstackgerrit | Merged openstack/nova master: docs: Populate "See Also" section with meaningful links https://review.opendev.org/c/openstack/nova/+/729917 | |
| 16:55:12 | openstackgerrit | Merged openstack/nova master: docs: Populate "See Also" section with meaningful links https://review.opendev.org/c/openstack/nova/+/729917 | |
| 16:56:30 | sean-k-mooney | noonedeadpunk: cool | |
| 16:56:30 | sean-k-mooney | noonedeadpunk: cool | |
| 16:56:51 | sean-k-mooney | noonedeadpunk: i think ooo was previously the only tool to make use of that but its a nice feature to have | |
| 16:56:51 | sean-k-mooney | noonedeadpunk: i think ooo was previously the only tool to make use of that but its a nice feature to have | |
| 17:43:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove dead code https://review.opendev.org/c/openstack/nova/+/786291 | |
| 17:44:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove 'nova.db.sqlalchemy.utils' https://review.opendev.org/c/openstack/nova/+/786292 | |
| 17:44:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove unused DB methods https://review.opendev.org/c/openstack/nova/+/786293 | |
| 17:44:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: test: Remove checks for SQLite < 3.7 https://review.opendev.org/c/openstack/nova/+/786294 | |
| 17:44:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: test: Remove checks for SQLite < 3.7 https://review.opendev.org/c/openstack/nova/+/786294 | |
| 17:44:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Use module-level imports for sqlalchemy https://review.opendev.org/c/openstack/nova/+/786295 | |
| 17:44:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Fold in indexes https://review.opendev.org/c/openstack/nova/+/786296 | |
| 17:44:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Fold in ForeignKey constraints https://review.opendev.org/c/openstack/nova/+/786297 | |
| 17:44:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove 'nova.db.base' module https://review.opendev.org/c/openstack/nova/+/786298 | |
| 17:44:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Copy docs from 'nova.db.*' to 'nova.db.sqlalchemy.*' https://review.opendev.org/c/openstack/nova/+/786299 | |
| 17:44:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Synchronize function signatures https://review.opendev.org/c/openstack/nova/+/786300 | |
| 17:44:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Clean up migration code https://review.opendev.org/c/openstack/nova/+/786301 | |
| 19:36:13 | noonedeadpunk | sean-k-mooney: we really want to follow best practises but not always have time for reading all renos for all releases :( So eventually missing cool things :( | |
| 19:36:13 | noonedeadpunk | sean-k-mooney: we really want to follow best practises but not always have time for reading all renos for all releases :( So eventually missing cool things :( | |
| 19:42:37 | noonedeadpunk | oh, wait. Isn't cell name not unique now? | |
| 19:42:37 | noonedeadpunk | oh, wait. Isn't cell name not unique now? | |
| 19:43:29 | noonedeadpunk | http://paste.openstack.org/show/804488/ <- Is it expected? | |
| 19:43:29 | noonedeadpunk | http://paste.openstack.org/show/804488/ <- Is it expected? | |
| 19:44:11 | noonedeadpunk | this happens only with the template by the way | |
| 19:44:11 | noonedeadpunk | this happens only with the template by the way | |
| 19:47:54 | noonedeadpunk | this condition feels wrong for the template https://opendev.org/openstack/nova/src/branch/master/nova/cmd/manage.py#L623-L624 | |
| 19:47:54 | noonedeadpunk | this condition feels wrong for the template https://opendev.org/openstack/nova/src/branch/master/nova/cmd/manage.py#L623-L624 | |
| 19:50:13 | noonedeadpunk | because `cell.database_connection` and `cell.transport_url` are always resolved while checked, and `database_connection` with `transport_url` are shown as template... | |
| 19:50:13 | noonedeadpunk | because `cell.database_connection` and `cell.transport_url` are always resolved while checked, and `database_connection` with `transport_url` are shown as template... | |
| 19:56:56 | noonedeadpunk | wrote down https://bugs.launchpad.net/nova/+bug/1923899 - will try to check what can be done there tomorrow, unless there already be a suggestions | |
| 19:56:56 | noonedeadpunk | wrote down https://bugs.launchpad.net/nova/+bug/1923899 - will try to check what can be done there tomorrow, unless there already be a suggestions | |
| 19:56:57 | openstack | Launchpad bug 1923899 in OpenStack Compute (nova) "Nova create duplicate cells when templates are used" [Undecided,New] | |
| 20:05:08 | openstackgerrit | Merged openstack/nova master: Explaining when a base image is considered unused to avoid confusion why some images aren't deleted. https://review.opendev.org/c/openstack/nova/+/786059 | |
| 20:05:08 | openstackgerrit | Merged openstack/nova master: Explaining when a base image is considered unused to avoid confusion why some images aren't deleted. https://review.opendev.org/c/openstack/nova/+/786059 | |
| 20:13:48 | noonedeadpunk | It feels like template conversion is processed somewhere in models, as eventually here it's already converted from template to url https://opendev.org/openstack/nova/src/branch/master/nova/objects/cell_mapping.py#L258 | |
| 20:13:48 | noonedeadpunk | It feels like template conversion is processed somewhere in models, as eventually here it's already converted from template to url https://opendev.org/openstack/nova/src/branch/master/nova/objects/cell_mapping.py#L258 | |
| 20:13:58 | noonedeadpunk | unless it's done somewhere in oslo.... | |
| 20:13:58 | noonedeadpunk | unless it's done somewhere in oslo.... | |
| 20:14:46 | noonedeadpunk | as kind of see nothing in models... https://opendev.org/openstack/nova/src/branch/master/nova/db/sqlalchemy/api_models.py#L111 | |
| 20:14:46 | noonedeadpunk | as kind of see nothing in models... https://opendev.org/openstack/nova/src/branch/master/nova/db/sqlalchemy/api_models.py#L111 | |
| 20:18:45 | noonedeadpunk | ok, that's where conversion is done https://opendev.org/openstack/nova/src/branch/master/nova/objects/cell_mapping.py#L159-L169 | |
| 20:18:45 | noonedeadpunk | ok, that's where conversion is done https://opendev.org/openstack/nova/src/branch/master/nova/objects/cell_mapping.py#L159-L169 | |
| 20:19:37 | sean-k-mooney | noonedeadpunk: the cell names are uniqe yes | |
| 20:19:37 | sean-k-mooney | noonedeadpunk: the cell names are uniqe yes | |
| 20:20:10 | sean-k-mooney | but i dont think we enforce that with a db constraint | |
| 20:20:10 | sean-k-mooney | but i dont think we enforce that with a db constraint | |
| 20:20:36 | sean-k-mooney | im not sure what will happen with http://paste.openstack.org/show/804488/ | |
| 20:20:36 | sean-k-mooney | im not sure what will happen with http://paste.openstack.org/show/804488/ | |
| 20:20:39 | noonedeadpunk | yeah, there's totally a bug in tempaltes usage | |
| 20:20:39 | noonedeadpunk | yeah, there's totally a bug in tempaltes usage | |
| 20:20:43 | sean-k-mooney | other then it will proably break | |
| 20:20:43 | sean-k-mooney | other then it will proably break | |
| 20:22:01 | sean-k-mooney | noonedeadpunk: it look like maybe you don thave support for multiple cells? | |
| 20:22:01 | sean-k-mooney | noonedeadpunk: it look like maybe you don thave support for multiple cells? | |
| 20:22:10 | sean-k-mooney | looking at https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/786258/1/tasks/nova_db_setup.yml | |
| 20:22:10 | sean-k-mooney | looking at https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/786258/1/tasks/nova_db_setup.yml | |
| 20:22:11 | noonedeadpunk | not sure just what's the best way to pass to avoid formatting here https://opendev.org/openstack/nova/src/branch/master/nova/objects/cell_mapping.py#L159-L169 considering it's going through oslo.versionedobjects | |
| 20:22:11 | noonedeadpunk | not sure just what's the best way to pass to avoid formatting here https://opendev.org/openstack/nova/src/branch/master/nova/objects/cell_mapping.py#L159-L169 considering it's going through oslo.versionedobjects | |
| 20:22:20 | sean-k-mooney | it was previously hardcoded as --name {{ nova_cell1_name }} | |
| 20:22:20 | sean-k-mooney | it was previously hardcoded as --name {{ nova_cell1_name }} | |
| 20:23:07 | noonedeadpunk | well, my point is more about that if I run excatly same create_cell command twice - I get exact same 2 cells with different uuids | |
| 20:23:07 | noonedeadpunk | well, my point is more about that if I run excatly same create_cell command twice - I get exact same 2 cells with different uuids | |
| 20:23:38 | sean-k-mooney | ya which is porably a nova bug | |
| 20:23:38 | sean-k-mooney | ya which is porably a nova bug | |
| 20:23:54 | noonedeadpunk | because verification if that cell already exists is just broken for tempalate user scenario - as it compares what is passed as an argument with already resolved template | |
| 20:23:54 | noonedeadpunk | because verification if that cell already exists is just broken for tempalate user scenario - as it compares what is passed as an argument with already resolved template | |
| 20:23:57 | sean-k-mooney | i cant think of a valid reason to allow that | |
| 20:23:57 | sean-k-mooney | i cant think of a valid reason to allow that | |
| 20:24:23 | sean-k-mooney | right we should have a unique constraint on the cell name | |
| 20:24:23 | sean-k-mooney | right we should have a unique constraint on the cell name | |
| 20:24:35 | noonedeadpunk | and you can't do that anyway when you use just old good fixed stuff | |
| 20:24:35 | noonedeadpunk | and you can't do that anyway when you use just old good fixed stuff | |
| 20:25:12 | noonedeadpunk | or avoid resolution of the template when we checking if same cell already exist | |
| 20:25:12 | noonedeadpunk | or avoid resolution of the template when we checking if same cell already exist | |
| 20:26:03 | sean-k-mooney | https://opendev.org/openstack/nova/src/branch/master/nova/db/sqlalchemy/api_models.py#L111-L129 | |