| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-04-01 | |||
| 10:41:17 | sean-k-mooney | gibi: so assuming the blueprint status is correcct that should be correct | |
| 10:41:33 | sean-k-mooney | looking at the list we had a fairly good completion ratio | |
| 10:49:48 | gibi | yepp we had ~70% | |
| 11:21:20 | artom | Wait, how the hell did Zuul not yet run on a patch I proposed last evening? | |
| 11:21:46 | gibi | artom: there was some outage | |
| 11:21:48 | sean-k-mooney | zuul restart | |
| 11:22:03 | gibi | do a recheck to queue it | |
| 11:22:05 | sean-k-mooney | all pending jobs got lost so just recheck | |
| 11:22:09 | artom | Ah | |
| 11:22:59 | sean-k-mooney | it was mention on th emailing list but i recall was " something something ooo ...." | |
| 11:23:03 | sean-k-mooney | then i stopped caring | |
| 11:26:09 | artom | Lulz | |
| 11:35:20 | openstackgerrit | Merged openstack/nova-specs master: Move the implemented specs for the wallaby release https://review.opendev.org/c/openstack/nova-specs/+/784369 | |
| 11:55:21 | openstackgerrit | Merged openstack/nova master: docs: Rewrite 'nova-manage db' docs to use proper directives https://review.opendev.org/c/openstack/nova/+/677509 | |
| 11:56:25 | openstackgerrit | Merged openstack/nova master: docs: Rewrite 'nova-manage api_db', 'cell_v2' docs https://review.opendev.org/c/openstack/nova/+/726192 | |
| 11:57:15 | openstackgerrit | Merged openstack/nova master: docs: Rewrite 'nova-manage placement' docs https://review.opendev.org/c/openstack/nova/+/726193 | |
| 11:58:16 | openstackgerrit | Merged openstack/nova master: docs: Rewrite 'nova-manage libvirt' docs https://review.opendev.org/c/openstack/nova/+/781504 | |
| 12:38:17 | gibi | cores: my today's doctor's appointment got pushed back to 17:50 CEST which means I cannot chair today's nova meeting. I updated the agenda on the wiki, and I might be able to follow the meeting. Who will volunteer to chair the meeting? | |
| 12:55:03 | gibi | lyarwood, bauzas, stephenfin, ^^ any volunteers :) | |
| 12:55:15 | bauzas | gibi: i can do | |
| 12:55:24 | gibi | bauzas: thanks, it is sold to you then :) | |
| 12:55:34 | bauzas | 18:00 CEST, right? | |
| 12:55:39 | gibi | 18:00 CEST yes | |
| 12:55:43 | bauzas | kk | |
| 12:56:01 | bauzas | gibi: any agenda already ? | |
| 12:56:39 | gibi | bauzas: the agenda is up to date on the wiki https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 13:02:11 | bauzas | gibi: all good, thanks | |
| 13:02:50 | bauzas | gibi: fwiw, as schools are closing next week, I'll take 2 days off on next Thursday and Friday | |
| 13:03:02 | gibi | bauzas: ack, | |
| 13:03:04 | bauzas | (and Monday is a bank holiday) | |
| 13:03:31 | bauzas | then, children will be on vacations for 2 weeks and then back to schools (hopefully) | |
| 13:10:44 | stephenfin | gibi: If you've a chance, could you take a look at https://review.opendev.org/c/openstack/nova/+/726195/ and the other few patches in that series today? Would be nice to close that out | |
| 13:14:09 | gibi | stephenfin: will try | |
| 13:14:23 | stephenfin | good enough for me. Thanks | |
| 13:46:25 | yonglihe | gibi, alex, xinren repropose the spec, hope you have time slot for that. btw, code alse rebased and addressed comments: Repropose smartnic support spec https://review.opendev.org/c/openstack/nova-specs/+/783632 | |
| 13:46:35 | gibi | yonglihe: ack | |
| 13:47:32 | yonglihe | thanks, i gonna run, have a good day. | |
| 13:49:55 | gmann | sean-k-mooney: lyarwood gibi basically if new return error code is new to that API (not from existing one) then we need microversion bump. and these are general return error code for all APis 400, 403, 404 and 415 | |
| 13:51:00 | gmann | sean-k-mooney: lyarwood gibi which APIs is this? I think most of server APIs have 409 exist return code | |
| 13:55:11 | gibi | os-services/{id}/force_doewn PUT | |
| 13:59:27 | gmann | yeah 409 is not there https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/api/openstack/compute/services.py#L358 | |
| 14:02:28 | gibi | yepp | |
| 14:02:43 | gibi | I accept 400 as a compromise for backportability | |
| 14:03:17 | gmann | +1 | |
| 14:17:16 | sean-k-mooney | gmann: yep that is basically what we discusssd on irc this morning 400 for backport reasons. 409 is more correct but would require version bump so we cant use it | |
| 14:17:20 | sean-k-mooney | at least not yet | |
| 14:17:48 | sean-k-mooney | we can make it use 409 in a followup patch if we wish too | |
| 14:23:23 | gmann | but we would not be able to backport 409 if do in follow up due to microvesion bump. | |
| 14:27:27 | sean-k-mooney | correct | |
| 14:27:44 | sean-k-mooney | so we were suggeing using 400 and backporting that | |
| 14:27:57 | sean-k-mooney | and leavign a todo to make it a 409 at some other point in the future | |
| 14:28:15 | sean-k-mooney | we coudl bundel it with some of the ohter todos we have | |
| 14:28:28 | sean-k-mooney | we have one for consitent return codes for unimplemnted feature for example | |
| 14:28:34 | gmann | yeah. make sense | |
| 15:19:02 | artom | Is Zuul... OK? | |
| 15:19:36 | artom | https://downforeveryoneorjustme.com/zuul.opendev.org ah :( | |
| 15:20:36 | melwitt | see #opendev for details, they've been debugging issues since yesterday | |
| 15:51:47 | bauzas | folks, gentle reminder, nova meeting in 9 mins on #openstack-meeting-3 | |
| 16:00:52 | bauzas | meeting started on #openstack-meeting-3 | |
| 17:01:35 | gibi | stephenfin: enjoy o/ | |
| 18:18:26 | sean-k-mooney | artom: by the way you proably want https://zuul.openstack.org/ | |
| 18:19:01 | sean-k-mooney | https://zuul.opendev.org/tenants has all then tenants | |
| 18:19:30 | sean-k-mooney | but zuul.openstack.org will show you the openstack ci dashboard | |
| 18:34:12 | artom | sean-k-mooney, I was just copy-pasting from the logs url | |
| 18:41:27 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1922053 https://review.opendev.org/c/openstack/nova/+/784129 | |
| 18:41:30 | openstack | bug 1922053 in OpenStack Compute (nova) "Operators can force up compute services with `done` evacuation migration records still active against the host" [Medium,In progress] https://launchpad.net/bugs/1922053 - Assigned to Lee Yarwood (lyarwood) | |
| 18:41:30 | openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Reject requests to force up computes when `done` evacuation records exist https://review.opendev.org/c/openstack/nova/+/784130 | |
| 20:27:57 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Neutron fixture: don't clobber profile and vif_details if empty https://review.opendev.org/c/openstack/nova/+/783385 | |
| 20:27:58 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Test SRIOV port move operations with PCI conflicts https://review.opendev.org/c/openstack/nova/+/783084 | |
| 20:27:58 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Update SRIOV port pci_slot when unshelving https://review.opendev.org/c/openstack/nova/+/784168 | |
| 20:28:16 | sean-k-mooney | :) | |
| 20:28:22 | sean-k-mooney | no more WIP | |
| 20:28:45 | artom | Yeah, rewrite the ugly [0] logic, and added a unit test | |
| 20:28:48 | artom | And a release note | |
| 20:28:51 | artom | And the bug reference | |
| 20:28:54 | artom | And my axe! | |
| 20:29:40 | sean-k-mooney | ah yes your using next() | |
| 20:29:53 | sean-k-mooney | you technially have extra () | |
| 20:29:59 | sean-k-mooney | that you dont need | |
| 20:30:15 | sean-k-mooney | equest = next((r for r in instance.pci_requests.requests | |
| 20:30:17 | sean-k-mooney | if r.requester_id == port['id'])) | |
| 20:30:37 | artom | No, that's needed | |
| 20:30:40 | artom | Wait, is it? | |
| 20:30:44 | artom | Maybe it isn't... | |
| 20:30:54 | artom | What you pass to next() has to be an interator | |
| 20:30:55 | sean-k-mooney | you are creating a touple | |
| 20:31:04 | artom | *iterator, not a list/tuple | |
| 20:31:07 | sean-k-mooney | but you can pass the generator expression driectly to next | |
| 20:31:38 | sean-k-mooney | iterator or generator | |
| 20:31:58 | sean-k-mooney | "r for r in instance.pci_requests.requests" is a generator expression | |
| 20:32:08 | artom | Oh yeah, works without the extra ( ) | |
| 20:32:11 | artom | TIL | |
| 20:32:36 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Update SRIOV port pci_slot when unshelving https://review.opendev.org/c/openstack/nova/+/784168 | |
| 20:32:36 | sean-k-mooney | with the extra () its doing a touple comprehention and then it taking the first element | |
| 20:32:53 | sean-k-mooney | without it its iterating the generator untile the first value is yeilded | |
| 20:33:20 | sean-k-mooney | so its faster too since it will early exit | |
| 20:35:03 | sean-k-mooney | artom: thats a python 3 thing by the way | |
| 20:35:20 | artom | Oh | |
| 20:35:21 | artom | Hrmm | |
| 20:35:34 | artom | Well, no, it's fine, Train is Python3 | |