| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-29 | |||
| 18:32:15 | melwitt | elod: will try it, thanks! | |
| 18:33:40 | elod | fingers crossed :X | |
| 18:33:48 | melwitt | :) | |
| 19:02:34 | sean-k-mooney | stephenfin: ok so the patch i pushed are not what i tought i pushed | |
| 19:03:01 | sean-k-mooney | stephenfin: as noted inline i lost all my work because i forgot to save before proceedign to the next patch in my interactive rebase | |
| 19:03:19 | sean-k-mooney | so i quickly did them again but i guess i did not put the change in the right place | |
| 19:03:29 | sean-k-mooney | ill respin them both again | |
| 19:05:08 | sean-k-mooney | that kind of annoying but i guess i should have check them more closely when i was trying to redoo it quickly after loosing my work | |
| 19:05:36 | sean-k-mooney | ill fix it tomorrow and ping you when its done | |
| 21:00:54 | openstackgerrit | Merged openstack/nova master: zuul: Add nova-live-migration-ceph job https://review.opendev.org/c/openstack/nova/+/768466 | |
| 21:06:36 | openstackgerrit | Merged openstack/nova master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/nova/+/783218 | |
| #openstack-nova - 2021-03-30 | |||
| 02:39:58 | openstackgerrit | Xinran WANG proposed openstack/nova-specs master: Repropose smartnic support spec https://review.opendev.org/c/openstack/nova-specs/+/783632 | |
| 05:46:18 | openstackgerrit | Xinran WANG proposed openstack/nova-specs master: Repropose smartnic support spec https://review.opendev.org/c/openstack/nova-specs/+/783632 | |
| 05:54:10 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Re-propose Remove tenant_id https://review.opendev.org/c/openstack/nova-specs/+/783783 | |
| 08:26:34 | openstackgerrit | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 08:26:36 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 08:26:37 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 08:26:37 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 08:26:37 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 08:29:51 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Repropose flavour and image defined ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/783806 | |
| 09:12:01 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Repropose flavour and image defined ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/783806 | |
| 09:24:39 | openstackgerrit | Merged openstack/nova master: Bumping min os-brick ver to 4.3.1 https://review.opendev.org/c/openstack/nova/+/783674 | |
| 09:28:19 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/wallaby: Bumping min os-brick ver to 4.3.1 https://review.opendev.org/c/openstack/nova/+/783822 | |
| 09:28:34 | lyarwood | gibi: ^ | |
| 09:40:18 | bauzas | lyarwood: adding nova to the bug | |
| 09:40:38 | bauzas | lyarwood: and then I'll add the correct tag | |
| 09:41:14 | bauzas | done. | |
| 09:50:24 | lyarwood | bauzas: thanks | |
| 09:53:09 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Repropose configurable-instance-hostnames https://review.opendev.org/c/openstack/nova-specs/+/783827 | |
| 09:55:04 | gibi | lyarwood: ack, thanks | |
| 09:58:54 | gibi | I don't have the +2 rights to push the wallaby backport through | |
| 09:59:03 | gibi | elod: could you check https://review.opendev.org/c/openstack/nova/+/783822 please? | |
| 10:14:03 | elod | +2+W'd ! | |
| 10:14:11 | gibi | thanks | |
| 10:14:31 | lyarwood | cheers | |
| 10:15:34 | elod | now it just has to merge. and then, release. i guess :X | |
| 10:17:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Follow up for SEV doc https://review.opendev.org/c/openstack/nova/+/783830 | |
| 10:17:39 | lyarwood | elod: it's a new rc but yeah | |
| 10:18:43 | stephenfin | kashyap: polite reminder to revisit https://review.opendev.org/c/openstack/nova/+/781438/ today, if you can :) | |
| 10:18:56 | elod | sorry, yes, another release candidate :) | |
| 10:19:49 | stephenfin | gibi: lyarwood: I think I've addressed kashyap's feedback on ^ (via a follow-up), so hopefully we can keep the docs train rolling forward? https://review.opendev.org/q/topic:%22docs%22+status:open | |
| 10:21:22 | lyarwood | yup I'll try to hit it again today, likely this evening if that's okay? | |
| 10:22:07 | stephenfin | for sure, any time in the next month would be okay, so long as they eventually merge and I can move on with my life :) | |
| 10:22:34 | lyarwood | yarp sounds good | |
| 10:28:05 | sean-k-mooney | i know people hate reviewing this patch but it has not passed grenade twice in the last 2 rebases so it appears to be working | |
| 10:28:07 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/602432 | |
| 10:56:44 | kashyap | stephenfin: Sorry, I had it open yesterday but got distracted | |
| 10:58:39 | kashyap | stephenfin: Thanks; I see you've worked in almost all the comments here: https://review.opendev.org/c/openstack/nova/+/782410/1/doc/source/admin/cpu-models.rst | |
| 11:00:51 | kashyap | stephenfin: Looks fine to me; just looked | |
| 11:25:07 | kashyap | stephenfin: I'm somewhat ambivalent about the folding in here: https://review.opendev.org/c/openstack/nova/+/782411 | |
| 11:26:06 | kashyap | I'm not against it; but just that sometimes having the separate doc w/ a single focus can be less distracting. One can link to the other, generic CPU modelss doc, though. | |
| 11:31:48 | sean-k-mooney | kashyap: too much linking can make reading them in git/github or pdf form so its a trade off but ya topic docs can be useful. i dont partically like the extream we take it to downstream | |
| 12:01:55 | sean-k-mooney | stephenfin: do you have a partical wording you would like me to add for the release note in the cpu_max_* patch | |
| 12:28:13 | gibi | stephenfin: I guess it is OK that these docs are only merged for Xena now | |
| 12:33:32 | sean-k-mooney | stephenfin: https://review.opendev.org/c/openstack/nova/+/769614/2//COMMIT_MSG#18 is that better? | |
| 12:34:32 | kashyap | sean-k-mooney: Yeah; I hear ya | |
| 12:50:39 | stephenfin | gibi: I think so, yeah | |
| 12:51:17 | gibi | stephenfin: OK, cool, I'm working through it | |
| 12:54:38 | stephenfin | sean-k-mooney: Yeah, that makes sense. So iiuc what we want to say is that previously we would attempt to best map the guest NUMA topology of pinned instances to the host NUMA topology, but that was buggy and wasn't updated e.g. during live migration so it's been removed? | |
| 12:55:24 | sean-k-mooney | well i could say that or i could try an implemente it ussing toplogy sorting | |
| 12:55:31 | sean-k-mooney | rahter then filtering | |
| 12:55:44 | sean-k-mooney | i feel like that should be a sperate patch however | |
| 12:58:25 | sean-k-mooney | if i proceed with removal of the code then yes ill update the release as you sugesst noting we tired but it was buggy and now removed | |
| 13:04:27 | stephenfin | makes sense | |
| 13:20:51 | sean-k-mooney | stephenfin: what would you like me to do note we remove the behavior and try and add the sorting in a follow up, add the sortign first in a prevous patch or just remove the behavior and note it | |
| 13:21:16 | stephenfin | I think the sorting should probably be separate so a follow-up? | |
| 13:26:36 | sean-k-mooney | ok ill adress the other comments so and then ill push and start working on the follow up | |
| 13:28:05 | sean-k-mooney | thanks for persiting with this i was exclusivly thinking baout this form the point of view of unpinned guests with numa toplogies | |
| 13:39:44 | bauzas | gibi: I only see one bugfix with https://bugs.launchpad.net/nova/+bugs?field.tag=wallaby-rc-potential | |
| 13:40:08 | bauzas | gibi: stephenfin: what about the cpu_max patch ? | |
| 13:40:36 | stephenfin | I don't think so. It's latent | |
| 13:41:10 | bauzas | https://review.opendev.org/q/project:openstack/nova+branch:stable/wallaby we only merged lyarwood's patch for os-brick | |
| 13:41:20 | bauzas | ok, so for the moment, only one patch for RC2 | |
| 13:41:31 | bauzas | gibi: when are you planning the RC2 release ? | |
| 13:48:43 | sean-k-mooney | bauzas: ya the cpu max patch is not an rc candiate | |
| 13:48:54 | bauzas | ack | |
| 13:49:11 | sean-k-mooney | ill backport it to stable/wallaby as normal once we do the release. | |
| 13:53:18 | bauzas | all good | |
| 13:56:27 | bauzas | folks, I think we have a consensus about nova shouldn't supporting rabbit MQs be unstable, right? | |
| 13:56:32 | bauzas | context : https://bugs.launchpad.net/nova/+bug/1921804 | |
| 13:56:35 | openstack | Launchpad bug 1921804 in OpenStack Compute (nova) "leftover bdm when rabbitmq unstable" [Undecided,New] | |
| 13:57:06 | dansmith | bauzas: I think we have always said, and can only say, that we expect rabbit to work, yes | |
| 13:57:26 | bauzas | yup | |
| 13:57:50 | bauzas | I'll move the bug status to Wontfix | |
| 13:58:07 | dansmith | if there's some particularly nasty bug we create for ourselves if rabbit breaks at some specific time, then mitigating that would be good, but I think in general we should expect rabbit to work | |
| 14:00:43 | gibi | bauzas: agreed about the leftover bdm, until it does not create a failure later just leaks some db resources then I'm OK to move it to wontfix | |
| 14:00:48 | bauzas | the bug is about the fact that we create a bdm even the volume is not attached | |
| 14:08:24 | bauzas | mmm, maybe we should document this in https://docs.openstack.org/nova/latest/contributor/project-scope.html | |
| 14:11:35 | gibi | bauzas: about the RC2, release should be cheap, but we don't have to rush. It is totally OK to have the RC proposed early next week. | |
| 14:11:44 | bauzas | yup | |
| 14:11:55 | bauzas | my question was more about the time we need to look at existing bugs | |
| 14:12:05 | gibi | looking now is good | |
| 14:12:07 | bauzas | as we could find regressions | |
| 14:12:27 | bauzas | I don't want to create a RC2 this week if we need another RC3 eventually | |
| 14:12:38 | gibi | yupp | |
| 14:47:15 | gibi | stephenfin: FYI there is a rendering issue in https://review.opendev.org/c/openstack/nova/+/781438/2/doc/source/admin/cpu-models.rst#60 but not serious so I'm OK if it is fixed in a fup | |
| 14:47:56 | stephenfin | damn, ack - will do a follow-up | |
| 15:01:07 | sean-k-mooney | stephenfin: so the max cpu error. it looks like that only happens when pinning is enabled | |
| 15:01:28 | sean-k-mooney | when i remove hw:cpu_policy=dedicated it goes away | |
| 15:01:31 | stephenfin | yeah, that would make sense based on my comments | |