Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-03-26
19:15:48 sean-k-mooney the pci request id shoudl be the nueturno port uuid
19:15:52 artom Ohhh
19:16:29 sean-k-mooney so i thnk we can look it up like that?
19:18:13 sean-k-mooney so if we get teh port we could loop over therm calling https://github.com/openstack/nova/blob/68ad2c67d891935c66e8c0e5a368695c202a9f49/nova/network/neutron.py#L1498-L1524
19:18:41 sean-k-mooney passing the port['id'] as pci_request_id
19:18:55 sean-k-mooney and then after that has updated them in memeory we woudl do a port update?
19:19:22 sean-k-mooney then i think we cloud call driver .spawn
19:20:39 sean-k-mooney artom: do you think that would work?
19:31:28 sean-k-mooney ... its not the neutron port uuid
19:31:52 artom sean-k-mooney, think so, yeah
19:31:58 artom Lemme try it
19:33:11 sean-k-mooney artom: the requester_id is the neutron port uuid
19:33:25 sean-k-mooney the pci_request_id is the request_id
19:33:40 sean-k-mooney unfortunetly the requester_id is not sotred in teh db
19:34:54 sean-k-mooney the requested_networks network object i think is the only thing that has the mapping
19:35:51 sean-k-mooney i think this is the same roadblock i hit the last time
19:39:40 sean-k-mooney ...
19:39:51 sean-k-mooney so the instance_extra tbale has it but not fully
19:39:54 sean-k-mooney [{"count": 1, "spec": [{"physical_network": "public"}], "alias_name": null, "is_new": false, "numa_policy": "preferred", "request_id": "03e6f4be-dc49-4825-a33d-337f2708be22", "requester_id": null}
19:40:17 sean-k-mooney the requester_id shoudl be the neutorn port uuid
19:40:51 sean-k-mooney if it was we coudl get the request id and then look up the claimed deivce in the pci device table and mapt them back to the ports
19:43:02 sean-k-mooney artom: i think im going to call it a day there. if we fixed that so the requester id was always set then we could use that
19:43:35 sean-k-mooney i think it curently not set becasue we dont save this back to the db and only pass it around
19:43:49 sean-k-mooney https://github.com/openstack/nova/blob/68ad2c67d891935c66e8c0e5a368695c202a9f49/nova/network/neutron.py#L2154-L2164
19:44:26 artom sean-k-mooney, ack yeah, my brain is getting rusty as well
19:47:12 sean-k-mooney we might need to do this in two parts
19:47:37 sean-k-mooney one patch that fixes populating that value and tries to file it in for exsitng instnace
19:47:47 sean-k-mooney maybe using the pci_slot
19:48:03 sean-k-mooney to figure out thte mappign between port and exctra
19:48:29 sean-k-mooney and tehn a secdond to use it to update the port or something like that
19:48:45 sean-k-mooney anyway enjoy your weekend
19:49:14 sean-k-mooney what frustrating abtout this is every time i look at this we have almsot all the info we need
19:49:17 sean-k-mooney almost
#openstack-nova - 2021-03-27
13:42:18 openstackgerrit Takashi Natsume proposed openstack/nova master: Update contributor guide for Xena https://review.opendev.org/c/openstack/nova/+/783534
15:27:03 openstackgerrit Artom Lifshitz proposed openstack/nova master: Neutron fixture: don't clobber profile and vif_details if empty https://review.opendev.org/c/openstack/nova/+/783385
15:27:04 openstackgerrit Artom Lifshitz proposed openstack/nova master: Test SRIOV port move operations with PCI conflicts https://review.opendev.org/c/openstack/nova/+/783084
#openstack-nova - 2021-03-29
07:59:11 bauzas_ good morning
07:59:24 bauzas_ gibi: a bit on and off as I need to restart my ZNC bouncer a couple of times
07:59:38 gibi bauzas_: good morning. ack
07:59:39 bauzas_ (changed my NAS who supports it)
08:14:10 bauzas_ hopefully, last ZNC bouncer recycle
08:19:56 openstackgerrit Merged openstack/osc-placement master: Update master for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781894
10:28:14 openstackgerrit Merged openstack/nova stable/wallaby: [stable-only]Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/nova/+/783195
10:28:27 openstackgerrit Merged openstack/nova stable/wallaby: [stable-only]Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/nova/+/783216
10:55:55 openstackgerrit Xinran WANG proposed openstack/nova-specs master: Repropose smartnic support spec https://review.opendev.org/c/openstack/nova-specs/+/783632
11:25:28 stephenfin kashyap: Can you revisit https://review.opendev.org/c/openstack/nova/+/781438/?
11:25:41 stephenfin I've added a follow-up addressing your comments here https://review.opendev.org/c/openstack/nova/+/782410/
12:56:09 kashyap stephenfin: Queued (I see it's the CPU models doc)
13:38:08 sean-k-mooney stephenfin: did you see my comments on the sev one that is already merged https://review.opendev.org/c/openstack/nova/+/781437/2/doc/source/admin/sev.rst
14:09:04 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: Add regression test for bug #1908075 https://review.opendev.org/c/openstack/nova/+/783653
14:09:05 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: api: Reject volume attach requests when an active bdm exists https://review.opendev.org/c/openstack/nova/+/783654
14:09:05 openstack bug 1908075 in OpenStack Compute (nova) "Nova allows a non-multiattach volume to be attached to multiple instances *if* its volume state is reset by an admin" [Low,In progress] https://launchpad.net/bugs/1908075 - Assigned to Lee Yarwood (lyarwood)
14:10:34 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: Add regression test for bug #1908075 https://review.opendev.org/c/openstack/nova/+/783655
14:10:35 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: api: Reject volume attach requests when an active bdm exists https://review.opendev.org/c/openstack/nova/+/783656
14:10:36 openstack bug 1908075 in OpenStack Compute (nova) "Nova allows a non-multiattach volume to be attached to multiple instances *if* its volume state is reset by an admin" [Low,In progress] https://launchpad.net/bugs/1908075 - Assigned to Lee Yarwood (lyarwood)
14:30:56 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Move port ID verification to REST API https://review.opendev.org/c/openstack/nova/+/675418
14:39:53 openstackgerrit Artom Lifshitz proposed openstack/nova master: Follow up from bp/pci-socket-affinity series https://review.opendev.org/c/openstack/nova/+/779556
14:47:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'create_db_entry_for_new_instance' https://review.opendev.org/c/openstack/nova/+/778545
14:47:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove references to 'instance_type' https://review.opendev.org/c/openstack/nova/+/778546
14:47:07 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove (almost) all references to 'instance_type' https://review.opendev.org/c/openstack/nova/+/778547
14:47:07 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove references to 'inst_type' https://review.opendev.org/c/openstack/nova/+/778548
14:47:09 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove useless mocks https://review.opendev.org/c/openstack/nova/+/778730
14:47:10 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove duplicate policy tests https://review.opendev.org/c/openstack/nova/+/778731
14:47:15 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732
14:47:19 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Merge flavor tests https://review.opendev.org/c/openstack/nova/+/783662
14:51:42 openstackgerrit Artom Lifshitz proposed openstack/nova master: Follow up from bp/pci-socket-affinity series https://review.opendev.org/c/openstack/nova/+/779556
15:08:14 openstackgerrit melanie witt proposed openstack/nova stable/rocky: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761813
15:35:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: Bumping min os-brick ver to 4.3.1 https://review.opendev.org/c/openstack/nova/+/783674
15:41:37 gibi lyarwood: os-brick min version bump due to critical bug https://bugs.launchpad.net/os-brick/+bug/1921381
15:41:40 openstack Launchpad bug 1921381 in os-brick xena "iSCSI: Flushing issues when multipath config has changed" [Critical,In progress] - Assigned to Gorka Eguileor (gorka)
15:43:36 gibi lyarwood: if you have time then I appreaciate your review
15:44:09 lyarwood ack just on a call
15:44:30 gibi ack, thanks
15:51:04 kopecmartin hi, can you confirm last comments in this devstack change please? https://review.opendev.org/c/openstack/devstack/+/768363 (just to be sure.. ) - if we add gawk to general, can we remove it from files/*/nova ?
16:22:00 lyarwood gibi: looking at this now, I think it's missing a few things
16:22:32 gibi could be
16:22:47 gibi I only bumped where pip asked for it
16:23:59 lyarwood gibi: which version of pip?
16:24:17 gibi 20.3.4
16:24:46 gibi hm
16:25:54 gibi I tried with 20.3.4 and that showed the eventlet bump, but eventually failed as eventlet 0.30.1 and greenlet does not like py39. So I went to another machine where I have py38
16:26:19 gibi and there it is pip 20.2.4 so that explains why I might missed something /o\
16:26:46 lyarwood gibi: no issues, mind if I push an update that works for me?
16:27:07 gibi lyarwood: I'm glad if you can fix it :)
16:27:10 gibi thanks
16:27:37 lyarwood gibi: np
16:28:24 openstackgerrit Archit Modi proposed openstack/nova master: [Docs] Use 'resize' instead of 'migrate' in migration confirm/revert https://review.opendev.org/c/openstack/nova/+/783705
16:36:42 openstackgerrit Lee Yarwood proposed openstack/nova master: Bumping min os-brick ver to 4.3.1 https://review.opendev.org/c/openstack/nova/+/783674
16:39:00 lyarwood gibi: ^ lets see how that gets on
16:39:35 gibi ack
17:05:25 sean-k-mooney stephenfin: havent fully read your review but ill try and adress it today
17:05:59 sean-k-mooney stephenfin: the main reason i did not remove the object fild in the patch was backports by the way but i assume you know that
17:06:19 stephenfin yeah, you can't remove it without a major version bump
17:06:39 sean-k-mooney do i need a major bump ok ok
17:06:58 sean-k-mooney am well i guess we should look at that
17:07:31 sean-k-mooney there are a few object that are long overdue one but ill stop working on my loacl patch to do that so until we deciide that is what we will do
17:08:06 sean-k-mooney i need to have 2 copies of the class to do a major bump
17:08:13 sean-k-mooney which is a lot more work
17:30:16 melwitt lyarwood, elod: looks like we have a new gate failure on stable/rocky ":stderr: alembic requires Python '!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*,!=3.5.*,>=2.7' but the running Python is 3.5.2" https://zuul.opendev.org/t/openstack/build/c68ff42e5a2347febc6912f0f950ac1d/console#4/0/31/controller
17:48:17 lyarwood melwitt: ack, smells like it needs to be capped right?

Earlier   Later