| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-26 | |||
| 03:42:39 | sean-k-mooney | same think there though 66a4ea9f25cdc75691ed55adc842b795c10b4191 was not merged when it ran | |
| 03:42:56 | eandersson | Yea it's very likely I got trigger happy there. | |
| 03:43:35 | sean-k-mooney | its merge now though https://review.opendev.org/c/openstack/nova/+/761812 so the recheck should pass | |
| 03:45:18 | sean-k-mooney | hum hopfully the grenade job will pass with the recheck too | |
| 03:50:32 | sean-k-mooney | looks like a filure in the post test hook https://zuul.opendev.org/t/openstack/build/23129f86fb5146a084bb04f3eb9fcfec/log/logs/devstack-gate-post_test_hook.txt#95 | |
| 03:50:40 | sean-k-mooney | when testing ceph | |
| 05:03:56 | openstackgerrit | Merged openstack/nova master: Fix check_instance_shared_storage() call https://review.opendev.org/c/openstack/nova/+/783026 | |
| 06:04:42 | openstackgerrit | Josephine Seifert proposed openstack/nova stable/stein: Add config parameter 'live_migration_scheme' to live migration with tls guide https://review.opendev.org/c/openstack/nova/+/783199 | |
| 06:11:44 | gibi | dansmith: thanks for the night whatch and the rechecks. The fix is merged and the RC1 patch is updated now. | |
| 06:11:55 | gibi | bauzas: ^^ | |
| 07:16:52 | openstackgerrit | OpenStack Release Bot proposed openstack/nova stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/nova/+/783195 | |
| 07:17:22 | openstackgerrit | OpenStack Release Bot proposed openstack/nova stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/nova/+/783216 | |
| 07:17:41 | openstackgerrit | OpenStack Release Bot proposed openstack/nova master: Update master for stable/wallaby https://review.opendev.org/c/openstack/nova/+/783217 | |
| 07:18:38 | openstackgerrit | OpenStack Release Bot proposed openstack/nova master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/nova/+/783218 | |
| 08:24:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/wallaby: [stable-only]Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/nova/+/783195 | |
| 08:26:23 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/nova/+/783216 | |
| 08:27:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/wallaby: [stable-only]Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/nova/+/783216 | |
| 08:32:18 | gibi | sean-k-mooney: could you please hit this two automatic os-vif patches https://review.opendev.org/c/openstack/os-vif/+/781891 ? | |
| 08:38:34 | bauzas | morning | |
| 08:38:50 | bauzas | gibi: sorry, looks like yesterday Frenode had some split | |
| 08:38:57 | bauzas | and maybe you pinged me | |
| 08:39:24 | bauzas | thanks for the RC1 patch | |
| 08:54:00 | gibi | bauzas: no worries everything went well during the night :) | |
| 08:54:56 | bauzas | gibi: I'll need to be off this afternoon btw. | |
| 08:55:12 | gibi | ack | |
| 08:55:17 | gibi | nothing pressing is in the queue | |
| 08:58:42 | openstackgerrit | Merged openstack/osc-placement master: Update master for stable/victoria https://review.opendev.org/c/openstack/osc-placement/+/751320 | |
| 09:00:49 | swp20 | gibi: morning, i find disk_filter is removed from U version, could u please give me some ref links about the reason? | |
| 09:01:10 | stephenfin | swp20: It'll be in the release notes | |
| 09:01:35 | stephenfin | swp20: https://docs.openstack.org/releasenotes/nova/train.html | |
| 09:01:44 | stephenfin | The CoreFilter, DiskFilter and RamFilter, which were deprecated in Stein (19.0.0), are now removed. VCPU, DISK_GB and MEMORY_MB filtering is performed natively using the Placement service. | |
| 09:02:16 | swp20 | stephenfin: thanks a lot. | |
| 09:07:16 | openstackgerrit | Merged openstack/osc-placement master: Add Python3 wallaby unit tests https://review.opendev.org/c/openstack/osc-placement/+/751321 | |
| 09:12:39 | swp20 | stephenfin: do we plan to move the remain filters to placement? | |
| 09:19:01 | bauzas | swp20: no, that depends | |
| 09:19:36 | bauzas | swp20: some filters can be deprecated if we can create what we name 'prefilters' using the Placement API | |
| 09:19:46 | bauzas | swp20: but some others, no | |
| 09:22:17 | swp20 | bauzas: got it, thanks. | |
| 09:25:00 | swp20 | bauzas: placemet has support PCI filter such as GPU/FPGA devices, isn't it? | |
| 09:27:09 | gibi | vgpu mdevs are modelled in placement but PCI devices not yet | |
| 09:27:49 | gibi | due to qos min bandwidth scheduling support some sriov PFs are modelled in placement but that only used for the bandwdith resource at the moment | |
| 09:28:00 | gibi | the PCI schduling still happens in the PCIFilter in nova | |
| 09:30:59 | bauzas | swp20: we only model vGPUs | |
| 09:31:11 | bauzas | swp20: but we don't really model PCI devices | |
| 09:31:36 | bauzas | and given we also have NUMA PCI affinity, we would also need to support this | |
| 09:31:45 | bauzas | a long story here. | |
| 09:33:49 | swp20 | gibi, buazas: got, thanks a lot. | |
| 09:35:41 | openstackgerrit | OpenStack Release Bot proposed openstack/placement stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/placement/+/783232 | |
| 09:35:45 | openstackgerrit | OpenStack Release Bot proposed openstack/placement stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/placement/+/783233 | |
| 09:35:50 | openstackgerrit | OpenStack Release Bot proposed openstack/placement master: Update master for stable/wallaby https://review.opendev.org/c/openstack/placement/+/783234 | |
| 09:36:13 | openstackgerrit | OpenStack Release Bot proposed openstack/placement master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/placement/+/783235 | |
| 11:25:26 | kashyap | gibi: or anyone else: Can I borrow your eyes: In this method here _add_rng_device() — do you see a way where 'hw_rng:allowed = False' on image property might *not* take effect? -- https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5665,#L5682 | |
| 11:31:16 | openstackgerrit | Slawek Kaplonski proposed openstack/nova master: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/783275 | |
| 12:24:17 | gibi | kashyap: the image_meta is unused in that function | |
| 12:24:41 | gibi | only the flavor extra_spec is used | |
| 12:24:53 | gibi | so that function does not care about any image property | |
| 12:25:23 | kashyap | gibi: Oh, so the "hw_rng:allowed" image meta is useless in this case then | |
| 12:28:50 | gibi | seem so | |
| 12:28:55 | gibi | it might be a bug | |
| 12:29:16 | kashyap | Hmm, OSP QE reported it to me... | |
| 12:29:47 | gibi | as the function gets an image_meta parameter but the it does not use it | |
| 12:31:11 | kashyap | gibi: Right; I guess we should: | |
| 12:31:19 | kashyap | flavor.extra_specs.get() or image_imeta.properties.get() ... | |
| 12:32:31 | gibi | yeah that could be a solution | |
| 12:34:37 | sean-k-mooney | we have a function for that | |
| 12:34:50 | sean-k-mooney | at lesate wehre we named then the same | |
| 12:35:27 | sean-k-mooney | hw_rng:allowed | |
| 12:35:37 | sean-k-mooney | shoudl not be use in image meta | |
| 12:35:47 | sean-k-mooney | only the flavor can allow it | |
| 12:37:05 | sean-k-mooney | https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json#L54-L59 is the only image metadata value | |
| 12:38:15 | kashyap | sean-k-mooney: You mean "hw_rng:allowed" can only be used by extra_spec and not image_meta? | |
| 12:38:21 | sean-k-mooney | yes | |
| 12:38:42 | sean-k-mooney | that was a desgin chocie | |
| 12:39:09 | sean-k-mooney | because we used to use /dev/random not /dev/urandom as you know | |
| 12:39:17 | sean-k-mooney | there were concerns about running out of entropy | |
| 12:39:26 | kashyap | sean-k-mooney: Wait. What you're pointing to is different: "hw_rng_model" --> this is useless now. | |
| 12:39:30 | sean-k-mooney | so it was an admin only extra spec | |
| 12:39:38 | sean-k-mooney | which defaut to false | |
| 12:39:59 | kashyap | sean-k-mooney: Okay ... so it's not a "bug" to not have it via image_meta | |
| 12:40:25 | sean-k-mooney | right it would be a bug to use it in image meta but the fact its not there is not | |
| 12:40:47 | sean-k-mooney | hw_rng_model is pretty useless not too yes | |
| 12:41:03 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L387-L394 | |
| 12:41:21 | sean-k-mooney | kashyap: but as you said we should not remove/deprecate it yet ^ | |
| 12:41:38 | kashyap | sean-k-mooney: You mean "as I said" in the commit message? :) | |
| 12:41:43 | sean-k-mooney | unless that comment you worte is also incorect | |
| 12:42:18 | kashyap | sean-k-mooney: No; it's not incorrect. I also wrote this in the commit message of the patch that introduced it: | |
| 12:42:21 | kashyap | - The 'hw_rng_model' image metadata property is now rendered | |
| 12:42:24 | kashyap | (temporarily) useless -- as it's not used anywhere outside the | |
| 12:42:26 | kashyap | _add_rng_device() method. But we don't want to deprecate it yet, as | |
| 12:42:29 | kashyap | we may extend it (see code comment for details); docucment that. | |
| 12:42:30 | kashyap | So we wan to keep it. | |
| 12:42:47 | sean-k-mooney | well there too but i was not reading the comit message | |
| 12:43:13 | sean-k-mooney | i rember this form when the rng supprot was first beign added | |
| 12:43:15 | kashyap | Righ; I wrote the code comment in image_meta.py | |
| 12:58:53 | openstackgerrit | Balazs Gibizer proposed openstack/osc-placement master: Update master for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781894 | |
| 13:02:22 | openstackgerrit | Balazs Gibizer proposed openstack/osc-placement master: Update master for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781894 | |
| 13:14:05 | dansmith | gibi: ah, based on the time, it must have been the last one before I went to bed, cool | |
| 13:19:27 | gibi | dansmith: yepp you almost saw the patch landing | |
| 13:19:30 | gibi | :) | |
| 13:21:36 | dansmith | well, sorry | |