| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-25 | |||
| 14:55:58 | bauzas | but I forgot to lookup the last job run | |
| 14:56:31 | dansmith | well, reviewers should be checking this stuff too | |
| 14:56:56 | bauzas | either way, ship has sailed but we can hold RC1 until we merge the fix | |
| 14:57:00 | bauzas | gibi: ^ | |
| 14:57:17 | bauzas | dansmith: you're already on it ? or you want me to fix the caller ? | |
| 14:57:25 | gibi | we will hodl the RC1 until the fix lands | |
| 14:57:45 | dansmith | bauzas: I'm looking yeah, hang on | |
| 14:57:58 | bauzas | gibi: thanks | |
| 14:58:06 | bauzas | dansmith: AFAIR, we don't have a long list of callers | |
| 14:58:34 | stephenfin | Mea culpa. I didn't think to at the existing CI run past seeing everything was green. I figured breakages would be obvious. I can work on a fix if no one else is? | |
| 14:59:13 | gibi | I don't see the obvious failure in the patch :/ | |
| 14:59:35 | bauzas | dansmith: interesting, looks to me it's dead code | |
| 14:59:49 | bauzas | or I'm blind | |
| 15:00:26 | dansmith | eh? | |
| 15:00:28 | bauzas | oh, wait no | |
| 15:00:30 | bauzas | I'm tired | |
| 15:00:43 | bauzas | _is_instance_storage_shared() | |
| 15:01:06 | bauzas | that's a compute to compute call | |
| 15:01:12 | dansmith | yeah, I'm running tests now to figure out what needs to change in there | |
| 15:02:12 | bauzas | all looks we only mock this caller | |
| 15:02:18 | bauzas | and we don't verify it | |
| 15:03:14 | bauzas | but maybe we verify it's called | |
| 15:10:52 | bauzas | dansmith: gibi: stephenfin: I have to get my kids off school but I'm back in 20-ish minutes | |
| 15:15:03 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix check_instance_shared_storage() call https://review.opendev.org/c/openstack/nova/+/783026 | |
| 15:15:22 | dansmith | bauzas: gibi ^ | |
| 15:15:26 | gibi | ack looking | |
| 15:15:39 | bauzas | dansmith: already on it | |
| 15:15:42 | bauzas | all looks good | |
| 15:15:54 | dansmith | assuming that clears the one fail, we should still examine the logs for more stuff | |
| 15:15:57 | bauzas | I know I reordered a few params | |
| 15:16:11 | bauzas | agreed | |
| 15:16:38 | bauzas | just giving a +2 as it doesn't harm but I agree on the fact we should wait for the next grenade run | |
| 15:17:26 | gibi | ack, I hold my +W until grenade | |
| 15:18:09 | bauzas | a very brief look on https://review.opendev.org/c/openstack/nova/+/761452/14/nova/compute/rpcapi.py makes me think it was the only method I switched the args | |
| 15:20:53 | gibi | bauzas: yes, I agree I don't see any other reordering | |
| 15:22:01 | dansmith | fwiw I was looking for more subtle fails when I found this | |
| 15:22:28 | dansmith | reorderings I would have expected to be caught by unit tests | |
| 15:27:53 | gibi | now I looked through the log you linked and the rest of the warning seems acceptable to me | |
| 15:50:50 | gibi | nova meeting starts in 10 minutes in #openstack-meeting-3 | |
| 15:54:19 | openstackgerrit | Merged openstack/nova stable/train: Add config parameter 'live_migration_scheme' to live migration with tls guide https://review.opendev.org/c/openstack/nova/+/782430 | |
| 16:22:51 | stephenfin | gibi, melwitt: In case you haven't seen it yet, the placement fix is here https://review.opendev.org/c/openstack/placement/+/782988 | |
| 16:23:01 | stephenfin | Might be worth putting into RC1 | |
| 16:23:18 | stephenfin | If not, it should be an immediate backport given how easy this is to hit | |
| 16:23:33 | sean-k-mooney | why was that not caut by the existing testing for duplicates? | |
| 16:23:49 | sean-k-mooney | oh | |
| 16:23:52 | stephenfin | Cos they use SQLite, I'm going to guess | |
| 16:23:54 | sean-k-mooney | that is useing sqlite | |
| 16:24:00 | stephenfin | yarp | |
| 16:24:08 | sean-k-mooney | ya ok makes sense | |
| 16:24:49 | sean-k-mooney | we could look at adding the same opertunistic testign we don in nova but that might eb overkill for the func tests | |
| 16:25:43 | gibi | stephenfin: I don't have cycles today any more | |
| 16:25:51 | sean-k-mooney | it makes sense why we are only seeing this now | |
| 16:25:57 | gibi | stephenfin: and I won't hold up RC1 for it | |
| 16:26:25 | stephenfin | Makes sense | |
| 16:26:38 | stephenfin | I'll propose the backport once we have the stable/wallaby branch | |
| 16:27:15 | sean-k-mooney | gibi: well it would not hold up RC1 of nova in either case | |
| 16:27:29 | stephenfin | he means placement RC1 I would assume | |
| 16:27:30 | gibi | sean-k-mooney: it is palcement :) | |
| 16:27:34 | gibi | yepp | |
| 16:27:39 | sean-k-mooney | yep | |
| 16:28:08 | sean-k-mooney | stephenfin: by the way didnt we talk about moveing placment back to launchpad form story borad | |
| 16:28:31 | sean-k-mooney | i guess we never came to a conclution or did anything about it | |
| 17:37:14 | dansmith | gibi: the errors are gone from the logs on my patch, so I think it's good to +W | |
| 17:37:25 | dansmith | still looking through it for other stuff | |
| 17:55:20 | gibi | dansmith: thanks will check in a minute | |
| 17:59:32 | gibi | I only saw message timeouts in the logs https://zuul.opendev.org/t/openstack/build/a22940c76b4e4c269bdcae178f081381/log/logs/subnode-2/screen-n-cpu.txt?severity=3 but I confirm that your fix solved the previous issue and I don't see any new problem | |
| 18:11:07 | gibi | OK those messaging timeouts was there before even the R6.0 bump so I think it is normal and relates to the upgrade | |
| 18:11:44 | gibi | so I'm approved the patch | |
| 18:12:05 | gibi | I hope it lands before I go to bed | |
| 18:12:16 | gibi | if not then I will leave notes in the RC1 patch | |
| 18:36:33 | dansmith | gibi: the timeouts are during the upgrade I think, where conductor is down | |
| 18:36:37 | dansmith | that's not new | |
| 19:23:59 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Regression test for unshelve with SRIOV port https://review.opendev.org/c/openstack/nova/+/783084 | |
| 19:48:25 | openstackgerrit | Mark Goddard proposed openstack/nova master: Check volume encryption keys prior to resize and migration https://review.opendev.org/c/openstack/nova/+/781079 | |
| 19:53:59 | gibi | dansmith: ack, then my guess way right about the upgrade | |
| 20:40:08 | openstackgerrit | sean mooney proposed openstack/nova master: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/769601 | |
| 20:40:09 | openstack | bug 1910466 in OpenStack Compute (nova) "NUMA instance spawn fails on get_best_cpu_topology when there is no 'threads' preference" [Medium,In progress] https://launchpad.net/bugs/1910466 - Assigned to sean mooney (sean-k-mooney) | |
| 20:40:10 | openstackgerrit | sean mooney proposed openstack/nova master: Fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/769614 | |
| 21:31:30 | gibi | dansmith: the 6.0 fix is failed on the gate on unrealted error. But zuul haven't voted yet. I left a comment in the RC1 release patch and delegated power to you to update / +1 it if the fix lands while I'm asleep. | |
| 21:31:30 | gibi | o/ | |
| 21:32:30 | dansmith | gibi: okay, will keep an eye on it | |
| 22:39:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix check_instance_shared_storage() call https://review.opendev.org/c/openstack/nova/+/783026 | |
| #openstack-nova - 2021-03-26 | |||
| 03:06:39 | openstackgerrit | Merged openstack/nova stable/stein: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761812 | |
| 03:12:34 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/602432 | |
| 03:16:19 | eandersson | melwitt do you know what is going on at the rocky ci? | |
| 03:16:33 | eandersson | > Cherry pick hash 9e9c022bde3a3ffdf0dd87e21bf9afde0dbc1e74 not on any master or stable branches | |
| 03:17:26 | sean-k-mooney | thats form the cherry pick script we have to ensure we dont skip branches wehn we backport | |
| 03:17:37 | sean-k-mooney | its run as part of the pep8 job | |
| 03:18:25 | sean-k-mooney | eandersson: this has not merge in trian yet so all the previous version will fail | |
| 03:18:53 | sean-k-mooney | that has been cherry picked incorrectly | |
| 03:19:06 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/356020 is merged | |
| 03:19:23 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/782982 is pending | |
| 03:19:48 | sean-k-mooney | but we shoudl have the cherry picked form lines for each branch | |
| 03:20:15 | sean-k-mooney | well | |
| 03:20:24 | sean-k-mooney | its bit that its incorrect persay | |
| 03:20:37 | sean-k-mooney | but untill https://review.opendev.org/c/openstack/nova/+/782982 merges it cant pass pep8 | |
| 03:21:01 | sean-k-mooney | eandersson: https://github.com/openstack/nova/blob/master/tools/check-cherry-picks.sh | |
| 03:21:08 | sean-k-mooney | that is what is causing it to fail | |
| 03:22:11 | sean-k-mooney | eandersson: im not sure why the first cherry pick start a train | |
| 03:23:01 | sean-k-mooney | i guess this merged a year ago so maybe train was correct | |