| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-18 | |||
| 15:01:44 | dansmith | ack, okay | |
| 15:01:47 | gmann | dansmith: abhishekk we still have not concluded that what to do on l-c job | |
| 15:01:59 | gmann | discussing in today TC meeting | |
| 15:02:03 | dansmith | gmann: okay I thought it wasn't quite decided yet, but others seemed to think it was | |
| 15:02:03 | abhishekk | gmann, ack, thanks | |
| 15:43:30 | bauzas | gibi: dansmith: fwiw, I removed my -2 from https://review.opendev.org/c/openstack/nova/+/761452 as we're after the FF | |
| 15:43:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Use proper headers in nova-manage man page https://review.opendev.org/c/openstack/nova/+/726191 | |
| 15:43:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage db' docs to use proper directives https://review.opendev.org/c/openstack/nova/+/677509 | |
| 15:43:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage api_db', 'cell_v2' docs https://review.opendev.org/c/openstack/nova/+/726192 | |
| 15:43:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage placement' docs https://review.opendev.org/c/openstack/nova/+/726193 | |
| 15:43:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document options for remaining nova-* commands https://review.opendev.org/c/openstack/nova/+/726195 | |
| 15:43:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Populate "See Also" section with meaningful links https://review.opendev.org/c/openstack/nova/+/729917 | |
| 15:43:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add man pages for 'nova-policy' https://review.opendev.org/c/openstack/nova/+/729918 | |
| 15:43:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage libvirt' docs https://review.opendev.org/c/openstack/nova/+/781504 | |
| 15:44:04 | bauzas | dansmith: still working on removing 5.0 but given we only have a week, maybe we should just merge the above ? ^ | |
| 15:45:29 | dansmith | bauzas: ack, I'm out tomorrow and won't get to revisiting that today I expect, so whatever gibi wants to do | |
| 15:45:57 | bauzas | dansmith: given we will remove the V5proxy in Xena, the 5.0 support would only be in the Wallaby release | |
| 15:46:17 | gibi | dansmith bauzas: if we land what we have today, does that pose any serious limitation? | |
| 15:46:45 | bauzas | gibi: mmmm, I don't know | |
| 15:47:07 | dansmith | gibi: well, I haven't reviewed the latest rev, but no, it's just more than we need and also it lies a bit about older versions we say we can support but can't really, but in practice it's probably not a big deal | |
| 15:47:11 | bauzas | we have a lof of merge conflicts that said => https://review.opendev.org/c/openstack/nova/+/761452 | |
| 15:47:51 | gibi | dansmith: OK, so it is safe to merge, and if time allows we can improve. But considering RC1 next week I don't think we will improve much | |
| 15:48:23 | dansmith | again, haven't reviewed the latest one, but the approach yeah | |
| 15:50:33 | gibi | I reviewed the changes between the version you reviewed and the latest and nothing major there. So I ugrade my vote to +2 | |
| 15:51:22 | gibi | btw, nova meeting starts in 10 minutes in #openstack-meeting-3 | |
| 15:55:24 | elod | lyarwood: about https://review.opendev.org/c/openstack/nova/+/758733 | |
| 15:55:54 | elod | lyarwood: only victoria is hit by the nova-ceph-multistore failure | |
| 15:56:00 | lyarwood | elod: urgh sorry | |
| 15:56:07 | elod | lyarwood: as only there exists the job | |
| 15:56:13 | elod | afais | |
| 15:56:15 | lyarwood | elod: I got a little carried away, someone was rechecking my stable/victoria changes | |
| 15:56:31 | lyarwood | elod: I've removed my -W | |
| 15:56:34 | elod | ok, no problem :) | |
| 15:56:44 | frickler | wasn't there a tool to resync placement data with nova-compute (on stein)? I have 14 instances on my compute, but only 6 in placement | |
| 15:57:19 | elod | lyarwood: just wanted to highlight that only victoria is blocked. (i guess the glance fix can be backported to older branches, though) | |
| 15:57:41 | lyarwood | frickler: https://docs.openstack.org/nova/stein/cli/nova-manage.html#placement heal_allocations? | |
| 15:58:18 | frickler | lyarwood: ah, "heal" was the keyword, thx | |
| 15:58:22 | lyarwood | elod: yeah assuming it applies, I can't recall when the feature was landed | |
| 15:58:41 | lyarwood | frickler: np | |
| 16:37:35 | gibi | lyarwood: could you hit the VDPA reno? https://review.opendev.org/c/openstack/nova/+/780866 | |
| 16:37:43 | lyarwood | sure | |
| 16:38:19 | gibi | thanks | |
| 17:10:44 | lyarwood | gibi: can we chat about the libvirt detach series tomorrow if you still have bandwidth to land it before rc | |
| 17:27:09 | Luzi | stephenfin: it seems you care for the documentation in nova :) do you have some time to review this doc fix for secure live migration: https://review.opendev.org/c/openstack/nova/+/781030 | |
| 17:31:35 | gibi | lyarwood: sure, I will ping you in the morning, my afternoon is pretty hectic | |
| 17:32:19 | stephenfin | Luzi: Sure. I meant to do that this morning | |
| 17:33:57 | lyarwood | gibi: kk sounds good, I'll be driving my kid around first thing, should be online by ~10am GMT | |
| 17:34:27 | lyarwood | if not it can wait until Monday, just want to help get it over the line | |
| 17:37:02 | openstackgerrit | Merged openstack/nova stable/pike: rt: Make resource tracker always invoking get_inventory() https://review.opendev.org/c/openstack/nova/+/778014 | |
| 17:37:24 | openstackgerrit | Merged openstack/nova stable/pike: Update resources once in update_available_resource https://review.opendev.org/c/openstack/nova/+/612295 | |
| 17:37:46 | Luzi | stephenfin, thank you | |
| 17:55:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add image metadata property reference guide https://review.opendev.org/c/openstack/nova/+/756867 | |
| 17:55:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Change 'add_stylesheet' to 'add_css_file' https://review.opendev.org/c/openstack/nova/+/781529 | |
| 17:55:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add 'nova:image-meta:' directive, role https://review.opendev.org/c/openstack/nova/+/781530 | |
| 17:55:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add cross-references to image metadata properties https://review.opendev.org/c/openstack/nova/+/781531 | |
| 19:01:16 | openstackgerrit | Merged openstack/nova master: Add config parameter 'live_migration_scheme' to live migration with tls guide https://review.opendev.org/c/openstack/nova/+/781030 | |
| 19:02:08 | gibi | lyarwood: ack, talk to you tomorrow | |
| #openstack-nova - 2021-03-19 | |||
| 00:19:43 | brinzhang_ | bauzas: can you re recheck the bug 1917592's fix? https://review.opendev.org/c/openstack/nova/+/778440 | |
| 00:19:45 | openstack | bug 1917592 in OpenStack Compute (nova) "Missed 'accel_uuids' when we the 'shelved_offload_time' time out in shelving instance periodic task" [Medium,In progress] https://launchpad.net/bugs/1917592 - Assigned to Brin Zhang (zhangbailin) | |
| 00:25:06 | openstackgerrit | Brin Zhang proposed openstack/nova master: Refactor check and exception https://review.opendev.org/c/openstack/nova/+/749052 | |
| 03:31:13 | openstackgerrit | Merged openstack/nova stable/train: compute: Lock by instance.uuid lock during swap_volume https://review.opendev.org/c/openstack/nova/+/758733 | |
| 04:19:47 | openstackgerrit | Rico Lin proposed openstack/nova master: [TEST][ARM64]Revert "libvirt: Add parsing of firmware metadata files" https://review.opendev.org/c/openstack/nova/+/781210 | |
| 06:04:18 | openstackgerrit | Josephine Seifert proposed openstack/nova stable/victoria: Add config parameter 'live_migration_scheme' to live migration with tls guide https://review.opendev.org/c/openstack/nova/+/781211 | |
| 08:45:33 | lyarwood | gibi: so I managed to get out of dad taxi duty this morning when you're able to talk about the detach series | |
| 08:47:09 | gibi | lyarwood: I've just replied to some of your comments in the series | |
| 08:47:12 | gibi | lyarwood: so we can talk | |
| 08:48:42 | gibi | I see you point about not raise when device is not in the live domain but try the detach from the persistent domain | |
| 08:52:03 | lyarwood | gibi: yeah it's just handles corner cases where things are in a weird state when a caller retries the detach | |
| 08:52:16 | lyarwood | gibi: not attached to the live but still in the persistent somehow | |
| 08:56:34 | gibi | lyarwood: give me 20 mins and I can make a proper conversation... | |
| 08:57:18 | lyarwood | gibi: yeah np I'll reply in the review | |
| 09:06:07 | bauzas | brinzhang0: sure, will review https://review.opendev.org/c/openstack/nova/+/778440 | |
| 09:06:17 | bauzas | as it's an important bugfix for Wallaby | |
| 09:06:42 | brinzhang0 | bauzas: thanks | |
| 09:06:53 | bauzas | brinzhang0: actually, can you please rebase it above https://review.opendev.org/c/openstack/nova/+/761452 ? | |
| 09:08:13 | brinzhang0 | It seems not impact for your patch, right? | |
| 09:09:35 | bauzas | brinzhang0: nevermind, I'll +W your patch and then I'll rebase my one | |
| 09:10:17 | brinzhang0 | bauzas: thanks, there are not order ^ | |
| 09:10:27 | bauzas | brinzhang0: unfortunately, yes | |
| 09:10:34 | bauzas | see the merge conflicts | |
| 09:10:44 | bauzas | but I'll rebase my patch | |
| 09:11:23 | brinzhang0 | bauzas: thanks, may conflict the test case in compute_mgr | |
| 09:22:19 | lucasagomes | hi, could somebody take a look at https://review.opendev.org/c/openstack/nova/+/776419, https://review.opendev.org/c/openstack/nova/+/776944 and https://review.opendev.org/c/openstack/nova/+/776934 ? | |
| 09:22:46 | lucasagomes | they r small patches towards enabling OVN to be the default backend in DevStack at the beggining of the next release cycle | |
| 09:22:59 | gibi | lyarwood: thanks for the reply. Is there anything else that I need to think about in the detach series? | |
| 09:23:02 | lucasagomes | it makes sure the nova gate won't break once we flip it | |
| 09:28:43 | nautik | gibi: Hi! Following our chat the other day, I pushed the blueprint https://blueprints.launchpad.net/nova/+spec/allow-special-characters-in-keypair-name along with the merge request https://review.opendev.org/c/openstack/nova/+/781076 | |
| 09:29:55 | nautik | gibi: reviews and comments are welcome, first time doing this and not yet so-much familiar with nova code; don't hesitate to tell me if you see missing tests for example | |
| 09:31:10 | gibi | nautik: thanks | |
| 09:38:09 | gibi | gmann, stephenfin, bauzas: can we extend accepted charachter set of keypair names without microversion? | |
| 09:38:25 | gibi | see the bp above | |
| 09:39:08 | gibi | the API ref and the json validation code in nova does not restrict a charset for the name but we have some custom code that rejectes @ for example | |
| 09:40:07 | gibi | the custom check is You specified more local devices than the limit allows | |
| 09:40:10 | gibi | sorry | |
| 09:40:20 | gibi | the custom check is https://opendev.org/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993 | |
| 09:43:49 | gibi | strictly speaking there everyting that worked before will work after we extend the charset so we are not breaking existing clients | |
| 09:43:50 | bauzas | gibi: looking | |
| 09:44:18 | gibi | except for those clients that relied on getting http 400 with keypair names containing @ for example | |
| 09:44:26 | bauzas | gibi: well, in between clouds, this would change, right? | |
| 09:44:45 | bauzas | as a user, how could I know I could use specific chars ? | |