Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-03-12
08:22:11 yonglihe code reactors.
08:22:16 yonglihe refactors
08:22:34 yonglihe but we have solutions for that.
08:25:27 yonglihe The one need decouple the flavor arq from port-arq need more force, that cofused everyone.
08:25:36 gibi I see
08:26:04 gibi alex_xu: will you be around in the next week to review the smartnic series ?
08:26:09 yonglihe but we could use port uuid instead of instace uuid as arq consumer, that will much more clear
08:26:23 gibi hm that sounds like a good idea
08:31:39 alex_xu gibi: yes, I will be there to review the smartnic series
08:31:47 gibi alex_xu: thanks
08:32:20 alex_xu np
08:32:50 gibi yonglihe: how do you feel can you propose the fixes not later than Wednesday next week?
08:33:56 yonglihe Your Wednesday, thats sounds ok for me.
08:35:58 gibi Ok
08:50:31 bauzas good morning Nova
08:51:47 bauzas have we discussed on FFEs ?
08:52:26 bauzas nvm http://lists.openstack.org/pipermail/openstack-discuss/2021-March/020772.html
08:53:27 gibi bauzas: yepp, and we have two requested on the ML
08:53:38 bauzas I see the smartnic ones
08:53:45 bauzas hence my question
08:53:51 gibi bauzas: sean-k-mooney requested one for the vdpa too
08:54:00 bauzas oh, the vdpa one
08:54:23 gibi if you read the scrollback then you see my discussion with yonglihe and alex_xu about the smartnic one
08:54:39 gibi from this morning
08:54:41 bauzas the vdpa one got eyes on it yesterday AFAICT
08:54:51 bauzas but what about the smartnic one ?
08:54:51 gibi bauzas: yes, and we found a bug
08:55:14 gibi bauzas: so the vdpa one is pretty close as sean-k-mooney fixed the bug during the night
08:55:40 gibi bauzas: for vdpa we need a patch that blocks unsupported operations like live-migrate, and needs a reno
08:55:42 bauzas merging stuff on today seems reasonable to me provided we kinda verify we don't really change a lot
08:56:12 bauzas like, adding new stuff looks good to me, but for example, asking to have a new ovo field, no
08:56:14 gibi I think we have a good chance to approve the vdpa one today
08:56:26 bauzas gibi: ok, and for smartnic ?
08:56:33 gibi that is a bigger step
08:56:35 bauzas gibi: I can try to look at it
08:56:38 bauzas hah
08:56:44 gibi I had various comments yesterday
08:56:54 bauzas I'll quickly look at the series
08:57:14 gibi yonglihe thinks the hard parts of that can be fixed not later than Wednesday
08:57:26 gibi bauzas: and alex_xu confirmed that he will be around to review
08:57:35 bauzas because as i said, if they want to modify some RPC APIs or want to change ov.o objects or DB, then I wouldn't be super happy
08:57:52 bauzas gibi: well, Wednesday is a bit late, no ? :-
08:57:53 bauzas :(
08:58:01 gibi it is a stretch
08:58:25 bauzas again, my concern is not really about when, but rather about what's modified
08:58:26 gibi bauzas: when you say no new ovo field do you mean we should not merge anything after tomorrow that changes an ovo?
08:58:31 bauzas yes
08:58:34 bauzas or a RPC API
08:58:37 bauzas or a DB upgrade
08:58:39 bauzas or...
08:58:46 bauzas or a API microversion
08:59:15 gibi there is no DB/RPC change in vdpa or smartnic
08:59:20 gibi but both changes ovo
08:59:23 bauzas because merging those while we're already close to RC1 means that if we see problems, it could be difficult to just revert the changes
08:59:24 gibi smartnic adds field https://review.opendev.org/c/openstack/nova/+/771363/13/nova/objects/network_request.py
08:59:36 bauzas /o\
08:59:52 bauzas if we merge those ovo changes today, I'm OK
09:00:05 bauzas what I'm not OK it to merge ovo changes like next week
09:00:08 gibi vdpa adds enum value https://review.opendev.org/c/openstack/nova/+/777481/8/nova/objects/fields.py
09:00:19 bauzas I know for vdpa
09:00:20 gibi bauzas: fair point
09:00:36 gibi then I think smartnic needs to be deferred
09:00:56 gibi I'm not happy to merge the ovo change today without seeing the whole series coming together
09:00:57 bauzas again, it's more a question about how to be reverting if we merge them next week and we see problems
09:01:09 bauzas gibi: yeah :(
09:01:20 gibi and you have a valid point about the risk in ovo
09:01:43 bauzas but for example, I could be OK with merging a new config option on Monday
09:01:58 bauzas Wednesday is late
09:02:11 bauzas but, at least if we see problems, it's simple to just revert
09:02:35 bauzas people could tell it's simple to revert ovo changes
09:02:50 bauzas but the problem here is that master is down then
09:03:07 gibi what do you mean by down?
09:08:43 bauzas gibi: I mean that if we would want to revert an ovo patch, this would mean that we absolutely need to be sure that we don't merge other ovo changes after this one
09:08:55 bauzas we can pretend it never existed but there is a high risk of tangling
09:09:19 bauzas hence me being super conservative about such changes to be merged while we're so close from RC1
09:09:45 gibi tanglig by having two different ovo object with the same version
09:12:23 gibi yonglihe: bauzas had a point above about the ovo change being risky close to RC1 and I think his point is valid. I'm affraid we have to defer the smartnic series to X
09:12:40 gibi alex_xu: ^^
09:12:52 bauzas I'll review the series this morning
09:13:02 bauzas it's fair to look at the change before cutting the rope
09:13:39 yonglihe gibi: got, that's reasonable. likely, we could merge smartnic in very ealry stage of X
09:13:49 bauzas but since I haven't reviewed the spec, it'll take time for me to load the context in mind :)
09:14:18 bauzas yonglihe: if you don't mind then, I can propose sponsoring your series as soon as we branch RC1
09:14:29 bauzas which will be in two weeks
09:15:16 yonglihe bauzas, sure, that sound good for me, and thanks.
09:15:24 gibi yonglihe: sorry for the bad news and thanks for the flexibility
09:15:35 gibi I will summarize this to the ML
09:15:35 bauzas yonglihe: thanks for your understanding :(
09:15:59 bauzas yonglihe: ping me once RC1 is cut, and then I'll review your patches
09:16:43 yonglihe bauzas: we all responsible to minimize risk, that's right way to go. thanks.
09:17:08 bauzas yonglihe: don't forget to ping me as I could forget
09:18:31 yonglihe bauzas, sure.
09:19:04 openstackgerrit Wenping Song proposed openstack/nova master: Remove get_device_profile_request_groups function in cyborg.py https://review.opendev.org/c/openstack/nova/+/780206
09:29:51 alex_xu gibi: bauzas got it, thanks for the review and feedback anyway
09:44:22 openstackgerrit Jinsheng Zhang proposed openstack/nova stable/victoria: Add nova support ironic instance port group network metadata https://review.opendev.org/c/openstack/nova/+/780209
10:00:15 gibi sean-k-mooney, stephenfin: I finished reading the new patches of vdpa. Left some small comments and question inline. I will be off for a while between 13:00 - 16:00 CET but I will review whatever needs to be reviewed. just let me know
10:03:33 stephenfin gibi: ack, working on a functional tests atm to prove it out before giving my final review
10:03:41 gibi stephenfin: cool
10:16:43 bauzas I can cycle a bit of reviews for the vdpa stuff
10:30:42 gibi bauzas: your help might be needed on the functional test patch as that is written by stephenfin so he cannot +2 it

Earlier   Later