| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-09 | |||
| 16:12:58 | stephenfin | sean-k-mooney: great | |
| 16:14:30 | sean-k-mooney | basically if the host is not a member of an aggreate with filter_tenant_id* then anyone coudl view it | |
| 16:14:48 | sean-k-mooney | if it is then only does listed in that can view it | |
| 16:16:11 | sean-k-mooney | the way i was suggsing doing it was look for all host wiht filter_tenant_id=<my-project> and if that is none then allow all hosts | |
| 16:16:33 | sean-k-mooney | you coudl do it other ways fo course but i think that is what i suggested in the past | |
| 16:16:34 | stephenfin | gmann, gibi: replied on https://review.opendev.org/c/openstack/nova/+/765798 | |
| 16:16:52 | stephenfin | the policy checks are correct, but we're not filtering the compute nodes retrieved | |
| 16:22:51 | gibi | stephenfin: good potin | |
| 16:22:54 | gibi | point | |
| 16:37:16 | sean-k-mooney | stephenfin: by the way are you ok with https://review.opendev.org/c/openstack/nova/+/773792 now? i did not remove the extension check since bauzas suggested i should add it when i discussed it previously | |
| 16:37:59 | sean-k-mooney | it hit the cinder issue i was disucssing with lyarwood eairler so i have not rechecked it yet | |
| 16:38:30 | stephenfin | Holy s***, OSC has a REPL?? | |
| 16:39:06 | stephenfin | sean-k-mooney: I'd like to remove it if we can. I'm literally trying to test if it will work as we speak :) | |
| 16:39:15 | sean-k-mooney | yes.... | |
| 16:39:19 | sean-k-mooney | you didnt know that | |
| 16:39:25 | stephenfin | but tbf I didn't read your replies yet. Looking | |
| 16:39:34 | sean-k-mooney | stephenfin: we can remove it | |
| 16:39:37 | sean-k-mooney | i tested it locally | |
| 16:39:52 | sean-k-mooney | if you request a feild that does not exist it does not break anything | |
| 16:40:05 | sean-k-mooney | also it passed tempest for the run where i did not have the extension test | |
| 16:40:29 | stephenfin | hmm, so we can avoid a second API check with no consequences? | |
| 16:40:34 | sean-k-mooney | so if bauzas is ok with me removing it and gibi is oke to review it again i can remove it | |
| 16:40:46 | sean-k-mooney | stephenfin: its cached | |
| 16:40:55 | sean-k-mooney | we will only ever check once right | |
| 16:41:00 | sean-k-mooney | oh way not we refresh the cache | |
| 16:41:12 | stephenfin | yup :) | |
| 16:41:13 | sean-k-mooney | ya ok we can kill the check | |
| 16:41:26 | stephenfin | though tbf, that refresh is behind a timer | |
| 16:41:27 | sean-k-mooney | i just didnt want to revert it and get -2 again | |
| 16:41:47 | stephenfin | so it's not as harmful as a I thought | |
| 16:41:51 | stephenfin | *as I | |
| 16:42:23 | sean-k-mooney | cool weell i need to recheck due to the cinder issue so i can respin instead but dont want to keep reving it for no reason | |
| 16:42:43 | sean-k-mooney | well not no reason but going back an forth | |
| 16:43:24 | stephenfin | Thanks fair | |
| 16:43:30 | sean-k-mooney | stephenfin: did i do https://review.opendev.org/c/openstack/nova/+/773792/8/nova/network/neutron.py#2043 correctly by the way | |
| 16:43:34 | stephenfin | bauzas is AFK at the moment | |
| 16:43:43 | stephenfin | so maybe gibi can weigh in? | |
| 16:43:54 | stephenfin | nah, what gibi suggested is what I was expecting | |
| 16:44:01 | stephenfin | :param: foo foo foo | |
| 16:44:05 | stephenfin | foo foo foo | |
| 16:44:16 | stephenfin | well, :return: | |
| 16:44:22 | stephenfin | you know what I mean :) | |
| 16:44:28 | sean-k-mooney | ah so just 4 spaces instead of like 8 | |
| 16:44:37 | stephenfin | yup | |
| 16:44:37 | sean-k-mooney | instead of removing the indet entirely | |
| 16:44:39 | stephenfin | please | |
| 16:44:42 | gibi | I can rerewiew | |
| 16:44:58 | gibi | if that was the question | |
| 16:45:15 | sean-k-mooney | well would you prefer i keep the extention check or remove it | |
| 16:45:34 | sean-k-mooney | since the call wont fail in either case and we dont check for the port resouces extension | |
| 16:46:08 | sean-k-mooney | gibi: specificlaly this if https://review.opendev.org/c/openstack/nova/+/773792/8/nova/network/neutron.py#2050 | |
| 16:47:31 | gibi | I'm OK to remove the check as neutron does not bark on nonexistent field and you access the field in the response conditionally | |
| 16:48:18 | sean-k-mooney | ya i use get and default to None and handel that properly later | |
| 16:48:50 | sean-k-mooney | in that case ill remove that and put back the correct indent for the return comment | |
| 16:49:11 | sean-k-mooney | sorry for the churn i go do that now | |
| 16:49:38 | sean-k-mooney | stephenfin: anything else for me to adress while i do that our are you happy other then that? | |
| 16:53:53 | stephenfin | sean-k-mooney: I'd really like to see that Wallaby reference dropped from the reno too /o\ | |
| 16:54:10 | stephenfin | I just left suggestions for other ways to store/get that metadata if you really rely on it | |
| 16:54:48 | sean-k-mooney | i know how to get it from git i just hate seeing release notes without it | |
| 16:54:53 | sean-k-mooney | but fine i can drop it | |
| 16:55:08 | sean-k-mooney | i almost never ead release notes outside of git | |
| 16:55:36 | stephenfin | Yeah, figured you would | |
| 16:55:43 | stephenfin | you could do a comment | |
| 16:56:24 | sean-k-mooney | hum i guess i could. whats the yaml comment syntax // | |
| 16:56:32 | sean-k-mooney | it follows c right | |
| 16:56:40 | stephenfin | as I noted, release notes should avoid version information in general since it doesn't make sense for backported fixes. That's not applicable here but in general, it's a good guide | |
| 16:56:42 | sean-k-mooney | i think ill just drop it for now | |
| 16:56:55 | stephenfin | '#' I think, but I'm not sure | |
| 16:56:56 | sean-k-mooney | well this is a feature | |
| 16:57:02 | sean-k-mooney | so it wont be backported but sure | |
| 16:57:11 | stephenfin | yeah, like I said, not applicable here but a good guide | |
| 16:57:28 | stephenfin | just never include version information in the release note and you never need to think about it | |
| 16:57:56 | sean-k-mooney | im not sure i actully agree on the backport thing but i also dont wnat to spend time debating it FF week :) | |
| 17:17:25 | lyarwood | has anyone deployed a local multinode devstack env recently? for some reason I can't curl keystone on the controller from the compute but I can ssh and ping between the hosts just fine | |
| 17:18:16 | sean-k-mooney | lyarwood: likely iptables | |
| 17:18:34 | lyarwood | sean-k-mooney: disabled, as is firewalld | |
| 17:18:36 | sean-k-mooney | do "sudo iptables -F; sudo iptables -X" | |
| 17:18:56 | lyarwood | what the flying | |
| 17:18:59 | lyarwood | >< | |
| 17:19:07 | lyarwood | ggwp systemd | |
| 17:19:27 | lyarwood | the service was dead but for what ever reason systemd didn't flush the rules | |
| 17:19:31 | sean-k-mooney | devstack/neutorn? add some iptable rules directly | |
| 17:19:51 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use improved guest CPU config APIs https://review.opendev.org/c/openstack/nova/+/762330 | |
| 17:19:51 | sean-k-mooney | i used to keep that command in my local.sh | |
| 17:20:00 | sean-k-mooney | so that devstack would just do it every time i stacked | |
| 17:20:07 | sean-k-mooney | i assume its working now? | |
| 17:20:08 | lyarwood | yeah not a bad idea | |
| 17:20:30 | lyarwood | yeah hopefully just stacking the compute again | |
| 17:21:15 | sean-k-mooney | i never bother to check what exacatly add the iptables ruels athat break it but the fix was simple so i never felt the need | |
| 17:28:19 | kashyap | lyarwood: gibi: The above patch (I resolved conflicts from a rebase) is chunky ... but solves a real live migration problem. In the past it was a blueprint and I wrote some docs in a "spec". But there's a case to be made for it to be an "advanced bug-fix" | |
| 17:28:47 | kashyap | I now need to go out, perhaps I can bring this up on the upstream meeting for discussion | |
| 17:31:41 | kashyap | [That needs to be split up for easier review] | |
| 17:32:09 | gibi | kashyap: ack, I have to look at it tomorrow | |
| 18:33:15 | sean-k-mooney | stephenfin: gibi i am doing some testing of vdpa for different api actions tl;dr i need to block shelve in addtion to livemigrate which was already planned. | |
| 18:33:47 | sean-k-mooney | but the reason i need to block shelve is because the vdpa change shared the same code for shelve as normal neutron vf ports | |
| 18:33:54 | sean-k-mooney | e.g. vnic_type=direct | |
| 18:33:58 | sean-k-mooney | so it also hits https://bugzilla.redhat.com/show_bug.cgi?id=1767797 | |
| 18:34:00 | openstack | bugzilla.redhat.com bug 1767797 in openstack-nova "When unshelving an SR-IOV instance, the binding profile isn't reclaimed or rescheduled, and this might cause PCI-PT conflicts" [High,Assigned] - Assigned to alifshit | |
| 18:34:40 | sean-k-mooney | nova is correctly claiming the device in the pci tracker but not updating the neutron port | |
| 18:34:47 | sean-k-mooney | before we regenerate the xml | |