| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-08 | |||
| 09:54:37 | nautik | I found this commit introducing the check https://github.com/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993 | |
| 09:54:58 | nautik | which fixes an issue about / (https://bugs.launchpad.net/nova/+bug/937408) | |
| 09:54:59 | openstack | Launchpad bug 937408 in OpenStack Compute (nova) "Can't delete keypair with a slash" [Medium,Fix released] - Assigned to Justin Shepherd (jshepher) | |
| 09:55:45 | gibi | bauzas: good for you :) | |
| 09:56:21 | nautik | but appearently users are commonly trying to put '@' in their key name | |
| 09:57:20 | gibi | nautik: based on the bug you linked the issue was forward slash in the name '/'. So we could try to see if we can make @ work | |
| 09:57:56 | gibi | nautik: if you have time to propose a patch that allows @ along with some functional test then I will be happy to review it | |
| 09:58:37 | nautik | ok cool, thank you | |
| 10:50:10 | elod | lyarwood: fyi, train and older branches are blocked until these aren't merged: https://review.opendev.org/q/Id62e91b1609db4b1d2fa425010bac1ce77e9fc51 | |
| 10:50:32 | lyarwood | elod: ack was about to look at the failures of my earlier swap_volume instance.uuid backports | |
| 10:50:38 | lyarwood | elod: thanks for the heads up | |
| 10:50:45 | elod | np | |
| 10:53:12 | lyarwood | I guess it's yet another reverse order backport because of grenade? | |
| 10:59:46 | elod | only stein needs to be merged prior to train | |
| 10:59:57 | elod | stein can be merged directly | |
| 11:00:51 | lyarwood | ah of course, grenade doesn't vote prior to that | |
| 11:41:14 | admin0 | hi all .. what scheduler controls --property quota:disk_io_limit for a ceph backend in nova | |
| 11:41:24 | admin0 | so that io limits can be properly enforced | |
| 11:47:31 | gibi | admin0: based on the code it is only used by the vmware virt driver | |
| 11:49:42 | sean-k-mooney | admin0: the io filter limits the scudling based on higlevel io ops | |
| 11:49:49 | sean-k-mooney | like building a vm or snapshots | |
| 11:50:02 | sean-k-mooney | it does not look at disk iops or bandwith | |
| 11:50:39 | sean-k-mooney | i assume that is what you wanted to enforce or loadblance on? | |
| 12:09:26 | sean-k-mooney | admin0: disk_read_iops_sec disk_write_iops_sec and disk_total_iops_sec are supported in the libvirt driver by the way | |
| 12:09:57 | sean-k-mooney | admin0: e.g. --property quota:disk_total_iops_sec=500 | |
| 12:10:37 | sean-k-mooney | admin0: there is no scheduling based on this and instead it enforece a limit on the amount of iops that a vm can do. | |
| 12:12:36 | admin0 | sean-k-mooney, https://gist.github.com/a1git/35020a03a3870741af463fc18e1e811c | |
| 12:12:39 | admin0 | i have the limit set at 800 | |
| 12:12:47 | admin0 | but i am getting a lot and its not hitting any limit | |
| 12:12:54 | admin0 | or that i don't know how to test this using fio | |
| 12:13:02 | sean-k-mooney | what virt driver are you using | |
| 12:13:19 | sean-k-mooney | also you cant change that after the vm is booted | |
| 12:13:41 | sean-k-mooney | so after you do the flavor set you need to create a new vm with that flavor | |
| 12:14:24 | sean-k-mooney | "openstack flavor set g6 --property quota:disk_total_iops_sec=800" would be what you shoudl set if you are using libvirt | |
| 12:42:13 | nightmare_unreal | hello is there a way to get statistics of live-migration ? Like what was the avg disk transfer rate, how much time it took etc. | |
| 12:42:51 | sean-k-mooney | historical migrationg i dont think so but you can get stats form the ongoing migration at least form libvirt | |
| 12:43:08 | sean-k-mooney | posibly also form the api but im not sure how much detail we have in the migration status | |
| 12:46:48 | lyarwood | nightmare_unreal: https://docs.openstack.org/api-ref/compute/?expanded=show-migration-details-detail#show-migration-details | |
| 12:47:23 | lyarwood | nightmare_unreal: we don't list the average transfer rate etc | |
| 12:47:27 | sean-k-mooney | ah we do have disk_remaining_bytes etctra in that responce good | |
| 12:47:33 | lyarwood | nightmare_unreal: iirc it is dumped in the logs | |
| 12:47:39 | nightmare_unreal | ah then i can calculate i think | |
| 12:47:44 | nightmare_unreal | disk remaining / total disk | |
| 12:48:00 | lyarwood | yup | |
| 12:48:07 | nightmare_unreal | thanks :D | |
| 12:48:09 | sean-k-mooney | am not entirly | |
| 12:48:37 | sean-k-mooney | the byts migrated can be larger then total disk | |
| 12:49:02 | lyarwood | right and remaining can also move around | |
| 12:49:12 | sean-k-mooney | disk_processed_bytes can be larger then disk_total_bytes if the vm is wriging to the disk while its being migrated | |
| 12:51:09 | sean-k-mooney | you can get a microsoft style progress bar where it sometiems gose backwared or time remaing goes up as the persentage completeion increases if your try to use disk_remaining_bytes/disk_total_bytes to caulate things | |
| 12:51:29 | sean-k-mooney | the data is not meaning less but unless the guest is idel it wont be linear | |
| 12:51:31 | lyarwood | lol | |
| 12:53:18 | nightmare_unreal | ahah I see | |
| 12:53:28 | nightmare_unreal | i will keep that in mind. | |
| 13:06:00 | sean-k-mooney | gibi: i have a pe8 issue in my port numa policies patch so ill fix the doc issue when i repin it shortly | |
| 13:06:28 | gibi | sean-k-mooney: ack | |
| 13:07:01 | sean-k-mooney | by the way did you want me to add a new doc for this or just fix the comment | |
| 13:07:15 | sean-k-mooney | i could add a doc too but did you have a specific place in mind? | |
| 13:07:33 | gibi | sean-k-mooney: just add a doc to the function about the item in the returned tuple | |
| 13:08:24 | sean-k-mooney | ah cool. i was wondering if you wanted a user facing doc. i could add one of those as a followup but porbly need to think where that should go. ill fix the comment thanks:) | |
| 13:29:41 | gibi | sean-k-mooney: regarding the user facing doc, I hope neturon has at least an API doc for this port parameter | |
| 13:29:43 | gibi | :) | |
| 13:30:21 | sean-k-mooney | i was thinking maybe we should add something to the networking guide | |
| 13:30:43 | gibi | yeah that would be good to have ^^ | |
| 13:30:44 | sean-k-mooney | they did not add the osc command but i submited a patch to do that | |
| 13:31:02 | gibi | the api ref is not missing but pretty short | |
| 13:31:04 | sean-k-mooney | so ill submit a follow up patch to the networkign guide to use that | |
| 13:31:12 | gibi | "The port NUMA affinity policy requested during the virtual machine scheduling. Values: None, requiered, preferred or legacy." | |
| 13:31:33 | sean-k-mooney | ya i can proably extend that too and explain what the policies do | |
| 13:31:49 | gibi | hm and there is a typo in it | |
| 13:31:53 | sean-k-mooney | we have the explaniaton in nova but it better to not need to cross reference | |
| 13:31:54 | gibi | requiered -> required | |
| 13:32:10 | sean-k-mooney | oh yes there is. | |
| 13:32:30 | sean-k-mooney | only in the doc however | |
| 13:32:30 | gibi | also when artom's series lands with the socket value we need to document that for the port attribute too | |
| 13:33:03 | sean-k-mooney | yep although that requires a neutron change to extend the db enum. its just a sting field but the model need to be extended | |
| 13:33:50 | gibi | I see | |
| 13:33:53 | gibi | good to know that | |
| 13:34:04 | gibi | I assumed it is an unrestricted string in neutron | |
| 13:34:12 | gibi | but the it is better | |
| 13:34:47 | sean-k-mooney | i think in terms fo the db coloum defiention yes but they are validating it in python | |
| 13:37:56 | sean-k-mooney | the only thing that is slightly unfortunete is they enabled each policy with a seperate flag in osc | |
| 13:38:21 | sean-k-mooney | rather then a vaule that takes a sting paramter but its not a huge issue | |
| 13:42:52 | admin0 | sean-k-mooney, i am using kvm .. first the flavor was created and the limit was set .. after that the instance was booted up | |
| 13:43:45 | sean-k-mooney | admin0: yes but you use a vaule that is only supproted for vmware | |
| 13:43:54 | sean-k-mooney | admin0: try the same with the one i pointed too | |
| 13:44:12 | admin0 | oh | |
| 13:44:15 | admin0 | i get it | |
| 13:44:16 | admin0 | thank you | |
| 13:44:18 | sean-k-mooney | openstack flavor set g6 --property quota:disk_total_iops_sec=800 | |
| 13:44:18 | admin0 | i will retry | |
| 13:45:29 | sean-k-mooney | that one and the others in the disk tuning section of https://docs.openstack.org/nova/latest/user/flavors.html work with libvirt | |
| 13:46:22 | openstackgerrit | Merged openstack/nova master: Replace md5 for fips https://review.opendev.org/c/openstack/nova/+/777686 | |
| 13:47:18 | openstackgerrit | Merged openstack/nova master: Centralize sqlite FK constraint enforcement https://review.opendev.org/c/openstack/nova/+/773833 | |
| 13:57:32 | openstackgerrit | sean mooney proposed openstack/nova master: support per port numa policies with sriov https://review.opendev.org/c/openstack/nova/+/773792 | |
| 13:58:20 | sean-k-mooney | alex_xu: stephenfin would either of ye have time to review ^ gibi made the doc update and fixed the pep8 issue. | |
| 13:59:39 | gibi | sean-k-mooney: thanks +2 | |
| 14:00:53 | sean-k-mooney | just lookign at your sqlite change that really is just refactoring it so that its cenratlised since we already had the dynamic logic. do we run with 3.7+ in the gate? | |
| 14:01:39 | sean-k-mooney | i assume we have no way to requrie a minium of 3.7 beyond moving to an os that provides it | |
| 14:01:42 | gibi | sean-k-mooney: I think you are referring to melwitt's change :) | |