| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-05 | |||
| 13:08:28 | lyarwood | I'd rather avoid duplication and move to zuulv3 now instead of waiting to get the ceph coverage in place | |
| 13:09:47 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Remove nova-dsvm-multinode-base https://review.opendev.org/c/openstack/nova/+/778908 | |
| 13:09:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Create and use nova-libvirt-irrelevant-files https://review.opendev.org/c/openstack/nova/+/778909 | |
| 13:11:53 | stephenfin | lyarwood: Low priority, but you may like 'Either a URI-style path (\'file:\\\\{path}\') to a JSON file ' | |
| 13:11:55 | stephenfin | whoops | |
| 13:12:01 | stephenfin | https://review.opendev.org/c/openstack/python-openstackclient/+/778910 | |
| 13:13:12 | lyarwood | stephenfin: nice idea | |
| 13:13:35 | stephenfin | I stole it https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/block-device-mapping-concepts.html | |
| 13:13:47 | stephenfin | (search for --block-device-mappings) | |
| 13:18:51 | sean-k-mooney | speaking of osc https://review.opendev.org/c/openstack/python-openstackclient/+/778571 | |
| 13:18:54 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Create and use nova-libvirt-irrelevant-files https://review.opendev.org/c/openstack/nova/+/778909 | |
| 13:18:56 | sean-k-mooney | that is for vdpa | |
| 13:19:27 | sean-k-mooney | stephenfin: care to take a look i dont know if i need a release note for that or anything else | |
| 13:19:40 | sean-k-mooney | stephenfin: i just did then minium i needed to not have to use curl | |
| 13:20:30 | stephenfin | sean-k-mooney: will do | |
| 13:20:45 | stephenfin | that's merged in neutron now? | |
| 13:20:53 | sean-k-mooney | yep | |
| 13:20:56 | stephenfin | cool | |
| 13:21:06 | stephenfin | will review fully after lunch but a small release note would be A+ | |
| 13:21:21 | stephenfin | and a link to the neutron change that added it (for context) | |
| 13:21:43 | sean-k-mooney | sure ill see if i can do that later today | |
| 13:30:11 | openstackgerrit | Merged openstack/nova master: tests: Stop mocking 'nova.virt.libvirt.utils.get_arch' https://review.opendev.org/c/openstack/nova/+/778879 | |
| 13:41:07 | tosky | lyarwood: in that patch, maybe you can also emove nova-dsvm-multinode-base | |
| 13:41:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move instance power state check to _detach_with_retry https://review.opendev.org/c/openstack/nova/+/778918 | |
| 13:42:28 | lyarwood | tosky: I've done that in the following change | |
| 13:55:29 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Placeholders for DB migration backports to Wallaby https://review.opendev.org/c/openstack/nova/+/778923 | |
| 13:55:39 | bauzas | gibi: stephenfin: sorry, was at some gym, here is the wallaby db placeholders change ^ | |
| 13:55:49 | bauzas | lemme look when we merged the other ones | |
| 13:55:53 | gibi | bauzas: thanks | |
| 13:56:30 | bauzas | gibi: IIRC, we wanted to have the placeholders *before* any other db migration for a cycle | |
| 13:56:37 | gibi | yes | |
| 13:56:48 | gibi | so if we merge it at the start of the cycle then we are goo | |
| 13:56:49 | gibi | d | |
| 13:56:57 | bauzas | like, you write a db migration for wallaby, you need to have the placeholders *before* | |
| 13:57:17 | bauzas | sure, but then we are lucky to not have any merged db migration during this cycle | |
| 13:57:37 | bauzas | my point is, we should backport this sooner than later and write another change for reserving the xena ones early in the cycle | |
| 13:57:53 | bauzas | don't we have this in the ptl guide or something like it ? | |
| 13:58:22 | bauzas | https://review.opendev.org/c/openstack/nova/+/686411 is the Train one | |
| 13:58:36 | gibi | bauzas: post release check list https://wiki.openstack.org/wiki/Nova/ReleaseChecklist | |
| 13:59:34 | gibi | linked in the https://docs.openstack.org/nova/latest/contributor/ptl-guide.html | |
| 13:59:38 | bauzas | the above change was merged on oct 4th | |
| 13:59:49 | bauzas | (2019) | |
| 13:59:56 | bauzas | and the train timeline was https://releases.openstack.org/train/schedule.html | |
| 14:00:08 | gibi | according to git it was included from ussuri | |
| 14:00:09 | sean-k-mooney | bauzas: so for xena i think stephenfin wants to move to alemnbic | |
| 14:00:22 | sean-k-mooney | so that might be different in the future | |
| 14:00:29 | bauzas | gibi: /me facepalms | |
| 14:00:38 | sean-k-mooney | not sure if we still need to do reservations the same way | |
| 14:00:40 | bauzas | so, yeah, this was merged early in the cycle, not late | |
| 14:00:56 | gibi | bauzas: hm, I think ti was merged after RC1 and therefore after we branched out stable/train | |
| 14:01:05 | bauzas | sean-k-mooney: we'll open the xena cycle before the PTG, we need the placeholders sooner than later | |
| 14:01:33 | bauzas | gibi: sure, but at this point in time, the ussuri placeholders change was merged when we did the master branch to ussuri | |
| 14:01:33 | sean-k-mooney | bauzas: sure just pointing out thye may not be used | |
| 14:01:41 | gibi | bauzas: correct | |
| 14:01:41 | sean-k-mooney | that said they dont hurt to have really | |
| 14:01:49 | gibi | bauzas: so it is only in ussuri but not in train | |
| 14:02:08 | bauzas | gibi: correct, that's a PEBKAC when I said Train | |
| 14:02:37 | bauzas | oh wai | |
| 14:02:40 | gibi | sean-k-mooney: it is like we don't know yet how the alembic migration will look like so I think we have to do the safe move and add reservation | |
| 14:02:43 | bauzas | man, this is confusing | |
| 14:02:47 | bauzas | https://review.opendev.org/c/openstack/nova/+/686411/2/nova/tests/functional/db/api/test_migrations.py | |
| 14:03:08 | bauzas | this was merged just after the branch but we name them train migrations | |
| 14:03:29 | bauzas | so, hence my confusion, placeholders go last | |
| 14:03:39 | bauzas | and just after we cut | |
| 14:03:40 | gibi | yeah it is like placeholder for migration backported from ussuri to train | |
| 14:03:47 | gibi | so both name can be correct :) | |
| 14:03:48 | bauzas | gibi: so you were right, we should hold until the branhc | |
| 14:03:58 | sean-k-mooney | gibi: yep we should for that reason and because whilte stephenfin want to do the move next cycle something might come up which means we cant finish it | |
| 14:04:10 | sean-k-mooney | so we need to prepare for backport in anycase | |
| 14:04:13 | gibi | sean-k-mooney: correct | |
| 14:04:40 | bauzas | sean-k-mooney: gibi: like I said to stephenfin, before discussing it at the PTG, I'd like to dig why we didn't like that before | |
| 14:07:08 | sean-k-mooney | alembic | |
| 14:07:17 | bauzas | yup | |
| 14:07:34 | sean-k-mooney | it was manly because we did not feel the effort of the move was worth it similar to removing mox | |
| 14:07:44 | bauzas | I recall this | |
| 14:07:51 | bauzas | but IIRC there were other concerns | |
| 14:08:02 | bauzas | that's what I'd like to dif | |
| 14:08:03 | sean-k-mooney | but like mox that ment the nova team was signing up to maintian sqlalchemy-migrate indefinetly | |
| 14:08:05 | bauzas | dig* | |
| 14:08:24 | bauzas | sure, but this prove to work ? | |
| 14:08:42 | bauzas | we would just pull another dependency we loose control | |
| 14:08:46 | bauzas | over their releases | |
| 14:08:56 | sean-k-mooney | bauzas: we are using a dep that neutron uses already | |
| 14:09:04 | bauzas | I know | |
| 14:09:23 | sean-k-mooney | bauzas: and the maintiner of sqlachmey asked us to move | |
| 14:09:25 | bauzas | but that just increases the potential flaw, it doesn't prove it works | |
| 14:09:40 | sean-k-mooney | it does prove it works they have used it for years | |
| 14:10:01 | sean-k-mooney | im pretty sure neutron moved beofre we created placment | |
| 14:15:48 | bauzas | oh yes, I remember | |
| 14:15:54 | sean-k-mooney | neutron dont seam to have placeholder migration anymore https://github.com/openstack/neutron/tree/b04dfcee192cf7ddcb69854e760739fdcfa7839e/neutron/db/migration/alembic_migrations/versions | |
| 14:16:03 | bauzas | I actually never remember neutron using sqalchemy-migrate | |
| 14:16:15 | bauzas | even when they were named quantum | |
| 14:16:16 | sean-k-mooney | and they have tooling to auto genrate the migrations | |
| 14:16:27 | sean-k-mooney | bauzas: i tought quantum did but maybe not | |
| 14:16:51 | bauzas | well, i played with quantum with the Folsom release, and I don't think they were using migrate | |
| 14:17:01 | bauzas | but that's been a while | |
| 14:17:11 | sean-k-mooney | actully hevan used it alredy | |
| 14:17:15 | sean-k-mooney | so i guess not | |
| 14:17:41 | bauzas | they were incubated during Essex, so I didn't use it in my prod | |
| 14:17:52 | bauzas | can't speak for Essex | |