| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-04 | |||
| 09:50:46 | lyarwood | bauzas: the only odd thing is that we format/encrypt /dev/sda | |
| 09:51:37 | lyarwood | https://github.com/openstack/os-brick/blame/bd629a3a4105f7f3f9f35b71350ea3c66f3690e9/os_brick/encryptors/cryptsetup.py#L80-L81 and https://github.com/openstack/os-brick/blob/bd629a3a4105f7f3f9f35b71350ea3c66f3690e9/os_brick/encryptors/luks.py#L97 cause that | |
| 09:51:47 | lyarwood | but I've never seen that be a problem before, it should be the same underlying block device | |
| 09:52:35 | lyarwood | unless theres some weirdness in the block layers and /dev/disk/by-id/scsi-360000000000000000e00000000010001 still doesn't look like it's encrypted by the time QEMU attempts to attach it | |
| 09:56:29 | stephenfin | gibi: lyarwood: bauzas: Finishing off the microversion to allow e.g. 'openstack server create --hostname $HOSTNAME ...'. Do we want to allow users to update the hostname? | |
| 09:56:56 | bauzas | stephenfin: spec ? | |
| 09:57:00 | stephenfin | I said in the spec that we would, but all that will change is what's stored on the metadata service unless someone re-runs e.g. cloud-init | |
| 09:57:03 | stephenfin | https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/configurable-instance-hostnames.html | |
| 09:57:24 | stephenfin | So I'm concerned it might be misleading | |
| 09:57:50 | bauzas | I missed that one or I'm old | |
| 09:58:04 | stephenfin | Well you are old... | |
| 09:58:13 | stephenfin | but I guess you just missed it :P | |
| 09:58:44 | bauzas | it's coming from the display name issue when users were dumb enough to think that ubuntu20.04 was a valid hostname ? | |
| 09:58:50 | stephenfin | yes | |
| 09:58:52 | bauzas | seriously | |
| 09:59:07 | stephenfin | well, sort of | |
| 09:59:26 | stephenfin | we said the idea of tying a display name and hostname together wasn't necessarily that clever | |
| 09:59:37 | bauzas | stephenfin: users can change their instance hostnames without asking nova, right? | |
| 09:59:59 | bauzas | it's just that nova metadata will give you one | |
| 10:00:03 | bauzas | but you can change it | |
| 10:00:19 | stephenfin | of course, but they'd have to disable cloud-init (or part thereof) | |
| 10:00:40 | bauzas | I'm pretty sure they don't need to do it | |
| 10:00:48 | bauzas | at least in 2013, this wasn't required | |
| 10:01:06 | bauzas | but now quantum, err neutron, does exist | |
| 10:02:56 | bauzas | but OK | |
| 10:03:26 | bauzas | stephenfin: let's assume the user wants to change their hostnames on the nova CLI, what's your concern ? | |
| 10:03:34 | stephenfin | I'm trying to find the relevant cloud-init docs. Best I've got is https://cloudinit.readthedocs.io/en/21.1/topics/instancedata.html but that's EC2-specific | |
| 10:03:52 | stephenfin | My concern is that AFAICT cloud-init only runs once when setting up the instance | |
| 10:04:26 | stephenfin | so providing a way to change the hostname in the metadata service could be misleading, since one would need a service to propagate that change to the instance and I don't know if such a service exists | |
| 10:04:44 | bauzas | stephenfin: https://cloudinit.readthedocs.io/en/latest/topics/modules.html#set-hostname | |
| 10:05:14 | bauzas | now I remember | |
| 10:05:30 | bauzas | man, I turned 40 but I forgot I reviewed this one | |
| 10:06:46 | bauzas | and now I see my vote on the change, I remember I approved it by fatigue | |
| 10:08:54 | lyarwood | bauzas: found it, there's another request to attach a volume that also ends up with that WWN somehow | |
| 10:09:14 | bauzas | lyarwood: hah | |
| 10:09:23 | bauzas | good catch, hence the conflict | |
| 10:10:09 | bauzas | stephenfin: so, IIRC, you can turn off the hostname management with cloud-init and set it thru any management tool like ansible or puppet | |
| 10:10:39 | lyarwood | yeah I'm not sure if this is an os-brick or cinder bug tbh | |
| 10:11:44 | bauzas | stephenfin: so, preserve_hostname be True in cloud.cfg and then you can play with /etc/hosts like you want | |
| 10:11:57 | gibi | stephenfin: on use case I can imagine for the changing of the hostname is that the instance is do managed by ansible, and the user changed the hostname with that and want to keep the nova view in sync with what is in the instance | |
| 10:12:19 | bauzas | gibi: yeah, honestly I feel bad with my review of the spec | |
| 10:12:46 | bauzas | I just feel I haven't properly reviewed it and eventually gave up with loosely approving it | |
| 10:12:56 | bauzas | because I see some operator concerns | |
| 10:14:06 | lyarwood | ah it's a cinder bug, noice. | |
| 10:14:06 | lyarwood | caused by us running multiple c-vol backends >< | |
| 10:14:15 | lyarwood | fun, I bet this has burnt us for years and no one has noticed | |
| 10:15:53 | bauzas | eeek, haven't seen the time flying and I need to dad taxi, shit. | |
| 10:16:22 | bauzas | my productivity would dramatically increase in 5 years once my both kids are in college. | |
| 10:16:46 | bauzas | (4 years actually) | |
| 10:20:03 | stephenfin | gibi: That's a fair point | |
| 10:20:07 | stephenfin | Aight, I'll do that so | |
| 10:26:28 | lyarwood | bauzas: FWIW https://bugs.launchpad.net/cinder/+bug/1917750 | |
| 10:26:28 | openstack | Launchpad bug 1917750 in Cinder "Running parallel iSCSI/LVM c-vol backends is causing random failures in CI" [Undecided,New] | |
| 11:49:29 | openstackgerrit | Merged openstack/nova master: libvirt: parse alias out from device config https://review.opendev.org/c/openstack/nova/+/772384 | |
| 11:52:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove references to 'inst_type' https://review.opendev.org/c/openstack/nova/+/778548 | |
| 11:52:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | |
| 11:52:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 12:28:11 | openstackgerrit | Merged openstack/nova master: tests: Poison os.uname https://review.opendev.org/c/openstack/nova/+/775415 | |
| 12:55:25 | kashyap | Can anyone give this the final ACK (already has a +2), and put it through, please? -- https://review.opendev.org/c/openstack/nova/+/774240 | |
| 13:00:01 | gibi | stephenfin ^^ please? | |
| 13:00:59 | stephenfin | yup, will look shortly | |
| 13:01:02 | gibi | thnks | |
| 13:08:47 | openstackgerrit | Merged openstack/nova stable/ussuri: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/773932 | |
| 13:28:03 | openstackgerrit | Takashi Kajinami proposed openstack/nova master: WIP: Clean up allocations left by evacuation https://review.opendev.org/c/openstack/nova/+/778696 | |
| 13:36:05 | openstackgerrit | Takashi Kajinami proposed openstack/nova master: WIP: Clean up allocations left by evacuation https://review.opendev.org/c/openstack/nova/+/778696 | |
| 14:12:35 | gmann | stephenfin: yeah, was busy yesterday but I am going to update that today. | |
| 14:39:41 | bauzas | gibi: thanks for the +2 on RPC API, tbc I did put a -2 on my own change as I think we should only merge it after FF next week | |
| 14:40:01 | bauzas | gibi: I guess you don't have yet a RC1 etherpad ? | |
| 14:41:11 | bauzas | stephenfin: dansmith: although I marked -2 on https://review.opendev.org/c/openstack/nova/+/761452 I'd appreciate a second core review for making sure we can land it when we want | |
| 14:41:50 | dansmith | I know, still pending | |
| 14:42:18 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-next: Start testing the q35 machine type https://review.opendev.org/c/openstack/nova/+/708701 | |
| 14:53:40 | gibi | bauzas: sure, the RPC bump need to be on hold until FF | |
| 14:53:48 | gibi | bauzas: I have the RC etherpad ready :) https://etherpad.opendev.org/p/nova-wallaby-rc-potential | |
| 14:53:58 | bauzas | huzzah, will add it then | |
| 14:54:03 | gibi | thanks | |
| 14:54:07 | kashyap | lyarwood: Ah, thanks for adding to CirrOS itself: https://github.com/cirros-dev/cirros/pull/65 | |
| 14:54:28 | bauzas | gibi: oh, already there, nice (or grenoble) | |
| 14:55:46 | gibi | :) | |
| 15:33:24 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove useless mocks https://review.opendev.org/c/openstack/nova/+/778730 | |
| 15:33:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove duplicate policy tests https://review.opendev.org/c/openstack/nova/+/778731 | |
| 15:33:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 15:41:38 | lyarwood | stephenfin: https://review.opendev.org/c/openstack/nova/+/673790 - any plans to respond to this -1 btw, I'm ready to go through the rest of the series once we've sorted this out. | |
| 15:42:07 | stephenfin | lyarwood: yup, I was going to do a separate FUP | |
| 15:42:12 | stephenfin | to avoid rebasing the whole series | |
| 15:43:27 | lyarwood | stephenfin: yup fair, I'll let you update the change before I continue on in the series | |
| 15:43:39 | lyarwood | and by that I mean comment, not rebase or anything | |
| 15:45:41 | stephenfin | kashyap: comments left on https://review.opendev.org/c/openstack/nova/+/774240. If you can respin I'll re-review today | |
| 15:47:49 | kashyap | stephenfin: Thanks for the review. Let me look ... | |
| 15:49:15 | kashyap | stephenfin: That mock of _register_instance_machine_type is required after Lee's change | |
| 15:49:27 | stephenfin | but you didn't touch that function? | |
| 15:49:36 | kashyap | stephenfin: Especially as the test is calling init_host() directly | |
| 15:50:10 | stephenfin | kashyap: Ah, whoops | |
| 15:50:15 | lyarwood | the diff has moved it around | |
| 15:50:20 | stephenfin | yup | |
| 15:50:24 | stephenfin | apologies | |
| 15:50:36 | kashyap | No problem | |
| 15:57:42 | kashyap | stephenfin: Is it palatable to you if I don't address the style nit here: https://review.opendev.org/c/openstack/nova/+/774240/11/nova/tests/unit/virt/libvirt/test_driver.py#1579 | |
| 15:57:45 | gibi | nova meeting starts in 2 minutes in #openstack-meeting-3 | |
| 15:57:48 | kashyap | stephenfin: I'm addressing the rest of all your comments | |
| 15:59:46 | stephenfin | sure | |