| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-02 | |||
| 09:11:00 | bauzas | context : https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f69/761452/8/check/openstack-tox-lower-constraints/f699784/testr_results.html | |
| 09:15:10 | bauzas | mmmm, there is a l-c tox target with not using use_develop | |
| 09:16:02 | bauzas | and also, I don't have py36 running | |
| 09:16:15 | bauzas | (as default) | |
| 09:17:23 | kashyap | lyarwood: Morning, when you get a min: Nova uses in-QEMU RBD driver with raw or QCOW2 format or both? | |
| 09:30:53 | stephenfin | bauzas: care to bump this +1 to +2? https://review.opendev.org/c/openstack/nova/+/775415/ | |
| 09:31:56 | hemanth_n | sean-k-mooney: can you review the PCI stat bug on stable/rocky when you get some time https://review.opendev.org/c/openstack/nova/+/761824 | |
| 09:40:47 | bauzas | stephenfin: I'm focusing on fixing the RPC API bump issues in the gate, but I can try to take a look on it later today | |
| 09:48:04 | lyarwood | kashyap: RAW only, we block qcow2 iirc | |
| 09:50:34 | kashyap | lyarwood: A QEMU dev was asking about it; do you know the reason why we block QCOW2? | |
| 09:51:08 | lyarwood | kashyap: we block it when cloning rbd volumes as rbd already does the COW for us | |
| 09:51:11 | lyarwood | kashyap: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/imagebackend.py#L1038-L1041 | |
| 09:51:38 | lyarwood | kashyap: ^ that's for ephemeral storage nova controls, I'm not sure about cinder tbh | |
| 09:52:22 | lpetrut | hi: what should we do about the windows rbd patch? https://review.opendev.org/c/openstack/nova/+/763550 lyarwood would like to bump the lower constraints, sean-k-mooney was asking us not to do that :) | |
| 09:53:03 | lyarwood | kashyap: https://github.com/openstack/cinder/blob/85975fb2b63866ba6e216e621b84d571b9dbe90e/cinder/volume/drivers/rbd.py#L1525-L1530 - looks like the same logic in cinder | |
| 09:53:33 | lyarwood | lpetrut: yeah sorry about this, I don;t think sean-k-mooney got that the current os-brick version would fail with your change, at least I'm hoping that's the case. | |
| 09:53:41 | kashyap | lyarwood: /me clicks | |
| 09:54:39 | lyarwood | gibi / stephenfin / gibi ; ^ any thoughts on lpetrut's issue? The change will not work with the current os-brick version listed in our lc/requirements.txt so we have to bump right? | |
| 09:54:51 | kashyap | lyarwood: Thanks! So the QEMU storage dev was wondering if Nova doesn't use qcow2-over-RBD due to this 2019 bug: https://bugzilla.redhat.com/show_bug.cgi?id=1744525 | |
| 09:54:52 | openstack | bugzilla.redhat.com bug 1744525 in qemu-kvm "Writing data to the qcow2 image over RBD is too slow" [Medium,Assigned] - Assigned to sgarzare | |
| 09:55:07 | kashyap | lyarwood: But I don't think that's the case; as the logic in Cinder and Nova predates that bug | |
| 09:56:21 | stephenfin | lyarwood: lpetrut: it sounds like we're avoiding bumping lower-constraints because it causes a mess? | |
| 09:56:34 | lpetrut | stephenfin yep :) | |
| 09:57:05 | stephenfin | Okay, in that case I suggest we spend a small amount of time trying to resolve the damage, and drop l-c if we can't do it easily | |
| 09:57:28 | stephenfin | Everyone else has dropped them. No point in us suffering for little to no benefit | |
| 09:57:58 | lpetrut | stephenfin: I had a patch set that sync-ed nova's lower constraints with the os-brick ones but some people were concerned by the amount of changes: https://review.opendev.org/c/openstack/nova/+/763550/12..14/lower-constraints.txt | |
| 09:58:34 | lyarwood | stephenfin: have people dropped them on master? | |
| 09:58:38 | stephenfin | sean-k-mooney: fwiw, dropping indirect dependencies from l-c can cause dependency resolution to devolve into a multi-hour slog, since the combinatorial matrix of possible versions for those indirect dependencies is huuuuuuge | |
| 09:58:39 | lyarwood | stephenfin: I noticed the stable stuff | |
| 09:58:50 | stephenfin | lyarwood: they're totally gone from oslo and neutron. Likely many other projects also | |
| 10:01:05 | lyarwood | well well well | |
| 10:01:30 | lpetrut | Cinder still uses lower constraints. most of them have been bumped here: https://github.com/openstack/cinder/commit/d3ffa90baa959530eaa1cd1d4e3800fbe9148806#diff-f868e67d7bc10a25bc6baaea42ed5c763b42174505e4441349a52cf60dc007b0 | |
| 10:01:34 | lyarwood | it doesn't really resolve our issue however | |
| 10:01:44 | lyarwood | https://review.opendev.org/c/openstack/nova/+/763550/12..14/requirements.txt <- as os-brick causes this as well | |
| 10:01:47 | lyarwood | that IMHO we can't avoid | |
| 10:02:05 | lyarwood | why don't I spend some time later today breaking that out into another change you can rebase on lpetrut | |
| 10:02:25 | lyarwood | there's a load of bugfixes in there that we need anyway outside of the new Windows RBD stuff | |
| 10:02:28 | stephenfin | that's...downgrading most things? | |
| 10:02:48 | lyarwood | yeah what the | |
| 10:03:13 | lpetrut | not quite, it's flipped :) | |
| 10:03:13 | stephenfin | That seems off. We won't be allowed to specify a lower limit that os-brick, but we should be able to specify a higher one | |
| 10:03:37 | lyarwood | oh right because you reverted it so the diff is the wrong way around | |
| 10:03:39 | stephenfin | ahh | |
| 10:03:41 | stephenfin | okay :) | |
| 10:03:48 | stephenfin | phew | |
| 10:03:50 | lpetrut | https://review.opendev.org/c/openstack/nova/+/763550/12/lower-constraints.txt | |
| 10:04:00 | stephenfin | yeah, I have no issues with bumping l-c | |
| 10:04:18 | stephenfin | the only issue would be if we were to backport this, but it's a feature so that's not an issue | |
| 10:04:59 | lpetrut | awesome. lyarwood: are you ok with going back to patchset 12? | |
| 10:06:14 | lyarwood | lpetrut: I'd like it to be a seperate change if I'm honest but I also don't want to hold you up anymore | |
| 10:07:06 | lyarwood | lpetrut: would you mind if I just broke it out into another change myself and documented the reasons for the increases in a fresh commit? | |
| 10:07:28 | lpetrut | lyarwood: sure, thanks! | |
| 10:07:37 | lyarwood | lpetrut: ack np and sorry for dragging this out | |
| 10:08:34 | lpetrut | np, glad that we managed to reach a consensus :D | |
| 10:14:02 | kashyap | stephenfin: Thank you for picking up the secure boot work! Please add yourself as the co-author / author as you see fit. I don't see your name on one of the patches that you revised. (I haven't looked at all yet; still ploughing through my post-PTO backlog of suff.) | |
| 10:20:54 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Bump the Compute RPC API to version 6.0 https://review.opendev.org/c/openstack/nova/+/761452 | |
| 10:35:42 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | |
| 10:36:35 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | |
| 10:37:21 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380 | |
| 10:38:07 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | |
| 11:04:15 | openstackgerrit | James Page proposed openstack/nova stable/train: add functional regression test for bug #1888395 https://review.opendev.org/c/openstack/nova/+/759533 | |
| 11:04:33 | openstack | bug 1888395 in OpenStack Compute (nova) train "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to Billy Olsen (billy-olsen) | |
| 11:15:17 | lyarwood | gibi / stephenfin: stupid question time, we only document direct requirements in requirements.txt, lower-constraints.txt etc right? so in bumping os-brick we don't need to bump everything the new version depends on in our tree? | |
| 11:16:16 | stephenfin | we document direct requirements in the various requirments.txt files. We document everything in lower-constraints.txt | |
| 11:16:38 | stephenfin | I suggested switching to just direct dependencies for lower-constraints.txt also but... | |
| 11:16:49 | lyarwood | well it's working with just os-brick bumped | |
| 11:16:53 | lyarwood | LC that is | |
| 11:16:54 | stephenfin | <stephenfin> sean-k-mooney: fwiw, dropping indirect dependencies from l-c can cause dependency resolution to devolve into a multi-hour slog, since the combinatorial matrix of possible versions for those indirect dependencies is huuuuuuge | |
| 11:17:07 | lyarwood | yeah I see | |
| 11:18:13 | stephenfin | you sure you're testing with pip >= 20.3 ? | |
| 11:18:55 | lyarwood | 20.2.2 | |
| 11:19:06 | stephenfin | yeah, you need to install 20.3+ first | |
| 11:19:21 | stephenfin | that has the new dependency resolver | |
| 11:19:22 | lyarwood | wait that was in the venv | |
| 11:19:34 | lyarwood | 20.3.1 outside but that doesn't matter | |
| 11:20:00 | stephenfin | I think pip might be bundled with virtualenv | |
| 11:20:25 | lyarwood | yeah but I thought I had a new enough version on f33 | |
| 11:21:24 | lyarwood | bumps and tries again | |
| 11:25:14 | lyarwood | cool that's failing correctly now, let me work through these | |
| 11:39:04 | brinzhang0 | stephenfin: how about the novnc feature? https://review.opendev.org/c/openstack/nova/+/622336 | |
| 11:39:39 | stephenfin | brinzhang0: I'm thoroughly confused on that now and need to sit down and figure it out | |
| 11:39:43 | brinzhang0 | I saw gibi said we will FF at 11th, can we complete this in this cycle? | |
| 11:40:29 | stephenfin | I'm setting up a dev environment atm to play around with it | |
| 11:40:36 | stephenfin | It might make sense to reshuffle the series so that the tenant ID -> project ID gets 2.89 and I don't know how long it will take to figure this out | |
| 11:40:39 | brinzhang0 | Now we are sopport input password when we open the console, if we do this config | |
| 11:42:14 | brinzhang0 | I am very sorry, the tenant series patches may need much time to back 2.89, Ithink I want to do whatever | |
| 11:42:28 | brinzhang0 | s/want/wont | |
| 11:43:36 | gibi | lyarwood, lpetrut, stephenfin: on the os-brick bump. I'm happy to review an lc bump and I hope it is not as big as the original proposal was. If it needs to be that big then I'm a bit affraid what such amount of change introduces | |
| 11:44:12 | lyarwood | gibi: thankfully it's not, I'm also breaking the os-win bump out into another change | |
| 11:44:32 | gibi | lyarwood: thanks for working on that | |
| 11:45:22 | gibi | stephenfin: on the removal of the indirect deps from lc. Is there a way to print the huge matrix to see where are those deps that needs contraints to significantly reduce the size of the matrix? | |
| 11:46:27 | stephenfin | I'm not sure. I haven't looked into that | |
| 11:46:37 | gibi | stephenfin: ack, I can try to look into that at some point | |
| 11:46:58 | gibi | I assume there are a short list of offender indirect deps | |
| 11:47:03 | gibi | if it is not the case then meh | |
| 11:48:30 | lyarwood | actually I don't need to break os-win out sorry, I thought it also had changes | |
| 11:48:54 | gibi | brinzhang0, stephenfin: I read stephenfin's comment on the vnc series but honeslty I haven't fully grocked the situation. So I trust stephenfin to do the invenstigation as he already started it and has a better view on it than me | |
| 11:49:00 | gibi | lyarwood: ack, no worries | |
| 11:52:23 | brinzhang0 | gibi:There are two sides we need to consider. Now, we can authorican the console for client-->proxy, we need to input the password when we open its console., this is also clarified in the specs. | |
| 11:52:30 | brinzhang0 | gibi: But we dont consider the authorican with proxy-->server yet, this is stephenfin concerned. | |