Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-03-01
14:13:36 sean-k-mooney well that will bot with an exsiting volumn
14:13:41 sean-k-mooney it wont create a new one
14:13:58 sean-k-mooney but ya anyway sorry got to go.
14:14:25 legochen ERROR (BadRequest): Block Device Mapping is Invalid: Boot sequence for the instance and image/block device mapping combination is not valid. (HTTP 400) (Request-ID: req-c004edcf-0deb-4354-8358-c78cdf7f6c08)
14:14:36 legochen okay, I got this error when add “,bootindex=0"
14:14:47 legochen sure, you busy first.
14:17:25 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Deprecate disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/c/openstack/nova/+/778004
14:19:36 sean-k-mooney lyarwood: i thought ^ was alredy dperecated when we added them
14:20:04 sean-k-mooney ik guess you did not formally do it but that was the intent of your comment
14:20:14 sean-k-mooney to so we could actully remove them in W
14:21:18 lyarwood sean-k-mooney: yeah I didn't formally do it at the time, was about to do it now and noticed so thought I'd follow normal procedure and remove them early in Xena
14:21:46 sean-k-mooney ok i guess it does not matter too much
14:21:59 sean-k-mooney it proably makes upgrades slightly simpler for 17
14:22:00 lyarwood yeah, would be nice to remove them now for my sanity but that's about it
14:22:05 sean-k-mooney since they can disable this after upgrade instead
14:22:07 lyarwood right
14:22:20 lyarwood well they can disable it after they move to 16.2 downstream
14:22:28 lyarwood we've backported the perf fixes to 8.3
14:23:40 sean-k-mooney ah ya good point
14:24:55 sean-k-mooney lyarwood: also no worries about lunch, if we can move the os-vif backport forward that would be good as we need it before 16.2 is release but we have a few months to work on that
14:26:25 lyarwood kk
15:00:51 openstackgerrit Jessie Lass proposed openstack/nova master: Add emulation support if host arch != guest arch. https://review.opendev.org/c/openstack/nova/+/772156
15:09:18 kashyap Strange, before rebasing, I didn't see this exception when running unit tests; but after rebase, I see:
15:09:26 kashyap "Exception: This test uses methods that set internal oslo_db state, but it does not claim to use the database [...]"
15:10:32 kashyap [https://zuul.opendev.org/t/openstack/build/0347425ea0d74725a73f41ee4eaf6dd1]
15:17:55 sean-k-mooney likely not mocking something you should
15:18:57 lyarwood yeah it should be in the trace
15:19:23 lyarwood ah it's my stuff that's causing this for you
15:19:24 lyarwood _register_instance_machine_type
15:19:35 lyarwood just mock that out
15:19:43 lyarwood kashyap: ^
15:20:03 kashyap lyarwood: Oh, I see. That's the change the rebase brought
15:20:24 kashyap sean-k-mooney: It came only after the rebase; it was not there before.
15:20:25 sean-k-mooney lyarwood: that might want to be mocked in the setup funciton
15:22:35 lyarwood sean-k-mooney: I assume kashyap's tests are calling init_host directly
15:23:16 kashyap lyarwood: Indeed, I noticed that removing the call to init_host "fixes" it - drvr.init_host("dummyhost")
15:23:33 kashyap lyarwood: I don't even think it's required to call here. Because, I checked in the PDB --
15:23:51 kashyap My test asserts expected results w/o the init_host() call
15:24:21 kashyap So I'm actually going to remove it; it's not required in this case, near as I can tell
15:24:49 kashyap Thanks for looking, folks!
15:25:03 lyarwood kashyap: https://review.opendev.org/c/openstack/nova/+/774240/10/nova/tests/unit/virt/libvirt/test_driver.py@1478
15:25:17 lyarwood kashyap: looks like you removed the mock from test__check_cpu_compatibility_start_ok
15:25:44 kashyap lyarwood: Urgh; that was accidental damage during rebase. Sloppy me.
15:25:52 kashyap I thought I double-checked, and still I failed
15:28:39 kashyap That's it; it's the missing mock
15:34:50 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags` https://review.opendev.org/c/openstack/nova/+/774240
15:43:06 openstackgerrit Balazs Gibizer proposed openstack/nova stable/pike: rt: Make resource tracker always invoking get_inventory() https://review.opendev.org/c/openstack/nova/+/778014
15:45:06 openstackgerrit Balazs Gibizer proposed openstack/nova stable/pike: Update resources once in update_available_resource https://review.opendev.org/c/openstack/nova/+/612295
16:23:59 openstackgerrit Merged openstack/nova master: apidb: Compact Mitaka database migrations https://review.opendev.org/c/openstack/nova/+/759400
16:24:13 stephenfin sean-k-mooney: Can you live with the bit of duplication in this? https://review.opendev.org/c/openstack/nova/+/775415/ I'd like to keep that series moving forward /o\
16:33:12 openstackgerrit Balazs Gibizer proposed openstack/nova stable/pike: rt: Make resource tracker always invoking get_inventory() https://review.opendev.org/c/openstack/nova/+/778014
16:34:30 openstackgerrit Balazs Gibizer proposed openstack/nova stable/pike: Update resources once in update_available_resource https://review.opendev.org/c/openstack/nova/+/612295
16:37:59 sean-k-mooney stephenfin: ill take a look after the meeting
16:53:30 dansmith bauzas: the compute 6.0 patch is failing almost everything because of versioning stuff. You have a TODO to fix that in the commit message, but are you looking for help via review or are we still waiting for you to work those issues out first?
16:59:11 bauzas dansmith: I'm just fixing a lot of them ;)
16:59:29 bauzas I saw a lot of stuff I forgot to modify
16:59:45 bauzas hopefully, will upload this in 1 hour
16:59:52 dansmith bauzas: ah cool
17:02:10 bauzas dansmith: thanks for having looked at it btw. ;)
17:02:34 dansmith bauzas: np, I said I would help, so definitely hold me to it.. just didn't want to duplicate effort
17:03:35 bauzas dansmith: thanks
17:23:15 openstackgerrit Balazs Gibizer proposed openstack/nova stable/ussuri: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/773932
17:23:50 gibi melwitt: fixed the functional test in the backport ^^
17:26:45 sean-k-mooney stephenfin: oh it was the os.name poison change
17:26:51 stephenfin yarp
17:27:06 sean-k-mooney stephenfin: since other dont think its worth effort to remove the duplication fair ennough i guess.
17:27:29 sean-k-mooney i would still like it to be done but i can live with it so ill change to +1 after i quickly re review
17:27:52 sean-k-mooney i dont think you have changed anything since i last looked have you
17:28:01 stephenfin nope, same as previously
17:29:28 sean-k-mooney ya just rebases ok +1'd
17:29:36 stephenfin ta
17:30:21 sean-k-mooney stephenfin: bauzas suggested thinking about putting it in the integreated_helpers module as a followup
17:30:29 sean-k-mooney not sure if you saw that
17:31:11 sean-k-mooney i also think there is a tone of stuff in the chain after it and its not worth the gate time to respin now
17:31:37 stephenfin I did. Given this thing is only used in unit tests, I don't think we want to be dragging in stuff from the functional test module
17:31:39 stephenfin I can reply now
17:32:05 sean-k-mooney fair we import things form unti in fucntional
17:32:22 sean-k-mooney so better to avoid possible curcular deps between the too
17:32:54 stephenfin yeah, if I had my way we wouldn't even import from unit inside functional tests
17:33:01 stephenfin fixtures should be a separate submodule
17:33:05 stephenfin but that's a lot of work
17:44:33 lyarwood stephenfin: so I'm stuck on https://review.opendev.org/c/openstack/nova/+/673790/14/nova/virt/libvirt/host.py#1235
17:45:26 lyarwood stephenfin: what's the reasoning behind flagging support based *any* machine type indicating support and not the default or requested machine type?
17:45:43 lyarwood stephenfin: I guess they all support UEFI and secure boot for x86_64
17:46:00 lyarwood stephenfin: but couldn't that cause issues on other arches if it isn't the case
17:50:24 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: Bump the Compute RPC API to version 6.0 https://review.opendev.org/c/openstack/nova/+/761452
17:50:45 bauzas dansmith: hopefully this latest rev should fix all the func/unit tests $
17:50:48 bauzas ^
17:51:08 bauzas now, I need to see what tempest and grenade tell me
18:11:12 dansmith bauzas: ack cool, will circle back later to see how zuul has judged you :P
18:11:35 sean-k-mooney fyi ptg dates are April 19-23, 2021
18:12:35 sean-k-mooney gibi: i assume you will create a poll for times and such at some point but the foundation just annouched that and registrations aree now open
18:15:34 bauzas a bit sad to have again a virtual DFG instead of a face-to-face :(
18:16:29 sean-k-mooney well in that time frame realsiticlaly vactiontion wont be to the point that people could attend
18:16:34 sean-k-mooney maybe in november
18:16:50 sean-k-mooney or whenever the next one would be.
18:26:19 sean-k-mooney stephenfin: by the way yes it would be nice if the fixtures were in a sperate module not under the unit or functional test but also yes that is a lot of work
18:30:16 atmark Hello, I have 2x NVMes that has same vendor and product id and I want to setup PCI passthrough. How can I separate the two NVMes in the alias? I currently have the following config
18:30:22 atmark passthrough_whitelist = {"vendor_id":"1344", "product_id":"51b2"}
18:30:27 atmark alias = {"vendor_id":"1344", "product_id":"51b2", "device_type":"type-PCI", "name":"nvme"}

Earlier   Later