Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-02-23
17:16:38 sean-k-mooney maybe now but again on python 2.7 it was not
17:16:51 sean-k-mooney anyway we shoudl proably revie https://review.opendev.org/c/openstack/nova/+/714676
17:17:17 sean-k-mooney but delete the current test i guess works for now
17:17:34 atmark is there filter can tag a set of computes to a tenant?
17:17:56 stephenfin prometheanfire: Yeah, I was all for dropping it in e.g. oslo projects, but we obviously have way more tests than anything there and when you start looking at the amount of bugs we need to workaround on older stdlib versions it seems less attractive
17:18:07 sean-k-mooney atmark: yes
17:18:38 stephenfin We'll do it _eventually_, but it's dropped down my priority list rn (and melwitt's too, evidently)
17:18:40 prometheanfire stephenfin: yep
17:18:42 sean-k-mooney there is both a post fitler and prefilter https://github.com/openstack/nova/commit/732e202e81142a8ea462a9ebcde9a7226a62a60b
17:19:37 atmark will take a look
17:19:39 atmark thanks
17:19:49 prometheanfire now I have to check on fasteners (which I think needs a mask of 0.16 at least) and virtualenv (which is a whole... thing)
17:20:32 sean-k-mooney atmark: the old way is to use https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#aggregatemultitenancyisolation but you should use https://docs.openstack.org/nova/latest/admin/aggregates.html#tenant-isolation-with-placement if you can
17:20:50 sean-k-mooney atmark: i think the latter was added around rocky
17:21:07 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove ;test_tcp_rst_no_compute_rpcapi' https://review.opendev.org/c/openstack/nova/+/777168
17:21:12 stephenfin prometheanfire: ^
17:21:33 prometheanfire thanks
17:21:51 stephenfin gibi, melwitt, lyarwood, bauzas: That ^ is taken out of https://review.opendev.org/c/openstack/nova/+/714676 and should unblock mock 4.x in requirements. Could you take a look?
17:23:12 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove 'test_tcp_rst_no_compute_rpcapi' https://review.opendev.org/c/openstack/nova/+/777168
17:23:42 stephenfin aha, melwitt already has a better solution https://review.opendev.org/c/openstack/nova/+/741351/
17:25:08 stephenfin prometheanfire: https://review.opendev.org/c/openstack/nova/+/741351 is approved, so that should be fixed once it goes through the gate
17:25:25 melwitt stephenfin: I was gonna say, I spent time to rewrite that test proper 🥺 thanks for finding it, I should have pinged you to look but I kept forgetting
17:25:33 prometheanfire awesome, thanks :D
17:26:08 prometheanfire was nova the one having problems with fasteners-0.16?
17:27:46 stephenfin That doesn't ring a bell
17:27:52 prometheanfire k
17:27:57 stephenfin do we use fasteners?
17:28:03 stephenfin I've no idea what that is, tbh
17:30:40 sean-k-mooney stephenfin: we do indrectly
17:30:44 sean-k-mooney its used in oslo
17:31:09 stephenfin Oh I guessed that but I meant directly
17:31:29 sean-k-mooney stephenfin: as far as i aware its only use for the fair lock in oslo.concurancy
17:31:38 sean-k-mooney that is where we use it in nova
17:31:50 prometheanfire must have been a ml thread that mentioned
17:31:52 sean-k-mooney all our locks are eventually provided by fasteners
17:32:11 bnemec Yes, there was an issue with the latest fasteners release and nova: https://github.com/harlowja/fasteners/issues/36
17:32:15 sean-k-mooney prometheanfire: i mentioned we could use it to backport a patch in nova for an ironic issue
17:32:33 sean-k-mooney e.g. port the lock to nova directly since we could not depned on oslo
17:33:07 prometheanfire bnemec: should we mask 0.16 (and maybe 0.15)
17:33:22 prometheanfire less deps are nice
17:34:05 bnemec I believe it has been capped since the bug was found.
17:34:46 bnemec Note that fasteners is the thing that does our file locking too. The fair lock stuff was added later.
17:34:50 prometheanfire no, I've been holding 0.15 and 0.16 back for too long :P
17:35:27 prometheanfire looks like 0.15 was masked but 0.16 has not been https://github.com/openstack/requirements/blob/master/global-requirements.txt#L308
17:39:27 melwitt I wonder if dansmith might have some thoughts about the cell func test locking + eventlet issue https://github.com/harlowja/fasteners/issues/36#issuecomment-760402680
17:40:24 dansmith sounds like something I would have thoughts on but I am like super deep in my current queue right now
17:41:01 sean-k-mooney in the func tests we serials the scater gather right
17:41:03 melwitt ok :( but understandable
17:41:16 openstackgerrit Chris Dent proposed openstack/placement master: Update traits in tests and requirements https://review.opendev.org/c/openstack/placement/+/777174
17:41:22 sean-k-mooney i belve we have a fixture that alteres its executiton
17:41:58 sean-k-mooney https://github.com/openstack/nova/blob/d10c9de25d7e4885a0ed2e5e31747e44f68359ba/nova/tests/unit/test_fixtures.py#L313-L321
17:42:36 sean-k-mooney so all the functest should be running in 1 thread of executin serially
17:42:41 melwitt are we using that in all tests though? I hadn't thought so. oh
17:43:34 sean-k-mooney maybe not
17:43:36 sean-k-mooney https://github.com/openstack/nova/blob/d10c9de25d7e4885a0ed2e5e31747e44f68359ba/nova/tests/unit/compute/test_compute.py#L1455
17:43:41 sean-k-mooney its used in teh compute unit tests
17:43:57 sean-k-mooney i tought we had a similar one in place for functional
17:44:32 melwitt I found this old patch from March 2020 having to do with monkey patching current_thread https://review.opendev.org/c/openstack/nova/+/707474, it's not clear to me when the problem was last reproduced
17:44:43 melwitt that is, I wonder if it's possible that could have fixed things
17:45:44 sean-k-mooney i think that is the same eventlet issue that is linked form teh fasteners one
17:46:15 sean-k-mooney ya it is https://github.com/harlowja/fasteners/issues/36#issuecomment-760402680
17:47:33 sean-k-mooney oh that was done as part of https://bugs.launchpad.net/nova/+bug/1863021
17:47:37 openstack Launchpad bug 1863021 in OpenStack Object Storage (swift) "[SRU] eventlet monkey patch results in assert len(_active) == 1 AssertionError" [Undecided,In progress] - Assigned to Chris MacNaughton (chris.macnaughton)
17:48:03 sean-k-mooney which wwas really just wack a mole trying to work around an eventlet bug in every openstack project
17:52:09 sean-k-mooney melwitt: so ya maybe that use to fix it and now its broken again or fastners also need to hack around the eventlet issue
17:52:37 melwitt sean-k-mooney: yeah lemme see if I can run the tests successfully locally with the new version
19:35:00 openstackgerrit Merged openstack/nova stable/train: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772986
19:38:36 openstackgerrit Merged openstack/nova master: Handle instance = None in _local_delete_cleanup https://review.opendev.org/c/openstack/nova/+/775308
19:39:41 openstackgerrit Merged openstack/nova master: Add net & utils methods for routed nets & segments https://review.opendev.org/c/openstack/nova/+/773976
19:40:58 openstackgerrit Merged openstack/nova master: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068
20:10:02 openstackgerrit melanie witt proposed openstack/nova stable/victoria: Add regression test for bug 1914777 https://review.opendev.org/c/openstack/nova/+/777121
20:10:03 openstack bug 1914777 in OpenStack Compute (nova) "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] https://launchpad.net/bugs/1914777 - Assigned to melanie witt (melwitt)
20:13:03 openstackgerrit melanie witt proposed openstack/nova stable/victoria: Handle instance = None in _local_delete_cleanup https://review.opendev.org/c/openstack/nova/+/777209
20:26:43 openstackgerrit melanie witt proposed openstack/nova stable/ussuri: Add regression test for bug 1893284 https://review.opendev.org/c/openstack/nova/+/777216
20:26:44 openstack bug 1893284 in OpenStack Compute (nova) ussuri "Per-user quotas not scoped correctly when creating a server" [Low,New] https://launchpad.net/bugs/1893284
20:26:45 openstackgerrit melanie witt proposed openstack/nova stable/ussuri: Default user_id when not specified in check_num_instances_quota https://review.opendev.org/c/openstack/nova/+/777217
20:26:45 openstackgerrit melanie witt proposed openstack/nova stable/ussuri: Add regression test for bug 1914777 https://review.opendev.org/c/openstack/nova/+/777218
20:26:48 openstackgerrit melanie witt proposed openstack/nova stable/ussuri: Handle instance = None in _local_delete_cleanup https://review.opendev.org/c/openstack/nova/+/777219
20:26:48 openstack bug 1914777 in OpenStack Compute (nova) victoria "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] https://launchpad.net/bugs/1914777 - Assigned to melanie witt (melwitt)
22:04:23 openstackgerrit Merged openstack/nova master: FUP: Catch and reraise routed nets exception https://review.opendev.org/c/openstack/nova/+/776694
22:41:38 openstackgerrit Merged openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi https://review.opendev.org/c/openstack/nova/+/741351
22:44:36 openstackgerrit melanie witt proposed openstack/nova stable/ussuri: Raise InstanceMappingNotFound if StaleDataError is encountered https://review.opendev.org/c/openstack/nova/+/777253
22:45:57 openstackgerrit melanie witt proposed openstack/nova stable/train: Raise InstanceMappingNotFound if StaleDataError is encountered https://review.opendev.org/c/openstack/nova/+/777254
#openstack-nova - 2021-02-24
00:40:13 openstackgerrit Brin Zhang proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336
00:44:08 brinzhang gibi, stephenfin: as current implementation of noVNC that we can support open console with password, but not used x509+vnc, we would like to optimize it later, can we let this feature go?
00:46:49 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292
00:47:19 openstackgerrit Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311
00:48:05 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380
00:48:36 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726
00:49:26 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704
00:50:19 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509
00:50:56 openstackgerrit Brin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315
00:51:41 openstackgerrit Brin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852
00:52:06 openstackgerrit Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851
00:52:27 openstackgerrit Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862
00:52:56 openstackgerrit Brin Zhang proposed openstack/nova master: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329
04:18:44 prometheanfire sean-k-mooney: let me know if https://review.opendev.org/777295 is needed when / if you get a chance (for reference https://review.opendev.org/777170 is the test for 0.16)
08:39:59 jkulik found the answer to my question regarding sync_aggregates: ironic host are not supported with aggregates.
08:40:26 jkulik how does AZ assignment work there, if they don't support aggregates?
08:49:24 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152

Earlier   Later