Posted	Nick	Remark
#openstack-nova - 2021-02-22
16:47:35	sean-k-mooney	its seams incorrect to sync the os-brick deps into nova
16:48:57	sean-k-mooney	im going to just bump the two libs os-brick and os-win and run the lc tox env locally
16:49:33	gibi	sean-k-mooney: I expect that you will recreate the error https://review.opendev.org/c/openstack/nova/+/763550/12#message-2f6b7331b58c77ee91a0a69d0ee187ded003d623
16:50:30	gibi	from that it seems that the minimum oslo.context needed by nova is different from the minimum oslo.context needed by os-brick. and the pep solver detects this
16:51:05	sean-k-mooney	ya this is because of the new resolver
16:51:31	sean-k-mooney	the old resolver used the first requirement for a dep
16:51:41	sean-k-mooney	the new one looks at all of them
16:51:44	bauzas	sean-k-mooney: if you feel brave enough, I'd prefer to have os-brick being bumped in a separate change
16:51:56	bauzas	again, we need to think of reverts
16:52:05	bauzas	and pulling a whole set of changes doesn't help this
16:52:33	sean-k-mooney	well currently its one patch but so wew would be pulling the bump and the feature
16:52:46	sean-k-mooney	that need the bump if we revert
16:54:39	gibi	I give up for today. See you all tomorrow o/
16:54:47	bauzas	gibi: thanks
18:48:16	sean-k-mooney	bauzas: gibi https://review.opendev.org/c/openstack/nova/+/763550/12//COMMIT_MSG#22
18:48:38	sean-k-mooney	bauzas: gibi we need to bump coverage but all oter lower contrats dont need to be bumped
18:48:59	sean-k-mooney	so just coverage, os-brick and os-win
20:47:51	openstackgerrit	Merged openstack/nova stable/ussuri: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772985
#openstack-nova - 2021-02-23
07:03:48	openstackgerrit	Lucian Petrut proposed openstack/nova master: hyper-v rbd volume support https://review.opendev.org/c/openstack/nova/+/763550
07:48:21	openstackgerrit	Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362
07:48:22	openstackgerrit	Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363
07:48:24	openstackgerrit	Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944
09:02:19	openstackgerrit	Brin Zhang proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336
09:02:23	openstackgerrit	Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292
09:02:25	openstackgerrit	Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311
09:02:27	openstackgerrit	Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380
09:02:31	openstackgerrit	Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726
09:09:37	openstackgerrit	Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704
09:12:58	openstackgerrit	Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509
09:13:56	openstackgerrit	Brin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315
09:51:40	slaweq	gibi: hi, did You saw errors like https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4f9/777015/1/check/neutron-tempest-multinode-full-py3/4f9f062/testr_results.html already?
09:51:51	slaweq	I saw it at least twice in last few days
09:51:53	slaweq	in same test
09:52:04	slaweq	do You want me to report new bug for that?
10:25:27	openstackgerrit	Lucas Alvares Gomes proposed openstack/nova master: [OVN] Explicitly set nova-next job to ML2/OVS https://review.opendev.org/c/openstack/nova/+/776944
10:25:30	openstackgerrit	Lucas Alvares Gomes proposed openstack/nova master: DO NOT REVIEW: Test OVN devstack module https://review.opendev.org/c/openstack/nova/+/776945
10:32:46	gibi	slaweq: hi, let me check it
10:36:25	gibi	slaweq: I see 6 failures in the last 7 days
10:36:30	gibi	http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22tempest.api.compute.servers.test_delete_server.DeleteServersTestJSON.test_delete_server_while_in_building_state%5C%22%20AND%20message%3A%5C%22FAILED%5C%22
10:37:44	slaweq	gibi: do You want me to open LP for that?
10:38:03	gibi	slaweq: I will check the logs first then I can open an LP. thanks for notifying us
10:38:14	slaweq	gibi: thank You
10:38:15	gibi	it happens outside of neutron jobs too
10:47:00	gibi	slaweq: reported https://bugs.launchpad.net/nova/+bug/1916588
10:47:03	openstack	Launchpad bug 1916588 in OpenStack Compute (nova) "Delete instance in build state result in HTTP 500: nova.exception.ConstraintNotMet: Constraint not met." [Undecided,New]
10:47:28	slaweq	gibi++ thx
11:26:22	gibi	slaweq: it turned out it is a duplicate of https://bugs.launchpad.net/nova/+bug/1914777
11:26:24	openstack	Launchpad bug 1914777 in OpenStack Compute (nova) "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] - Assigned to melanie witt (melwitt)
11:30:40	gibi	slaweq: I've just approved the fix for it https://review.opendev.org/c/openstack/nova/+/775308
11:34:46	slaweq	gibi++ thx a lot
11:43:42	openstackgerrit	Brin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852
11:43:43	openstackgerrit	Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851
11:43:44	openstackgerrit	Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862
11:43:45	openstackgerrit	Brin Zhang proposed openstack/nova master: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329
12:59:17	openstackgerrit	Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084
14:04:53	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Follow up for QoS interface attach https://review.opendev.org/c/openstack/nova/+/777112
14:05:08	gibi	bauzas, stephenfin: a small fup for QoS based on your comments ^^
14:08:21	bauzas	gibi: ack
14:08:33	bauzas	today is a review day for me
14:15:28	bauzas	gibi: question
14:15:43	bauzas	gibi: when you mention the audit command in the exception, do we raise it to the user ?
14:16:36	bauzas	gibi: /me looks at whether we have a sync call for attaching
14:16:45	gibi	attach is synch
14:16:57	bauzas	ok, so the user will get HTTP500, right?
14:17:07	bauzas	with the exception
14:17:07	gibi	I assume so
14:17:20	gibi	let me check it in a devstack
14:17:36	bauzas	gibi: in this case, we shouldn't be explain to use the audit command
14:17:44	bauzas	explaining*
14:17:54	bauzas	as the user wouldn't know how to do it
14:18:01	bauzas	hence my LOG concern
14:18:10	bauzas	to not pass it to the user
14:18:16	bauzas	but if we don't, fair enough
14:20:11	openstackgerrit	Lucian Petrut proposed openstack/nova master: hyper-v rbd volume support https://review.opendev.org/c/openstack/nova/+/763550
14:24:57	gibi	bauzas: only the name of the exception is returned on the REST API
14:24:58	gibi	http://paste.openstack.org/show/802931/
14:25:11	bauzas	oh shit you're right
14:25:23	bauzas	just the first reason
14:25:42	bauzas	hmmm, even not
14:26:36	bauzas	changed my vote
14:27:05	gibi	thanks
14:27:48	gibi	stephenfin: do you know a way to tell mypy that a = {} is really an empty dict that will never have keys?
14:28:18	sean-k-mooney	the presnece of keys is not an atirbute of the type
14:28:40	sean-k-mooney	so that statement does not make sese form a type checking perspectiv
14:28:56	bauzas	a parameter being {} by default ?
14:29:04	bauzas	I hope we don't do it
14:29:19	bauzas	or maybe I misunderstood
14:29:20	gibi	bauzas: nope, a singalling of a failure here https://github.com/openstack/nova/blob/8ca5d2169fc3ba5cf86f830a93cf92bae925e1f4/nova/network/neutron.py#L650
14:29:25	gibi	sean-k-mooney: good point
14:29:45	gibi	sean-k-mooney: but if we only have
14:29:47	gibi	a = {}
14:29:52	gibi	if a:
14:30:03	gibi	then this code does not have a key type defined either
14:30:14	sean-k-mooney	thats fine
14:30:21	sean-k-mooney	you dont need to define a key type
14:30:25	sean-k-mooney	you can just use dict
14:30:27	gibi	I can assign a: ty.Dict = {}
14:30:42	sean-k-mooney	you can but ty.Dict is an alis for dict
14:30:50	gibi	true
14:30:51	gibi	thank

Earlier   Later