| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-18 | |||
| 10:03:14 | gibi | bauzas, stephenfin: the general direction is OK to me in https://review.opendev.org/c/openstack/nova/+/706295 (neutron client bump) I just had some question inline | |
| 10:03:50 | gibi | swp20: I will try | |
| 10:04:25 | gibi | stephenfin: ack, I will check the libvirt metadata too | |
| 10:04:59 | stephenfin | gibi: cool, I'll take a look at the noVNC patch too | |
| 10:05:22 | lyarwood | stephenfin: yup sorry didn't want to jump the gun on that | |
| 10:15:39 | openstackgerrit | Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084 | |
| 10:21:27 | gibi | stephenfin, lyarwood: I'm +2 on the libvirt ip metadata (including ipVersion). lyarwood do you want to get back to that patch or should I send it through? | |
| 10:22:24 | lyarwood | gibi: I just wanted to ensure Sean was okay with it tbh | |
| 10:22:47 | lyarwood | gibi: they left a comment on the spec about talking it over in the review | |
| 10:23:19 | gibi | lyarwood: OK let's wait for sean-k-mooney's vote on the review then | |
| 10:23:39 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/763550 - FWIW the HyperV RBD change looks ready now | |
| 10:23:45 | gibi | lyarwood: on it | |
| 10:26:02 | lpetrut | thanks for the reviews | |
| 10:27:56 | gibi | lpetrut: is there any other patch needed in nova for the rbd support? or can I close the bp once https://review.opendev.org/c/openstack/nova/+/763550 merges? | |
| 10:28:16 | lpetrut | nope, that's it | |
| 10:28:26 | gibi | lyarwood: thanks for the review on the noVNC patch | |
| 10:28:47 | gibi | lpetrut: ack, I will close the bp accordingly | |
| 10:45:34 | bauzas | oh, man, why _get_provider_aggregates() is so cryptic ? | |
| 10:46:00 | bauzas | it can return either None, a tuple with empty list, or an exception | |
| 10:46:42 | bauzas | stephenfin: thanks for having letting me rework on negative tests, I need to check all of the above | |
| 10:46:46 | gibi | because nobody cared in the past to have a proper return type. but now with mypy... :D | |
| 10:47:37 | bauzas | gibi: technically, it's a private method, so that's my call | |
| 10:47:52 | gibi | also we don't have a clear guideline (or pattern) when to return None for error case and when to raise for it | |
| 10:48:10 | gibi | s/None/falsy value/ | |
| 10:59:08 | openstackgerrit | Lucas Alvares Gomes proposed openstack/nova master: [OVN] Adapt the live-migration job scripts to work with OVN https://review.opendev.org/c/openstack/nova/+/776419 | |
| 11:16:07 | stephenfin | lyarwood: gibi: I have some pretty serious concerns about the VNC patch. Why would one ever recommend an 8 ASCII character, trivially brute forceable password over TLS encryption? | |
| 11:17:26 | stephenfin | Lots of comments left. I don't know if it's possible yet (starting to investigate), but this feels like something the proxy layer should be providing for us (i.e. HTTPS and a password to get to the proxy, and then TLS from the proxy to the guest) | |
| 11:19:39 | lyarwood | stephenfin: hmm how do we lose the ability to encrypt traffic between the proxy and guest? | |
| 11:19:46 | stephenfin | per my reading of things, yes | |
| 11:20:26 | stephenfin | the presence of an entirely separate auth scheme suggests as much https://review.opendev.org/c/openstack/nova/+/622336/30/nova/console/rfb/auths.py#30 | |
| 11:20:39 | stephenfin | as does the QEMU doc on available security methods https://qemu.readthedocs.io/en/latest/system/vnc-security.html | |
| 11:24:38 | lyarwood | stephenfin: ah crap sorry I didn't look at RFBAuthSchemeVeNCrypt | |
| 11:32:38 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: only wait for plugtime events in pre-live-migration https://review.opendev.org/c/openstack/nova/+/770745 | |
| 11:33:59 | stephenfin | Man, my security know how is not what it should be, but it sounds like there's a TLSNone subtype we can use with VeNCrypt https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#7243subtypes-with-vnc-suffix | |
| 11:34:44 | stephenfin | Sorry, X509Vnc | |
| 11:38:20 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add net & utils methods for routed nets & segments https://review.opendev.org/c/openstack/nova/+/773976 | |
| 11:38:21 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | |
| 11:38:52 | bauzas | gibi: stephenfin: sean-k-mooney: last round hopefully ^ | |
| 11:39:20 | bauzas | tl;dr: I now hard-stop when we can't find aggregates for subnets | |
| 11:39:25 | bauzas | s/subnets/segments | |
| 11:59:31 | gibi | bauzas: acj | |
| 11:59:33 | gibi | ack even | |
| 12:06:23 | gibi | good idea ^^ | |
| 12:21:55 | openstackgerrit | Merged openstack/nova stable/victoria: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766023 | |
| 13:04:59 | openstackgerrit | Belmiro Moreira proposed openstack/nova master: Fixes the elapsed time logged during a live migration https://review.opendev.org/c/openstack/nova/+/776428 | |
| 13:08:41 | gibi | stephenfin: this bp is set to Need Code Review state but I haven't found the impl code https://blueprints.launchpad.net/nova/+spec/configurable-instance-hostnames did I miss something? | |
| 13:10:14 | sean-k-mooney | bauzas: that is only if its a routed network yes | |
| 13:10:34 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816 | |
| 13:10:35 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: extra specs/image props: add `socket` PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748 | |
| 13:10:36 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749 | |
| 13:10:36 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Track host NUMA topology in PCI manager https://review.opendev.org/c/openstack/nova/+/774149 | |
| 13:10:37 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: pci: implement the `socket` NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779 | |
| 13:31:57 | bauzas | stephenfin: gibi: sean-k-mooney: guys, hopefully, we could see us not virtually ;) | |
| 13:32:16 | bauzas | :( | |
| 13:33:16 | gibi | yeah | |
| 13:33:31 | sean-k-mooney | eventually | |
| 13:35:49 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags` https://review.opendev.org/c/openstack/nova/+/774240 | |
| 13:37:02 | kashyap | gibi: sean-k-mooney: artom: --^ IMHO, really don't like two separate config options (which was suggested in there); it is needlessly verbose and adds noise work | |
| 13:37:23 | kashyap | I refactored it into a helper method; rewrote docs | |
| 13:37:36 | kashyap | And added a test, of course; and fixed other bits. /me hopes he didn't miss anything else. | |
| 13:39:30 | sean-k-mooney | kashyap: as i said this is one of the points of contention that has come up every time we discussed it. i know you have always favoured the +/- approch but i know others have requested two config options in the past | |
| 13:39:51 | kashyap | Well, it is overblown "contention". No one else disagreed with it | |
| 13:40:09 | kashyap | sean-k-mooney: Right; I really dislike bike-shedding on this, really | |
| 13:40:20 | kashyap | I just feel it is bloated to add needlessly extra options | |
| 13:40:31 | kashyap | sean-k-mooney: I know you were in the "+/- camp" as you put it | |
| 13:40:31 | sean-k-mooney | kashyap: im pretty sure other cores have asked you in the passed to have the two config options | |
| 13:40:35 | kashyap | No | |
| 13:40:42 | sean-k-mooney | i think i rememebr who they were too | |
| 13:40:49 | kashyap | sean-k-mooney: The patch is only posted now. There was no patch before | |
| 13:40:50 | sean-k-mooney | i just dont want to name drop in case im wrong | |
| 13:40:56 | kashyap | You're imagining the conversation. Really. | |
| 13:41:04 | sean-k-mooney | kashyap: we have discussed this in person at a desing summit before | |
| 13:41:47 | kashyap | Oh, well. I was not there; or don't remember the details. | |
| 13:42:35 | kashyap | It is simply overkill; and is not just worth it. What is there is clear, and intuitive. That suffices. | |
| 14:03:45 | bauzas | stephenfin: working on the new rev | |
| 14:06:02 | bauzas | stephenfin: could we discuss on https://review.opendev.org/c/openstack/nova/+/773976/7/nova/exception.py ? | |
| 14:10:33 | stephenfin | bauzas: sure, what's up? | |
| 14:10:45 | stephenfin | did you see my comment on the next patch also? | |
| 14:12:15 | bauzas | stephenfin: just uploaded my comments | |
| 14:13:35 | sean-k-mooney | ah here https://review.opendev.org/c/openstack/nova/+/773976/7/nova/scheduler/utils.py#1370 | |
| 14:13:39 | sean-k-mooney | ys its used in both | |
| 14:14:53 | sean-k-mooney | thats called form the request filter in the next change right | |
| 14:15:23 | sean-k-mooney | ya here https://review.opendev.org/c/openstack/nova/+/749068/17/nova/scheduler/request_filter.py#341 | |
| 14:15:30 | bauzas | sean-k-mooney: yup | |
| 14:15:41 | bauzas | honestly, we should just supporting this exception | |
| 14:15:47 | bauzas | for all of the issues | |
| 14:15:58 | bauzas | we could have other exceptions, like for looking at the port | |
| 14:16:19 | bauzas | but for getting a NoValidHost, just the above should be needed | |
| 14:17:53 | bauzas | anyway, stephenfin provided me a good concern for https://review.opendev.org/c/openstack/nova/+/749068/17/nova/tests/fixtures.py so I'll provide a new revision, but in case we want to dicuss about exceptions here, maybe let's agree on providing a new FUP then | |
| 14:18:32 | stephenfin | bauzas: hmm, so we do | |
| 14:18:59 | stephenfin | I hate to say it but could we use two exceptions? /o\ | |
| 14:19:22 | stephenfin | I know it's sort of bikeshedding, but I'm uncomfortable with using non-generic exceptions across multiple "services"# | |
| 14:20:02 | stephenfin | with the obvious caveat that if everyone else disagrees with me or thinks it's not an option, I can go along with the majority | |
| 14:22:11 | bauzas | well, I can see your concerns | |
| 14:22:26 | bauzas | let me try to first upload the new series and discuss about it later for a FUP | |
| 14:22:47 | stephenfin | sounds good to me | |
| 14:42:12 | bauzas | stephenfin: huh, /me is a sad panda again due to mypy https://review.opendev.org/c/openstack/nova/+/773976/7/nova/network/neutron.py#3533 | |
| 14:42:26 | bauzas | because of static type checking, we need to change code | |
| 14:42:51 | bauzas | it's like when we want to tell about objects and we need to avoid circular imports | |
| 14:43:06 | bauzas | sounds to me that mypy is strictier than it should and prevents us good faith | |