| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-17 | |||
| 14:18:48 | sean-k-mooney | lyarwood: if you are taking to them then it would be ice to fix https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1856387 | |
| 14:18:50 | openstack | Launchpad bug 1856387 in linux (Ubuntu Bionic) "Freezing on boot since kernel 4.15.0-72-generic release" [High,Fix released] - Assigned to You-Sheng Yang (vicamo) | |
| 14:19:07 | sean-k-mooney | the current currenle they use is missing the backport | |
| 14:19:21 | sean-k-mooney | *current kernel | |
| 14:20:35 | sean-k-mooney | i tried to fix this in devstack https://review.opendev.org/c/openstack/devstack/+/766079 and nova https://review.opendev.org/q/topic:%22workaround-disable-apic%22+(status:open%20OR%20status:merged) | |
| 14:20:43 | sean-k-mooney | but was told it would be fixed in cirros | |
| 14:20:57 | sean-k-mooney | so it woudl be good to confirm that is fixed. | |
| 14:21:11 | sean-k-mooney | if they are rebuilding the image | |
| 14:23:26 | lyarwood | kk | |
| 14:30:44 | frickler | lyarwood: sean-k-mooney: best discuss in #cirros with smoser directly | |
| 14:33:03 | sean-k-mooney | frickler: ack, wasnt sure who was maintianing it | |
| 14:48:38 | stephenfin | bauzas: Reviewed the routed networks series again | |
| 15:22:14 | openstackgerrit | Merged openstack/nova master: Run nova-live-migration job with neutron-trunk enabled https://review.opendev.org/c/openstack/nova/+/775838 | |
| 15:44:25 | openstackgerrit | Merged openstack/nova master: use psycopg2 binary instead of source package https://review.opendev.org/c/openstack/nova/+/770473 | |
| 15:45:14 | openstackgerrit | Merged openstack/nova stable/ussuri: Add upgrade check about old computes https://review.opendev.org/c/openstack/nova/+/770765 | |
| 15:45:37 | openstackgerrit | Merged openstack/nova stable/ussuri: add functional regression test for bug #1888395 https://review.opendev.org/c/openstack/nova/+/759522 | |
| 15:45:39 | openstack | bug 1888395 in OpenStack Compute (nova) ussuri "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to Billy Olsen (billy-olsen) | |
| 15:45:52 | openstackgerrit | Merged openstack/nova stable/ussuri: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/c/openstack/nova/+/759151 | |
| 15:46:20 | openstackgerrit | Merged openstack/nova master: tox: Add passenv DISABLE_CHERRY_PICK_CHECK to pep8 https://review.opendev.org/c/openstack/nova/+/776111 | |
| 15:50:38 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766023 | |
| 15:51:59 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766024 | |
| 15:52:52 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766025 | |
| 16:31:04 | openstackgerrit | Merged openstack/nova stable/victoria: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772984 | |
| 16:59:17 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: Define and emit DeviceRemovedEvent and DeviceRemovalFailedEvent https://review.opendev.org/c/openstack/nova/+/749929 | |
| 17:22:36 | openstackgerrit | Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084 | |
| 17:33:30 | bauzas | gibi: thanks for the review | |
| 17:34:55 | bauzas | stephenfin: ack, will try to provide a new revision again | |
| 17:46:28 | bauzas | stephenfin: wdym by "trailing full stop" https://review.opendev.org/c/openstack/nova/+/773976/6/nova/network/neutron.py@3500 ? | |
| 17:46:47 | stephenfin | just add a full stop at the end of the sentence :) | |
| 17:46:54 | stephenfin | you had it elsewhere | |
| 17:47:17 | bauzas | a dot ? | |
| 17:47:19 | bauzas | OK, can do | |
| 17:47:23 | stephenfin | oh, a period | |
| 17:47:27 | stephenfin | British English | |
| 17:47:31 | stephenfin | yeah | |
| 17:47:33 | bauzas | oh maaaaaan | |
| 17:47:52 | bauzas | artom: how quebecian folks name the end of a phrase ? "un point", right? | |
| 17:49:07 | sean-k-mooney | or a "full stop" | |
| 17:49:39 | sean-k-mooney | oh that what you said first | |
| 17:50:00 | sean-k-mooney | bauzas: why is frech frech so differnt for canadian french | |
| 17:50:45 | sean-k-mooney | also stephenfin and i technically speak https://en.wikipedia.org/wiki/Hiberno-English more of the time | |
| 17:50:54 | bauzas | sean-k-mooney: we name it the same AFAIK :p it's "un point" | |
| 17:51:25 | sean-k-mooney | well a decimal point and period/full stop are two different things | |
| 17:52:09 | bauzas | sean-k-mooney: b/c you folks are enough crazy to use a dot for decimal numbers | |
| 17:52:17 | bauzas | sean-k-mooney: we rather use commas | |
| 17:52:20 | sean-k-mooney | we call it a point if its its mid way in a charter and a fullstop or period if its on the base of the charter | |
| 17:52:34 | sean-k-mooney | bauzas: well we call it a decimal point | |
| 17:52:50 | bauzas | like, I'd be happy to pay you 10,000€ in my language | |
| 17:53:17 | bauzas | it's more or less the amount of a pint of beer in Paris | |
| 17:53:18 | sean-k-mooney | would that not be 10 euro in your defintion | |
| 17:53:34 | bauzas | indeed ;) | |
| 17:53:55 | bauzas | 10.000,00€ in my language is ten thousand euros and zero cts | |
| 17:54:00 | sean-k-mooney | also we put the € first so €10,000 is ten thousand euros | |
| 17:54:20 | bauzas | we use dots for thousands | |
| 17:54:32 | bauzas | and commas for decimals | |
| 17:54:50 | sean-k-mooney | yep we use , for thosand seperate and . for decimal point | |
| 17:54:51 | bauzas | you can't imagine how Excels is f**** lots of Frenchs :p | |
| 17:55:04 | sean-k-mooney | although . is techncally not a desimal point but i cant type it in this font | |
| 17:56:08 | sean-k-mooney | most indian languages also dont group by 3 digts | |
| 17:57:50 | sean-k-mooney | · is a descimal point . is a full stop | |
| 17:58:39 | sean-k-mooney | no one make that distinction unless they are writing by hand however and even then many done bother anymore | |
| 17:58:44 | bauzas | I even don't know how to set a decimal point on my french keyboard | |
| 17:59:02 | bauzas | I only have full stops | |
| 17:59:02 | sean-k-mooney | you normally cant even on a iso or ansi one | |
| 17:59:07 | bauzas | \o/ | |
| 17:59:21 | bauzas | even your own keyboards don't respect your language, lovely | |
| 17:59:25 | sean-k-mooney | tecnically the on the number pad should be · | |
| 17:59:28 | sean-k-mooney | not . | |
| 17:59:38 | bauzas | anyway | |
| 18:00:05 | sean-k-mooney | its like the fact taht the - on the number pad is different to the one on the number line | |
| 18:00:11 | sean-k-mooney | but many things treat them the same | |
| 18:00:27 | bauzas | gibi: stephenfin: thanks to you, I have to dig into PEP484 to find how to say as type hint result : "it's a bool or None" | |
| 18:00:29 | sean-k-mooney | which is why word always breadk linux command by changing it | |
| 18:00:48 | stephenfin | bauzas: ty.Optional[bool] | |
| 18:00:50 | bauzas | gibi: stephenfin: the whole reason why I hate mypy, it overcomplicates things | |
| 18:00:56 | bauzas | stephenfin: just saw it | |
| 18:01:11 | sean-k-mooney | bauzas: we can agreee to disagree on that :) | |
| 18:01:33 | stephenfin | yeah :) | |
| 18:01:40 | bauzas | https://www.python.org/dev/peps/pep-0484/ is my new bed book | |
| 18:02:57 | openstackgerrit | Jessie Lass proposed openstack/nova master: Add emulation support if host arch != guest arch. https://review.opendev.org/c/openstack/nova/+/772156 | |
| 18:04:34 | bauzas | stephenfin: question, don't you feel we duplicate information between docstrings and type hints ? | |
| 18:04:50 | bauzas | of course, we will miss static type checking with docstrings | |
| 18:05:11 | bauzas | but from a reviewer perspective, this is the exact same metadata | |
| 18:05:26 | sean-k-mooney | bauzas: yes but i would prefer to delete the doc sting if i had to choose | |
| 18:05:51 | stephenfin | gibi already said as much in a review. mypy is for types information, docstring are for context | |
| 18:06:06 | sean-k-mooney | i never really like having the parmaters in the doc stings. they always just felt like a hack due to a lack of typing | |
| 18:06:08 | bauzas | sean-k-mooney: if the API docs are autogenerated based on type hints, I could imagine it | |
| 18:06:21 | stephenfin | that could be done quite easily with Sphinx | |
| 18:06:27 | bauzas | I know | |
| 18:06:28 | stephenfin | except we don't publish API docs so it's a moot point | |
| 18:06:31 | bauzas | is it done already ? | |
| 18:06:40 | stephenfin | it might well be. I haven't looked | |
| 18:06:45 | bauzas | stephenfin: well, we don't publish them, but you can introspect them | |
| 18:06:46 | sean-k-mooney | stephenfin: well we have the api ref | |
| 18:06:56 | bauzas | yuuuuuuuuuup | |
| 18:06:56 | sean-k-mooney | https://docs.openstack.org/api-ref/compute/ | |
| 18:07:05 | sean-k-mooney | is that not the api docs | |
| 18:07:09 | bauzas | and some methods are documented | |
| 18:07:30 | stephenfin | sean-k-mooney: nah, I meant the Python API | |
| 18:07:42 | sean-k-mooney | i use those daylie more then any other docs bar maybe https://docs.openstack.org/nova/latest/configuration/config.html | |