| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-11 | |||
| 00:19:00 | sean-k-mooney | although no | |
| 00:19:10 | sean-k-mooney | if we loaded it from the db teh default would be different | |
| 00:19:12 | sean-k-mooney | https://github.com/openstack/nova/blob/5b52db409b00e6257e83598efa0d8528ebe380e0/nova/objects/instance_pci_requests.py#L99-L100 | |
| 00:20:09 | sean-k-mooney | thats just weird but ya not nows problem | |
| 02:08:11 | openstackgerrit | Merged openstack/placement master: Implement secure RBAC for reshaper https://review.opendev.org/c/openstack/placement/+/774827 | |
| 02:08:20 | openstackgerrit | Merged openstack/placement master: policy: Add releasenote for RBAC work https://review.opendev.org/c/openstack/placement/+/774654 | |
| 09:12:34 | bauzas | and type hints :p | |
| 09:12:40 | bauzas | stephenfin: :p | |
| 09:13:26 | stephenfin | I don't get the dislike, tbh. They're really just structured comments that are (usually) checked for correctness | |
| 09:13:33 | stephenfin | who doesn't want self-checking comments :) | |
| 09:13:39 | stephenfin | *self-validating? | |
| 09:13:59 | stephenfin | I can stick in a follow-up patch to add them though, seeing as I have them worked out already :D | |
| 09:16:26 | kashyap | stephenfin: FWIW, yeah, I definitely see the value of function annotations | |
| 09:20:13 | kashyap | Although, IIRC, they annotations aren't enforced at runtime | |
| 09:20:31 | stephenfin | not without specific configuration, no | |
| 09:21:49 | stephenfin | https://github.com/beartype/beartype | |
| 09:21:53 | stephenfin | and libraries like it | |
| 09:22:24 | stephenfin | Pretty sure Dropbox or Instagram or someone has a library for doing that too | |
| 09:23:43 | kashyap | I see | |
| 09:23:59 | kashyap | stephenfin: Do you know of any big projects enforcing it? | |
| 09:24:36 | stephenfin | At runtime? Not sure. Most of Instagram and Dropbox's codebases and type hinted now though, afaik | |
| 09:24:40 | stephenfin | Sphinx uses it everywhere | |
| 09:25:03 | kashyap | (Yeah, at runtime.) I see | |
| 09:28:37 | bauzas | stephenfin: well, static typing is nice, but we have reviews and docstrings | |
| 09:28:53 | bauzas | code reviews* | |
| 09:29:41 | bauzas | it's just adding more complexity for the sake of nothing, since we have documentation for parameters | |
| 09:30:19 | stephenfin | We don't though, and where we do, I've found it's been wrong more than a few times | |
| 09:30:28 | stephenfin | I've already caught a few bugs with what little type hinting I've done | |
| 09:31:10 | bauzas | ~o~ | |
| 09:31:22 | bauzas | anyway, I'll add them ;) | |
| 09:32:57 | openstackgerrit | Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084 | |
| 09:55:26 | gibi | I accept mypy, but I also have some reservation about the ROI of it. Adding proper typing for nested dict passed around is mentally hard and we use a lot of such dicts in our code. | |
| 09:56:52 | gibi | sometimes it feels like we need to retrofit into nova a whole static type hierarchy just to be able to express typing things properly | |
| 09:57:17 | gibi | and than I feel bad about using a dynamic language for that | |
| 10:08:59 | kashyap | gibi: Hey, when you get a moment | |
| 10:09:11 | gibi | kashyap: hit me | |
| 10:09:18 | kashyap | gibi: On the test coverage here: https://review.opendev.org/c/openstack/nova/+/774240/5/nova/tests/unit/virt/libvirt/test_driver.py#1524 | |
| 10:09:30 | kashyap | gibi: I'm right now setting up an env to test it properly (in a real env) | |
| 10:10:24 | kashyap | gibi: That said, we don't want to invest too much time right now to do many unit tests there -- as we want to replace (in a different patch series) that part of _check_cpu_compatibility() | |
| 10:10:33 | kashyap | ... to use better and improved libvirt CPU APIs | |
| 10:11:14 | gibi | hm, I remember that patch, where we are with that being merged? | |
| 10:11:15 | kashyap | gibi: It is this one: https://review.opendev.org/c/openstack/nova/+/762330/ | |
| 10:11:19 | kashyap | gibi: Good question | |
| 10:11:33 | kashyap | gibi: That patch needs to be split out into 3 or 4 patches, as I noted in the review | |
| 10:11:47 | kashyap | I might do it if chengsheng doesn't respond there. | |
| 10:12:04 | kashyap | _But_: that needs to be done _on top of_ the disable CPU flags patch | |
| 10:12:43 | kashyap | Because, that helps solve a more important problem for operatorswith lesser code, without having to fix the whole world | |
| 10:12:44 | gibi | so you say that now it is hard and therefore costly to add unit test for _check_cpu_compatibility but after https://review.opendev.org/c/openstack/nova/+/762330/ there will be proper coverage | |
| 10:12:48 | gibi | ? | |
| 10:13:08 | kashyap | gibi: Indeed, that's what I mean. You make a good point there, no questions | |
| 10:13:43 | kashyap | gibi: I mean, we keep the unit tests that I included in there, for the minimal coverage there is | |
| 10:14:39 | kashyap | gibi: Also, please take a 4 minutes to read this context I wrote for today's meeting at the bottom: https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 10:15:20 | gibi | kashyap: OK, let's expedite https://review.opendev.org/c/openstack/nova/+/762330/ after your fix lands | |
| 10:15:22 | kashyap | That should give you context on _why_ I'm doing what I'm doing. And why I'm trying to keep it short and small - to be backportable | |
| 10:16:46 | kashyap | gibi: Yep; thank you. | |
| 10:16:54 | gibi | I need to recover your topic on the agenda, it seems stephenfin overwrote it :) | |
| 10:17:14 | kashyap | Oh no, what have you done, stephenfin :D | |
| 10:17:19 | stephenfin | whoops | |
| 10:17:47 | kashyap | No problem :) I can re-add it -- assuming gibi is already not doing it | |
| 10:17:55 | gibi | I will fix it | |
| 10:18:11 | kashyap | I spent half hour writing clear sentences to reduce cognitive load, and stephenfin, you erased it :D | |
| 10:18:28 | gibi | this is partially my fault as I did not clean up the agenda after the last meeting | |
| 10:18:49 | kashyap | No problem; Wiki maint is a chore | |
| 10:21:20 | gibi | kashyap: fixed it, read it. It looks OK to me. If no objection on the meeting then I will approve the bp | |
| 10:22:01 | kashyap | gibi: Understood; we can talk there. | |
| 10:22:06 | gibi | coo | |
| 10:22:07 | gibi | l | |
| 10:22:48 | kashyap | Thanks! /me goes to fix his env. meanwhile to test the damn patch for real | |
| 10:33:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: trace migration tests to see what steps take too long https://review.opendev.org/c/openstack/nova/+/775094 | |
| 10:48:47 | kashyap | Isn't this strange? I have these services enabled for my DevStack run: | |
| 10:48:48 | kashyap | ENABLED_SERVICES=g-api,g-reg,key,n-api,n-cpu,n-sch,n-cond,mysql,rabbit,dstat,quantum,q-svc,q-agt,q-dhcp,q-l3,q-meta | |
| 10:49:12 | kashyap | During stack.sh, I see this fly by: "+./stack.sh:echo_summary:416 echo -e Configuring Horizon" | |
| 10:59:27 | kashyap | gibi (or anyone): Have you ever seen this? After 18 minutes of stack.sh, it fails o me like this: -- http://paste.openstack.org/show/802558/ | |
| 11:05:29 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Record the machine_type of instances in system_metadata https://review.opendev.org/c/openstack/nova/+/767533 | |
| 11:05:30 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type get command https://review.opendev.org/c/openstack/nova/+/769548 | |
| 11:05:30 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type update command https://review.opendev.org/c/openstack/nova/+/774896 | |
| 11:05:31 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP nova-manage: Add machine_type list_unset command https://review.opendev.org/c/openstack/nova/+/774897 | |
| 11:05:31 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-status: Add hw_machine_type check for libvirt instances https://review.opendev.org/c/openstack/nova/+/770643 | |
| 11:05:32 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add a config update workflow test for [libvirt]hw_machine_type https://review.opendev.org/c/openstack/nova/+/774898 | |
| 11:05:32 | openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add admin docs for configuring and updating machine types https://review.opendev.org/c/openstack/nova/+/774899 | |
| 11:07:13 | lyarwood | kashyap: Didn't find service registered by hostname after 60 seconds | |
| 11:07:30 | kashyap | lyarwood: Yeah; figured out - actually it's a CPU model prob | |
| 11:07:40 | kashyap | I gave a model that is marked as "no" by libvirt | |
| 11:07:56 | kashyap | Thanks for looking :) sean-k-mooney gave the hint, while we're on a call | |
| 11:07:56 | lyarwood | kashyap: so n-cpu didn't start? | |
| 11:08:03 | lyarwood | k | |
| 11:08:33 | kashyap | lyarwood: Saw the exception in journalctl -u devstack@n-cpu | |
| 11:11:20 | gibi | sorry I was away | |
| 11:11:24 | gibi | but I see you solved it | |
| 11:12:06 | kashyap | Yes; no problem. I never count on instant responses :) | |
| 11:56:36 | gibi | sean-k-mooney: hi! here is a bug report https://bugs.launchpad.net/nova/+bug/1915255 based on the git log https://review.opendev.org/c/openstack/nova/+/739131 seems suspicious causing it. Could you please take a look? | |
| 11:56:37 | openstack | Launchpad bug 1915255 in OpenStack Compute (nova) "[Victoria] nova-compute won't start on aarch64 - raises PciDeviceNotFoundById" [Undecided,New] | |
| 11:57:43 | sean-k-mooney | am yes i can take a look | |
| 12:00:00 | sean-k-mooney | so the function that is failing is not one i added but one im started calling | |
| 12:00:28 | sean-k-mooney | that exception i think shoudl alreay be caught but maybe not in the current code path | |
| 12:00:57 | sean-k-mooney | its failing to look up the parent netdev name for badnwith based schduling | |
| 12:02:01 | sean-k-mooney | we could rewrite that function to call libvirt instead of sysfs possibly | |
| 12:14:36 | gibi | hm, then I will take a look too | |
| 12:15:16 | gibi | lyarwood: hi! Could this be another manifestation of the detach retry bug I'm trying to fix? https://bugs.launchpad.net/nova/+bug/1914664 | |
| 12:15:17 | openstack | Launchpad bug 1914664 in OpenStack Compute (nova) "QEMU monitor read failure in ServerStableDeviceRescueTest" [Undecided,New] | |