| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-09 | |||
| 10:13:46 | sean-k-mooney | we only check that on the compute node | |
| 10:14:14 | sean-k-mooney | i could jut stick that in the extra info json blob and then we could check it in the filter | |
| 10:16:10 | sean-k-mooney | or we coudl track them in plamcnet next cycle but i kind of want to fix this for everyone not running master | |
| 10:17:39 | stephenfin | I'd say push the patch and let's see in the review what everyone else thinks | |
| 10:18:25 | sean-k-mooney | ya ok. not today though i was checking the db for my neutron port numa poicy seriese | |
| 10:18:56 | sean-k-mooney | just noticed this wehn i was looking at the pci devices table | |
| 10:24:30 | sean-k-mooney | the pci request has {"count": 1, "spec": [{"physical_network":"public"}] we have nothing to match that against in the pci device table so really that is all that is missing | |
| 10:28:31 | gibi | bauzas: ack, I will check | |
| 10:46:38 | sean-k-mooney | you know when you see something odd in nova and then you investiate and all you find its a world full of sad pandas | |
| 10:47:09 | sean-k-mooney | that is what the test coverage for this piece of the pci tracker is like | |
| 10:47:11 | sean-k-mooney | https://github.com/openstack/nova/blob/4827a90a02ef91e777b1fcaa946c20c54dd0a29a/nova/tests/unit/pci/test_stats.py#L164-L168 | |
| 10:48:30 | lyarwood | Sad Pandas, all the way down. | |
| 10:49:27 | stephenfin | gibi: It is not at all a priority, but while it's fresh in your mind I've addressed all but one of your comments on https://review.opendev.org/c/openstack/nova/+/676209 and am researching the final one now | |
| 10:49:47 | sean-k-mooney | lyarwood: indeed | |
| 11:12:15 | gibi | stephenfin: ack, will check this afternoon | |
| 11:15:36 | bauzas | for us, we say "I'm a sad clown" | |
| 11:29:57 | sean-k-mooney | bauzas: because pandas are cute so when they are sad its really bad. also its a meme | |
| 11:38:00 | sean-k-mooney | bauzas: sad panda https://i.kym-cdn.com/photos/images/newsfeed/000/092/706/Sad_Panda_Chibi_by_mongrelssister.png | |
| 11:39:30 | sean-k-mooney | happy panda https://i.pinimg.com/originals/99/2a/35/992a358dcff70ca9bfcb4b227c08333c.png | |
| 11:39:47 | sean-k-mooney | now back to unit test land... | |
| 11:42:18 | lyarwood | bauzas: also helpful reminder, sean-k-mooney isn't English, stephenfin is but that's another story. ./me runs | |
| 11:42:33 | sean-k-mooney | haha | |
| 11:44:30 | gibi | lol | |
| 11:45:45 | gibi | I feel there is an intersting story behind this | |
| 11:49:24 | sean-k-mooney | gibi: stephenfin lived in essex for a bit when he was young before moving back to live in clare | |
| 11:49:35 | lyarwood | and loves being called English | |
| 11:49:45 | lyarwood | /s | |
| 11:49:55 | gibi | :D | |
| 11:49:57 | sean-k-mooney | gibi: but calling an irish person english is like calling lyarwood welsh | |
| 11:50:31 | lyarwood | well tbh it's likely worse given recent history | |
| 11:50:47 | lyarwood | anyway | |
| 11:59:32 | gibi | bauzas: I'm +2 on the route net series | |
| 12:08:54 | sean-k-mooney | stephenfin: ok so the tags are not store in the pci_devices table but they are in the PciDevicePoolList in teh compute nodes table that is used to populate the host_state object | |
| 12:09:08 | sean-k-mooney | stephenfin: so its not a performcne issue | |
| 12:09:32 | sean-k-mooney | i was just expecting it to be in both | |
| 12:12:52 | kashyap | lyarwood: Reading back ... I parsed bauzas' "english speaking" as "anglosphere" | |
| 12:14:11 | lyarwood | thank you captain obvious ;) | |
| 12:15:21 | sean-k-mooney | kashyap: so did we :) but there was an opertunity for a joke to be made | |
| 12:16:23 | lyarwood | and as a new dad I need the practice | |
| 12:17:50 | kashyap | sean-k-mooney: Hehe, figured as much; don't want to rob you of a good tease | |
| 12:18:05 | sean-k-mooney | i dont know you were fairly on point. maybe it was too good and you need to recalibrate to dad joke levels | |
| 12:19:02 | kashyap | Heh | |
| 12:21:02 | kashyap | sean-k-mooney: Do you ever sleep, BTW? ... I almost see your scrollback at all hours. Unless my IRC client is tricking me | |
| 12:25:27 | sean-k-mooney | i didnt sleep much last night. went to sleep aroudn 2-3 work at about half 5 got up at 8 and started working around 8:30. | |
| 12:25:36 | sean-k-mooney | so ill be finishing early today | |
| 12:41:09 | gibi | kashyap: I left feedback in https://review.opendev.org/c/openstack/nova/+/774240/ | |
| 12:45:37 | kashyap | sean-k-mooney: Ouch; get some good rest | |
| 12:45:43 | kashyap | gibi: Will look after lunch; thank you | |
| 13:16:22 | kashyap | gibi: In your review, which test job you quote that unit test failure from? | |
| 13:16:25 | gibi | bauzas: could you hit https://review.opendev.org/c/openstack/nova/+/756530 at some point? that is the last real change in the qos changes in Wallaby | |
| 13:16:34 | gibi | kashyap: tox -e py38 | |
| 13:16:50 | gibi | kashyap: to get the debug log you need to define OS_DEBUG=1 in your env and make the test fail | |
| 13:20:09 | kashyap | gibi: Ah, thanks! | |
| 13:24:16 | sean-k-mooney | or just do "tox -e py3" | |
| 13:24:21 | sean-k-mooney | then you dont need to care | |
| 13:24:48 | sean-k-mooney | it will use your systems default python | |
| 13:25:24 | sean-k-mooney | kashyap: just be aware that OS_DEBUG at least for functional test will be very very verbose when it fails | |
| 13:25:46 | kashyap | sean-k-mooney: Noted :) Just unit tests | |
| 13:29:10 | kashyap | sean-k-mooney: Have you got a latest minimal DevStack (without Cinder)? | |
| 13:29:22 | kashyap | sean-k-mooney: I have this ... can this be cutdown any further? - https://paste.centos.org/view/c9c4ecdf | |
| 13:32:23 | bauzas | gibi: I was thinking about it, LOL. | |
| 13:32:30 | bauzas | it's my next todo | |
| 13:32:47 | gibi | bauzas: thanks | |
| 13:34:11 | sean-k-mooney | kashyap: its not a minimal config but this is the bases i work off https://paste.centos.org/view/c57cf6a4 | |
| 13:35:30 | sean-k-mooney | kashyap: you should not need FORCE=yes or the neutron settings your adding | |
| 13:35:44 | sean-k-mooney | unless its conflicting with your home/work network | |
| 13:37:17 | sean-k-mooney | kashyap: you also done need the data dirs stuff but you are using a non default location so not minimal but i guess its what you need | |
| 13:37:23 | bauzas | gibi: no spec for the attach/detach case, right? https://review.opendev.org/c/openstack/nova/+/756530/21//COMMIT_MSG | |
| 13:37:43 | bauzas | I was thinking about the workflow, do we have other resources for attach/detach ? | |
| 13:38:01 | gibi | bauzas: there is spec for the qos series | |
| 13:38:05 | kashyap | sean-k-mooney: Reading ... | |
| 13:38:30 | bauzas | I know | |
| 13:38:31 | bauzas | https://review.opendev.org/c/openstack/nova-specs/+/755477 | |
| 13:38:48 | kashyap | sean-k-mooney: The data dirs stuff -- that is intentional; as I want it to be in a non-default location | |
| 13:38:49 | bauzas | okay okay, will lookup | |
| 13:38:51 | kashyap | sean-k-mooney: Thanks! | |
| 13:38:55 | gibi | bauzas: then I don't get your question | |
| 13:39:11 | bauzas | gibi: I didn't remember whether we discussed about the workflow | |
| 13:39:14 | bauzas | but yeah we did | |
| 13:39:16 | gibi | bauzas: there is only neutron resource request and the PCI request it handled for interface attach | |
| 14:43:25 | stephenfin | lyarwood: You've done the next patch in the series but any chance you could hit this? https://review.opendev.org/c/openstack/nova/+/741663/ | |
| 14:52:31 | lyarwood | ops my bad, sure | |
| 14:53:02 | openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Deprecate 'admin_api' rule https://review.opendev.org/c/openstack/placement/+/772334 | |
| 14:53:03 | openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Add note about keystone's expansion of roles https://review.opendev.org/c/openstack/placement/+/772752 | |
| 14:53:04 | openstackgerrit | Stephen Finucane proposed openstack/placement master: Move policy deprecation to base rules https://review.opendev.org/c/openstack/placement/+/772784 | |
| 14:53:05 | openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Add releasenote for RBAC work https://review.opendev.org/c/openstack/placement/+/774654 | |
| 14:53:35 | stephenfin | gmann: ^ | |
| 14:53:44 | bauzas | gibi: had an open question with some nits too https://review.opendev.org/c/openstack/nova/+/756530 | |
| 14:53:54 | stephenfin | release note fresh out of the oven | |
| 14:53:59 | bauzas | tl;dr: should we delete the QoS allocations on interface detach ? | |
| 14:54:13 | gmann | stephenfin: ack. mostly rebase right | |
| 14:54:22 | stephenfin | yeah, I just reapplied +W | |
| 14:54:31 | stephenfin | the releasenote is the only real change | |
| 14:56:06 | gmann | ok | |
| 15:05:29 | gmann | stephenfin: lgtm 1 comment on adding link to keystone doc https://review.opendev.org/c/openstack/placement/+/774654 | |
| 15:07:13 | lyarwood | does anyone know if there's an easy way to list instances by cell via an existing cli? | |
| 15:07:41 | lyarwood | context being a nova-status check I've added lists cell uuids and not instance uuids which isn't that useful | |
| 15:08:10 | lyarwood | before I go and write something to list instances by cell uuid or instances that fail my check I wanted to ensure something didn't already exist | |
| 15:08:22 | lyarwood | I can't see anything obvious in osc | |
| 15:08:30 | openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Add releasenote for RBAC work https://review.opendev.org/c/openstack/placement/+/774654 | |