| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-08 | |||
| 13:29:47 | kashyap | gibi: Thanks; will look | |
| 13:38:28 | bauzas | gibi: shit about the 2 NICs... | |
| 13:38:34 | bauzas | :( | |
| 13:39:01 | bauzas | gibi: unfortunately, we need to express ONE Requestspec for both | |
| 13:39:26 | bauzas | context : https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py | |
| 13:40:41 | bauzas | but we need to express aggregates requirement something like "(agg1 or agg2) AND agg3" in the same spec | |
| 13:41:51 | bauzas | so, like you said, by calling require_aggs() multiple ways | |
| 13:46:27 | gibi | bauzas: I think we have ONE request spec but we have a list of network requests | |
| 13:47:24 | gibi | and the input in the network request list | |
| 13:47:56 | gibi | and the output is in the Destination | |
| 13:48:13 | gibi | maybe we just need to move the require_aggregate into the for loop | |
| 13:48:24 | gibi | instead of having it after the for loop | |
| 13:58:55 | sean-k-mooney | stephenfin: by the way just notice the cell db still has plamcnet related tables in it | |
| 13:59:03 | sean-k-mooney | we dont support that any more right | |
| 13:59:19 | sean-k-mooney | is that something we should clean up in or after your current db series ? | |
| 14:00:00 | sean-k-mooney | im thinking a nova manage command to drop them from the cell db and remove them form the compacted schema ? | |
| 14:03:33 | bauzas | gibi: indeed, I'll add a func test and verifying it | |
| 14:03:57 | gibi | coolio | |
| 14:06:55 | bauzas | https://www.youtube.com/watch?v=fPO76Jlnz6c | |
| 14:07:58 | kashyap | gibi: Heya, so here: https://review.opendev.org/c/openstack/nova/+/774240/3/nova/virt/libvirt/driver.py#4608 | |
| 14:08:26 | kashyap | gibi: I'm testing both the enabling and disabling part in the test. Would you like me to test something further? | |
| 14:09:17 | gibi | I think the codeblock starging at L698 is not covered while the code blocks starting at L4599 is covered | |
| 14:10:14 | kashyap | gibi: Oh, the one in this method _check_cpu_compatibility() | |
| 14:10:19 | kashyap | gibi: Okay, will figure something out ... | |
| 14:10:32 | kashyap | gibi: I'll respond to the rest on the change; thanks | |
| 14:10:33 | gibi | yes | |
| 14:10:35 | gibi | thanks | |
| 14:11:17 | kashyap | gibi: Good catch | |
| 14:23:13 | stephenfin | sean-k-mooney: Yeah, I have a patch somewhere to clean those up | |
| 14:23:27 | stephenfin | But I think it can/should wait til alembic is in place | |
| 14:34:58 | bauzas | gibi: 2 secs for a quick question ? | |
| 14:35:05 | gibi | bauzas: sure | |
| 14:35:13 | bauzas | gibi: in your example https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py#329 | |
| 14:35:22 | bauzas | gibi: you mention 'agg1 or agg2 AND agg3' | |
| 14:35:33 | bauzas | (the and is priority over the or) | |
| 14:35:46 | bauzas | so, we would get NoValidHosts for your example, right? | |
| 14:36:20 | gibi | if there is no host that is in both agg2 and agg3 or agg1 and agg3 then yes it is a no valid host | |
| 14:36:29 | gibi | but a host can be in multiple aggregated | |
| 14:36:32 | gibi | -d | |
| 14:36:44 | bauzas | ok, b/c my functest only has one host per agg | |
| 14:37:00 | bauzas | but I can try to do something | |
| 14:37:20 | bauzas | like, adding host5 that's in both aggregates | |
| 14:37:24 | bauzas | lemme try about it | |
| 14:38:56 | gibi | ok | |
| 14:54:58 | sean-k-mooney | stephenfin: sorry was on a call that sounds fine by me | |
| 14:55:28 | sean-k-mooney | stephenfin: i was just inspecting some data in the db for one of my changes and found it odd that those tabels were still there | |
| 15:00:29 | bauzas | I'm absolutely puzzled | |
| 15:00:42 | bauzas | looks like our HostNameWeigherFixture doesn't work | |
| 15:01:25 | gibi | bauzas: that is only handles host1,2,3 in the baseline | |
| 15:01:41 | bauzas | gibi: http://paste.openstack.org/show/802441/ | |
| 15:01:51 | bauzas | gibi: aaaaaaah | |
| 15:02:10 | bauzas | so we need to fix this :p | |
| 15:02:20 | gibi | you can pass in weights to the fixture | |
| 15:02:26 | bauzas | i was thinking the weigher was smarter :) | |
| 15:02:37 | bauzas | will lookup | |
| 15:02:48 | bauzas | tbh, I haven't looked at the fixture yet | |
| 15:02:53 | bauzas | RTFM | |
| 15:03:00 | gibi | it is a good enough fixture :) | |
| 15:03:05 | bauzas | or rather, RTFM | |
| 15:03:12 | bauzas | (read the f*** module) | |
| 15:03:59 | bauzas | ok, I see the init call | |
| 15:04:09 | bauzas | we can pass the weights | |
| 15:04:14 | bauzas | all good, thanks for the quick resolution | |
| 15:04:39 | gibi | happy to help | |
| 15:10:46 | gmann | sean-k-mooney: openstack-tempest-skiplist is under/from tripleO project. not new i think | |
| 15:11:14 | gmann | stephenfin: yeah, most of functional tests also run with permission to all (""). we might need more work there too | |
| 15:11:38 | gmann | gibi: ah, I missed that. will work on this today | |
| 15:11:46 | gibi | gmann: thanks | |
| 15:14:20 | sean-k-mooney | gmann: yep its not. i was just worreid if this was being used sytemwide for all tempest jobs | |
| 15:15:01 | sean-k-mooney | gmann:that would be bad since its disiableing things based on wether its supported or not by ooo but since its only used by ooo its fine | |
| 15:15:18 | gmann | sean-k-mooney: no, I think that may be used in tripleO jobs only | |
| 15:15:20 | sean-k-mooney | i just would have expected to see ooo/tripleo in the repo name | |
| 15:16:00 | gmann | yeah that is confusing even last month release team also had same confusion and nobody know if it is Tempest repo or something else | |
| 15:16:37 | gmann | and skip list could be maintained in file itself, I do not think separate repo is needed | |
| 15:17:37 | sean-k-mooney | gmann: ya i think they were not thinking baout zuul job inheritance wehn they created it but if it works for them i guess its ok | |
| 15:18:02 | sean-k-mooney | i just wanted to make sure a patch to that would not skip something in a nova job which it wont so all good | |
| 15:56:54 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Record the machine_type of instances in system_metadata https://review.opendev.org/c/openstack/nova/+/767533 | |
| 15:57:00 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add commands for managing instance machine type https://review.opendev.org/c/openstack/nova/+/769548 | |
| 15:57:04 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP nova-status: Add hw_machine_type check for libvirt instances https://review.opendev.org/c/openstack/nova/+/770643 | |
| 16:33:20 | dansmith | stephenfin: ack on the networks thing, I've seen that one too | |
| 16:38:29 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add net and utils methods for getting routed netks and segments https://review.opendev.org/c/openstack/nova/+/773976 | |
| 16:38:29 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | |
| 16:38:48 | bauzas | gibi: updated, thanks for your comments ^ | |
| 16:39:00 | bauzas | added both functest and UT for verifying it | |
| 16:41:40 | gibi | bauzas: on it | |
| 16:52:10 | lyarwood | melwitt: https://review.opendev.org/c/openstack/nova/+/766976 - before I forget, would you mind hitting this today? You reviewed the bugfix on top of it but missed the regression test on Friday. | |
| 17:04:36 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: Define and emit DeviceRemovedEvent and DeviceRemovalFailedEvent https://review.opendev.org/c/openstack/nova/+/749929 | |
| 17:04:50 | gibi | stephenfin: fixed your comment in ^^ | |
| 17:06:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: add AsyncDeviceDetachEventsHandler https://review.opendev.org/c/openstack/nova/+/772381 | |
| 17:06:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: allow querying devices from the persistent domain https://review.opendev.org/c/openstack/nova/+/772383 | |
| 17:09:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: parse alias out from device config https://review.opendev.org/c/openstack/nova/+/772384 | |
| 17:10:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246 | |
| 17:16:38 | gibi | bauzas: I'm +2 on the routed net series, good job! | |
| 17:16:47 | bauzas | thanks | |
| 17:17:01 | gibi | sean-k-mooney: I would appreciate your view on the question in https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py#312 | |
| 17:17:25 | bauzas | gibi: then hopefully I'll switch soon on the compute RPC API version bump now that dansmith is back :) | |
| 17:17:27 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags` https://review.opendev.org/c/openstack/nova/+/774240 | |
| 17:17:36 | gibi | bauzas: awesome :0\ | |
| 17:17:38 | gibi | :) | |
| 17:17:52 | bauzas | I was mostly done with it, but faced problems | |