Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-02-03
18:05:04 lyarwood my reading of https://github.com/openstack/nova/blob/fefd984fd1294f23677e3df4390e37c7664883a0/nova/utils.py#L752-L778 and what I've seen when stashing hw_machine_type in there is that it ends up being reflected in the image metadata properties
18:05:10 sean-k-mooney but lyarwood seams to have found all of it might be in a specific case?
18:05:29 melwitt oh
18:05:46 sean-k-mooney so SM_IMAGE_PROP_PREFIX
18:05:56 sean-k-mooney was ment to be filtering to just the image ones right
18:06:20 lyarwood you would assume so
18:07:12 sean-k-mooney so key = key[len(SM_IMAGE_PROP_PREFIX):]
18:07:17 sean-k-mooney is striping the key
18:07:21 sean-k-mooney i think that is the issue
18:08:21 sean-k-mooney because you have img_hw_machine_type that matches hw_machine_type which you added
18:08:21 lyarwood so in my case I've not even set it in the image metadata
18:08:21 lyarwood I'm only updating it in system_metadata while n-cpu starts
18:08:21 lyarwood and spawns
18:08:22 lyarwood and it's still showing up as an image prop
18:08:36 lyarwood let me write a func test to show this
18:10:01 sean-k-mooney can you include your new key with a prfix too
18:10:13 sean-k-mooney e.g. abi_hw_machine_type
18:10:27 sean-k-mooney i think adding an abi prefix or simialr would stopp it being included
18:10:57 lyarwood it wouldn't, that's just trimming off SM_IMAGE_PROP_PREFIX from any matching keys
18:11:20 lyarwood L771-774 will still include it
18:12:11 sean-k-mooney oh i see
18:12:27 sean-k-mooney we shoudl be looping over the known filed in the image metadata object
18:12:33 lyarwood brb
18:12:34 sean-k-mooney not everything in the dict
18:12:47 sean-k-mooney so for key, value in system_meta.items(): is wrong
18:13:26 sean-k-mooney well that woudl work but we need to check " if key not in imageMeta.fields(): continue
18:13:28 sean-k-mooney or similar
18:36:06 openstackgerrit Merged openstack/placement master: policy: Suppress policy deprecation warnings https://review.opendev.org/c/openstack/placement/+/771852
18:36:42 openstackgerrit Merged openstack/placement master: policy: Don't persist default rule changes in tests https://review.opendev.org/c/openstack/placement/+/772508
18:38:23 openstackgerrit Merged openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240
18:38:56 openstackgerrit Merged openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235
18:39:03 openstackgerrit Merged openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236
18:44:27 openstackgerrit Merged openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237
18:48:12 openstackgerrit Merged openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238
18:48:16 openstackgerrit Merged openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239
18:49:03 openstackgerrit Merged openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241
18:49:13 openstackgerrit Merged openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242
18:50:33 openstackgerrit Merged openstack/placement master: policy: Remove the deprecated 'placement' rule https://review.opendev.org/c/openstack/placement/+/772333
19:50:50 openstackgerrit Merged openstack/nova stable/ussuri: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761810
19:56:05 openstackgerrit Merged openstack/nova stable/victoria: Prevent archiving of pci_devices records because of 'instance_uuid' https://review.opendev.org/c/openstack/nova/+/758837
20:23:00 melwitt ci passed on 3 patches of mine in a row
20:26:33 sean-k-mooney lol
22:52:09 openstackgerrit melanie witt proposed openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi https://review.opendev.org/c/openstack/nova/+/741351
22:54:58 openstackgerrit melanie witt proposed openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi https://review.opendev.org/c/openstack/nova/+/741351
22:58:21 openstackgerrit Merged openstack/nova stable/train: Handle disabled CPU features to fix live migration failures https://review.opendev.org/c/openstack/nova/+/758763
23:18:38 openstackgerrit melanie witt proposed openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi https://review.opendev.org/c/openstack/nova/+/741351
23:19:36 melwitt prometheanfire: this should hopefully work ^ you're already cc'd on the review but in case you miss the gerrit notification
23:20:11 openstackgerrit Ghanshyam proposed openstack/placement master: DNM: testing direct l-c https://review.opendev.org/c/openstack/placement/+/773813
#openstack-nova - 2021-02-04
00:45:47 prometheanfire melwitt: thanks :D
06:34:22 openstackgerrit sean mooney proposed openstack/nova master: [WIP] harden image metadata storage https://review.opendev.org/c/openstack/nova/+/774044
08:02:12 gibi good morning
08:21:26 openstackgerrit Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944
11:39:02 lyarwood stephenfin: morning, do you know if there's a standard way of checking the config of an instance in the libvirt func tests before I go looking or hacking around?
11:39:51 stephenfin wdym the "config"?
11:40:05 stephenfin As in the XML generated by nova or attributes of the instance?
11:40:30 lyarwood stephenfin: well that or the GuestConfig (?) objects we generate that in turn create the XML
11:40:49 lyarwood stephenfin: I don't really want to assert things in the XML if we have objects that work just as well tbh
11:41:20 lyarwood LibvirtConfigObjects is what I mean sorry
11:41:35 lyarwood np if there's no prior art, I'll hack something up now
11:41:50 stephenfin Hmm, I don't think so. The only example I can think of is the NUMA live migration tests, but that intercepts the live migration API call to validate the XML
11:42:22 lyarwood cool yeah I think that's the one I saw yesterday, I'll hack something up now
11:43:00 lyarwood _get_guest_config should work tbh
12:14:50 sean-k-mooney lyarwood: there isnt really one
12:15:01 sean-k-mooney unless you have a reference to the driver
12:15:17 sean-k-mooney normally the funct test start the services
12:15:53 sean-k-mooney and there is no rpc call that you can make to teh compute manager to get it so you need to use teh service instance ot get teh driver an then call functions on it.
12:16:01 sean-k-mooney but what you can do is use the logs
12:16:18 sean-k-mooney and you can technically get teh domain xmls form that if you had too
12:19:10 lyarwood yeah I've got it working
12:19:27 lyarwood we keep a reference to the driver so it's a normal passthrough mock
12:20:08 sean-k-mooney cool
12:46:22 lyarwood sean-k-mooney: so https://review.opendev.org/c/openstack/nova/+/774044/1/nova/utils.py would still let hw_machine_type through right
12:47:04 sean-k-mooney yes
12:47:30 sean-k-mooney but i know how to fix that im debating if i want to go with a simpler fix before this one
12:48:01 sean-k-mooney basically i notice we never included ramdisk_id and kernel_id when we converted image metadata to ovos
12:48:24 sean-k-mooney so this became much more involed of a change involving object changes
12:48:42 lyarwood kk
12:48:45 sean-k-mooney but it was quite late/early this moring when i figured that out and didnt want to start agin
12:49:40 sean-k-mooney it will include hw_machine_type because you are using the same key as the image proerty - a sufix
12:49:50 sean-k-mooney lyarwood: if you add a prefix it would not be included
12:50:22 lyarwood kk, well I think I might leave it, the actual behaviour means I don't need to make any other changes to the util method fetching the machine type
12:50:26 sean-k-mooney what im going to do in the simpler version is remove key = key[len(SM_IMAGE_PROP_PREFIX):]
12:50:50 lyarwood kk
12:50:54 sean-k-mooney and build the proerties differnetly so it only contianes the one with image_
12:51:22 sean-k-mooney lyarwood:hehe
12:51:46 lyarwood so that would cause me to also add a system_metadata lookup in that util method
12:51:56 lyarwood that isn't the end of the world, it's what I had originally
12:52:05 lyarwood in a seperate change
12:52:30 sean-k-mooney well i wanted you to use image_ orginally as a prefix to avoid the extra lookup
12:52:35 sean-k-mooney we can do it either way
12:52:49 sean-k-mooney i was going to look at wriing the other patch to have someting backportable
12:52:54 sean-k-mooney assumeing we wanted too
12:53:07 sean-k-mooney if we dont then i can just finish fixing this patch
12:53:31 lyarwood that's also something I could do, always storing it as SM_IMAGE_PROP_PREFIX_hw_machine_type
12:53:41 lyarwood and that wouldn't bork me
12:53:45 lyarwood with this fix in place
12:53:57 sean-k-mooney ya
12:54:40 sean-k-mooney do you have an opipion on what way i should go with the fix. should i also do the version without the ovo change
12:59:18 lyarwood I don't at the moment tbh
12:59:33 lyarwood Let me post this and grab something to eat and then I'll think it through once I'm back

Earlier   Later