| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-22 | |||
| 03:45:03 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242 | |
| 08:20:21 | gibi | sean-k-mooney: hi! I don't find the bp https://blueprints.launchpad.net/nova/+spec/port-scoped-sriov-numa-affinity behind https://review.opendev.org/c/openstack/nova-specs/+/765901 spec | |
| 09:12:45 | nightmare_unreal | i have submitted a bug report for placement on launchpad but I found there is a storyboard for placement, should I mark it as invalid and submit again on storyboard ? | |
| 09:22:40 | frickler | nightmare_unreal: interesting question. since placement has moved back to nova governance, I'd say it should also revert to using LP, but that's mainly my aversion against sb speaking | |
| 09:23:43 | nightmare_unreal | okay frickler , i will wait for some time . Someone might look at it | |
| 09:24:02 | nightmare_unreal | and will let me know if it should be moved or not | |
| 09:24:51 | frickler | gibi: ^^ ptl topic probably ;) | |
| 09:27:20 | gibi | nightmare_unreal, frickler: interesting question, I would not start a move back to launchpad just because we have a single core team | |
| 09:27:41 | gibi | but there could be other legitimate reasons | |
| 09:27:57 | nightmare_unreal | got it | |
| 09:28:45 | gibi | nightmare_unreal: link me to the bug I please | |
| 09:29:00 | nightmare_unreal | gibi: https://bugs.launchpad.net/nova/+bug/1912749 | |
| 09:29:02 | openstack | Launchpad bug 1912749 in OpenStack Compute (nova) "clouds.yaml does not use placement API version variable" [Undecided,New] | |
| 09:29:08 | gibi | thnaks | |
| 09:40:59 | frickler | gibi: I think the main question would be how to integrate storyboard into your bug tracking workflows, assuring that issues created there aren't just getting ignored | |
| 09:59:41 | openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add reference docs for internal block device structures https://review.opendev.org/c/openstack/nova/+/771711 | |
| 10:01:25 | brinzhang_ | gibi: good moning^ | |
| 10:03:09 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING https://review.opendev.org/c/openstack/nova/+/754702 | |
| 10:07:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING https://review.opendev.org/c/openstack/nova/+/754702 | |
| 10:07:38 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for UML https://review.opendev.org/c/openstack/nova/+/743230 | |
| 10:07:40 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231 | |
| 10:07:42 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/c/openstack/nova/+/754700 | |
| 10:07:44 | lyarwood | ^ had to rebase these for the ceph gate fix and to resolve a conflict in the UML and Xen removal changes | |
| 10:08:21 | brinzhang_ | lyarwood: morning^ | |
| 10:14:53 | lyarwood | brinzhang_: morning, what's up? | |
| 10:16:28 | gibi | frickler: regardless of the bug tracking tool, we are a bit behind triaging placement bugs due to multiple reasons | |
| 10:16:38 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Allow encryption tests in nova-ceph-multistore again https://review.opendev.org/c/openstack/nova/+/771837 | |
| 10:20:45 | gibi | lyarwood: plugged back my +2s on the libvirt bump series | |
| 10:22:39 | nightmare_unreal | gibi: did you saw the bug , does it fit on placement project ? | |
| 10:22:42 | openstackgerrit | Wenping Song proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | |
| 10:22:58 | brinzhang_ | lyarwood: this morning, gmann's give me some suggestion to update he tenant-usages patch, but while I do it, I found in one file inherit the orignal class, the function in the class with @wsgi.Controller.api_version limit the request version | |
| 10:23:06 | gibi | nightmare_unreal: I opened in a browser tab, but haven't spent time on it yet | |
| 10:23:17 | nightmare_unreal | gibi: ACK :) | |
| 10:23:18 | gibi | nightmare_unreal: I will try to get to it | |
| 10:23:24 | nightmare_unreal | thanks | |
| 10:24:14 | brinzhang_ | but when I test the case, I cannot reqire the 2.90 index or show api in https://review.opendev.org/c/openstack/nova/+/768852/8/nova/api/openstack/compute/simple_project_usage.py#408 | |
| 10:25:00 | brinzhang_ | lyarwood: the request always request the api in 2.40~2.89, where is wrong? | |
| 10:27:45 | brinzhang_ | lyarwood: that case in https://review.opendev.org/c/openstack/nova/+/768852/8/nova/tests/unit/api/openstack/compute/test_simple_project_usage.py#586 | |
| 10:28:22 | brinzhang_ | lyarwood: I am not sure what I missed, maybe the inherit function is not right | |
| 10:29:09 | lyarwood | brinzhang_: so if a 2.90 request isn't being made then that's an issue with the test not the api code | |
| 10:29:51 | lyarwood | brinzhang_: and looking at the test I can't see anything that should stop it, I've never really touched this test code however so it might be something weird like an extra var required somewhere | |
| 10:31:24 | brinzhang_ | lyarwood: I am not found these test cases where need to change, I have spent almost 3 hours on this :( | |
| 10:51:41 | lyarwood | brinzhang_: yeah I'm not sure, I thought you had to add a reference to the controller in the test but there's more missing | |
| 10:51:50 | lyarwood | brinzhang_: I'll try to play around with it later if you're still stuck | |
| 10:52:57 | brinzhang_ | lyarwood: thanks, I would like gmann can have a check today | |
| 10:53:18 | brinzhang_ | after dinner I will try to trace it | |
| 10:54:07 | brinzhang_ | gmann: update the project usage patach follow your suggestion, pls help me check the question | |
| 10:54:44 | brinzhang_ | gmann: the case test run failed https://review.opendev.org/c/openstack/nova/+/768852/8/nova/tests/unit/api/openstack/compute/test_simple_project_usage.py#586 | |
| 11:36:56 | openstackgerrit | Stephen Finucane proposed openstack/placement master: WIP: Allow project readers to see project-specific usages https://review.opendev.org/c/openstack/placement/+/771964 | |
| 12:01:42 | stephenfin | lyarwood: Are you planning to review https://review.opendev.org/c/openstack/nova/+/743231/10 and https://review.opendev.org/c/openstack/nova/+/743230 or do you need to ask someone else to do it? | |
| 12:02:06 | stephenfin | I just reviewed them myself, but while it's been a while I still wrote the bulk of it so probably shouldn't give the sign off :-\ | |
| 12:02:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove 'hypervisor_version' from 'libvirt_info' https://review.opendev.org/c/openstack/nova/+/744199 | |
| 12:03:22 | lyarwood | stephenfin: I've made changes so it might be better to get someone else to approve, I'll review anyway and +1 | |
| 12:03:40 | stephenfin | Makes sense. Maybe bauzas? ^ | |
| 12:04:10 | lyarwood | as a service | |
| 12:04:12 | lyarwood | :D | |
| 12:09:51 | bauzas | stephenfin: at lunch :) | |
| 12:10:25 | bauzas | stephenfin: ping me at 1.30pm your time and I'll look at them ;) | |
| 12:21:23 | nightmare_unreal | question : where does osc reads clouds.yaml file, can't seem to figure out :/ . | |
| 13:03:34 | openstackgerrit | Elod Illes proposed openstack/nova stable/queens: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/c/openstack/nova/+/747362 | |
| 13:06:57 | openstackgerrit | Elod Illes proposed openstack/nova stable/queens: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/c/openstack/nova/+/747362 | |
| 13:29:13 | sean-k-mooney | gmann: gibi we might want to increase the test timeout on tempest-integrated-compute form 2 hours to 3 | |
| 13:29:40 | sean-k-mooney | it timed out on https://review.opendev.org/c/openstack/nova/+/757614 during the senario tests but everything else ran fine | |
| 13:29:58 | sean-k-mooney | it does look like a potentally slow node but we should proably keep an eye on it | |
| 13:31:05 | sean-k-mooney | thats the only time out there https://zuul.opendev.org/t/openstack/builds?job_name=tempest-integrated-compute&project=openstack/nova | |
| 13:31:17 | gibi | sean-k-mooney: ack. looking at the run historyt https://zuul.opendev.org/t/openstack/builds?job_name=tempest-integrated-compute&project=openstack/nova most of the runs are areound 1.5 hours | |
| 13:31:19 | sean-k-mooney | and it normally complete in aboiut 1:20 | |
| 13:31:26 | sean-k-mooney | yep | |
| 13:31:29 | gibi | so let's keep an eye on it | |
| 13:31:37 | gibi | but right now I would not increase yet | |
| 13:31:44 | sean-k-mooney | i think in general the current time out looks right | |
| 13:33:07 | sean-k-mooney | the fact we have a normal run lenght in the next patch in the chain would seam to indicate that the time it ran fro is unrealted to the patch too | |
| 13:34:39 | gibi | yes, I think this was an extra slow node | |
| 13:34:58 | sean-k-mooney | collections.defaultdict(lambda: 0) huh thats a new one | |
| 13:36:05 | sean-k-mooney | so ret: ty.DefaultDict[str, int] = collections.defaultdict(lambda: 0) is default initallising a dictionary where the values will be 0 | |
| 13:37:55 | gibi | defaultdict takes a callable to produce the default value | |
| 13:38:07 | gibi | sometimes we use int instead of lamba: 0 | |
| 13:38:10 | gibi | both produce 0 | |
| 13:38:56 | gibi | as int() == 0 as well as lambda: 0() == 0 | |
| 13:39:32 | sean-k-mooney | ya its a cleaver solution but also suprisign if you have not seen it before | |
| 13:39:54 | sean-k-mooney | i would have expect to just pass 0 honestly | |
| 13:40:06 | sean-k-mooney | but i can see why that would not be a good patern in general | |
| 13:40:17 | gibi | you cannot pass 0 as that is not a callable | |
| 13:40:35 | sean-k-mooney | if it was a complex object instead of a literall it would be a problem to allow passing the object directly | |
| 13:40:42 | sean-k-mooney | since it would be shared not cloned | |
| 13:40:51 | sean-k-mooney | hence a callable to produce the defualt value | |
| 13:40:54 | gibi | yepp | |
| 13:41:02 | gibi | so we have to pass something that returns 0 | |
| 13:41:21 | gibi | both int, and lamba:0 is good for that, but a 0 literal is not | |
| 13:41:43 | sean-k-mooney | yep | |
| 13:42:40 | sean-k-mooney | its more a deficite of the api of the datastucture then anything else. its more flexable however then the claical default approch | |
| 13:43:10 | sean-k-mooney | its just different form how get and set_default work | |
| 13:43:43 | sean-k-mooney | but inline with how sorted or filter works where you provide a key funcion as a callable | |
| 13:52:37 | nightmare_unreal | how can i access clouds.yaml file once it's loaded. Suppose i want to read some values from it . For context i am trying to read placement_api_version | |
| 13:53:26 | sean-k-mooney | there is a lib for it but OSC will automaticlaly do it for vars in the right format | |
| 13:54:49 | sean-k-mooney | its just a yaml file however so in your own code you can jsut read it with the stardard lib | |
| 13:55:10 | sean-k-mooney | i think its in osc-lib | |
| 13:56:03 | nightmare_unreal | i am working on a bug : osc client does not read placement API version variable . variable name placement_api_version | |
| 13:56:26 | nightmare_unreal | so i am trying to figure out where in osc it reads the yaml file | |
| 13:57:04 | sean-k-mooney | its case sensitive and has to be uppercase just an fyi | |