| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-18 | |||
| 16:57:58 | kashyap` | Either way; back to the original issue | |
| 17:00:09 | gibi | so | |
| 17:00:21 | gibi | I can make it work it just wierdly order dependent | |
| 17:00:34 | kashyap` | gibi: Hmm, so that behaviour of "no event when detaching from live config first" sounds strange and inconsistent. | |
| 17:00:35 | gibi | and also the persistent side does not generate event | |
| 17:00:44 | gibi | kashyap`: yeah | |
| 17:01:04 | kashyap` | gibi: Let me ask Peter; if this is a "bug or a feature" ;-) | |
| 17:03:35 | gibi | kashyap`: could be some kind of complication in my test as well. I try to re-test it with a simpler tempest test as now there is rescue involved as well | |
| 17:05:58 | kashyap` | gibi: I want to phrase the (complex) problem in my own words, so tell me if this is correct: | |
| 17:06:18 | kashyap` | (Because I'm not clear in _which_ combination the event is generated and in which not) | |
| 17:06:48 | kashyap` | - Assume a domain has both a persistent (i.e. inactive) and a live config. | |
| 17:06:51 | kashyap` | - Detach a device from the inactive config first --> detach successful; but does not generate an event | |
| 17:06:54 | kashyap` | - Detach a device from the live config first, then detach it from the persistent config --> the second detach fails; and no event generated in both cases | |
| 17:07:37 | kashyap` | gibi: Is that correct? (With the final point being: if the third attempt in the last step is a live config --> then the detach works) | |
| 17:08:05 | gibi | kashyap`: Detach a device from the live config first, then detach it from the | |
| 17:08:09 | gibi | persistent config | |
| 17:08:40 | gibi | in this case both detach returns without generating event, and the device remains attached (at least in the live config) | |
| 17:09:22 | kashyap` | Aah --> both of them fail (i.e. detach not succesful) and nor do they generate an event? | |
| 17:10:30 | gibi | nova only checks the live config so I can only say that the detach failed from the live config as teh device remains there. | |
| 17:10:40 | gibi | but meanwhile I simplifed the test | |
| 17:10:48 | gibi | and now | |
| 17:11:15 | gibi | I can start with live detach first and it succeeds and generates event as well | |
| 17:11:40 | gibi | so there is some complication my first test scenario that makes the behavior different | |
| 17:11:59 | kashyap` | gibi: The event is _REMOVAL_FAILED, yeah? | |
| 17:12:14 | kashyap` | gibi: If you like, I can start an upstream thread w/ the libvirt folks on libvir-list, and Cc you | |
| 17:13:24 | gibi | kashyap`: when I get event it is VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED | |
| 17:13:36 | gibi | kashyap`: I think I've never seen VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED in my tests ever | |
| 17:13:36 | kashyap` | Err, sorry; it's a succesful removal | |
| 17:13:58 | gibi | kashyap`: let's not rush with that mail, I think I tested too much first | |
| 17:14:16 | kashyap` | gibi: No rush at all :-) Just outlining as an option | |
| 17:14:20 | gibi | and I have to figure out what extra the nova rescue does | |
| 17:14:28 | gibi | that makes the behavior different | |
| 17:14:49 | gibi | because with a simple ACTIVE instance the live first scenario works | |
| 17:14:51 | gibi | as expected | |
| 17:14:58 | gibi | removes the device and generates event | |
| 17:15:16 | kashyap` | Right; gibi - while it's fresh in your mind, do you want to quickly add a note on the scenarios you've tested and the ones that are "weird"? | |
| 17:15:35 | kashyap` | Doesn't have to be now; I know it's EoD in CET. Tomm is fine too | |
| 17:15:42 | gibi | sure I will comment on the patch | |
| 17:16:38 | gibi | lyarwood: you mentioned that I could check the device both in the persistent config and in the live config. do you have a pointer how to check in the persistent config? | |
| 17:16:43 | kashyap` | Excellent; this hot unplug thing is always muddy; so many variables involved. | |
| 17:22:42 | kashyap` | gibi: I wonder if lyarwood meant 'nodedev-list' | |
| 17:22:59 | kashyap` | (No, wait - that's for listing devices on the host) | |
| 17:27:09 | kashyap` | Normally, there should be a '--persitent' flag for most of the listing ('domiflist', 'domblklist', et al) APIs. | |
| 17:27:31 | gibi | kashyap`: yeah, I'm doing this from the nova code | |
| 17:27:55 | kashyap` | gibi: So what do you want to check? Query the presence of a device from peristent config? | |
| 17:28:21 | gibi | yes | |
| 17:28:33 | gibi | nova currently query the live config only | |
| 17:31:05 | kashyap` | gibi: Are you referring to this? | |
| 17:31:05 | kashyap` | device_name_for_logging=self.vif_driver.get_vif_devname(vif), | |
| 17:31:08 | kashyap` | live=live, | |
| 17:33:00 | gibi | kashyap`: https://github.com/openstack/nova/blob/5b65812ef2c6ac46bea30e2e603284eac232339e/nova/virt/libvirt/guest.py#L315 | |
| 17:33:28 | gibi | this is how nova checks if a device is in the config and I think it is checking the live config | |
| 17:34:06 | gibi | kashyap`: for vifs the code is here https://github.com/openstack/nova/blob/5b65812ef2c6ac46bea30e2e603284eac232339e/nova/virt/libvirt/guest.py#L230 | |
| 17:35:10 | gibi | I guess the key is self._domain.XMLDesc(0) in both case but I failed to find the proper doc what 0 means and what else I can plug there | |
| 17:35:31 | gibi | anyhow I have to drop off | |
| 17:35:33 | gibi | for today | |
| 17:35:33 | kashyap` | gibi: Ah, it's all custom parsing of the XML | |
| 17:35:42 | gibi | yep | |
| 17:35:47 | kashyap` | Yeah, I need to head out shortly too; we can work it out tomm | |
| 17:35:55 | gibi | kashyap`: thanks for the help, let's continue this tomorrow | |
| 17:35:59 | gibi | o/ | |
| 18:42:02 | gmann | gibi: stephenfin can either of you check this- https://review.opendev.org/c/openstack/placement/+/764394 | |
| 18:56:30 | elod | lyarwood: sorry, I was off today, but will look into the patches tomorrow | |
| 19:01:35 | openstackgerrit | sean mooney proposed openstack/nova-specs master: libvirt: support vdpa kernel networking https://review.opendev.org/c/openstack/nova-specs/+/764999 | |
| 19:04:02 | sean-k-mooney | artom: im proably going to call it there for today let me know if there is anything else you want me to adress in ^ | |
| 19:04:20 | sean-k-mooney | it will be tomorrow before i get to it proably | |
| 19:04:35 | artom | sean-k-mooney, cool, thanks! | |
| 19:04:56 | artom | Guyze. | |
| 19:05:03 | artom | Guyze guyze guyzes. | |
| 19:05:07 | artom | http://www.hardware.py/ is available! | |
| 19:06:06 | artom | Aww, it's restricted :( | |
| 19:10:25 | sean-k-mooney | hehe while agree the docs to that moduel are lacking im not sure it need its own webseit even thouh it could definetly fill one | |
| 19:12:57 | openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: `socket` PCI NUMA-affinity Policy https://review.opendev.org/c/openstack/nova-specs/+/765551 | |
| #openstack-nova - 2021-01-19 | |||
| 01:51:26 | openstackgerrit | Brin Zhang proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336 | |
| 05:56:44 | openstackgerrit | Rico Lin proposed openstack/nova master: add openstack-python3-wallaby-jobs-arm64 job https://review.opendev.org/c/openstack/nova/+/742094 | |
| 07:24:12 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 07:24:12 | openstackgerrit | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 07:24:13 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 08:08:35 | gibi | lyarwood, kashyap: never mind I think I found the doc for XMLDesc https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetXMLDesc | |
| 08:40:09 | openstackgerrit | Xing Zhang proposed openstack/nova stable/train: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/c/openstack/nova/+/768736 | |
| 08:47:20 | lyarwood | gibi: sorry had already logged yesterday when you asked that | |
| 08:47:28 | lyarwood | teething-- | |
| 09:00:29 | lyarwood | stephenfin / sean-k-mooney ; https://review.opendev.org/c/openstack/nova/+/761725 - would you mind taking a look at this stable/train backport and the changes made for stable/train? LGTM from a stable core point of view. | |
| 09:19:15 | kashyap | gibi: Ah, nod | |
| 09:27:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Add nova-live-migration-ceph job https://review.opendev.org/c/openstack/nova/+/768466 | |
| 09:28:46 | lyarwood | finally \o/ | |
| 09:29:15 | lyarwood | still needs some devstack-plugin-ceph and devstack changes to land but it's almost there | |
| 09:29:36 | lyarwood | then it's just the multinode grenade job iirc | |
| 09:33:18 | openstackgerrit | Merged openstack/nova-specs master: Libvirt supports composing cyborg owned vGPU accelerator into domain XML https://review.opendev.org/c/openstack/nova-specs/+/750116 | |
| 09:36:43 | stephenfin | lyarwood: looking | |
| 10:01:57 | lyarwood | did we agree on a spec review day before the deadline btw? | |
| 10:02:17 | lyarwood | I'm trying to finish the libvirt eph encryption spec today for review but appreciate it's pretty late | |
| 10:20:38 | bauzas | lyarwood: no, we said no during the meeting | |
| 10:21:01 | lyarwood | bauzas: ack thanks, and the deadline is Thursday for specs right? | |
| 10:21:01 | bauzas | but we can continue to look at the specs | |
| 10:21:05 | bauzas | correct | |
| 10:21:17 | lyarwood | bauzas: ack thanks, I'll get this posted today and go from there | |
| 10:21:19 | bauzas | ++ | |
| 10:24:11 | sean-k-mooney | lyarwood: yep just have a meeting in a at half past but ill look at it after. i am familar with the backport and it is something we shoudl do but ill do an actual review after the meeting | |
| 10:24:57 | bauzas | stephenfin: do you want to have +2/+W for all the series before merging https://review.opendev.org/c/openstack/nova/+/758155 or do you prefer to merge each of them | |