Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-18
12:33:43 lyarwood gibi: we don't get the event as the device is still attached to the live config
12:34:06 lyarwood gibi: and failure is for sync failures where QEMU rejects the request to detach
12:34:07 gibi lyarwood: but we expect that libvirt will detach from the live config as we asked for it
12:34:17 gibi in the first request
12:34:19 lyarwood gibi: we expect that it should try
12:34:32 gibi and if fails then it should tell us it failed, isn't it?
12:35:04 kashyap gibi: lyarwood: So, Peter Krempa came back; let me post the chat summary snippet here, from #virt, OFTC:
12:35:05 lyarwood gibi: no, again the failure event is for when QEMU tells libvirt that it can't detach the device when the request is initially made
12:35:36 lyarwood gibi: if that request is accepted but the guestos doesn't allow the device to detach then we don't get anything back
12:35:49 lyarwood that's my understanding at least, lets see what kashyap has
12:36:50 kashyap lyarwood: Yeah; now I hear some additional subtleties; I'm going to post the full summary on the change; and we all can read and discuss here
12:48:20 kashyap gibi: lyarwood: Done; see here (I also like DanPB's advice on dealin w/ active vs. inactive config separately): https://review.opendev.org/c/openstack/nova/+/770246/7/nova/virt/libvirt/driver.py#2330
12:51:29 kashyap Let me know if that answers your question; if not, please note there, if anything doesn't add up :-)
12:51:34 gibi sorry, I'm on a call
12:51:53 kashyap No rush at all
13:00:34 gibi kashyap: thanks for the summary, I will work DanPB's suggestion into the patch as handling the live an the persistent config separately feels cleaner to me too
13:03:01 kashyap Np
13:22:21 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231
13:22:21 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/c/openstack/nova/+/754700
13:43:36 openstackgerrit Brin Zhang proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336
14:24:40 stephenfin sean-k-mooney: Can you fix the failures on https://review.opendev.org/c/openstack/nova-specs/+/765901 real quick?
14:25:42 sean-k-mooney oh it failed yes ill do it now
14:26:04 sean-k-mooney sorry should have ran pep8
14:30:27 sean-k-mooney stephenfin: for the leading underscore
14:30:30 sean-k-mooney for [2]
14:30:37 sean-k-mooney shoudl it be [_2]
14:30:38 stephenfin *trailing
14:30:42 stephenfin [2]_
14:30:51 sean-k-mooney oh
14:31:07 sean-k-mooney and the first one does not need that?
14:31:20 stephenfin you already have it on the first one :)
14:31:41 sean-k-mooney oh for [1]_
14:31:49 sean-k-mooney i have another instance of [2] before that
14:31:56 sean-k-mooney cool ill fix them all
14:35:36 openstackgerrit sean mooney proposed openstack/nova-specs master: add port scoped numa affinity spec https://review.opendev.org/c/openstack/nova-specs/+/765901
14:36:19 sean-k-mooney stephenfin: i think ^ fixes everything
14:36:30 sean-k-mooney let me know if there is anything else and ill respin
14:36:39 stephenfin will do
14:44:36 stephenfin sean-k-mooney: I have my doubt about that policy amendment to the modernize os-hypervisors API spec
14:44:53 stephenfin "namely the idea that we shoudl allow users with the PROECT_ADMIN role to list all hyperviors there project is allowed to acess via the summary endpoint"
14:45:41 stephenfin there doesn't appear to be anything that restrict projects to specific hypervisor(s)
14:45:59 stephenfin at least there's no tenant or project attribute of the ComputeNode or Service objects
14:46:07 stephenfin did you have something specific in mind?
15:00:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move query param generation to RequestGroup o.vo https://review.opendev.org/c/openstack/nova/+/756894
15:01:45 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos https://review.opendev.org/c/openstack/nova/+/756895
15:03:08 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109
15:04:31 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110
15:06:22 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111
15:08:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614
15:09:29 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/utils.py https://review.opendev.org/c/openstack/nova/+/769942
15:10:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor ResourceRequest constructor https://review.opendev.org/c/openstack/nova/+/769720
15:12:15 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530
15:13:39 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152
15:14:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove unused Instance method https://review.opendev.org/c/openstack/nova/+/757615
15:15:00 sean-k-mooney stephenfin: i intened to reuse the aggreate metadtaa used for the teannt afinity filters
15:15:15 sean-k-mooney we use the same metadat for both the placment prefilter or the post filter
15:15:37 sean-k-mooney the prefilter allwos you to do stict tenant isolation
15:15:51 sean-k-mooney so that only a given tenatn can use member of a give aggreate
15:18:26 sean-k-mooney stephenfin: https://docs.openstack.org/nova/rocky/admin/configuration/schedulers.html#tenant-isolation-with-placement
15:18:52 sean-k-mooney you do openstack aggregate set --property filter_tenant_id=9691591f913949818a514f95286a6b90 myagg
15:19:00 sean-k-mooney to restict the usage
15:19:12 sean-k-mooney stephenfin: so the check you would do is simple.
15:19:20 sean-k-mooney gretrive all aggreate with the current teant id
15:19:26 sean-k-mooney show only host in those aggreates
15:20:01 sean-k-mooney stephenfin: if the list is of aggrates is empty then list all hosts
15:20:21 sean-k-mooney since that tenant is unconfiged
15:20:53 stephenfin makes sense
15:31:26 openstackgerrit Dan Smith proposed openstack/nova master: Do not inherit os_glance properties on snapshot https://review.opendev.org/c/openstack/nova/+/771234
15:49:53 stephenfin gibi: Could you stick https://review.opendev.org/c/openstack/nova/+/764482/ on your review queue, please?
15:50:10 gibi stephenfin: on it
15:53:09 lyarwood has anyone hit https://bugs.launchpad.net/tempest/+bug/1912178 locally today?
15:53:10 openstack Launchpad bug 1912178 in tempest "Links are not allowed as constraints (pip 20.2.4)" [Undecided,New]
15:53:27 stephenfin not me
15:53:51 gibi lyarwood: yes
15:53:53 lyarwood weird, I'm not sure what is adding the URI to the constraints list
15:54:02 lyarwood oh cool not just me then, cool
15:54:38 gibi lyarwood: I think devstack edits the constraints list based on what repos/libs you asked in the local.conf to be cloned
15:55:09 gibi lyarwood: as far as I understand the issue appears if somehow the pip version gets updated in your devstack vm
15:55:28 gibi lyarwood: for me, in a clean ubuntu 20.04 the first devstack stach.sh works
15:55:45 gibi but subsequnt unstack.sh && stack.sh fails with the above rror
15:56:47 lyarwood gibi: yeah I was about to say I've not touched the version of pip in this env
15:57:10 gibi lyarwood: I suspect that the stach.sh runs some update if it is not in a clean vM
15:57:14 gibi but I have no proof
16:00:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929
16:00:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246
16:02:00 lyarwood gibi: fun, so I've updated pip and it seems to be working now
16:02:15 gibi hm, interesting
16:14:28 stephenfin bauzas: If you've a chance this week, care to look at https://review.opendev.org/q/topic:bp/compact-db-migrations-wallaby ? dansmith and gibi have already looked through it, so I need a final pair of eyes
16:14:43 bauzas sure, will do
16:14:56 stephenfin you can ignore the apidb series at the bottom for now - I suspect I need to rework some of that
16:15:01 stephenfin cool, thanks
16:25:13 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove 'hypervisor_version' from 'libvirt_info' https://review.opendev.org/c/openstack/nova/+/744199
16:29:54 openstackgerrit Stephen Finucane proposed openstack/nova master: Add generate schemas tool https://review.opendev.org/c/openstack/nova/+/769796
16:35:51 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231
16:35:52 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/c/openstack/nova/+/754700
16:51:53 openstackgerrit Merged openstack/python-novaclient master: Deprecate agent commands and APIs https://review.opendev.org/c/openstack/python-novaclient/+/769068
16:52:46 gibi lyarwood, kashyap`: back from some testing. If a domain has both a persistent and a live config, then detaching from only the persistent domain first works but does not generate an event. detaching from the live first then detaching from the persistent second does not work none of them generate event (but if the 3rd attempt is live again then that works).
16:53:10 kashyap` gibi: On a call; but reading (as I'm not speaking) ...
16:53:37 gibi so it seems we always need to detach from the persistent first, don't wait for any event, then detach from the live, and wait for event
16:54:19 kashyap` Wait, you're contrasting "persistent" vs. "live" -- my brain was expecting either persistent vs. transient; or live vs offline :-)

Earlier   Later