Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-06
19:35:11 melwitt yeah but we use 0 (on master) and -1 (on queens) to mean "no preference"
19:35:35 sean-k-mooney yep so we need to adjust that logic slightly
19:35:47 sean-k-mooney so that the closet match code works
19:41:57 melwitt sean-k-mooney: did you want to work on the fix? or did you want me to stack a change on top of your test?
19:43:17 sean-k-mooney im testing a quick hack but sofar its not working so if you want to stack a change on top go for it
19:43:44 sean-k-mooney that is what im trying currrntly but the two things i have tired so far have no effect :)
19:44:29 melwitt oh heh. well it's up to you
19:46:15 sean-k-mooney oh its becasue its using the numa toplogy object i think
19:46:19 openstackgerrit Merged openstack/nova master: tests: Remove 'test_extended_hypervisors' https://review.opendev.org/c/openstack/nova/+/769519
19:46:28 sean-k-mooney ill give it one more try then im going for dinner and its all yours
19:48:06 melwitt hehe, k. well it was your idea on how to fix it :) so if you want to stick with it that wfm. if not, I can give it a try
19:51:19 openstackgerrit sean mooney proposed openstack/nova master: [WIP] fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/769614
19:51:34 sean-k-mooney this is probaly not right but it passes the new test i added
19:52:08 melwitt ack
19:52:29 sean-k-mooney the vcpu toplogy cannot cahnge per numa node
19:52:44 sean-k-mooney so i dont actully think we shoul dbe looking at the numa node there
19:53:23 sean-k-mooney hum i just ran all the libvirt func tests and they passed
19:53:30 sean-k-mooney im running the full set now
20:00:58 sean-k-mooney :( i hit the subunit parser bug....
20:01:00 sean-k-mooney File "/opt/repos/nova/.tox/functional/lib/python3.8/site-packages/subunit/v2.py", line 227, in _write_packet
20:01:02 sean-k-mooney raise ValueError("Length too long: %r" % base_length)
20:01:04 sean-k-mooney ValueError: Length too long: 5072548
20:01:39 sean-k-mooney there are dissadvatages to OS_DEBUG=1
20:03:31 sean-k-mooney ok im going to have dinner and we can see what the ci says but i thinnk that working acourdign to to the func tests that have run but i think i have disabled too much
20:07:31 sean-k-mooney melwitt: wem might actully be able to just remove https://github.com/openstack/nova/blob/ccb2e11129d4a0730b0ba19a7f49ed8fc5a05f6d/nova/virt/hardware.py#L616-L637
20:07:49 sean-k-mooney it was added by https://github.com/openstack/nova/commit/770ab8eeb72b184ac6164aeabb89c4bf45f938a9
20:07:59 sean-k-mooney but in not conviced the resoning is correct
20:08:40 melwitt hm ok
20:09:50 sean-k-mooney the guest vcpu toplogy is indepenet of its numa toplogy
20:10:26 sean-k-mooney this patch was trying to support different guest vcpu toplogies per numa node which we have never supported
20:11:22 sean-k-mooney at least looking at https://github.com/openstack/nova/commit/770ab8eeb72b184ac6164aeabb89c4bf45f938a9#diff-027adff210e1ed4c63524a486cb988702337880b5c0773482200a136e391ecfbR773
20:16:15 sean-k-mooney it looks like we still have some of those unit tests https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/test_hardware.py#L792-L881
20:17:29 sean-k-mooney the last one is definetly not requesatable via the api
20:17:30 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/test_hardware.py#L858-L883
20:17:59 sean-k-mooney oh my func test run passed locally too.
20:18:08 sean-k-mooney ok really getting dinner now o/
20:53:02 openstackgerrit Lance Bragstad proposed openstack/placement master: Bump oslo.log version to 4.3.0 https://review.opendev.org/c/openstack/placement/+/760229
22:15:06 gmann stephenfin: done, left comment for https://review.opendev.org/c/openstack/nova/+/769520/1/nova/api/openstack/compute/hypervisors.py#363
22:15:24 gmann stephenfin: and other two patches of this BP also
#openstack-nova - 2021-01-07
04:46:27 openstackgerrit Lance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly https://review.opendev.org/c/openstack/placement/+/766785
04:46:28 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240
07:16:08 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in usage* commands https://review.opendev.org/c/openstack/python-novaclient/+/769675
07:21:27 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in usage* commands https://review.opendev.org/c/openstack/python-novaclient/+/769675
08:50:37 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in flavor-access commands https://review.opendev.org/c/openstack/python-novaclient/+/769019
09:44:48 Yumeng hi gibi
09:45:37 gibi Yumeng: hi
09:46:00 Yumeng welcome back from holiday^^ how was it?
09:51:15 Yumeng gibi: Can you check my response here? https://review.opendev.org/c/openstack/nova-specs/+/750116/14/specs/wallaby/approved/support-vGPU-nova-cyborg-interaction.rst#225
09:54:04 gibi Yumeng: thanks. The time off was good.
09:54:27 gibi I will try to check back to that spec
09:54:34 Yumeng gibi: sounds nice!
09:54:40 Yumeng thanks!
09:55:08 gibi Yumeng: did you have some time of during this period or you will be off for the chinees new year instead?
09:56:13 Yumeng This year's Chinees new year holiday starts from Feb 11, so we still have time ^^
09:57:44 gibi OK
09:59:37 Yumeng gibi: but there will be some change in cyborg team this month. I will changed my company and work priority since Jan 18. So I'm going to step down from the PTL position and Xinran Wang will take over the PTL duty.
10:00:36 gibi Yumeng: thanks for the information, will you be able to push the implementation forward after jan 18 or it will also be taken over by somebody else?
10:02:59 Yumeng gibi: after jan 18, vGPU will be taken over by wenpingsong and chenke from Cyborg team.
10:03:09 gibi Yumeng: thanks for that info too
10:03:30 Yumeng It also makes sense to ping the new PTL as well ^^
10:06:36 gibi bauzas: do you have any outstanding issues with the cyborg spec other than the deprecation issue? https://review.opendev.org/c/openstack/nova-specs/+/750116
10:07:40 Yumeng gibi: now in the cyborg side, we are pushing the driver implementation:https://review.opendev.org/q/topic:%22enable-vgpu-in-cyborg%22+(status:open%20OR%20status:merged). We will try to merge before I leave. so that you guys can see at least a whole implementation in cyborg side.
10:08:10 gibi Yumeng: cool. Does it contain support for vgpu in the fake driver we use in tempest testing?
10:08:22 Yumeng emmm not yet
10:08:42 Yumeng we can test in real env at this moment
10:08:45 gibi it is not super urgent, but good to not forget about it
10:08:51 bauzas gibi: honestly, I need to do a second revision
10:09:25 Yumeng yep, we need to do that.
10:09:53 gibi bauzas: no worries, we have two weeks still until spec freeze
10:10:14 bauzas gibi: I'll try to look at it this week honestly
10:10:19 gibi thanks
10:11:41 bauzas gibi: Yumeng: my main concerns about this spec (outside the fact of the deprecation) were about making sure that both vGPU ways work
10:11:57 bauzas and maybe by the same methods if we could
10:12:14 gibi I agree that we need to reuse as much in the existing nova code as possible
10:12:21 bauzas (without changing the flavors=
10:13:01 bauzas gibi: but maybe I could leave some implementation concerns for the nova changes
10:13:23 bauzas and accepting the spec if I see it goes to a direction I like
10:13:44 gibi bauzas: if you have specific concerns then it does not harm to state them now.
10:13:49 bauzas I don't want to leave this spec not accepted b/c of any technical nits
10:13:56 gibi so that we wont forget it
10:14:15 bauzas gibi: sure, just explaining why I need to revise it
10:14:20 gibi cool
10:14:34 gibi sure we will wait for your re-review
10:15:15 Yumeng cool. thanks!
11:13:55 brinzhang bauzas: https://review.opendev.org/c/openstack/nova/+/729563 I replied your comments, pls review cyborg shelve/unshelve support patch
11:14:23 brinzhang I was not found there are sth. need to change
11:45:43 openstackgerrit Lee Yarwood proposed openstack/nova-specs master: libvirt: Update instance machine type stash spec https://review.opendev.org/c/openstack/nova-specs/+/769547
11:48:25 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Clean up base migration https://review.opendev.org/c/openstack/nova/+/758155
11:48:26 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Merge in unique constraints https://review.opendev.org/c/openstack/nova/+/758156
11:48:26 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Drop "remove" of index https://review.opendev.org/c/openstack/nova/+/758157
11:48:27 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Icehouse database migrations https://review.opendev.org/c/openstack/nova/+/758394
11:48:27 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Juno database migration https://review.opendev.org/c/openstack/nova/+/758395
11:48:28 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/c/openstack/nova/+/758396
11:48:28 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Liberty database migrations https://review.opendev.org/c/openstack/nova/+/758397
11:48:29 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Mitaka database migrations https://review.opendev.org/c/openstack/nova/+/758398
11:48:29 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Newton database migrations https://review.opendev.org/c/openstack/nova/+/759085
11:48:30 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Ocata database migrations https://review.opendev.org/c/openstack/nova/+/759086
11:48:30 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Pike database migrations https://review.opendev.org/c/openstack/nova/+/759087
11:48:31 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Queens database migrations https://review.opendev.org/c/openstack/nova/+/759088
11:48:31 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Rocky database migrations https://review.opendev.org/c/openstack/nova/+/759089

Earlier   Later