| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-05 | |||
| 07:36:54 | brinzhang0 | gibi: pls review cyborg shelve/unshelve patch while you are free https://review.opendev.org/c/openstack/nova/+/729563, thanks | |
| 07:42:43 | openstackgerrit | Mamduh proposed openstack/os-vif stable/stein: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765914 | |
| 07:46:02 | openstackgerrit | Mamduh proposed openstack/os-vif stable/stein: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765974 | |
| 08:28:42 | gibi | brinzhang0: done, I have one more issue to fix then it is good to go from my perspective | |
| 08:29:24 | brinzhang0 | gibi: good news, thanks | |
| 08:32:37 | brinzhang0 | gibi: could you please review the PS21, comment by your suggestion https://review.opendev.org/c/openstack/nova/+/729563/21 | |
| 08:33:12 | brinzhang0 | or I missed your mean | |
| 08:38:38 | openstackgerrit | zhangtongjian proposed openstack/nova-specs master: remove unicode from code https://review.opendev.org/c/openstack/nova-specs/+/769260 | |
| 08:41:37 | bauzas | good morning Nova | |
| 08:55:22 | openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765962 | |
| 08:55:23 | openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765977 | |
| 09:01:30 | openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/c/openstack/nova/+/729563 | |
| 09:01:34 | brinzhang0 | gibi: done | |
| 09:58:38 | openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765962 | |
| 09:58:39 | openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765977 | |
| 10:09:55 | stephenfin | gibi: I'm looking at a bug report where cold migration fails for an SR-IOV instance with "Port update failed for port XXX: Unable to correlate PCI slot 0000:xx:yy.z". Does that ring a bell? | |
| 10:10:34 | stephenfin | It sounds familiar, but I can only find bugs related to unshelve, not cold migration | |
| 10:12:20 | stephenfin | Ah, got it https://bugs.launchpad.net/nova/+bug/1512880 | |
| 10:12:21 | openstack | Launchpad bug 1512880 in OpenStack Compute (nova) newton "Failed cold migration with SR-IOV" [Medium,Fix released] | |
| 10:55:56 | gibi | brinzhang0, stephenfin: sorry, I was away | |
| 11:45:34 | gibi | brinzhang0: one more thing https://review.opendev.org/c/openstack/nova/+/729563 | |
| 11:48:27 | brinzhang0 | gibi: ok, can be remove the excetpion block | |
| 11:48:33 | gibi | brinzhang0: yepp | |
| 11:48:37 | gibi | then I will be +2 | |
| 11:48:45 | brinzhang0 | cool | |
| 11:48:51 | openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329 | |
| 11:49:27 | gibi | brinzhang0: I also started reviewing the tenant_id replacement series and left some comments. I haven't reached the top of that series but I will continue today | |
| 11:50:36 | brinzhang0 | gibi: thank you very much, I will update it after you completed review | |
| 11:50:45 | gibi | brinzhang0: OK, cool | |
| 11:51:29 | brinzhang0 | and there are some novaclient patch and sdk patach need to be submit, but it not urgent | |
| 11:52:25 | gibi | brinzhang0: yepp, does patches needs to be proposed during this cycle too | |
| 11:52:40 | gibi | so that we can have a client release that compatible with the new microverison | |
| 11:52:56 | brinzhang0 | gibi: yes | |
| 11:53:27 | brinzhang0 | I just dont want to change the v288, if that need todo, it will be waste so much time :( | |
| 11:54:04 | brinzhang0 | but it depends on os-hypervisor and novnc feature ^^ | |
| 11:55:07 | gibi | brinzhang0: I also reviewed the novnc password patch yesterday and there are some upgrade pieces missing there | |
| 11:55:38 | gibi | right now every 2.88 candidate is blocked by comments, stephenfin works on hypervisor patch to be in sync in the latest spec amendment | |
| 11:55:53 | brinzhang0 | gibi: yeah, I have seen, while we have time will be updated, in latest two days | |
| 11:56:04 | gibi | OK | |
| 11:57:55 | brinzhang0 | yes, I saw the spec update, but there is no time to review into, I will try my best to review and follow this patch asap | |
| 11:58:19 | openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/c/openstack/nova/+/729563 | |
| 11:58:27 | brinzhang0 | gibi: done by cyborg shelve/unshelve patch, and test the test_api.file in my local, it was past | |
| 11:58:59 | gibi | brinzhang0: looking... | |
| 12:02:59 | gibi | brinzhang0: thanks. I'm +2 now | |
| 12:03:32 | gibi | stephenfin, bauzas: ^^ shelve - unshelve support with cyborg accelerators looks good to me now but needs a second core | |
| 12:04:05 | brinzhang0 | gibi: thanks | |
| 12:04:34 | brinzhang0 | stephenfin, bauzas: pls review this patch wile you have free time, thanks | |
| 12:11:35 | brinzhang0 | gibi: https://review.opendev.org/c/openstack/nova/+/767251 this is a samll change, gmann have already +2 for it, pls review | |
| 12:12:00 | gibi | looking | |
| 12:16:04 | gibi | brinzhang0: I have one issue about json vs. single quote usage in the example | |
| 12:16:07 | gibi | https://review.opendev.org/c/openstack/nova/+/767251 | |
| 12:17:03 | brinzhang0 | gibi: yeah, will be update | |
| 12:21:18 | openstackgerrit | Brin Zhang proposed openstack/nova master: Improving the description for unshelve request body https://review.opendev.org/c/openstack/nova/+/767251 | |
| 12:21:52 | brinzhang0 | gibi: done | |
| 12:22:03 | gibi | looking | |
| 12:23:04 | brinzhang0 | gibi: thanks | |
| 12:23:06 | gibi | gmann: brinzhang0 respun https://review.opendev.org/c/openstack/nova/+/767251 now I'm +2. could you re-review it? | |
| 12:57:40 | openstackgerrit | Takashi Natsume proposed openstack/python-novaclient master: Deprecate agent commands and APIs https://review.opendev.org/c/openstack/python-novaclient/+/769068 | |
| 14:03:45 | bauzas | gibi: ack, will look at the shelve cyborg support | |
| 14:03:54 | gibi | bauzas: thanks | |
| 14:04:30 | bauzas | that reminds me I have to rebase my own series on routed networks | |
| 14:08:19 | gibi | stephenfin: I reviewed https://review.opendev.org/c/openstack/nova/+/758396 and I have some questions inline. It was a long step forward, my brain hurts :) | |
| 14:08:55 | gibi | I need some distraction now | |
| 14:09:30 | stephenfin | heh, no problem. Stuck on that PCI unshelve issue from this morning (it's a different issue, it seems) but I'll take a look at some point today, hopefully | |
| 14:09:35 | stephenfin | and thanks! | |
| 14:09:37 | sean-k-mooney | i am reliably informed that the internet has many distrcations | |
| 14:10:17 | sean-k-mooney | stephenfin: do you mean https://bugzilla.redhat.com/show_bug.cgi?id=1911710 | |
| 14:10:18 | openstack | bugzilla.redhat.com bug 1911710 in openstack-nova "[osp 13][neutron] cold migration fails for sriov instance with: Port update failed for port <uuid>c: Unable to correlate PCI slot" [Urgent,New] - Assigned to nova-maint | |
| 14:10:28 | stephenfin | yup | |
| 14:10:32 | sean-k-mooney | cause that is not unshelve | |
| 14:10:44 | sean-k-mooney | different code path | |
| 14:10:58 | gibi | sean-k-mooney: yeah :) | |
| 14:12:00 | sean-k-mooney | the error is raised form here https://github.com/openstack/nova/blob/34c5df7b2b8c7eebbfc8aa0bc3edba501dddcb61/nova/network/neutron.py#L3396-L3398 | |
| 14:12:29 | sean-k-mooney | and it only happens if we have not claimed the pci device we are trying to update the neutron port with if i recall correctly | |
| 14:12:41 | stephenfin | My thinking was that there had been an unshelve on the host before that was using an old record, and the cold migrated instance was trying to use the same record | |
| 14:13:01 | sean-k-mooney | no that gives you a differnet error | |
| 14:13:06 | stephenfin | I'm trying to write a functional test to prove out that theory but have got stuck in the weeds | |
| 14:13:46 | sean-k-mooney | you get someting like libvirtError: Requested operation is not valid: PCI device 0000:5d:17.4 is in use by driver QEMU, domain instance-00003be0 | |
| 14:13:55 | sean-k-mooney | in that case e.g. a libvirt error | |
| 14:14:28 | stephenfin | Ah | |
| 14:16:10 | sean-k-mooney | im donwloadign the customer logs to take a quick look but i would suspect that the device its trying to use is unclaimed | |
| 14:16:46 | stephenfin | hmm, okay if you're looking at that I'll got back to the os-hypervisors work | |
| 14:17:50 | sean-k-mooney | im only going to look at it breifly but want to clarify a few things as peopel have mentioned rebuilds in it so i want to confirm what operation is actully happening | |
| 14:18:03 | sean-k-mooney | ill let you know if i find anything | |
| 14:18:56 | stephenfin | On that note, gibi: currently each entry in the 'hypervisors' field of the '/os-hypervisors/detail' response is identical to what '/os-hypervisors/{hypervisor}' returns. If I'm adding 'uptime' to the latter, I assume I should add it to the former also? | |
| 14:19:39 | stephenfin | as an aside, the whole '/os-hypervisors/detail' API is a bit weird and fairly "non-REST'ful" | |
| 14:19:57 | sean-k-mooney | /os-hypervisors/detail is the list endpoint | |
| 14:20:03 | sean-k-mooney | right | |
| 14:20:12 | sean-k-mooney | so i would expect it to be the same | |
| 14:20:18 | sean-k-mooney | well the detailed list endpoint | |
| 14:20:26 | sean-k-mooney | vs just /os-hypervisors | |
| 14:20:31 | stephenfin | Yeah, it's a variant of the list endpoint but with additional detail in each resource | |
| 14:20:38 | stephenfin | I'd expect it to be the same too | |
| 14:21:19 | sean-k-mooney | for me you are reall adding the uptime to the os-hyperviors resource | |
| 14:21:34 | sean-k-mooney | rather then just that specific endpoint | |
| 14:21:44 | sean-k-mooney | so showing it in detail makes sense | |
| 14:22:09 | sean-k-mooney | where as previously it was on the stats resouce | |
| 14:23:50 | stephenfin | makes sense | |
| 14:25:34 | sean-k-mooney | it is a migration by the way | |
| 14:25:40 | sean-k-mooney | not a rebuild | |