Posted	Nick	Remark
#openstack-nova - 2020-12-16
09:08:24	gibi	gmann: what do you mean by specific request body? how this is differ from the lock action?
09:08:36	gibi	brinzhang: no worries, we have gmann to help :)
09:08:56	gibi	(it is just the timezone differences that will make it hard to get a decisions)
09:09:26	brinzhang	gibi: and Isubmit a patch for update the description of unshleve az parameter https://review.opendev.org/c/openstack/nova/+/767251
09:28:51	elod	lyarwood if you have a minute: can you hit this one? >>> https://review.opendev.org/c/openstack/nova/+/766497 (bandit 1.7.0 is not yet yanked, so maybe it's worth to push the bandit cap fixes, too... though that's also not a quick fix...)
09:29:58	elod	the swift side has already merged
09:41:18	lyarwood	elod: ACK'd lets do this
09:53:09	bauzas	gibi: morning, saw your pings with brinzhang
09:54:13	gibi	lyarwood: about the lower contraint jobs, after elod summarized the situation to me as a nova PTL I think if we got blocked on the lower constraints jobs and we have no time to fix it then make it non-voting and ask the help of the deployers relying on that job to fix it
09:56:18	elod	and just an addition: lower-constraints jobs are (mostly) fixed, so this ^^^ is only valid for the future I think
09:56:59	elod	lyarwood: thx \o/
09:59:04	bauzas	does anyone know how to fix a blank page from Zuul with Firefox ?
09:59:10	bauzas	it does work fine with Chrome
09:59:20	bauzas	and I flushed cookes
09:59:22	bauzas	cookies*
10:00:15	gibi	bauzas: havn't seen that problem yet in my firefox
10:00:30	bauzas	that's weird
10:00:33	bauzas	I get the 200s
10:00:53	bauzas	but looks like javascript is blocked or something like this
10:01:13	bauzas	ah, gotcha
10:01:16	bauzas	got a console exception
10:01:23	bauzas	Exception { name: "NS_ERROR_FILE_CORRUPTED", message: "", result: 2152857611, filename: "https://zuul.opendev.org/static/js/main.a8854164.chunk.js"
10:02:14	bauzas	gibi: could you try refreshing your local cache ?
10:02:27	bauzas	anyhow, the gate looks busted
10:02:40	gibi	let me check in a private mode
10:03:01	bauzas	all the jobs are in "queued" state
10:03:42	gibi	bauzas: this openes for me in a private mode or in an empty firefox profile https://zuul.opendev.org/t/openstack/build/fce6478a6842495f851b8c88336f0049/log/compute1/logs/screen-c-vol.txt
10:04:15	bauzas	super weirdo
10:05:00	gibi	there are jobs running https://zuul.opendev.org/t/openstack/status
10:05:08	bauzas	gibi: could you please tell me which main.js version you have ?
10:05:11	gibi	but we have 155 check queu
10:05:19	bauzas	mine https://zuul.opendev.org/static/js/main.a8854164.chunk.js is failing
10:05:30	gibi	bauzas: on which page?
10:05:57	gibi	I have this https://zuul.opendev.org/static/js/main.67746290.chunk.js
10:06:27	bauzas	not the same version
10:06:41	gibi	I'm not even sure it is them same main
10:06:46	gibi	who knows
10:08:15	bauzas	gibi: this JS was loaded on https://zuul.opendev.org/t/openstack/build/fce6478a6842495f851b8c88336f0049/log/compute1/logs/screen-c-vol.txt
10:08:22	gibi	I have this as well https://zuul.opendev.org/static/js/main.a8854164.chunk.js
10:08:27	gibi	in another pag
10:08:28	gibi	e
10:08:37	bauzas	which FF version ?
10:08:53	bauzas	mine is 83.0
10:09:15	gibi	83.0 (64-bit)
10:09:18	bauzas	and the check pipeline is super late, indeed
10:09:20	bauzas	ergh
10:09:26	bauzas	i'm then confused
10:10:29	bauzas	ok, restarted FF and now it works...
10:10:33	bauzas	what the heck
10:10:37	bauzas	sorry for the noise
10:10:52	bauzas	anyway, as I said, zuul is slow this morning
10:11:16	bauzas	I sent https://review.opendev.org/c/openstack/nova/+/749068/ to gerrit yesterday, but no jobs run yet
10:25:24	openstackgerrit	Wenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/c/openstack/nova-specs/+/740184
11:32:59	sean-k-mooney	gmann: no i was suggest allowing explictly {} so null or empty dict
11:33:28	sean-k-mooney	allowing {} does not meant allowing anytihng
13:14:38	openstackgerrit	Merged openstack/nova stable/pike: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766497
13:18:51	openstackgerrit	Lance Bragstad proposed openstack/placement master: Bump oslo.log version to 4.3.0 https://review.opendev.org/c/openstack/placement/+/760229
13:18:52	openstackgerrit	Lance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly https://review.opendev.org/c/openstack/placement/+/766785
13:18:54	openstackgerrit	Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240
13:20:41	openstackgerrit	Andrew Bonney proposed openstack/nova master: Fix URL construction for 'nova-manage placement audit' https://review.opendev.org/c/openstack/nova/+/767348
13:27:11	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos https://review.opendev.org/c/openstack/nova/+/756895
13:28:40	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109
13:30:05	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110
13:31:32	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111
13:33:00	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614
13:34:26	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Support interface attach with qos ports https://review.opendev.org/c/openstack/nova/+/756530
13:37:42	openstackgerrit	Adit Sarfaty proposed openstack/nova master: Retry on vmware create_vm when it fails https://review.opendev.org/c/openstack/nova/+/764586
14:43:47	openstackgerrit	Elod Illes proposed openstack/nova stable/queens: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/767364
15:19:33	openstackgerrit	sean mooney proposed openstack/nova master: only wait for plugtime events in pre-live-migration https://review.opendev.org/c/openstack/nova/+/767368
15:22:16	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109
15:22:17	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110
15:23:46	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111
15:23:46	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614
15:26:35	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Support interface attach with qos ports https://review.opendev.org/c/openstack/nova/+/756530
15:29:23	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152
15:35:15	gibi	stephenfin: fixed your comments in the qos series
15:35:55	gibi	also I finished the main patch https://review.opendev.org/c/openstack/nova/+/756530
15:37:21	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Remove unused Instance method https://review.opendev.org/c/openstack/nova/+/757615
16:12:04	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Reproduce bug 1907522 in functional test https://review.opendev.org/c/openstack/nova/+/766791
16:12:04	openstack	bug 1907522 in OpenStack Compute (nova) "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host " [High,In progress] https://launchpad.net/bugs/1907522 - Assigned to Balazs Gibizer (balazs-gibizer)
16:13:26	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/766925
16:15:35	gibi	stephenfin: and fixued up this as well ^^
16:17:03	gmann	gibi: for specific budy I mean, rest of the action APIs like lock does not take any parameter in request body so they are allowed everything since legacy time. But in unshelve API, 2.77 version added AZ to be a valid param in request body so in this action API we said if user can pass AZ as valid param then let's allow null or AZ only and block everything else.
16:17:40	gibi	gmann: lock takes a lock_reason optionally similarly how unshelve takes AZ optionally
16:18:23	gibi	https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/lock_server.py
16:21:16	gmann	gibi: ah yeah, we have not added 'locked_reason' as required.
16:21:33	gibi	we not added AZ as required either
16:22:02	gmann	gibi: so we can pass anything in cok API like lock: {'unknown': 'unknown'}
16:22:10	gibi	no you cannot
16:22:16	gibi	as additionalProperties false
16:22:21	gmann	https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L31
16:22:24	gmann	here it is ^^
16:23:26	gmann	that required is specially to block the empty dict so that we can have more strict shcema.
16:23:36	gmann	let me check comments again if any other reason
16:23:44	gibi	gmann: but why we need more sticter schema?
16:24:13	gibi	the meaning of unshelve: {} and unshelve: null is the same from the impl perspective (except the schema)
16:24:42	gmann	gibi: schema main idea is to have a very strict checks so that user will only be able to pass the usable parameters and everything else will be 400
16:25:09	gibi	sure, I'm OK not to allow 'unknown':'unknown'
16:26:28	gibi	what I see that our API acceptr "<action>":{} and "<action>": null in mot of the cases but not for unshelve
16:29:46	openstackgerrit	Balazs Gibizer proposed openstack/nova master: stabilize unit test asserting log https://review.opendev.org/c/openstack/nova/+/764796

Earlier   Later