| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-12-14 | |||
| 17:45:34 | sean-k-mooney | so the have to retry them ocationally | |
| 17:48:38 | gibi | flaky is for nose a pytest :/ | |
| 17:51:58 | gibi | ok I don't think I can make it work without digging too deep into the internals of the untit test framework. So I | |
| 17:52:03 | gibi | So I stop here | |
| 17:52:36 | gibi | honestly I don't know what we can do with https://bugs.launchpad.net/nova/+bug/1823251 | |
| 17:52:36 | openstack | Launchpad bug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed] | |
| 17:53:28 | sean-k-mooney | gibi: what is it ment to be testing | |
| 17:53:40 | sean-k-mooney | gibi: e.g. shoud we just remove the test and be done with it | |
| 17:53:47 | gibi | db migrations as far as I understand | |
| 17:54:03 | sean-k-mooney | but what does walk version mean | |
| 17:54:32 | gibi | version by version do the db migrations | |
| 17:54:32 | sean-k-mooney | ah ok | |
| 17:54:42 | sean-k-mooney | do we need to do that for mysql? | |
| 17:54:47 | sean-k-mooney | is sqlight enough | |
| 17:54:53 | gibi | we do it for sqlite mysql and postgres | |
| 17:55:09 | sean-k-mooney | yep because fo the opertunistic testing code | |
| 17:55:19 | sean-k-mooney | but im wondering if we should exclude it form that | |
| 17:55:24 | gibi | I guess we added all these because we thought there are differences between the db engines regarding schema upgrade | |
| 17:55:45 | gibi | but I don't have historical context to say more | |
| 17:55:55 | sean-k-mooney | should that not be caught but the indivual upgrade check | |
| 17:56:10 | sean-k-mooney | https://github.com/openstack/nova/blob/7dcc4cfea7da2ef1163e0a65618cb784f5159c6d/nova/tests/unit/db/test_migrations.py#L253-L254 | |
| 17:56:15 | sean-k-mooney | is the one that fails right | |
| 17:57:08 | gibi | all the walk_versions can fail | |
| 17:57:20 | gibi | at least I saw failures both form the unit and the functional one | |
| 17:57:23 | sean-k-mooney | ah ok so its not jsut for mysql | |
| 17:57:34 | gibi | yes, the api_db is tested in the func env the cell db tested in the unit env | |
| 17:58:06 | gibi | now I'm not sure I see other than mysql failures | |
| 17:58:08 | sean-k-mooney | right but is it only with mysql backend that if fails or with any db backend | |
| 18:00:20 | gibi | the e-r query filters for mysql | |
| 18:00:41 | gibi | but I think I did not see non-mysql failures | |
| 18:01:20 | sean-k-mooney | ya i only recall mysql but that could just be my falut human memory | |
| 18:01:42 | sean-k-mooney | which was why i was ondering would running it with sqlithg only be an option | |
| 18:02:29 | gibi | the question is, do we lose test coverage? | |
| 18:04:48 | gibi | I guess I stop here today. see all tomorrow o/ | |
| 18:05:55 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/unit/db/test_migrations.py#L1062-L1128 | |
| 18:06:34 | sean-k-mooney | arguably yes but if it unrelayable its value is limited | |
| 18:06:51 | sean-k-mooney | maybe sqlacamy has a retry mechanium we can use | |
| 18:07:05 | sean-k-mooney | but ya enjoy your evning | |
| 18:11:43 | sean-k-mooney | gibi: this might be of interest https://review.opendev.org/c/openstack/manila/+/291397/ | |
| 18:16:30 | sean-k-mooney | gibi: it looks like we are getting a timeout exception | |
| 18:16:56 | sean-k-mooney | gibi: so adding the different timeout for this like manilla does mught be the path forward | |
| 18:39:09 | openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job for pyflakes, request version conflict https://review.opendev.org/c/openstack/placement/+/766994 | |
| 18:52:45 | openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job for pyflakes, request version conflict https://review.opendev.org/c/openstack/placement/+/766994 | |
| 20:05:14 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Bump oslo.log version to 4.3.0 https://review.opendev.org/c/openstack/placement/+/760229 | |
| 20:05:15 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly https://review.opendev.org/c/openstack/placement/+/766785 | |
| 20:05:16 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | |
| 20:33:23 | JamesBenson | sean-k-mooney: FWIW, I deployed ubuntu 18 with kernel: 5.4.0-58-lowlatency, worked just fine. :-) | |
| 20:37:46 | sean-k-mooney | thats good to hear. it appeared to be working when i did it but as i said i had fault ram so did not get to test it that way for long | |
| 20:39:05 | openstackgerrit | melanie witt proposed openstack/nova master: Initialize global data separately and run_once in WSGI app init https://review.opendev.org/c/openstack/nova/+/733627 | |
| 20:44:24 | JamesBenson | yeah, just did it, thought I would follow up with you. :-) Have a good one. | |
| 20:46:03 | JamesBenson | Haven't done any performance testing between the kernels though, so don't know if there is any benefit. My refstacks took the same amount of time though. | |
| 20:47:10 | sean-k-mooney | in thory if anything it should be slower but the performace should be more consitent espcially with regard to io latency | |
| 20:48:12 | JamesBenson | the lowlatency should be slower? | |
| 20:48:43 | sean-k-mooney | slower is too blunt | |
| 20:49:39 | sean-k-mooney | in theory the throughput of concurrent task may go down but the execution fo a singel item should complete faster | |
| 20:49:59 | sean-k-mooney | there is a trade of in general between latency and througput | |
| 20:50:14 | sean-k-mooney | bout shoudl get more consistent performace too | |
| 20:50:27 | JamesBenson | ah, I see. Interesting | |
| 20:51:19 | sean-k-mooney | if you are not hevialy over subsribing the host i think it would generally be an improvment | |
| 20:52:14 | JamesBenson | Thanks for the info, always more to learn and further dig into things :-) | |
| 20:52:52 | sean-k-mooney | yep i was couious about that too and its still on my todo list to dig into in more detail | |
| 21:22:08 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/c/openstack/nova/+/602432 | |
| 21:23:52 | sean-k-mooney | melwitt: ^ i have not had time to manually test that but i belvie that should resolve the grenade issues. | |
| 21:26:21 | openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job for pyflakes, request version conflict https://review.opendev.org/c/openstack/placement/+/766994 | |
| 21:31:41 | melwitt | sean-k-mooney: ack thanks for the heads up | |
| 21:32:47 | sean-k-mooney | i left some comments in gerrit basically to explain the code i added to do the fallback. we will see what grenade thinks when it runs | |
| 21:34:37 | sean-k-mooney | melwitt: i shoudl proably an addtional unit test or two also so ill proably respin it tomorrow but if there is anything else you think i shoudl add let me know. im going to call it a day there o/ | |
| 21:35:18 | melwitt | cool sean-k-mooney, will do. seeya later o/ | |
| 21:47:39 | jawad_axd | Hi! Can someone push me on this one, with newly added compute . I can see in 'openstack compute service list' but not in 'openstack hypervisor list'. This is nova-compute log http://paste.openstack.org/show/801032/ | |
| 21:50:42 | openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job for pyflakes, request version conflict https://review.opendev.org/c/openstack/placement/+/766994 | |
| 22:03:40 | openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job for pyflakes, request version conflict https://review.opendev.org/c/openstack/placement/+/766994 | |
| 22:39:12 | openstackgerrit | Ghanshyam proposed openstack/nova stable/rocky: DNM: testing gate https://review.opendev.org/c/openstack/nova/+/767027 | |
| #openstack-nova - 2020-12-15 | |||
| 00:24:25 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly https://review.opendev.org/c/openstack/placement/+/766785 | |
| 00:24:26 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | |
| 00:25:26 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | |
| 00:54:56 | openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job for pyflakes, request version conflict https://review.opendev.org/c/openstack/placement/+/766994 | |
| 00:55:16 | openstackgerrit | Wenping Song proposed openstack/nova master: Remove redundant code in instance delete https://review.opendev.org/c/openstack/nova/+/759577 | |
| 01:24:15 | gmann | gibi: melwitt lyarwood this fixes the placement gate (l-c job )- https://review.opendev.org/c/openstack/placement/+/766994 | |
| 01:25:05 | gmann | gibi: melwitt lyarwood I have moved it to latest hacking version which is easy than solving the old hacking + old pyflake compatible versions. | |
| 03:06:20 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | |
| 06:38:08 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | |
| 07:56:28 | gibi | sean-k-mooney: I do see that these test are slower then the others in the CI, but I don't see any timeout in nova. When it fails it fails from an exception from the db driver | |
| 08:25:28 | gibi | gmann: I've left comment in https://review.opendev.org/c/openstack/placement/+/766994 | |
| 08:37:02 | bauzas | good morning Nova | |
| 08:38:34 | hemanth_n | sean-k-mooney: hey regarding backports which we discussed yesterday, I am afraid it requires more patches to backport to ussuri. For now i found these 3 bfe7b7f3ee340012b3a9f1294ce86b07456ab206, 6c4d1a6aabb101466d2a2d05ed4c6240425b76b5, 0ab8a03c782851d4019c90e6159bd1f83c0658e6 and tests are failing still which implies more patches are needed (placement fixtures related ones are needed for sure). I want to take a pause and see if this is the | |
| 08:38:34 | hemanth_n | direction we want given lot many patches are required to make the patch i submitted clean cherrypick.. thoughts? | |
| 08:56:15 | bauzas | gmann: gibi: is https://review.opendev.org/c/openstack/placement/+/766994 helping the placement CI ? | |
| 08:56:55 | bauzas | we have a lof of open reviews from lbragstad about secure-rbac https://review.opendev.org/q/topic:%22secure-rbac%22+(status:open%20OR%20status:merged) , and I want to make sure that it would help | |
| 08:57:31 | bauzas | whoops, bad gerrit query https://review.opendev.org/q/topic:%2522secure-rbac%2522+(status:open+OR+status:merged)+project:openstack/placement | |
| 09:35:39 | openstackgerrit | Elod Illes proposed openstack/nova stable/pike: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766497 | |
| 10:37:25 | gibi | bauzas: regarding the rbac thing I need to rely on gmann but as far as I know we did similar things in nova in Victoria | |
| 10:37:43 | bauzas | yup for sure | |
| 10:37:46 | gibi | bauzas: regarding the lower constraint fix I that is needed to unblock the placement gate | |
| 10:37:49 | bauzas | let's wait for gmann's reply | |
| 10:57:11 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add requested_networks field to RequestSpec object https://review.opendev.org/c/openstack/nova/+/749977 | |
| 10:57:11 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | |
| 11:50:00 | gibi | does somebody already looked into the volume handling timeout happening fairly frequently on master in tempest? there is a long timeout (196s) that runs out in various volume handling operations | |
| 11:50:04 | gibi | e.g. detach | |
| 12:01:00 | lyarwood | gibi: I have not but I can if you point me at an example | |
| 12:01:18 | elod | lyarwood: I'm back from PTO and I can work with the 'make LC non-voting' patch if you need help with that | |