| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-12-10 | |||
| 14:30:39 | lyarwood | gibi: kk | |
| 14:30:46 | gibi | lyarwood: then I will try to reenable the gate with https://review.opendev.org/c/openstack/nova/+/766474 | |
| 14:31:38 | gibi | regarding https://review.opendev.org/c/openstack/nova/+/766364/ I have to figure out if we need this to avoid leaking something instead of clearly rolling back the migration | |
| 14:40:09 | gmann | brinzhang: ah that is good question, I do not think we need to do any improvement on deprecated APIs. We have not done any update on deprecated API in past too. policy changes were on policy side only so we thought of keeping consistency. But I will discuss it in today meeting to get more opinion. | |
| 14:41:50 | elod | lyarwood: btw, if you are busy, I can do the bandit backports till pike | |
| 14:42:17 | elod | just let me know :) | |
| 14:44:10 | lyarwood | elod: if you have time then please go ahead and I can review | |
| 14:44:42 | gmann | brinzhang: but server sec group is not deprecated API -https://docs.openstack.org/api-ref/compute/?expanded=list-security-groups-by-server-detail#servers-security-groups-servers-os-security-groups | |
| 14:45:10 | elod | lyarwood: ok, doing it now | |
| 14:45:52 | gmann | brinzhang: ah just saw that we did mention about not to change deprecated APIs for tenant-id - https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/remove-tenant-id.html | |
| 14:46:24 | gmann | brinzhang: so we are good on that and let's target only non-deprecated APIs only | |
| 14:49:12 | gmann | brinzhang: also our all deprecated APIs are capped with corresponding microversion and they are 404 for higher than deprecated microversion so technically we cannot do any change in those API which include the microversion bump. | |
| 14:49:55 | openstackgerrit | Illes Elod proposed openstack/nova stable/stein: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766487 | |
| 15:00:52 | openstackgerrit | Illes Elod proposed openstack/nova stable/stein: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766487 | |
| 15:03:47 | openstackgerrit | Illes Elod proposed openstack/nova stable/rocky: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766492 | |
| 15:11:14 | lyarwood | elod: Bernard just replied on the ML about the cross project issue with the bandit cap | |
| 15:11:32 | lyarwood | elod: and thinking about it more an overall cap in requirements might be the only way to unblock things here | |
| 15:11:49 | lyarwood | elod: but landing from stable/pike as you suggested for the project specific changes | |
| 15:11:56 | lyarwood | elod: so grenade works etc | |
| 15:12:53 | lyarwood | `ERROR Failed to update project None in 3s` oh cool a new zuul error | |
| 15:13:29 | openstackgerrit | Illes Elod proposed openstack/nova stable/pike: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766497 | |
| 15:14:30 | lyarwood | https://github.com/PyCQA/bandit/issues/663 that said it looks like they might yank 1.6.3 after all | |
| 15:23:53 | gibi | lyarwood: this is not the first time I saw that zuul ERROR | |
| 15:24:09 | gibi | lyarwood: at the previous time it was around a gerrit restart so I assmue that caused it | |
| 15:24:33 | lyarwood | ah kk | |
| 15:24:54 | bauzas | ergh, call me stupid | |
| 15:25:00 | bauzas | requested_networks can be None | |
| 15:26:39 | gibi | lyarwood: pinged infra about it | |
| 15:28:00 | lyarwood | gibi: ah thanks, I was just going to recheck tbh | |
| 15:28:10 | gibi | lyarwood: sure, | |
| 15:29:27 | gibi | lyarwood: infra increased some git cloning timeouts in the zuul executors | |
| 15:29:32 | gibi | recently | |
| 15:30:22 | gibi | they expect that it helps | |
| 15:35:09 | elod | lyarwood: if they would yank bandit 1.6.3 that would be the best :) | |
| 15:35:53 | elod | lyarwood: until that, let's see if we can merge the bandit cap patches, as it might take some time | |
| 15:36:06 | lyarwood | elod: ack lets keep trying | |
| 15:36:27 | lyarwood | elod: I'm just worried that we will need to land multiple caps across multiple projects to allow the gate to work again | |
| 15:37:08 | elod | lyarwood: yes, that's possible :S | |
| 17:00:12 | gibi | lyarwood, melwitt: I rechecked https://review.opendev.org/c/openstack/nova/+/766471 (master unblock patch) as it bounced due to zuul " ERROR Failed to update project None in" | |
| 17:01:07 | gibi | I have to leave in ~15 minutes so I hope melwitt can take over rechecking it if needed | |
| 17:12:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM https://review.opendev.org/c/openstack/nova/+/766509 | |
| 17:13:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/victoria: DNM https://review.opendev.org/c/openstack/nova/+/766511 | |
| 17:15:42 | lyarwood | gibi: ack thanks I'll also be around for a while to recheck when required | |
| 17:16:04 | gibi | lyarwood: thanks I will check back too before I go to sleep but now dinner time | |
| 17:16:07 | gibi | o/ | |
| 17:17:32 | gibi | lyarwood: ahh, it is already got errors from zuul on https://zuul.opendev.org/t/openstack/status | |
| 17:17:39 | gibi | :/ | |
| 17:17:54 | gibi | so I think we have to wait for infra | |
| 17:22:23 | lyarwood | ack np enjoy dinner \o | |
| 17:29:20 | bauzas | sean-k-mooney: around ? | |
| 17:29:38 | bauzas | sean-k-mooney: I found why my functest is not working, I need to mock the neutron extension for segments | |
| 17:30:24 | sean-k-mooney | bauzas: ah yes you do | |
| 17:30:40 | sean-k-mooney | i think i have an example of that | |
| 17:30:58 | sean-k-mooney | in one of teh regression test i wrote | |
| 17:32:13 | sean-k-mooney | bauzas: https://github.com/openstack/nova/commit/71bc6fc9b89535679252ffe5a737eddad60e4102#diff-4763b3c03cb51e2efd60e19a11af59d4bfb76fbca93c953dfd9201eb5187ee88 | |
| 17:33:11 | sean-k-mooney | bauzas: you can just do https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1888395.py#L38-L55 | |
| 17:33:54 | sean-k-mooney | bauzas: you could also update the fixture | |
| 17:34:18 | sean-k-mooney | bauzas: but im not sure we want it there by default | |
| 17:35:14 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1891-L1905 | |
| 17:35:43 | sean-k-mooney | personally i would not add it there since most deployment wont have it and just add it in your test class | |
| 17:35:56 | bauzas | ack thanks | |
| 17:36:14 | bauzas | sorry I had to drop because of an Amazon delivery for my new headset \o/ | |
| 17:36:25 | sean-k-mooney | oh nice | |
| 17:38:15 | JamesBenson | sean-k-mooney: originally I had tried `custom` and posted `cpu_models = nehalem,westmere` & `cpu_model_extra_flags = pcid, vmx, pdpe1gb` but then I couldn't boot up VM's. Those three flags are the ones of interest, but aren't in both models. I thought that the way mentioned above was the right way, but couldn't get it working. Maybe the flags need to be there for all of them? | |
| 17:45:18 | sean-k-mooney | JamesBenson: that should be valid | |
| 17:45:29 | sean-k-mooney | pdep1GB is for 1G hugepages | |
| 17:45:49 | sean-k-mooney | nehalem does not actully support that if i remeber correctly | |
| 17:46:01 | sean-k-mooney | you need host supprot to use it | |
| 17:46:06 | JamesBenson | correct, nehalem doesn't support any of those three. | |
| 17:46:15 | JamesBenson | but westmere does | |
| 17:46:19 | sean-k-mooney | wel it support vmx | |
| 17:46:34 | sean-k-mooney | not in the model defieniotn but in the cpu | |
| 17:47:02 | sean-k-mooney | wehn using multiple models the flags must be valid for all models in the list | |
| 17:47:59 | sean-k-mooney | on your westmer host that should work | |
| 17:48:01 | JamesBenson | ah, okay, so that's the trick then. And just verifying, to check for the flags, I just issued `cat /proc/cpuinfo` | |
| 17:48:07 | sean-k-mooney | but on your nehalem host it will fail | |
| 17:48:24 | JamesBenson | let me double check the flags on my hosts. | |
| 17:48:27 | sean-k-mooney | yep cat /proc/cpuinfo or use lscpu | |
| 17:49:05 | sean-k-mooney | for vmx you need to enable nested virt too in the hosts kernel | |
| 17:50:08 | JamesBenson | okay, yeah only vmx on the nehalem, westmere has all three. | |
| 17:50:16 | sean-k-mooney | cat /sys/module/kvm_intel/parameters/nested | |
| 17:50:18 | sean-k-mooney | Y | |
| 17:50:34 | JamesBenson | just change that to Y? | |
| 17:50:44 | sean-k-mooney | Y or 1 | |
| 17:51:18 | sean-k-mooney | that is showing the current nested virt status | |
| 17:51:25 | sean-k-mooney | if that is N or 0 then you dont have it enabled | |
| 17:51:57 | JamesBenson | okay, cool. So which is better: cpu_models = nehalem,westmere with the vmx flag or host-model? Or should I get a list of flags that are on both and put all of the flags in there? | |
| 17:52:11 | JamesBenson | It is an `N` | |
| 17:52:31 | JamesBenson | Thanks for the help & insight be the way. Super helpful :-) | |
| 17:52:34 | sean-k-mooney | ya so you need to drop a file into /etc/modeprobe.d | |
| 17:53:41 | sean-k-mooney | what i would do is as follows | |
| 17:54:20 | sean-k-mooney | on the nehelm host set cpu_models = nehalem and cpu_model_extra_flags = vmx | |
| 17:54:53 | sean-k-mooney | on the westmear host do cpu_model_extra_flags = pcid, vmx, pdpe1gb cpu_models = nehalem,westmere | |
| 17:55:22 | sean-k-mooney | in the flavor then add a required trait for pdep1gb on flavor that use 1G hugepages | |
| 17:56:12 | sean-k-mooney | JamesBenson: the feature flags are reported as traits to placement so you can express what you need in both the flavor and image | |
| 17:56:22 | JamesBenson | okay. Is this the recommended path for mixed architectures to get the most out of them? | |
| 17:56:38 | JamesBenson | great, we have windows VM's so that's what I'm hoping to speed up with using those flags. | |
| 17:57:55 | sean-k-mooney | normaly you would use something like host aggreates. PCID should acclerate gust where you have mitigation enabled somewhat | |
| 17:58:32 | sean-k-mooney | vmx is only useful if those windows instnace have hyperv or are using docker with linux instance | |
| 17:59:18 | sean-k-mooney | on host without pdep1gb you can still use 2MB hugepages | |