Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-12-09
18:59:41 sean-k-mooney our inablity to use one of the mock decortors is due to mock the lib vs unittest.mock
19:00:12 stephenfin sean-k-mooney: my understanding of that was that it was also an issue in the Python 3.9 unittest.mock implementation
19:00:19 sean-k-mooney i think its teh use of assert raises as a context manager actully
19:00:38 stephenfin I can root out the bug report in the morning (dinner time here)
19:01:27 stephenfin melwitt: I think that might be a wiser approach, but I'm not the only one with a say here. It just seems foolish to have to work around bugs with e.g. unittest.mock on Python 3.6 when mock 3.x+ doesn't have them
19:03:12 melwitt stephenfin: no I think what you're saying makes sense, I think that would be a simpler way to address this
19:03:41 sean-k-mooney stephenfin: https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises
19:03:45 melwitt I can put that together
19:03:53 sean-k-mooney with self.assertRaises(SomeException) as cm:
19:03:55 sean-k-mooney do_something()
19:04:03 sean-k-mooney stephenfin: that does not work with mock the lib
19:04:13 sean-k-mooney or at least it did not work in the past
19:05:28 sean-k-mooney perhaps its actully caused by soemthing else but that is what we belived it was blocking that form working in nova the last time we investigated
21:57:13 JamesBenson Hi all, I've modified my nova.conf with `cpu_mode = host-model` in a mixed CPU environment, but not all of my CPU flags passed through. What else am I missing?
23:40:18 openstackgerrit melanie witt proposed openstack/nova stable/victoria: WIP [stable-only] Target cell for min bw migration service lookup https://review.opendev.org/c/openstack/nova/+/766364
23:42:36 sean-k-mooney JamesBenson: host model will not pass all the flags
23:43:27 sean-k-mooney JamesBenson: some cpu flags are not virtualisable but the real reason is host model chose the clost model to you actual cpu listed in qemus/libvirts cpu model xml file
23:44:06 sean-k-mooney those models are ment to represent the common set of flag commen to a specific generation of a cpu not the specific sku
23:44:31 sean-k-mooney so if you cpu has feature that are not avaiable on other cpus in the same generation those feature flags likely wont be present
#openstack-nova - 2020-12-10
00:45:29 openstackgerrit Wenping Song proposed openstack/nova master: Remove redundant code in instance delete https://review.opendev.org/c/openstack/nova/+/759577
02:17:02 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380
02:29:39 brinzhang gmann: hi, I have a question with remove tenant_id
02:30:15 brinzhang gmann: the Servers Security Groups API, just need to change this apihttps://docs.openstack.org/api-ref/compute/?expanded=list-security-groups-by-server-detail#servers-security-groups-servers-os-security-groups
02:31:15 brinzhang but it will be impact the deprecated apis, https://docs.openstack.org/api-ref/compute/?expanded=list-security-groups-by-server-detail#security-groups-os-security-groups-deprecated
02:31:41 brinzhang does it need to be consider to change the deprecated apis?
02:32:23 brinzhang I saw the refresh policies changed the deprecated APIs too
03:34:52 JamesBenson sean-k-mooney: originally I had tried `custom` and posted `cpu_models = nehalem,westmere` & `cpu_model_extra_flags = pcid, vmx, pdpe1gb` but then I couldn't boot up VM's. Those three flags are the ones of interest, but aren't in both models.
03:36:03 JamesBenson sean-k-mooney: I thought that the way mentioned above was the right way, but couldn't get it working. Maybe the flags need to be there for all of them?
07:53:18 openstackgerrit Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336
08:12:17 openstackgerrit Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336
08:19:48 openstackgerrit Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336
08:38:21 bauzas good morning Nova
08:44:36 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380
09:34:59 gibi melwitt: hi
09:35:13 melwitt gibi: hi
09:35:29 gibi melwitt: I saw your comment about the chicken-egg
09:36:19 melwitt I figured :) I'm tired so I might be wrong but afaict it is chicken and egg
09:36:20 gibi melwitt: I guess we need to pull the fixes top of each other and then ask infra to promote
09:36:57 gibi melwitt: I will add a unit test coverage for your qos fix during my day (I assume you will go to sleep soon)
09:37:05 melwitt yeah, either that or disable the min bw tempest tests to let the lower-constraints change through and then re-enable it
09:37:22 lyarwood ah right I was going to ask about the bw failures in nova-next
09:37:26 brinzhang gibi, dansmith: could you please review cyborg shelve/unshelve patch again https://review.opendev.org/c/openstack/nova/+/729563 ? thanks
09:37:38 lyarwood brinzhang: dansmith is out until 2021 FYI
09:38:16 melwitt gibi: cool yes that would be appreciated, I am going to sleep soon. also I didn't find anything as to the cause for the failure on the master branch with the port binding failure too so that one needs eyes on it too
09:39:04 brinzhang lyarwood: ack, a shocking news, dansmith will work to k8s?
09:39:55 melwitt gibi: for my patch I had been thinking to add resource requests to one of the nova/tests/functional/cross_cell_migrate.py but it would take me a bit to learn how to incorporate that
09:39:58 lyarwood brinzhang: umm not that I'm aware of, he's just out on PTO until the new year.
09:40:14 melwitt *test_cross_cell_migrate.py
09:41:11 melwitt maybe that would be overkill anyway, I dunno
09:41:23 gibi melwitt: I think this upgrade check that breaks in stable is removed from master
09:41:45 melwitt gibi: it is but it's failing in a different way for the master branch
09:41:46 brinzhang lyarwood: yeah, I like that job too^, thanks
09:41:56 gibi melwitt: ohh, then I will check that too
09:42:31 melwitt gibi: here's my ML post with links to more info http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019319.html
09:43:56 melwitt lajoskatona is looking at the neutron side but I doubt it's neutron. it's just that when we request the port binding it results in neutron getting UnknownResourceProvider, I have no idea how that can happen
09:53:56 gibi melwitt: sorry I was pulled in a downstream call
09:54:02 gibi I will pick up the threads after it
09:54:16 melwitt thanks gibi++
09:54:19 melwitt o/
09:54:23 gibi melwitt: have a nice evening
10:00:17 stephenfin sean-k-mooney: The issue with https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises is nothing to do with mock the lib
10:00:26 stephenfin sean-k-mooney: that happens because of testtools
10:01:10 stephenfin sean-k-mooney: https://github.com/testing-cabal/testtools/issues/113 https://github.com/testing-cabal/testtools/issues/275
10:02:26 gibi lyarwood: regarding qos stable failures: other than the the packaging 20.4 bump and the qos break, is there any other know break on stable/victoria at the moment?
10:04:09 lyarwood gibi: not on stable/victoria that I'm aware of
10:04:19 lyarwood gibi: <= stable/train has other issues
10:07:36 brinzhang hi all, the nova-multi-cell task always failed, is there a bug tracing?
10:07:47 brinzhang https://8881082f52814b33cb4d-7716d10619577c42ab1386a760b8bb5c.ssl.cf2.rackcdn.com/764292/8/check/nova-multi-cell/9429107/testr_results.html
10:10:41 gibi lyarwood: ack, I saw the bandit affecting train and older
10:10:56 gibi brinzhang: yes, the nova-cell-multi is broken right now
10:11:08 gibi brinzhang: I have to look at it after my current call
10:11:24 gibi brinzhang: here is melwitt's post about it from the mL http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019319.html
10:11:24 brinzhang gibi: ack
10:12:51 brinzhang gibi: I saw your talking about above, sorry to mention again
10:13:19 lyarwood gibi: ack kk, we could switch both jobs to NV and then land things?
10:16:41 gibi lyarwood: both job is nova specific? then yes. NV->fix1->fix2->revert NV could be a solution
10:17:39 gibi lyarwood: sorry I have to be off for an hour or so
10:19:05 lyarwood gibi: np
10:19:15 lyarwood gibi: pushing now, I'll ask elod and others to review
10:19:45 lyarwood git-review really takes a while now
10:20:02 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: lower-constraints: Bump packaging to 20.4 https://review.opendev.org/c/openstack/nova/+/765749
10:20:03 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: zuul: Temporarily make nova-multi-cell non-voting https://review.opendev.org/c/openstack/nova/+/766440
10:20:45 lyarwood oh lyarwood--
10:24:19 openstackgerrit MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova/+/750552
10:25:29 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: [stable-only] Temporarily make nova-multi-cell non-voting https://review.opendev.org/c/openstack/nova/+/766440
10:25:30 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: lower-constraints: Bump packaging to 20.4 https://review.opendev.org/c/openstack/nova/+/765749
10:34:44 lyarwood elod / bauzas ^ would you mind taking a look at the above stable changes
10:35:16 elod lyarwood: sure, looking
10:37:24 melwitt gibi: one last update before I really go, I can see on zuul status that my stable/victoria change minbw tests have failed still but now for a different reason. the logs are not yet available but I suspect that now that the cell is correctly targeted, it's now hitting the same bug that exists on the master branch. just fyi
10:38:00 lyarwood can someone kick melwitt so she can get some sleep?
10:38:05 lyarwood :)
10:38:08 melwitt D:
10:38:15 lyarwood only joking
10:38:23 lyarwood but seriously get some sleep :D
10:38:38 melwitt I know, that was my OMG I CANT BELIEVE YOU SAID THAT look
10:38:44 melwitt :)
10:39:38 melwitt ok, gnight for reals
10:39:47 lyarwood hehe twas a good one :)
10:39:54 lyarwood \o
10:48:41 elod lyarwood: will the two patch work separately? Don't they need to be squashed to fix every issue? (or will the .zuul.yaml change only run limited tests that could pass? O.o)

Earlier   Later