Earlier  
Posted Nick Remark
#openstack-nova - 2020-12-01
13:26:53 lyarwood and stephenfin
13:27:35 gibi lyarwood: you are welcome. this is a review day so I'm going through the whole open spec list (I started my work day a bit late today)
14:13:14 sean-k-mooney gibi: i review the smart nic spec so +1 form me. some minor nits but they could adress with a FUP if we cared later
14:14:11 gibi sean-k-mooney: thanks. I do need some acknowledgement from neutron too
14:16:14 sean-k-mooney ya although i think the only real depency there are teh api extention which i would expect to be tracked on the neutron side and the vnic type.
14:16:50 sean-k-mooney i assume they have both been filed as an rfe bug at the minium for them to review but good to get them to sign off on that before we approve the nova spec
14:18:41 gibi i don't know if neutron rfe exists for this
14:19:14 sean-k-mooney if it was nova the api extenion would require a spec on there side but i know they try to avoid requiring specs
14:19:27 sean-k-mooney ti would need a least a blueprint and rfe bug
14:20:18 sean-k-mooney ther process is to file an rfe bug which the driver team will review and determin if it need a bluepritn or spec or if it can continue as an rfe bug
14:24:35 openstackgerrit Lee Yarwood proposed openstack/nova-specs master: libvirt: Store and allow the default machine type to be changed https://review.opendev.org/c/openstack/nova-specs/+/762199
14:28:02 sean-k-mooney gibi: just brought this up on the neuton channel ralonsoh will bring it up in there drivers meeting on friday
14:28:11 gibi sean-k-mooney: cool
14:28:12 gibi thanks
14:33:28 ralonsoh gibi, sean-k-mooney https://wiki.openstack.org/wiki/Meetings/NeutronDrivers#Agenda
14:33:40 ralonsoh I'll propose it this friday, 1400UTC
14:33:41 gibi ralonsoh: thanks
14:34:26 gibi xinranwang: FYI ^^
14:36:35 gibi I'm done with the first round on the open specs. Will re-review the updated once
14:38:00 sean-k-mooney gibi: im goign to try and write the two spec for the vdpa support and neutron port numa affintiy today just an fyi
14:38:16 gibi sean-k-mooney: ack, no worries M1 is not spec freeze
14:38:52 sean-k-mooney ya i just want to see if i can get the specs out an hopefully poc level code up before i go on vacation in a few weeks
14:39:22 openstackgerrit Lee Yarwood proposed openstack/nova-specs master: Image and flavor defined ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/752284
14:40:14 sean-k-mooney ill be around until the 18th by the way then back on the 4th
14:42:22 gibi sean-k-mooney: I have very similar vacation plans
14:52:35 bauzas sean-k-mooney: gibi: related to this, I'll be off tomorrow for my birthday and I should be off for two weeks after Dec 20th
14:52:49 bauzas like sean-k-mooney
14:53:12 sean-k-mooney bauzas: oh well happy birthday in advance
14:54:19 bauzas well, 40
14:54:33 gibi bauzas: ohh, nice number happy cake day for tomorrow
14:54:48 bauzas and still be in lockdown and not being able to ski by the end of this year :( :( :(
14:55:25 bauzas so, honestly, I'd prefer to stay at 39 and just wait until 2021
14:56:06 sean-k-mooney i was going to ask it it was a big one but didnt want to be wrong :) congrats but ya it suck with the current restriction but hopfully you will still enjoy it and celeberate in the new year
14:56:23 sean-k-mooney bauzas: wanting to stay at 39 i think is a normal thing :P
14:56:35 bauzas :)
14:57:21 bauzas I'm OK with being at 40 or more if I can skiing and doing some gym
14:57:30 bauzas for the moment, I can't do both
14:57:37 gibi lyarwood: I have only one open thing in the machine_type spec https://review.opendev.org/c/openstack/nova-specs/+/762199
14:58:04 bauzas interesting, can't see https://review.opendev.org/c/openstack/nova-specs/+/762199 in my nova-specs dashboard
14:58:10 gibi bauzas: sorry for the lockdown
14:58:49 bauzas any reason why shorturl.at/ltFM1 can't see https://review.opendev.org/c/openstack/nova-specs/+/762199 ?
14:58:53 bauzas shit
14:59:01 bauzas http://shorturl.at/ltFM1
15:00:31 gibi bauzas: I heard from others that old dashboard does not work with the new gerrit but I don't have first hand experience
15:01:04 bauzas anyway, I think I found a way to see the specs
15:01:54 bauzas https://review.opendev.org/q/project:openstack/nova-specs+is:open+NOT+reviewer:self+NOT+label:Workflow%253C%253D-1+label:Verified%253E%253D1%252Czuul
15:15:13 openstackgerrit Merged openstack/nova-specs master: Add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova-specs/+/760750
15:26:08 stephenfin bauzas: if you're not reviewing a spec atm, could you look at these logging improvements? https://review.opendev.org/q/topic:%2522bug/1852727%2522+status:open
15:29:54 sean-k-mooney stephenfin: quick question what the note sysntax in sphinx ":: note:" ?
15:30:07 stephenfin .. note::
15:30:08 sean-k-mooney or .. note::
15:30:16 sean-k-mooney cool thanks
15:30:41 sean-k-mooney ya that syntax highlight correctly too
15:33:27 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: check for AMD SEV only on x86-64 https://review.opendev.org/c/openstack/nova/+/714425
15:56:44 gibi lyarwood: updated https://bugs.launchpad.net/nova/+bug/1905701 to inprogress (the gerrit - launchpad integration doesnt work) please put it to fix released once https://review.opendev.org/c/openstack/nova/+/764246 merges
15:56:44 openstack Launchpad bug 1905701 in OpenStack Compute (nova) "Do not recreate libvirt secret when one already exists on the host during a host reboot" [Medium,In progress] - Assigned to Lee Yarwood (lyarwood)
16:00:32 lyarwood gibi: oh my bad, I forgot that the gerrit upgrade broke automagic LP updates
16:01:22 gibi no worries, I look at the untriaged bug list time to time so I detect it. But once I put it in inprogress I loose it from my radar
16:30:57 gibi teoobo_: hi!
16:31:24 gibi teoobo_: so I understand that you would liket to work on https://bugs.launchpad.net/nova/+bug/1751784
16:31:24 openstack Launchpad bug 1751784 in OpenStack Compute (nova) "Add more LOG.debug in nova.virt.hardware" [Wishlist,Confirmed] - Assigned to Matteo Sposato (teoobo)
16:31:30 teoobo_ Hello everybody!
16:32:24 gibi teoobo_: first I suggest to check if the logging problem still exists
16:32:35 gibi as it is an old bug
16:32:57 sean-k-mooney the main problem is we dont wnat to log a lot during normal filtering
16:33:19 teoobo_ I have searched for low-hanging-fruit
16:33:22 sean-k-mooney the hardware module code is common between both the virt driver and the numa toplogy filter
16:35:04 sean-k-mooney gibi: teoobo_ the loggin can definetly be imporved but we need a blance between verbosity and usefull ness
16:35:18 teoobo_ Thanks for the advice! I will check this in devstack
16:35:20 sean-k-mooney we have some operator that run debug loggign in production permently
16:35:52 gibi sean-k-mooney: I agree, we can start with only logging for obvious run-out-of-resource cases
16:36:38 sean-k-mooney we might want to log some info at info level too. we log very little at info
16:36:46 gibi teoobo_: good idea to look at the logs in a devstack, try to make some seduling that have to fail and see if the log gives enough info what part of the resource request was impossible to fulfill
16:37:33 gibi sean-k-mooney: yeah, if there is too much on debug but noting on info then we can try to re-balance that too
16:38:24 sean-k-mooney gibi: i think that is part of the probelm but even with debug some of the filtering functon dont log at all i think
16:38:42 sean-k-mooney its been a while since i looked at the logging specificlaly
16:39:15 sean-k-mooney i do know that the info level logs are basically useless for debuging why the numatoplogy filter filtered out all hosts
16:40:47 gibi sean-k-mooney: teoobo_ is a new to nova (pinged me privately first) so teoobo_ might need exta guidance but I think this is a good problem to work on
16:41:25 gibi teoobo_: feel free to ping me here in the channel if you need help (I work in UTC+1 time zone)
16:46:00 stephenfin bauzas: thanks for the reviews :)
16:46:20 bauzas np, those changes were needed
16:46:56 bauzas and I'm still a foolish young boy that can do things without thinking about the consequences
16:47:09 bauzas Thursday, just a word : NO!
16:48:05 bauzas just ask me anything, I'm about to make stupid things
16:57:53 openstackgerrit Lee Yarwood proposed openstack/nova-specs master: Image and flavor defined ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/752284
17:11:29 lyarwood has anyone raised a bug about https://zuul.opendev.org/t/openstack/build/13400ea7d7af4dd88fca244b82301c79/log/job-output.txt#65297 yet?
17:12:22 lyarwood test_cold_migrate_unshelved_instance raising cat: can't open '/mnt/timestamp': No such file or directory
17:12:34 lyarwood https://zuul.opendev.org/t/openstack/builds?job_name=nova-multi-cell&branch=master looks pretty broken as a result
17:13:56 stephenfin nope, I saw it this morning but thought it was intermittent
17:14:00 stephenfin I can raise one if you haven't
17:15:51 lyarwood no issues, I'll do it now
17:21:05 lyarwood stephenfin: https://bugs.launchpad.net/tempest/+bug/1906428
17:21:05 openstack Launchpad bug 1906428 in tempest "test_cold_migrate_unshelved_instance failing with cat: can't open '/mnt/timestamp': No such file or directory" [Undecided,New]
18:10:04 openstackgerrit Merged openstack/nova master: remove python warnning from tox https://review.opendev.org/c/openstack/nova/+/752190
19:14:15 sean-k-mooney bauzas: gibi stephenfin by the way now that provider.yaml is a thing we shoudl update https://docs.openstack.org/nova/latest/admin/virtual-gpu.html#optional-provide-custom-traits-for-multiple-gpu-types to descibe how to use that to add teh traits tor the PGPU RPs
20:00:45 openstackgerrit sean mooney proposed openstack/nova-specs master: libvirt: support vdpa kernel networking https://review.opendev.org/c/openstack/nova-specs/+/764999
23:53:08 openstackgerrit Merged openstack/nova stable/train: Change default num_retries for glance to 3 https://review.opendev.org/c/openstack/nova/+/762610
23:53:26 openstackgerrit Merged openstack/nova stable/victoria: Fix a hacking test https://review.opendev.org/c/openstack/nova/+/758112
#openstack-nova - 2020-12-02
00:23:24 openstackgerrit Keigo Noha proposed openstack/nova stable/stein: Change default num_retries for glance to 3 https://review.opendev.org/c/openstack/nova/+/764963
01:18:49 openstackgerrit Jorhson Deng proposed openstack/nova-specs master: Remove RPC call to ensure volume attachment successful https://review.opendev.org/c/openstack/nova-specs/+/758920

Earlier   Later