| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-11-20 | |||
| 12:41:46 | sean-k-mooney | but i did not like there add a libvirt secret thing | |
| 12:41:57 | lyarwood | https://github.com/openstack/cinder/blob/30501b9ecd6d4ed8dd6405be01795d8634013b24/cinder/volume/drivers/rbd.py#L1438-L1453 | |
| 12:41:57 | sean-k-mooney | that was the hack in my view | |
| 12:42:02 | lyarwood | https://github.com/openstack/nova/blob/e16800cc0aebf1174c5c0b6c4b043b09622524e9/nova/virt/libvirt/volume/net.py#L37-L76 | |
| 12:42:09 | lyarwood | you can have multiple secrets | |
| 12:42:24 | lyarwood | as long as the UUIDs are copied on the computes | |
| 12:42:27 | admin0 | the cinder part is good .. cinder can create volumes in both ceph .. only part is nova works with its default one and has no idea/clue about 2nd one | |
| 12:42:53 | sean-k-mooney | ya so they were manually defineing the second secret on the compute nodes | |
| 12:43:20 | lyarwood | that's fine | |
| 12:43:31 | lyarwood | admin0: apologies so I forgot about https://github.com/openstack/nova/blob/e16800cc0aebf1174c5c0b6c4b043b09622524e9/nova/virt/libvirt/volume/net.py#L37-L76 | |
| 12:43:56 | lyarwood | admin0: so c-vol needs to return connection_info with {"auth_enabled": True} | |
| 12:45:29 | sean-k-mooney | is that enough or will you need to maulaly add the persistint key first. i think that would be required yes? | |
| 12:45:41 | sean-k-mooney | that a one time operation on all the compute nodes | |
| 12:46:18 | lyarwood | sean-k-mooney: correct you still need to populate the secret on the computes | |
| 12:46:28 | lyarwood | admin0: and thinking about it that's what you have likely missed here | |
| 12:46:47 | lyarwood | admin0: you need two ceph secrets in libvirt per compute with these two clusters | |
| 12:47:36 | sean-k-mooney | this fells like something that could be imporved with a specless blueprint to allow the config options to have multiple vlaues | |
| 12:48:26 | lyarwood | sean-k-mooney: I'd rather drop the use of the config here and just rely on cinder | |
| 12:48:29 | lyarwood | sean-k-mooney: for volumes | |
| 12:49:07 | sean-k-mooney | well the config options were for the images_backend really | |
| 12:49:17 | sean-k-mooney | but i ment for createing the secret in libvirt | |
| 12:49:39 | sean-k-mooney | i guess we coudl drop that and make it just a deployment step | |
| 12:49:42 | stephenfin | lyarwood: Could you create a bug report for https://review.opendev.org/#/c/761730/ if you're planning to backport it? If you're not, I'll approve now | |
| 12:51:22 | lyarwood | stephenfin: yup can do | |
| 12:51:51 | lyarwood | sean-k-mooney: we can't automate that so it's always going to be a deployment step | |
| 12:52:15 | lyarwood | brb | |
| 12:53:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prevent nova-compute start with DB credentials https://review.opendev.org/762176 | |
| 12:57:48 | admin0 | This uuid must be different than any existing uuid’s used by cinder/libvirt -- so i just generate a new uuid on the fly ? | |
| 12:58:19 | lyarwood | yeah it just needs to be the same across both the computes and host where cinder is running | |
| 12:58:45 | lyarwood | just use uuidgen | |
| 13:02:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prevent nova-compute start with DB credentials https://review.opendev.org/762176 | |
| 13:03:03 | admin0 | lyarwood, this is what i have in cinder.conf -- https://gist.github.com/a1git/e8edfc7c0f148085165d4b8589d3f5a7 | |
| 13:03:08 | admin0 | i don't see any uuid in there | |
| 13:05:13 | sean-k-mooney | admin0: i think its in your ceph.conf | |
| 13:05:24 | admin0 | its not there | |
| 13:05:36 | admin0 | the uuid is what matches virsh secret-list | |
| 13:05:54 | admin0 | but does not exist on ceph or cinder side | |
| 13:07:07 | sean-k-mooney | [ceph] | |
| 13:07:09 | sean-k-mooney | ... | |
| 13:07:11 | sean-k-mooney | rbd_user = cinder | |
| 13:07:13 | sean-k-mooney | rbd_secret_uuid = 457eb676-33da-42ec-9a8c-9293d545c337 | |
| 13:07:49 | sean-k-mooney | so you need to add rbd_secret_uuid to you your hdd and ssd sections i think | |
| 13:07:57 | sean-k-mooney | in cinder | |
| 13:09:16 | sean-k-mooney | yes https://docs.openstack.org/cinder/rocky/configuration/block-storage/drivers/ceph-rbd-volume-driver.html | |
| 13:10:11 | admin0 | but how come its working for the 1st ceph without this value being in ceph or cinder conf anywhere | |
| 13:10:28 | sean-k-mooney | beacus its usign the value form nova which matches | |
| 13:10:45 | sean-k-mooney | the secret for the first cluster | |
| 13:24:11 | openstackgerrit | Lucian Petrut proposed openstack/nova master: hyper-v rbd volume support https://review.opendev.org/763550 | |
| 13:25:11 | sean-k-mooney | lpetrut: do you have a spec filed for that? | |
| 13:25:20 | sean-k-mooney | or at least a specless blueprint | |
| 13:25:57 | lpetrut | sean-k-mooney: good point, I'm filing blueprints right away | |
| 13:26:00 | sean-k-mooney | lpetrut: we need something to track addign an entire storage protocol to the hyperv driver. | |
| 13:26:15 | lpetrut | sean-k-mooney: definitely | |
| 13:31:21 | lpetrut | sean-k-mooney: I think a specless blueprint should be enough: https://blueprints.launchpad.net/nova/+spec/hyperv-rbd | |
| 13:31:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make nova-compute hard fail on db config https://review.opendev.org/763559 | |
| 13:37:34 | sean-k-mooney | lpetrut: if the chagne was larger it would not be but in this case i might be its really up to gibi and the rest of the core team to decide | |
| 13:38:00 | sean-k-mooney | lpetrut: do you have a third party ci in the works to test this | |
| 13:38:20 | sean-k-mooney | lpetrut: i dont see an os-brick-rbd voting on either change | |
| 13:38:41 | sean-k-mooney | i expect we will want to see that pass before merging this | |
| 13:41:13 | lpetrut | atm we're only testing smb, iscsi and FC volumes but we'll add another os-brick job for RBD | |
| 13:42:42 | sean-k-mooney | and a nova job? ideally tempest full with rbd and hyperv? | |
| 13:44:29 | lpetrut | atm the nova job only covers lvm. if by any chance a nova patch breaks support for one of the volume backends (very unlikely considering the minimal nova code for that), we'll notice it when the os-brick CI starts failing | |
| 13:44:36 | sean-k-mooney | it could be the same job just triggering it on nova | |
| 13:45:27 | gibi | lpetrut: thanks for the bp. Could you join to an upcoming Nova weekly meeting to shortly dicuss your bp and approve it to Wallaby? | |
| 13:45:49 | lpetrut | gibi: definitely | |
| 13:46:06 | gibi | lpetrut: then please add your bp to the OpenDiscussion section of the meeting agenda https://wiki.openstack.org/wiki/Meetings/Nova | |
| 13:46:14 | gibi | so we won't forget it | |
| 13:46:30 | lpetrut | gibi: awesome, thanks for the tip | |
| 13:46:38 | gibi | thanks! | |
| 14:24:29 | bauzas | stephenfin: thanks, looking | |
| 14:24:39 | bauzas | for the open spec | |
| 14:32:51 | openstackgerrit | Lucian Petrut proposed openstack/nova master: hyper-v rbd volume support https://review.opendev.org/763550 | |
| 14:37:39 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Image and flavor defined ephemeral storage encryption https://review.opendev.org/752284 | |
| 14:40:55 | openstackgerrit | Lucian Petrut proposed openstack/nova master: hyper-v rbd volume support https://review.opendev.org/763550 | |
| 14:52:01 | openstackgerrit | Dan Smith proposed openstack/nova master: RFC: Update the install documents for cells and less distro specific https://review.opendev.org/763412 | |
| 15:11:09 | sean-k-mooney | oh i forgot about that | |
| 15:12:04 | gibi | weekend starts early today :) | |
| 15:16:57 | dansmith | heh yeah | |
| #openstack-nova - 2020-11-23 | |||
| 03:53:15 | openstackgerrit | chengsheng proposed openstack/nova master: CPU selection with hypervisor consideration https://review.opendev.org/c/openstack/nova/+/762330 | |
| 06:19:42 | openstackgerrit | YumengBao proposed openstack/nova-specs master: libvirt supports composing cyborg owned vGPU accelerator into domain XML https://review.opendev.org/c/openstack/nova-specs/+/750116 | |
| 08:15:38 | gibi | good morning Nova | |
| 08:15:56 | gibi | new gerrit... interesting | |
| 08:33:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support sys.argv in wsgi app https://review.opendev.org/c/openstack/nova/+/763750 | |
| 08:33:40 | gibi | and gerrit works :) | |
| 09:37:23 | openstackgerrit | Lucian Petrut proposed openstack/nova master: hyper-v rbd volume support https://review.opendev.org/c/openstack/nova/+/763550 | |
| 09:40:59 | lpetrut | gibi: I had to double check to make sure I haven't opened android-review.googlesource.com :) | |
| 09:41:29 | gibi | lpetrut: :) | |
| 09:41:46 | gibi | please note that not everything works https://etherpad.opendev.org/p/gerrit-3.2-post-upgrade-notes | |
| 09:42:19 | gibi | the biggest missing piece for me is the launchpad integration. You have to manually set bug status | |
| 09:43:29 | lpetrut | interesting, good to know. looks like there's quite some work going on in order to bring back those features | |
| 10:21:31 | lyarwood | bauzas: https://review.opendev.org/c/openstack/nova/+/752486 - would you mind hitting this and the regression test below it? | |
| 10:25:53 | kashyap | Oh, shiny new Gerrit | |
| 10:41:16 | stephenfin | why does everything need to be in bold? | |
| 10:42:15 | bauzas | lyarwood: ack, sorry I was taxi for my kids | |
| 10:49:32 | bauzas | how can I see in which releases was merged https://review.opendev.org/c/openstack/nova/+/752247 ? | |
| 10:49:55 | bauzas | in the previous Gerrit version, we had a 'included in' value | |
| 10:50:41 | gibi | bauzas: good question | |
| 10:50:46 | gibi | I havn't found it | |
| 10:51:05 | stephenfin | here's a bit of fun - right click on an element in a path list patch and "inspect" it | |
| 10:51:24 | stephenfin | takes at least 10 seconds for Firefox to catch up on my machine :-D | |