Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-11-12
16:56:14 gibi bauzas: no worries
16:56:21 gibi bauzas: hope it did not hurt
16:56:29 dansmith stephenfin: and what, assume tablet from usb or virtio, and mouse from ps2?
16:56:46 dansmith since it's image metadata, deprecating a thing just means debt forever that we can never get rid of right?
16:56:47 stephenfin yes, assuming we even want to support ps2
16:57:27 bauzas gibi: nope, no worries, it was just a yearly one
16:57:37 gibi :)
16:57:52 stephenfin dansmith: Sort of, but I think this is actually better
16:58:20 bauzas (and I was off the chan today because I was working on https://review.opendev.org/#/c/761452/ )
16:58:25 owalsh dansmith: so I've been thinking about https://review.opendev.org/762176. I'm really not convinced yet but maybe I'm missing something obvious...
16:58:32 stephenfin Actually, no, it makes no difference
16:58:39 stephenfin We can remove the 'hw_pointer_model' image metadata property in a future major version bump
16:58:45 dansmith stephenfin: but it's "better" just in that you like the name of input_bus more than pointer_model right? Just adding virtiotablet to the existing key gives us no infinite debt, keeps the choices small so that it's harder to pick something that will likely work
16:58:48 stephenfin If we do, nova will simply start ignoring it
16:59:00 dansmith stephenfin: then we've broken users
16:59:17 dansmith I think we're pretty much trying to never do that right? have we ever stopped honoring an image meta property?
16:59:35 stephenfin yes, we'd need mitigation which is why I don't think we'd ever do it
17:00:11 stephenfin same reason we'll continue supporting e.g. 'hw_disk_bus=uml'
17:00:15 owalsh dansmith: so based on what sean said most of the deployment frameworks already do the right thing, and I'm sorting out tripleo/puppet-nova ...
17:00:16 stephenfin like, forever
17:01:06 owalsh dansmith: so I think that leave two scenarios where we could have a nova.conf where the compute gets db creds:
17:01:07 stephenfin dansmith: it's much better UX IMO, yes
17:01:12 dansmith stephenfin: well, it just doesn't make any sense to me to deprecate a thing we'll never remove, which is really not that in need of change
17:01:34 owalsh dansmith: 1 - a roll you're own deployment that screws it up (because there are no docs)
17:01:47 stephenfin dansmith: we're going to end up in that situation anyway
17:01:56 stephenfin usbtablet will be meaningless in a Q35 world
17:01:59 dansmith owalsh: I think everyone agrees it needs to be doc'd better
17:02:01 digvijay hi.. facing issue with attaching NFS based cinder volume to VM.. (http://paste.openstack.org/show/799964/).. any ideas
17:02:04 stephenfin and already is on non-x86
17:02:05 owalsh dansmith: 2 - an all-in-one deployment (is that not a valid expection to the rule)
17:02:17 stephenfin given neither support ps2
17:02:54 owalsh dansmith: so we just fix the docs and leave it at that instead of ripping puppet-nova, and the debs, and the rpms and etc.. into pieces...
17:02:58 dansmith stephenfin: that's the same for all of our keys that specify a platform-specific value (like ide, sata, etc).. you're just adding an additional degree of freedom by adding a new key
17:03:23 owalsh dansmith: or maybe we do that, for the sake of elegance, but not a priority in W
17:03:55 dansmith owalsh: well, I meant document it to help with the roll-your-own case and for future deployment tools, but go forward with the startup abort, which requires fixing tripleo
17:04:21 dansmith owalsh: tbh, I'm not the one that really wanted the startup abort, but it does seem like the right thing to do to me
17:04:31 dansmith owalsh: especially since tripleo seems to be one of the only ones not already getting this right
17:05:27 owalsh issue is actually in puppet-nova so tripleo is not to blame here
17:05:54 dansmith owalsh: do any other major deployment tools use puppet-nova besides tripleo?
17:06:02 dansmith they used to, but I didn't think much anymore
17:06:21 dansmith however, tripleo is easier to type, but feel free to apply my comments to the appropriate project :)
17:07:26 owalsh ack, either way take it for granted that the fix is happening and will be backported. Once that is out of the way the hard fail doesn't achieve much IMO, just breaks all-in-one for a lot of people
17:07:55 dansmith devstack is by default an AIO tool and it has been doing it right for years
17:08:20 dansmith but, again, I'm not the only one you need to convince
17:08:40 dansmith IIRC, it was stephenfin that originally thought we should be blocking startup on invalid or insecure configs, and I agree with him
17:08:48 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM: Testing system scope in tempest https://review.opendev.org/740124
17:08:55 dansmith and that doesn't happen very often, so it MUST be right :)
17:10:43 owalsh dansmith: well I know where he lives, if it wasn't for this lockdown!
17:10:55 dansmith sudo refuses to run when a sudoers.d file has invalid permissions, even on my single-user laptop because it's a bad idea for everyone
17:10:56 dansmith owalsh: hah
17:12:37 owalsh dansmith: well given this wasn't really documented I don't think it ok land the assert in W. How about warning that is deprecated for now?
17:13:43 dansmith owalsh: that's a gibi call.. so far I've not heard that this was a surprise to anyone, and you know we have known this is wrong downstream for a while. So to me it seems like a valid thing to do aggressively because of the security aspect, but I'll defer to gibi for timing
17:15:24 gibi I see a big pushback on the hard fail, but I also do supprised that all tool that supprots all-in-one today are worked around that hard failure due to upgrade_level 'auto' that is landed cycle ago
17:16:11 gibi if the whole push back is just to get more time to do the fixes then I'm fine to delay the patch even further
17:16:31 dansmith gibi: you _do_ see a big pushback? I didn't see much from the ML, but maybe I'm missing some?
17:16:50 dansmith sounded to me like debian just wanted some agreement on best practices or something
17:17:12 gibi dansmith: I understood from the ML that we are breaking debian, osa, and tripleo as well. Only kolla and devstack are immune
17:18:09 dansmith but OSA says they already try to do the right thing and are willing to change, especially if we do some docs
17:18:31 dansmith anyway, as I said, I defer to you on the timing
17:19:35 gibi yeah, I might mix the amount of broken thing with the amount of pushback. Now that I re-read OSA mail it does not feel like a pushback
17:20:13 dansmith they know that db creds do not belong in the nova-compute conf, they just let them be there for AIO
17:20:47 dansmith just like we (tripleo/puppet/whatever) also know that, and have hacked around it thus far :)
17:21:37 owalsh no hack, it was just like that when I got here and it comes from puppet-nova. tripleo will be immune too once https://review.opendev.org/755689 lands, so probably today/tomorrow
17:22:01 owalsh however AFAIK there are puppet AIO jobs in CI
17:22:11 owalsh and RDO
17:22:21 dansmith it was a hack when we set the config to something non-default purely to avoid a failure, and we knew that the right thing was to stop putting creds in that file :)
17:22:32 gibi I have to leave for today, will read back tomorrow, and reply on the ML
17:22:48 dansmith o/
17:22:50 gibi o/
17:23:43 owalsh o/ I'll poke some CI guys to think about it too, not sure they have grokked the implications yet
17:27:36 owalsh sean-k-mooney: re https://bugs.launchpad.net/nova/+bug/1903908 you looked at the code yea?
17:27:36 openstack Launchpad bug 1903908 in puppet-nova "nova conf [api]/dhcp_domain is required on nova-compute" [Undecided,New] - Assigned to Oliver Walsh (owalsh)
17:28:36 owalsh sean-k-mooney: would you mind explaining the issue on the LP?
17:38:43 sean-k-mooney owalsh: its required to generate teh config dirve yes
17:38:55 sean-k-mooney with the correct hostname
17:39:27 sean-k-mooney if its not set then it will not have the doamin
17:39:35 sean-k-mooney and will get novalocal instead
17:50:29 owalsh sean-k-mooney: ack, could you response to gibi on the LP? CI logs from the original LP are long gone I expect
17:50:36 owalsh respond
17:51:12 sean-k-mooney ya i can
17:51:19 owalsh ack thanks
18:03:39 stephenfin dansmith: Sorry, had a meeting. It's late so I won't pick up the hw_input_bus vs. virtiotablet discussion again rn, but needless to say I still think my approach is the right one and will just have to think of ways to talk you around ;) In the interim, the reviews at https://review.opendev.org/#/c/756552/ if you want to note down your concerns for others to see
18:04:00 stephenfin and yes to blocking startup on invalid or insecure configs
18:04:25 dansmith stephenfin: yeah, I was going to suggest you update it with your (new, I think) approach of just going with bus only, and then I can -1 with my concerns
18:04:38 dansmith I'd like to see some more input on it, given that it affects rpc, api, images, and the future,
18:04:52 dansmith but if I'm the only one that doesn't like a new thing, then obviously I'll move on
18:05:08 dansmith "update it" meaning, comment on the patch with your thoughts
18:05:14 stephenfin gotcha
18:06:51 stephenfin I'll post to openstack-discuss too. We could spin out a spec to discuss this but the ML would probably attract a larger audience and a spec is a lot for a single design debate
18:08:21 dansmith well, I think gerrit is plenty wide for a detail like this, but whatever you want.. ml is fine too
18:17:48 openstackgerrit Daniel de Oliveira Pereira proposed openstack/nova master: Avoid changing transport_url value when updating Cell0 https://review.opendev.org/762433
19:41:30 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Wait for revert resize to complete https://review.opendev.org/762543
19:41:47 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Use helpers for cross-cell resize https://review.opendev.org/762544
19:42:02 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Use helpers for cross-cell resize https://review.opendev.org/762544
19:43:00 stephenfin lyarwood, gibi: I'm on PTO tomorrow, but if you have a chance to look at https://review.opendev.org/762543 (now with a bug report), that's be great. It's not super common but even one intermittent gate failure is one too many
19:43:05 stephenfin o/
21:18:16 openstackgerrit Daniel de Oliveira Pereira proposed openstack/nova master: Avoid changing transport_url when updating Cell0 https://review.opendev.org/762433
#openstack-nova - 2020-11-13
00:00:04 openstackgerrit Brin Zhang proposed openstack/nova master: WIP: Cyborg suspend/resume support https://review.opendev.org/729945
00:00:30 openstackgerrit Brin Zhang proposed openstack/nova master: [Trivial] Rename host/node to hostname/nodename in conductor manager https://review.opendev.org/762499
01:03:57 openstackgerrit Ghanshyam Mann proposed openstack/nova master: [WIP] Migrate nova-grenade-multinode job to zuulv3 native https://review.opendev.org/742056

Earlier   Later