| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-10-27 | |||
| 12:29:20 | sean-k-mooney | thanks :) | |
| 12:30:02 | sean-k-mooney | return tuple([cls[1] for cls in classes if cls[0].startswith("vir")]) should work provided they keep to there nameing scheme | |
| 12:31:03 | sean-k-mooney | well when the gate is green again can people take a look at https://review.opendev.org/#/c/751642/7 and ill recheck https://review.opendev.org/#/c/602432/22 later | |
| 12:31:16 | gmann | gibi: thanks | |
| 13:12:27 | sean-k-mooney | lyarwood: gibi stephenfin just spoke to fungi and frickler in #opendev we might need to make grenade non voting for https://review.opendev.org/#/c/759831/ to merge or merge it to victoria first and forward port it | |
| 13:13:22 | lyarwood | sean-k-mooney: oh fun | |
| 13:13:49 | lyarwood | sean-k-mooney: I didn't realise this was also broken in V | |
| 13:13:52 | fungi | usually you merge to the oldest affected branch first and work your way up to the newest | |
| 13:14:09 | fungi | at least if upgrade testing is impacted | |
| 13:14:25 | sean-k-mooney | lyarwood: i saw it broken on a grenade job fro one of frickler patches it failed in the inital stack i think | |
| 13:14:37 | lyarwood | sean-k-mooney: did we also bump eventlet etc there? | |
| 13:15:19 | lyarwood | the other way of fixing this is to revert requirements.txt bumps | |
| 13:15:56 | sean-k-mooney | actully looking at it again it might be the scond stacking | |
| 13:16:06 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/89443efd462f4d7fb2e470568546b232 | |
| 13:16:16 | lyarwood | hopefully that's the case | |
| 13:16:34 | fungi | yeah, if that's the case then just fixing in master should be sufficient | |
| 13:16:36 | sean-k-mooney | it https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_894/759850/1/check/designate-grenade-pdns4/89443ef/controller/logs/screen-n-cpu.txt | |
| 13:16:53 | sean-k-mooney | there is a grenade.sh log | |
| 13:16:55 | sean-k-mooney | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_894/759850/1/check/designate-grenade-pdns4/89443ef/controller/logs/grenade.sh_log.txt | |
| 13:17:11 | sean-k-mooney | so that means the first stacking passed right | |
| 13:17:17 | sean-k-mooney | e.g. victoia | |
| 13:17:28 | sean-k-mooney | so this is just a master issue | |
| 13:17:40 | lyarwood | coolio | |
| 13:18:19 | sean-k-mooney | well im not sure about that | |
| 13:18:33 | sean-k-mooney | e.g. i dont know if we alwasy have a grenade.sh log or not in that job | |
| 13:19:05 | sean-k-mooney | ok we are good | |
| 13:19:07 | sean-k-mooney | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_894/759850/1/check/designate-grenade-pdns4/89443ef/controller/logs/old/devstacklog.txt | |
| 13:19:16 | sean-k-mooney | we have a succeful inital devstack run | |
| 13:19:25 | sean-k-mooney | so ya its failing on the master upgrade | |
| 13:20:31 | openstackgerrit | Lee Yarwood proposed openstack/nova master: releasenotes: Add fixes note for bug #1882521 https://review.opendev.org/758971 | |
| 13:20:31 | openstack | bug 1882521 in OpenStack Compute (nova) "Failing device detachments on Focal" [High,Fix released] https://launchpad.net/bugs/1882521 - Assigned to Lee Yarwood (lyarwood) | |
| 13:21:51 | lyarwood | sean-k-mooney: cool, so everything is green in CI at the moment, I'll continue watching it. | |
| 13:26:14 | gibi | fingers crossed | |
| 13:38:54 | bauzas | sean-k-mooney: agreed with you on the "vir" prefix, I'm a bit afraid they could change their naming | |
| 13:39:12 | bauzas | but let's merge the change now and discuss for it on a FUP | |
| 13:39:43 | sean-k-mooney | yep if i was very concerned about that i would have -1d | |
| 13:40:02 | bauzas | sean-k-mooney: i did in on PS3, but after thinking on it, I finally provided a +2 | |
| 13:40:25 | sean-k-mooney | i think we can cross that bridge when it comes up | |
| 13:41:02 | lyarwood | right, I really doubt it's ever going to change tbh | |
| 13:41:13 | lyarwood | even if it did checking for _ wouldn't be enough | |
| 13:41:39 | lyarwood | so yeah lets cross that bridge if it ever comes up | |
| 13:42:09 | bauzas | sure, but i wonder whether we should verify that only LibvirtError should be a private class and maybe if not then stopping the compute service when restarting | |
| 13:42:16 | bauzas | lyarwood: ^ | |
| 13:43:26 | bauzas | so in case libvirt supports a new public class that is not having a vir prefix by a new major release (hopefully), then the compute service would stop to run and we would get an exception explaining it | |
| 13:44:19 | bauzas | maybe a overthought so, but here the problem is that I don't see any API situation for python-libvirt | |
| 13:44:40 | bauzas | we only have https://libvirt.org/python.html that is documented | |
| 14:09:15 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: WIP/DNM - Image defined ephemeral storage encryption https://review.opendev.org/752284 | |
| 14:23:33 | lyarwood | bauzas: sorry my irc client disconnected silently, yeah we can make this more robust but I don't think the return on that effort is going to be high tbh | |
| 14:24:10 | bauzas | lyarwood: I wish libvirt would provide a better robust API | |
| 14:24:17 | bauzas | for the python bindings | |
| 14:24:25 | bauzas | like, having a public scheme | |
| 14:24:25 | lyarwood | bauzas: I'm not sure why you think it isn't | |
| 14:24:47 | lyarwood | bauzas: oh, well it's basically https://libvirt.org/html/libvirt-libvirt-domain.html | |
| 14:24:59 | bauzas | lyarwood: the problem ties to python, by default you can introspect any object | |
| 14:25:13 | lyarwood | bauzas: through the two main classes described in your previous link | |
| 14:25:21 | bauzas | lyarwood: yeah, but that's not the python binding API, right? | |
| 14:26:38 | lyarwood | bauzas: true, we could use better documentation | |
| 14:26:40 | bauzas | totally unrelated, I really would love Gerrit supporing images or memes https://review.opendev.org/#/c/759828/2/specs/wallaby/approved/nova-support-webvnc-with-password-anthentication.rst@175 | |
| 14:26:56 | bauzas | I mean the Gerrit UI | |
| 14:27:19 | bauzas | hyperlinks would stay plain text for gerrit text clients | |
| 14:27:29 | bauzas | but for those which are smart... | |
| 14:28:50 | sean-k-mooney | unicode works | |
| 14:29:02 | sean-k-mooney | although sometimes it can break things | |
| 14:29:51 | bauzas | sean-k-mooney: how so ? | |
| 14:32:01 | sean-k-mooney | using unicode in commit messages has broken things in the past | |
| 14:32:21 | gibi | bauzas: you can try to add a client side script that resolves the links for you locally | |
| 14:32:25 | sean-k-mooney | i think it broke the zuul parser that looks for depend on | |
| 14:32:54 | sean-k-mooney | but ya you can use code injector | |
| 14:32:59 | bauzas | lol | |
| 14:33:20 | bauzas | for gerrit | |
| 14:33:26 | sean-k-mooney | i use code injector to allow me to copy form gerrit commits again | |
| 14:33:30 | sean-k-mooney | *comments | |
| 14:34:07 | sean-k-mooney | you need to set user-select: text to get comment to be selectable again | |
| 14:34:29 | openstackgerrit | Lee Yarwood proposed openstack/os-traits master: Add COMPUTE_EPHEMERAL_ENCRYPTION tratis https://review.opendev.org/759878 | |
| 14:46:59 | gibi | sean-k-mooney: could you paste that code, I could use that too | |
| 14:50:25 | sean-k-mooney | i need to fix it but yes right now i some times need to refresh as it can run too early but before it was quadadic still fast can cleint side i just felt bad | |
| 14:51:05 | sean-k-mooney | http://paste.openstack.org/show/799434/ | |
| 14:55:53 | gibi | thanks | |
| 14:58:59 | sean-k-mooney | the reason it broke is both firefox and chrome change how ineritance works for css | |
| 14:59:35 | sean-k-mooney | so the default value that was inherited chaned | |
| 15:02:32 | sean-k-mooney | gibi: this is basically what i based it on https://www.smashingmagazine.com/2019/04/mutationobserver-api-guide/ | |
| 15:08:59 | sean-k-mooney | gibi: i might just need to add subtree to that list https://www.smashingmagazine.com/2019/04/mutationobserver-api-guide/#childlist-with-subtree | |
| 15:09:48 | gibi | thanks | |
| 15:11:01 | sean-k-mooney | im going to hack on it for 5 mins and see if i can get it back to workign without a refresh | |
| 15:14:24 | sean-k-mooney | gibi: i just need to call it once when the script is loaded and then on mutation http://paste.openstack.org/show/799435/ | |
| 15:14:31 | sean-k-mooney | that should work | |
| 15:16:14 | sean-k-mooney | gibi: also "review\.opendev\.org" is what im using for the site regex/matcher thing for the code injector plugin | |
| 15:16:36 | sean-k-mooney | i have it set to run on page load | |
| 15:37:51 | gibi | sean-k-mooney: works nicely (after an extra refresh) | |
| 15:47:58 | bauzas | gibi: sean-k-mooney: fwiw dev mode on FF or Chrome works fine | |
| 15:48:05 | bauzas | no need for a plugin | |
| 15:48:25 | bauzas | newspapers* | |
| 15:48:42 | sean-k-mooney | bauzas: to add it sure but its kind of annoying to have to keep changing it | |
| 15:48:54 | bauzas | I don't really copy/paste a lot | |
| 15:49:16 | bauzas | what you can also do is just to click on "reply" at a comment | |
| 15:49:30 | sean-k-mooney | ya but that quotes it | |
| 15:49:32 | bauzas | you'll get the text with a "> " prefix | |
| 15:49:34 | bauzas | right | |
| 15:49:39 | bauzas | but easy peasy nope ? | |
| 15:49:42 | sean-k-mooney | its annoying when you providing code examples | |