| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-10-21 | |||
| 15:56:27 | markguz_ | i'm a try it now | |
| 15:57:17 | bauzas | I'm litterally looking at the nova-manage source code | |
| 15:57:31 | bauzas | and we assume a _cell0 postfix if nothing was passed | |
| 15:58:27 | markguz_ | so nova_vsphere should be nova_vsphere_cell0 ? | |
| 15:58:31 | bauzas | ok, got it | |
| 15:58:52 | markguz_ | full disclosure.. this is rocky... so maybe it's been fixed subsequently? | |
| 15:59:26 | bauzas | looking at the rocky code then | |
| 15:59:49 | bauzas | no changes | |
| 15:59:53 | bauzas | ok, got the answer | |
| 15:59:56 | bauzas | markguz_: https://github.com/openstack/nova/blob/stable/rocky/nova/cmd/manage.py#L1149 | |
| 16:00:16 | bauzas | you're entering this inner method since you don't pass a connection string as a CLI param | |
| 16:00:39 | bauzas | in this case, we're getting your 'nova' db | |
| 16:00:57 | bauzas | but then we consider that the cell0 connection URL will be 'nova_cell0' | |
| 16:01:11 | markguz_ | bauzas: gibi: as a sidenote, is creating a separate region the only way to have nova/libvirt/kvm + neutron/ml2/openvswitch coexist with nova/vsphere + neutron/nsx ? | |
| 16:01:20 | bauzas | in your case, mysql+pymysql://nova:XXX@192.168.128.254/nova_vsphere_cell0 indeed | |
| 16:01:51 | markguz_ | ok. i have created that db, but was expecting nova-manage to magically know to use nova_vsphere_cell0 | |
| 16:04:07 | bauzas | db sync has to happen after map_cell0 | |
| 16:13:17 | markguz_ | bauzas: gibi: that got it, all i was missing was the connection string for cell_v2 map_cell0 | |
| 16:13:31 | bauzas | cool | |
| 16:13:34 | gibi | markguz_: nice to hear that | |
| 16:13:45 | markguz_ | is this really the only way to coexist the vsphere stuff with the libvirt/kvm stuff? | |
| 16:14:15 | markguz_ | the docs are pretty sketchy on having a hybrid env | |
| 16:21:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: [doc]: Fix glance image_metadata link https://review.opendev.org/759100 | |
| 16:37:29 | bauzas | gibi: I know this is late but food for thoughts https://review.opendev.org/#/c/755477/2/specs/wallaby/approved/support-interface-attach-with-qos-ports.rst@126 | |
| 16:38:01 | bauzas | I have to disappear, my spouse is looking at me for shopping needs | |
| 16:40:22 | gibi | bauzas: good point, replied in https://review.opendev.org/#/c/755477/2/specs/wallaby/approved/support-interface-attach-with-qos-ports.rst@126 | |
| 16:40:31 | gibi | bauzas: have a nice shopping ;) o/ | |
| 17:31:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove irrelevant comment https://review.opendev.org/759112 | |
| 17:31:41 | stephenfin | gibi: ^ | |
| 17:32:15 | gibi | stephenfin: thanks | |
| 17:36:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove 'BandwidthUsage', 'BandwidthUsageList' https://review.opendev.org/759114 | |
| 17:37:41 | stephenfin | also gibi :) ^ | |
| 17:37:49 | stephenfin | let's see what CI thinks | |
| 17:37:53 | gibi | thanks | |
| 18:06:21 | ganso | melwitt, elod: Hi! If you have a minute could you please take a look at this stable/stein backport that is the same as the stable/train you previously: https://review.opendev.org/#/c/757886/ ? Thanks in advance! | |
| 18:08:52 | openstackgerrit | melanie witt proposed openstack/nova stable/train: Follow up for cherry-pick check for merge patch https://review.opendev.org/759118 | |
| 18:09:13 | melwitt | ganso: ack, will look later | |
| 18:09:25 | ganso | melwitt: thanks! | |
| 18:16:04 | openstackgerrit | sean mooney proposed openstack/nova master: Fix unplugging VIF when migrate/resize VM https://review.opendev.org/751642 | |
| 18:38:13 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/602432 | |
| 18:39:11 | lyarwood | sean-k-mooney: if you're still around, did I see you talking about an ipv6 issue earlier today? | |
| 18:39:37 | lyarwood | sean-k-mooney: just noticed tempest-ipv6-only failing across a few of my changes | |
| 18:39:39 | sean-k-mooney | thats in the world dump script and limestone | |
| 18:39:52 | lyarwood | sean-k-mooney: kk, did you have a bug for that? | |
| 18:40:14 | sean-k-mooney | so https://review.opendev.org/#/c/759042/ is the fix for the worlddump script | |
| 18:40:28 | sean-k-mooney | and the limestone ci seam to be ipv6 by default | |
| 18:40:46 | sean-k-mooney | but there might be a dhcp/nat issue | |
| 18:40:59 | lyarwood | kk | |
| 18:41:06 | lyarwood | I'll leave my rechecks until the morning then | |
| 18:41:09 | sean-k-mooney | the vms are ment to get ipv4 private ips but devstack failed because it had not ipv4 adress atall | |
| 18:41:10 | lyarwood | thanks! | |
| 22:44:31 | openstackgerrit | Xav Paice proposed openstack/nova stable/ussuri: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/759151 | |
| 23:16:12 | openstackgerrit | Xav Paice proposed openstack/nova stable/train: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/759153 | |
| 23:32:06 | openstackgerrit | Merged openstack/nova master: virt: Remove 'get_console_pool_info' API https://review.opendev.org/749311 | |
| #openstack-nova - 2020-10-22 | |||
| 01:12:42 | openstackgerrit | Xav Paice proposed openstack/nova stable/ussuri: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/759151 | |
| 01:34:19 | openstackgerrit | Xav Paice proposed openstack/nova stable/train: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/759153 | |
| 04:49:09 | openstackgerrit | Merged openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/745895 | |
| 06:28:08 | bauzas | good morning Nova | |
| 07:11:46 | gibi | bauzas: good morning | |
| 07:11:59 | bauzas | :) | |
| 08:49:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove 'BandwidthUsage', 'BandwidthUsageList' https://review.opendev.org/759114 | |
| 09:05:19 | gibi | stephenfin: now I feel making o.vo fields typesafe is fultile. E.g. an o.vo IntegerField accept strings and coerce them to integeres with an int() conversion. So if I type an IntegerField to int then mypy will flag obj.int_field = '123' assignemnet which is valid in o.vo. Also if I map it to str then mypy will not flag obj.int_field = 'bob' which is invalid in o.vo | |
| 09:05:33 | gibi | s/flutile/futile | |
| 09:14:37 | gibi | which means it is very limited what we can typecheck | |
| 09:16:18 | gibi | List*Fields are complicated as they are coreced from Iterables but not from str or Mapping myobj.list_of_ints = {1, 2, 3} | |
| 09:16:36 | gibi | sorry I wanted to link https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fields.py#L648 | |
| 09:17:24 | gibi | btw myobj.list_of_ints = {'1', '2', '3'} also accepted by ovo as the elements of the iterable is coerced to int | |
| 09:27:27 | stephenfin | gibi: I hadn't considered coercion /o\ | |
| 09:28:06 | stephenfin | Hmm, that does sound pretty futile alright. Damn :-\ | |
| 09:29:49 | stephenfin | I had been thinking it might make sense to at least define the attributes and simply set their type to Any, so that we'd know you could define e.g. 'InstanceNUMACell.cpu_policy' but not '.cpu_policyyyy'. However, I guess we rely on that to store working data | |
| 09:32:48 | gibi | stephenfin: I can generate the fields with https://github.com/gibizer/ovo-mypy-plugin and map them to Any. I guess non o.vo fields defined via simply assigning value to them in nova code. So those can be typed in nova code and picked up by mypy | |
| 09:34:42 | stephenfin | gibi: I think there's probably value in that. I mean, it sounds like the best we can get unless we wanted to drop the coerce functionality | |
| 09:35:08 | stephenfin | which, tbc, I wouldn't be entirely against either; explicit is better than implicit and all that | |
| 09:36:12 | gibi | stephenfin: I don't know if the generic RPC code depends on coerce or not. But the specific nova usage of o.vo can be converted to not use coerce | |
| 09:37:13 | gibi | or at least to use explicit coerce | |
| 09:37:22 | gibi | instead of implicit during assignment | |
| 09:39:16 | stephenfin | Even if the RPC code did rely on it, type checking doesn't happen at run time so we could require explicit coercion for non-RPC cases | |
| 09:39:27 | stephenfin | i.e. get static type checking working | |
| 10:12:56 | gibi | stephenfin: so then we are back to defining IntegerField as int even though we know that o.vo is more forgiving than that at runtime? | |
| 10:41:21 | openstackgerrit | Merged openstack/nova master: virt: Remove 'post_interrupted_snapshot_cleanup' API https://review.opendev.org/749313 | |
| 12:32:49 | openstackgerrit | sean mooney proposed openstack/os-vif stable/victoria: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/759255 | |
| 12:33:06 | sean-k-mooney | lyarwood: can you reivew https://review.opendev.org/#/c/756406 and https://review.opendev.org/#/c/759255/ | |
| 12:33:24 | sean-k-mooney | they are os-vif stable/victoria backports | |
| 12:35:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/759256 | |
| 12:36:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/758396 | |
| 12:40:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/758396 | |
| 12:54:12 | lyarwood | sean-k-mooney: ack will do | |
| 12:57:42 | lyarwood | sean-k-mooney: done, LGTM. | |
| 12:59:11 | sean-k-mooney | lyarwood:thanks | |
| 13:02:53 | sean-k-mooney | lyarwood: if you fell like doing other reviews https://review.opendev.org/#/q/topic:bug/1895220+(status:open+OR+status:merged) is related to a downstream escalation | |
| 13:03:19 | sean-k-mooney | i have just rechecked them but i would really like to get thos merged sooner rather then later | |
| 13:04:10 | lyarwood | sean-k-mooney: ack queued | |
| 13:12:58 | openstackgerrit | Merged openstack/nova master: fixtures: Handle binding of first port https://review.opendev.org/746949 | |
| 13:13:06 | openstackgerrit | Merged openstack/nova master: Remove self.server dependency form _evacuate_server https://review.opendev.org/758209 | |
| 15:47:57 | gibi | nova weekly meeting starts in 12 minutes in #openstack-meeting-3 | |
| 16:07:25 | openstackgerrit | Merged openstack/nova stable/victoria: libvirt: Increase incremental and max sleep time during device detach https://review.opendev.org/757305 | |
| 16:32:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/758396 | |
| 16:32:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Compact Liberty database migrations https://review.opendev.org/758397 | |
| 16:32:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Compact Mitaka database migrations https://review.opendev.org/758398 | |
| 16:32:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Compact Newton database migrations https://review.opendev.org/759085 | |