Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-10-15
17:44:55 melwitt that makes sense
17:46:59 sean-k-mooney anyway the tl;dr for gibi is we shoudl catch the excpetion here https://github.com/openstack/nova/blob/2c3ff1004e8812da0bc4e5502762e6b9a7650846/nova/pci/whitelist.py#L85-L87 instead
17:47:18 sean-k-mooney to that if should be in a try
17:48:00 sean-k-mooney and we retrun fause if we get the PciConfigInvalidWhitelist excption
17:48:15 sean-k-mooney whcih is what he is doing here https://review.opendev.org/#/c/756697/4/nova/pci/manager.py
17:48:54 sean-k-mooney back to your orginal question
17:48:57 sean-k-mooney https://review.opendev.org/#/c/756697/4/nova/pci/devspec.py
17:49:18 sean-k-mooney is still going to raise and excption if you input an invalid whitelist
17:49:36 sean-k-mooney so i think the compute agent will still fail to start in that case
17:50:13 sean-k-mooney but we support 3 different type of adresses.
17:51:08 sean-k-mooney gibi only exeteded this one since its the one we use for the virt driver objcts
17:52:28 sean-k-mooney since gibi is not catching the excption it will still fail here
17:52:30 sean-k-mooney https://github.com/openstack/nova/blob/2c3ff1004e8812da0bc4e5502762e6b9a7650846/nova/pci/whitelist.py#L52-L79
17:52:54 sean-k-mooney when we are parsing the whitelist if it had a 32bit domain
17:53:25 sean-k-mooney this will raise the new excption
17:53:47 sean-k-mooney spec = devspec.PciDeviceSpec(ds)
17:53:53 sean-k-mooney line 75
18:21:27 ganso hi folks! If anyone could please spare a few minutes to look at this stable/train backport, should be really simple and quick as the other ones: https://review.opendev.org/#/c/757870/
18:22:30 ganso melwitt, lyarwood, elod ^
18:24:12 melwitt ganso: ack will look later today
18:24:22 ganso melwitt: thank you!
20:12:33 elod ganso: the backport looks good to me, just as it was ok to ussuri. +2
20:12:50 ganso elod: thanks!
#openstack-nova - 2020-10-16
08:00:14 yingjisun gibi: are you here?
08:08:29 gibi yingjisun: hi!
08:14:15 yingjisun gibi: I have a question about updating nova db. I would like to change the length of internal_access_path in console_auth_tokens, starting from Train. I want to modify nova/db/sqlalchemy/models.py and the migration file under nova/db/sqlalchemy/migrate_repo/versions. However I did not find some placeholder in Train. 402_add_resources.py is the last one in Train and 403_ is "Add reserved schema migrations for Ussuri". So how can I do it in Train ?
08:15:03 yingjisun Here is the repo link. https://github.com/openstack/nova/tree/master/nova/db/sqlalchemy/migrate_repo/versions
08:19:19 gibi yingjisun: good question, let me think about it
08:24:26 yingjisun Thank you very much. If it is not a question at hand, I can ask it in openstack-discuss alias. I do not want you to spend much time on this. :)
08:25:46 gibi yingjisun: I think you can use 403 for the backport to Train. As 402 is train and and no newer migration merged yet
08:26:56 yingjisun ok. Then I will open a bug first and invovle more people to review it. Thank you.
08:27:05 gibi but it would be nice to ask dansmith about this ^^ I've never done db migration backports
08:27:24 yingjisun sure. I will.
08:27:35 gibi thnks
08:27:38 gibi thanks
08:28:46 gibi link me the bug when you open it
08:28:57 yingjisun ok.
09:11:40 gibi dansmith: could you please update the topic of the channel with the wallaby runways etherpad link? https://etherpad.opendev.org/p/nova-runways-wallaby ?
10:17:26 frickler gibi: ^^ like this?
10:22:36 gibi frickler: thanks
10:22:44 gibi is there a way I can do it next time?
10:26:12 openstackgerrit Andrew Bonney proposed openstack/nova master: Handle disabled CPU features to fix live migration failures https://review.opendev.org/757577
11:11:41 openstackgerrit Balazs Gibizer proposed openstack/nova master: Ignore PCI devices with 32bit domain https://review.opendev.org/756697
11:19:04 openstackgerrit Balazs Gibizer proposed openstack/nova master: Ignore PCI devices with 32bit domain https://review.opendev.org/756697
11:20:13 gibi sean-k-mooney, melwitt: I tried to follow the suggestion from the discussion you had yesterday about ^^. Let me know how do you like this
11:30:59 openstackgerrit Balazs Gibizer proposed openstack/nova master: Set instance host and drop migration under lock https://review.opendev.org/754815
11:42:50 frickler gibi: I think you can be added to the chanserv config, but I need to verify the details
11:43:11 gibi frickler: OK, let me know if I need to anything extra
11:43:50 gibi dansmith: I think https://review.opendev.org/#/c/738482/ is ready for your eyes, again
11:52:48 frickler gibi: o.k., added you to chanserv, you should now be able to issue "/msg chanserv topic #openstack-nova topic <new topic line>". the bot also has some extensive help feature if needed
11:53:03 gibi frickler: thanks!
11:56:43 gibi frickler: works. thanks again
12:00:37 frickler gibi: seems I there was on "topic" too much in the command I gave you, need to drop the second one. also you dropped the "Current runways:" part, not sure if that was intentional
12:00:46 frickler other than that, welcome ;)
12:01:05 gibi good point
12:01:07 gibi fixing it
12:49:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Ignore PCI devices with 32bit domain https://review.opendev.org/756697
14:25:37 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use _evacuate_server helper in func test https://review.opendev.org/758210
19:18:04 ganso melwitt, elod: thanks a lot for the reviews yesterday! If you could please spare 1 more minute, this is the last one, to stable/stein, the conflict is due to a trivial change not being there: https://review.opendev.org/#/c/757886/
#openstack-nova - 2020-10-17
06:22:55 openstackgerrit Merged openstack/nova master: bindep: Install python3 and python3-devel on CentOS 8 and Fedora https://review.opendev.org/755928
07:53:09 openstackgerrit Takashi Natsume proposed openstack/nova master: Add placeholder migrations for Victoria backports https://review.opendev.org/754396
07:53:36 openstackgerrit Takashi Natsume proposed openstack/nova master: Update contributor guide for Wallaby https://review.opendev.org/754427
08:27:37 admin0 hi all .. i am getting resource provider 'xxxx' not found .. i think the compute node was renamed .. the name was set back to the same as before, but this log still persists
08:28:10 admin0 i want to check if there is a way that exists that fixes this .. or is it something that is fixed from the database
09:45:25 openstackgerrit Merged openstack/nova master: Use cell targeted context to query BDMs for metadata https://review.opendev.org/752459
09:45:34 openstackgerrit Merged openstack/nova master: Clean up the DynamicVendorData constructor https://review.opendev.org/752718
09:54:24 openstackgerrit Merged openstack/nova master: compute: Lock by instance.uuid lock during swap_volume https://review.opendev.org/754695
12:02:17 openstackgerrit Merged openstack/nova stable/train: Removes the delta file once image is extracted https://review.opendev.org/748035
#openstack-nova - 2020-10-18
04:48:06 openstackgerrit Merged openstack/nova master: Prevent archiving of pci_devices records because of 'instance_uuid' https://review.opendev.org/757656
#openstack-nova - 2020-10-19
02:58:39 openstackgerrit wangzhh proposed openstack/nova master: Ignore InstanceNotFound exception when host rejoin cluster https://review.opendev.org/757053
07:27:11 bauzas good morning Nova
07:47:47 xinranwang gibi: Hi, Gibi. Could you and others please review the sriov nic support spec before PTG so we can discuss it during the meeting? https://review.opendev.org/#/c/742785/
07:48:25 xinranwang Please feel free to leave the comment if any questions or suggestions. Thank you all in advance :)
07:54:43 bauzas review day for me indeed
08:10:31 gibi xinranwang: hi! I did review it two weeks ago and left comments
08:10:47 gibi bauzas: o/
08:11:34 xinranwang gibi: oops, sorry for miss your comments. I will look into it soon. :)
08:30:20 gibi xinranwang: no worries
08:31:38 stephenfin bauzas: Seeing as I wasn't there Thursday afternoon, the suggestions was that we could use alembic for everything >= Train, allowing us to drop the unsupported/unloved sqlalchemy-migrate. However, that's a follow-up and probably needs a spec, for sure
08:32:13 stephenfin i.e. I wasn't suggesting introducing alembic as part of the compaction, just so we're clear :)
08:32:45 bauzas all good then
08:32:51 bauzas we can discuss it during next week
08:32:56 stephenfin yup
08:33:51 gibi stephenfin: I've approved the bp as per the meeting discussion
08:34:00 stephenfin gibi: Great! Thanks :)
08:34:03 gibi stephenfin: but left two comments in the bp whiteboard as requested
08:34:17 stephenfin Now to start generating schema diffs
08:34:24 gibi cool
08:34:50 gibi stephenfin: I spent some time on mypy and o.vo it is a tricky busines
08:35:10 stephenfin with the pyi approach?
08:35:13 gibi stephenfin: do you know a way to tell mypy that we have stub for a type but not for a whole file
08:35:16 gibi stephenfin: yes
08:35:31 stephenfin not off the top of my head, no
08:35:36 gibi stephenfin: for me it seems mypy handles pyi as per file :/
08:36:09 gibi so if we generate pyi for the Instance o.vo in nova then mypy will not load the py file and does not check the member functions on Instance o.vo
08:37:10 gibi so now I looking at writing a plugin for mypy using the get_class_decorator_hook triggering on the oslo register decorator
08:37:53 gibi anyhow, it is interesting enough to spend some time on it :)
08:38:36 stephenfin I guess that's kind of greenfield? :)
08:38:46 gibi totally green :D
08:39:49 gibi this is how mypy sees an ovo definition http://paste.openstack.org/show/799163/

Earlier   Later