Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-10-06
18:22:40 dansmith I'm not saying change it, because we do other stuff like it, I'm just pointing out this as an example
18:22:49 sean-k-mooney ya
18:23:03 dansmith just something to keep in mind the next time someone asks why :)
18:23:14 sean-k-mooney ah yep
18:26:52 dansmith sean-k-mooney: check my questions on that and tell me if I should be -1ing
18:28:57 sean-k-mooney looking now
18:32:38 openstackgerrit Merged openstack/nova stable/queens: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729178
18:32:47 openstackgerrit Merged openstack/nova stable/queens: Improve CinderFixtureNewAttachFlow https://review.opendev.org/749228
18:32:54 openstackgerrit Merged openstack/nova stable/queens: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/749229
18:35:50 sean-k-mooney dansmith: you can -1 i am missing the test. i dont need the host check but im not asserting we ignore and log the error in any of the tests
18:36:58 sean-k-mooney dansmith: i commented in line. is there a better way to handel the change in behavior. where im moving work that was prviously done in one api call to another?
18:37:21 sean-k-mooney its rare we do this but it sometimes happens
18:37:54 dansmith sean-k-mooney: no, I just wanted to note it, same as here
18:38:35 sean-k-mooney cool
18:41:48 sean-k-mooney hum same host resize. perhaps that is why we do that check.
18:42:07 dansmith sean-k-mooney: ... :)
18:42:18 sean-k-mooney ill chekc the call flow again when i add the unit test
18:42:24 dansmith cool
18:42:51 sean-k-mooney i think the new unplug call would be before the netowrkign is plugged for the dest
18:43:23 sean-k-mooney so i think it still works but ill make sure and either add the same check or leave a comment in the code
18:45:26 sean-k-mooney one of the side effect of when libvirt is in charge fo when libvirt is responcible for addign and removing port form ovs is
18:45:41 sean-k-mooney on same host resize it remvoe and add the port to ovs
18:45:56 sean-k-mooney even when we dont call unplug_vifs
18:46:56 sean-k-mooney e.g. if you using ovn or ovs with the ovs firewall then libvirt removes the ovs port when we destory the domain
18:47:56 sean-k-mooney plug_vif in os vif is a noop in that case. that is what the next patch changes
18:48:49 sean-k-mooney with https://review.opendev.org/#/c/602432/21 os-vif now does the plugging but i need the call to unplug_vifs eairler to have the set of events that neutron sends be the same in the same host resize case
18:51:20 openstackgerrit Navid Pustchi proposed openstack/nova-specs master: add availability-zone-affinity-anti-affinity-filter review. https://review.opendev.org/756380
18:55:30 openstackgerrit Navid Pustchi proposed openstack/nova-specs master: add availability-zone-affinity-anti-affinity-filter review. https://review.opendev.org/756380
20:44:13 rm_work can i see from the nova endpoint which version I am actually running? I assumed so? but the versions i'm seeing listed didn't change when i upgraded so i can't tell if my upgrade failed or if i'm just looking at the wrong spot
20:52:27 rm_work ok yeah nm, verified my upgrade failed :D
21:26:42 openstackgerrit Navid Pustchi proposed openstack/nova-specs master: add availability-zone-affinity-anti-affinity-filter review. https://review.opendev.org/756380
21:39:50 openstackgerrit Navid Pustchi proposed openstack/nova-specs master: add availability-zone-affinity-anti-affinity-filter review. https://review.opendev.org/756380
21:51:36 openstackgerrit melanie witt proposed openstack/nova stable/stein: Sanity check instance mapping during scheduling https://review.opendev.org/756404
21:58:07 openstackgerrit Moshe Levi proposed openstack/os-vif stable/victoria: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/756406
23:01:29 openstackgerrit Merged openstack/nova master: Add Python3 wallaby unit tests https://review.opendev.org/754322
23:10:56 openstackgerrit melanie witt proposed openstack/nova master: Initialize global data separately and run_once in WSGI app init https://review.opendev.org/733627
#openstack-nova - 2020-10-07
02:38:12 openstackgerrit Wonil Choi proposed openstack/nova stable/rocky: Set instance host and drop migration under lock https://review.opendev.org/756421
05:51:11 openstackgerrit Ade Lee proposed openstack/nova master: Replace md5 with oslo version https://review.opendev.org/756434
07:08:42 gibi good morning Nova
08:31:49 openstackgerrit Jorhson Deng proposed openstack/nova master: add task state for attach volume and detach volume https://review.opendev.org/754258
08:36:35 kashyap gibi: If you're feeling security-inclined this morning, see if my questions here make sense :-) - https://review.opendev.org/#/c/756434/
08:39:17 gibi kashyap: looking
08:39:51 kashyap It's not from me, but it's a bulk change across components so that OpenStack works in a FIPS-based setup
08:40:31 kashyap Many moons ago /me worked on testing FIPS stuff at Red Hat :)
08:40:50 kashyap (https://en.wikipedia.org/wiki/Federal_Information_Processing_Standards)
08:41:20 kashyap (A better explanation is on Mozilla's blokg: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/FIPS_Mode_-_an_explanation)
08:44:08 bauzas good morning folks
09:00:03 gibi bauzas: o/
09:00:16 gibi kashyap: got pulled sideways will get back to you soon
09:00:42 kashyap gibi: Yeah, no rush at all
09:05:07 gibi kashyap: replied in the review.
09:05:45 kashyap Yep, just saw, thanks!
09:18:15 openstackgerrit Wenping Song proposed openstack/nova master: Add instance project_id for cyborg arq https://review.opendev.org/738428
09:31:14 openstackgerrit Elod Illes proposed openstack/nova stable/pike: Don't generate service UUID for deleted services https://review.opendev.org/673833
09:34:32 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684
09:34:33 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add nova healthcheck API https://review.opendev.org/731396
11:43:38 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
11:43:50 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
11:44:03 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
11:44:16 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
11:44:30 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
11:44:54 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
11:47:25 sean-k-mooney kashyap: we will need to make sure that we maintaing backwards compatiablty with that fips change
11:47:50 sean-k-mooney mdbooth looked at adressing part of it a few cycles ago
11:48:24 sean-k-mooney there are some places where we use md5 that cant just be replaced we need a fallback to md5 if the new hash is not located
11:48:29 kashyap Right, the upgrade impact needs to be clearly spelled out.
11:50:02 sean-k-mooney hum this is a different approch
11:50:08 sean-k-mooney this is less of an issue
11:50:24 sean-k-mooney as md5 will still be used but anotated as not used for security
11:50:52 sean-k-mooney the previous attempt where jut change the hash to be a sha hash instead
12:05:20 kashyap Yes, see the usedforSecurity property
12:05:28 kashyap (So you first commented without clicking the change :D)
12:07:40 sean-k-mooney kashyap: yes to point out that this has come up before and that the previous approch would break upgrades so wanted to highlight htat any fips change need to be checked for that carfully
12:09:14 sean-k-mooney i need to reboot my laptop then do an os upgrade so im going to be offline for a bit
13:08:27 cuseinovic Hello Nova Team and others :) I have some question about nova-manage please
14:51:22 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support interface attach with qos ports https://review.opendev.org/756530
15:11:08 openstackgerrit Balazs Gibizer proposed openstack/nova-specs master: Support interface attach with qos ports https://review.opendev.org/755477
15:15:54 openstackgerrit Merged openstack/nova stable/queens: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.opendev.org/749230
15:23:13 openstackgerrit Merged openstack/nova stable/queens: compute: refactor volume bdm rollback error handling https://review.opendev.org/749231
15:23:21 openstackgerrit Merged openstack/nova stable/queens: Add regression tests for bug #1889108 https://review.opendev.org/749232
15:23:21 openstack bug 1889108 in OpenStack Compute (nova) queens "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
15:23:26 openstackgerrit Merged openstack/nova stable/queens: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749233
15:23:28 zigo https://docs.openstack.org/releasenotes/nova/unreleased.html <--- That's empty ... :/
15:23:42 zigo Can this be fixed please?
15:23:53 zigo I know another project, but can't remember which one, who had the same issue.
15:28:51 openstackgerrit Dan Smith proposed openstack/nova master: Allow blacklisting image type capabilities https://review.opendev.org/756534
15:29:32 dansmith gibi: this ^ is finishing a fixme from a previous blueprint, quite trivially.. do you want a specless blueprint for it, or is just linking to the older completed one enough?
15:52:38 openstackgerrit Dan Smith proposed openstack/nova master: Allow excluding image type capabilities https://review.opendev.org/756534
16:09:44 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Only add a USB controller if it's necessary https://review.opendev.org/756549
16:09:45 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove support for '[libvirt] use_usb_tablet' https://review.opendev.org/756550
16:09:45 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Rationalize attachment of USB tablet https://review.opendev.org/756551
16:09:46 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add support for virtio-based input devices https://review.opendev.org/756552
16:10:18 bauzas zigo: huh, that's horrible
16:10:53 bauzas I have to leave it now but I can take a look at why reno is f*** up tomorrow morning
16:11:38 bauzas my best guess is that since we branched, the current points to wallaby but we forgot to deliver a victoria page
16:11:47 bauzas this should be easy to fix
16:11:56 bauzas zigo: ^
16:14:02 bauzas mmmm, we have merged the necessary tho https://review.opendev.org/#/c/754321/
16:14:04 bauzas gibi: gmann: ^
16:14:35 bauzas lemme try to reproduce it locally

Earlier   Later