| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-17 | |||
| 15:59:44 | sean-k-mooney | stephenfin: actully the adress is 0000:00:03. its missing the function e.g. 0000:00:03.1 vs 0000:00:03. | |
| 16:00:21 | sean-k-mooney | so its proably not the formating but its likely related to that change in my patch | |
| 16:24:29 | stephenfin | sean-k-mooney, bauzas: Either of you know why we pass 'live=True' here instead of actually checking the power state of the instance as we do elsewhere? https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4396 | |
| 16:24:51 | stephenfin | for both PCI (link above) and MDEV-type devices https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7512 | |
| 16:25:46 | bauzas | looking | |
| 16:25:54 | stephenfin | Is it because we pass 'persistent=True' when attaching them, e.g. https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4425 ? | |
| 16:27:04 | sean-k-mooney | i would expect use to be consistent | |
| 16:27:28 | sean-k-mooney | git blame on github does not work on that file because its too big | |
| 16:27:49 | sean-k-mooney | we want to remove it form both the live and persistt doamin that said we dont use the persitent domain | |
| 16:28:04 | bauzas | stephenfin: "–live indicates that the operation is dynamic and will reflect in the running guest." | |
| 16:28:31 | sean-k-mooney | bauzas: right but that should be true of attach too | |
| 16:28:39 | stephenfin | So if the guest was paused or stopped, that would fail right? | |
| 16:28:43 | sean-k-mooney | https://github.com/openstack/nova/blob/f47bde539c89d1ac1fa90ea6f0d72a7e2de19532/nova/virt/libvirt/guest.py#L488 | |
| 16:28:54 | sean-k-mooney | yes | |
| 16:29:01 | stephenfin | so...bug? | |
| 16:29:09 | sean-k-mooney | although you cant detach from a paused guest | |
| 16:29:13 | sean-k-mooney | it will fail | |
| 16:29:24 | stephenfin | PCI devices or anything? | |
| 16:29:47 | sean-k-mooney | so detach will send a acpi interupt to the guest | |
| 16:29:48 | stephenfin | I guess PCI devices are different because of the whole "managed" aspect | |
| 16:29:59 | sean-k-mooney | but when its paused nothing will repond to that | |
| 16:30:03 | sean-k-mooney | so the detach shoudl fail | |
| 16:30:15 | sean-k-mooney | the same shoudl be true fo mdevs | |
| 16:30:39 | sean-k-mooney | in the pasued state the vm domain is still defined but the cpus are stopped | |
| 16:30:50 | sean-k-mooney | qemu is still running | |
| 16:30:58 | sean-k-mooney | unlike suspend | |
| 16:31:04 | stephenfin | does that also apply for e.g. block devices? | |
| 16:31:10 | sean-k-mooney | yes | |
| 16:31:25 | bauzas | you lost me, folks | |
| 16:31:37 | sean-k-mooney | we use virtio-blk which uses a pci per volume by default | |
| 16:31:50 | sean-k-mooney | so volume detaches do a pci hot unplug | |
| 16:31:58 | sean-k-mooney | so it wont work on a paused guest | |
| 16:32:20 | sean-k-mooney | im not sure about virtio-scisi but i suspect that wont work either | |
| 16:32:29 | stephenfin | bauzas: we're questioning whether the live parameter makes sense here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2247 | |
| 16:32:50 | stephenfin | or if we should be outright rejecting a request to attach/detach a device from a paused guest | |
| 16:32:54 | sean-k-mooney | stephenfin: i think we shoudl be passing both live and persisted in almsot every case | |
| 16:33:18 | sean-k-mooney | stephenfin: i dont know of any reason we would not want to update both | |
| 16:33:23 | sean-k-mooney | always | |
| 16:33:53 | sean-k-mooney | well i guess if the vm was off | |
| 16:34:03 | sean-k-mooney | but in htat case we dont need to update the domain | |
| 16:34:10 | sean-k-mooney | we will just recreated it when we start it | |
| 16:36:28 | stephenfin | okay, let me see if I can untangle this /o\ | |
| 16:43:48 | sean-k-mooney | this could explain why we are getting out of sync | |
| 16:44:08 | sean-k-mooney | there is at least one bug where the live and perstient domains get out of sync | |
| 16:44:21 | sean-k-mooney | if we are attaching with persistent and detaching with live that would do it | |
| 16:48:00 | lyarwood | sean-k-mooney: https://review.opendev.org/#/c/747123/ FYI | |
| 16:48:05 | lyarwood | sean-k-mooney: moved to the train UCA | |
| 16:57:34 | sean-k-mooney | cool if you need more testing i can try that but ill just see what the ci says first | |
| 17:00:40 | openstackgerrit | sean mooney proposed openstack/nova master: Fix unplugging VIF when migrate/resize VM https://review.opendev.org/751642 | |
| 17:00:40 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/602432 | |
| 17:01:11 | sean-k-mooney | stephenfin: gibi i have not fixed the functest failure but hopefully its simpler to figure out now that i have pushed the patches | |
| 17:01:29 | sean-k-mooney | stephenfin: ill keep debuging it locally and see if i can figure it out | |
| 17:29:23 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883 | |
| 19:00:21 | openstackgerrit | Merged openstack/nova master: api: Set min, maxItems for server_group.policies field https://review.opendev.org/752211 | |
| 19:00:31 | openstackgerrit | Merged openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247 | |
| 19:00:31 | openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | |
| 19:59:44 | openstackgerrit | Merged openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090 | |
| 20:02:22 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883 | |
| 20:02:23 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/752557 | |
| 20:04:54 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Introduce nova-evacuate https://review.opendev.org/744883 | |
| 20:04:54 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/752557 | |
| 20:24:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fakelibvirt: Use versionutils to set min versions found in the driver https://review.opendev.org/749707 | |
| 20:24:38 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/746981 | |
| 20:24:39 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | |
| 20:24:39 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | |
| 20:24:39 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | |
| 20:24:40 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | |
| 20:24:40 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | |
| 20:28:15 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747976 | |
| 20:56:16 | openstackgerrit | Merged openstack/nova stable/ussuri: Move confirm resize under semaphore https://review.opendev.org/751353 | |
| 22:55:45 | gregwork | is it possible to adjust the weight of vcpu qupotas in nova | |
| 22:56:21 | gregwork | like lets say i have a flavor that has the extra spec of cpushares 256 and is part of a cpu pinset of 4 cores | |
| 22:56:45 | gregwork | this would be a very limited amount of cpu time an instance could occupy during contention | |
| 23:35:30 | openstackgerrit | Merged openstack/nova stable/train: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747610 | |
| #openstack-nova - 2020-09-18 | |||
| 00:00:29 | openstackgerrit | Jeremy Stanley proposed openstack/nova master: DNM: Testing PDF builds https://review.opendev.org/752585 | |
| 00:34:04 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: Testing PDF builds https://review.opendev.org/752585 | |
| 07:51:22 | bauzas | good Friday Nova | |
| 08:04:25 | lyarwood | Morning \o | |
| 08:05:18 | lyarwood | sean-k-mooney / bauzas / stephenfin / gibi ; so some good news, the libvirt version bump https://review.opendev.org/#/c/746981/ works with the train UCA https://review.opendev.org/#/c/747123/ | |
| 08:05:31 | lyarwood | the only issue remaining appears to be with how the grenade jobs are deployed | |
| 08:06:04 | lyarwood | oh they are, weird | |
| 08:09:50 | lyarwood | ah right I need to backport this to stable/ussuri | |
| 08:10:18 | lyarwood | fun chicken and egg problem here | |
| 08:11:15 | kashyap | lyarwood: Mornin, I still haven't gotten to the Focal thing; was beset with a worser storm downstream, if you know what I mean :D | |
| 08:12:54 | lyarwood | np | |
| 08:14:21 | nightmare_unreal | Hello is there a glance dedicated channel ? | |
| 08:14:50 | nightmare_unreal | nvm found it | |
| 08:19:09 | gibi | lyarwood: what exactly need to be backported to ussir? | |
| 08:19:13 | gibi | ussuri | |
| 08:21:16 | lyarwood | gibi: https://review.opendev.org/#/c/752641/ I believe, do devstack uses the train UCA when deplying the stable/ussuri env during a grenade run | |
| 08:21:37 | lyarwood | that or I could hack enabling the UCA into grenade on master somehow | |
| 08:22:04 | lyarwood | so* devstack sorry | |
| 08:22:28 | gibi | hm so in ussuri the train UCA has newer libvirt than the default packages? | |
| 08:24:00 | lyarwood | yes correct | |
| 08:24:39 | lyarwood | the train UCA has the new MIN_{LIBVIRT,QEMU}_VERSIONs we are looking to set in the current bump on master | |
| 08:24:59 | lyarwood | as well | |
| 08:26:24 | gibi | this means that we now change what libvirt version we use for testing the upgrade from ussuri | |
| 08:36:22 | lyarwood | gibi: we would also change the version of libvirt installed when testing stable/ussuri as a whole | |
| 08:36:39 | lyarwood | gibi: but tbh I don't think anyone is actually using the default versions installed in bionic | |
| 08:38:59 | bauzas | sorry I was focusing on some downstream bugs | |