| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-16 | |||
| 13:32:19 | sean-k-mooney | gibi one sec ill take a look | |
| 13:32:24 | stephenfin | there's a config option that we use to set the logging level for e.g. oslo.log | |
| 13:33:32 | sean-k-mooney | gibi that is because we swapped the default backend | |
| 13:33:34 | bauzas | sean-k-mooney: looks to me a feature https://bugs.launchpad.net/nova/+bug/1887377 | |
| 13:33:34 | openstack | Launchpad bug 1887377 in OpenStack Compute (nova) "nova does not loadbalance asignmnet of resources on a host based on avaiablity of pci device, hugepages or pcpus." [Undecided,New] - Assigned to sean mooney (sean-k-mooney) | |
| 13:33:46 | sean-k-mooney | os vif now uses the native backend | |
| 13:33:51 | bauzas | sean-k-mooney: because it could be a weigher or using the placement API | |
| 13:33:54 | sean-k-mooney | instead of ovs-vsctl | |
| 13:34:07 | stephenfin | definitely a feature | |
| 13:34:10 | sean-k-mooney | gibi: i can install a log filter for that if you like and drop it | |
| 13:34:31 | stephenfin | sean-k-mooney: again, there's already a conf option for this in nova | |
| 13:34:35 | stephenfin | that oslo.log provides | |
| 13:34:44 | sean-k-mooney | bauzas: its one that i want to backport downstream and do as a preqquist to numa in placment | |
| 13:34:55 | stephenfin | I just can't remember what it's called and quick grep doesn't return anything, heh | |
| 13:35:02 | sean-k-mooney | bauzas: i would prefer to backport it upstream too but if we agree it a feature then fine | |
| 13:35:21 | sean-k-mooney | i guess its something we could not bring back but its broderlien in my view | |
| 13:36:03 | bauzas | sean-k-mooney: well, it would change the behaviour then, right? | |
| 13:36:13 | bauzas | at least if you modify the default | |
| 13:36:27 | sean-k-mooney | loadbalancing between the numa nodes on the host | |
| 13:36:31 | bauzas | surely | |
| 13:36:43 | sean-k-mooney | it would slightly yes | |
| 13:36:49 | bauzas | but operators already know about it, | |
| 13:36:55 | bauzas | so they know it's packing atm | |
| 13:37:14 | sean-k-mooney | they know that if they are using numa they should match teh numer of numa nodes that are on the host | |
| 13:37:20 | sean-k-mooney | but they often dont do that | |
| 13:37:23 | bauzas | if we change the default to rather spreading, then this would change their own capacity | |
| 13:37:24 | gibi | stephenfin: https://docs.openstack.org/oslo.log/latest/configuration/index.html#DEFAULT.default_log_levels | |
| 13:37:33 | gibi | I think this is the config | |
| 13:37:35 | stephenfin | that's the one \o/ | |
| 13:37:43 | bauzas | sean-k-mooney: for this reason, I don't want it to be a bug | |
| 13:37:52 | sean-k-mooney | bauzas: it will pesimise the spawnign of large vms | |
| 13:37:54 | stephenfin | yes, we overload that in 'nova/config.py' | |
| 13:38:02 | sean-k-mooney | but it would fix many other issues | |
| 13:38:04 | bauzas | and fwiw, everytime we added a new filter or weigher, we said "noooo sorry, not a bug" | |
| 13:38:16 | bauzas | this would be the same | |
| 13:38:19 | sean-k-mooney | bauzas: its not a new filter or weigher | |
| 13:38:22 | bauzas | I know | |
| 13:38:48 | bauzas | but spreading/packing resources are related to a weigher, even not that's the implementation way | |
| 13:39:01 | sean-k-mooney | ok well then ill close the downstrema bz and say this wont be fixed in 16.x then | |
| 13:39:01 | gibi | stephenfin, sean-k-mooney: I will add an extra log settings for the periodic ovs debug log in https://docs.openstack.org/oslo.log/latest/configuration/index.html#DEFAULT.default_log_levels | |
| 13:39:06 | bauzas | ie. you want to change how to organize the resources | |
| 13:39:14 | bauzas | for this reason, not a bug | |
| 13:39:15 | gibi | I mean in nova.config.parse_args | |
| 13:39:20 | sean-k-mooney | gibi: you could or i coudl do it in os-vif | |
| 13:39:26 | sean-k-mooney | i think os-vif makes more sense | |
| 13:39:36 | sean-k-mooney | gibi: this is coming form the ovs plugin | |
| 13:39:38 | gibi | yeah, you are right os-vif is a better place | |
| 13:39:49 | gmann | gibi: stephenfin brinzhang_ ok for me, +A on 500->400. | |
| 13:39:59 | sean-k-mooney | it woudl still be configrev via the nova.conf jsut form a os vif config section | |
| 13:40:00 | gibi | gmann: thanks | |
| 13:40:05 | sean-k-mooney | so the ux is more or less the same | |
| 13:40:09 | gmann | gibi: is it ocata is 'Unmaintained' for nova? we only need backport till pike? | |
| 13:40:16 | gmann | lyarwood: ^^ | |
| 13:40:18 | bauzas | gmann: gibi: stephenfin: are we discussing on the API issue we saw yesterday ? | |
| 13:40:33 | gmann | bauzas: yeah, server group with empty 'policies' | |
| 13:40:36 | bauzas | if so, there are some docs for telling whether we need to have a new microversion or not | |
| 13:40:40 | gibi | bauzas: it is about the server group policies being an empty list before 2.63 | |
| 13:40:40 | sean-k-mooney | bauzas: leave a comment on the loadbalancing bug and ill convert it to a blueprint/spec | |
| 13:40:58 | bauzas | gibi: and afaict, 500 being changed 400 is told "nooope, that's a bug" | |
| 13:40:58 | gmann | bauzas: yeah this one we do not need microversion bump for 500->400 - https://docs.openstack.org/nova/pike/contributor/microversions.html#id2 | |
| 13:41:11 | bauzas | hence not a microversion required | |
| 13:41:16 | gmann | yeah | |
| 13:41:19 | gibi | yeah | |
| 13:41:20 | bauzas | and you can backport | |
| 13:41:28 | stephenfin | Cool, that's my understanding too. Glad we all agree | |
| 13:41:36 | bauzas | sean-k-mooney: just did, closed at Invalid/Wishlist | |
| 13:41:50 | stephenfin | The API telling you did a naughty thing >>> having to read docs to figure it out | |
| 13:41:55 | gibi | gmann: I think ocata is still open in EM | |
| 13:42:01 | gmann | it is documented also if new error code is from already returned error codethen no microversion needed - https://docs.openstack.org/nova/pike/contributor/microversions.html#id2 | |
| 13:42:20 | gmann | stephenfin: your base patch for adding test failing, did not check why | |
| 13:42:27 | bauzas | gmann: stephenfin: gibi: https://docs.openstack.org/nova/latest/contributor/microversions.html#when-do-i-need-a-new-microversion | |
| 13:42:32 | stephenfin | gmann: Any chance you could swing by https://review.opendev.org/#/c/745906/ and the other two patches in the series again today so we can finally close that out? It went into merge conflict yet again :( | |
| 13:42:36 | bauzas | "Fixing a bug so that a 400+ code is returned rather than a 500 or 503 does not require a microversion change." | |
| 13:42:45 | gmann | gibi: i think no as CI is broken there and not fixable due to stests issue. | |
| 13:42:48 | stephenfin | I'd say PyPI issues | |
| 13:42:58 | gmann | i see. got it | |
| 13:43:03 | gibi | gmann: I still see the branch exists in https://opendev.org/openstack/nova/ | |
| 13:43:06 | bauzas | gibi: stephenfin: gmann: any change I could look ? | |
| 13:43:15 | stephenfin | bauzas: https://review.opendev.org/#/c/752211/1 | |
| 13:43:24 | bauzas | ta | |
| 13:43:29 | gibi | bauzas: yeah stephenfin has some ^^ | |
| 13:43:41 | bauzas | hah, the ship has sailed :) | |
| 13:43:47 | stephenfin | https://review.opendev.org/#/c/752210/ is still open though | |
| 13:43:52 | gmann | gibi: yeah that should be removed once it move to EOL after 6 month from being marked as 'unmaintained' let me check email | |
| 13:43:54 | stephenfin | gmann: Yeah, pypi mirror issues :( | |
| 13:44:09 | gibi | gmann: ohh, I see. the it could be unmaintained | |
| 13:44:15 | gibi | gmann: I forgot we have such state | |
| 13:44:58 | gibi | sean-k-mooney: so let's add the default log change to os-vif. Will you push a patch? | |
| 13:45:16 | bauzas | stephenfin: the gate is borked, nope ? | |
| 13:45:28 | stephenfin | on and off | |
| 13:45:41 | stephenfin | I guess it depends on the node you land on or something | |
| 13:45:53 | stephenfin | given one patch failed badly and the next one passed just fine | |
| 13:46:45 | sean-k-mooney | gibi: ya im fixing some unit test on a nova bug but ill push the os-vif patch this evening. if you feel like doing it jut add me as an a review | |
| 13:47:00 | sean-k-mooney | we can priorties the backport | |
| 13:47:06 | gibi | sean-k-mooney: no rush, I let you do it and I wil review it when its up | |
| 13:47:08 | gibi | sean-k-mooney: thanks | |
| 13:47:12 | gmann | gibi: this declared ocata as unmaintained and EOL after 3 month http://lists.openstack.org/pipermail/openstack-discuss/2020-July/015747.html http://lists.openstack.org/pipermail/openstack-discuss/2020-July/015744.html | |
| 13:47:16 | sean-k-mooney | cool ill add you to the review | |
| 13:47:21 | gibi | sean-k-mooney: thanks | |
| 13:47:35 | mgoddard | Hi. I'm hitting an issue with encrypted volumes and migration/evacuation. Raised a bug about it: https://bugs.launchpad.net/nova/+bug/1895848 | |