Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-09-15
15:40:04 gmann if we decide to fix in older microversion then we can only fix the error code from 500->400. I feel we should ask to use new microversion.
15:42:42 openstackgerrit Federico Ressi proposed openstack/nova master: Requires default python3-devel package on CentOS https://review.opendev.org/752073
16:29:38 ganso Hi Nova folks! If anyone could please take one last look at https://review.opendev.org/#/c/748533/ it already has +2 and +1 (thanks stephenfin and sean-k-mooney!)
16:34:28 sean-k-mooney oh yes :) gibi i think is done for the day. bauzas maybe you can take a look its libvirt/networking related but its relivitly simple to review
16:34:56 openstackgerrit Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652
18:31:30 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090
#openstack-nova - 2020-09-16
00:24:30 brinzhang0 gmann: agree with you, allowing to request array([]) of the policy is itself an error, improve the error code from 500 to 400, it's good for me
00:33:49 brinzhang0 gmann, gibi, bauzas: Looks like it's a small change, and it's happened in microversion 2.1~2.63,
00:35:04 gmann brinzhang0: as it is already fixed in 2.64, my suggestion is that there is no much benefits to improve error code for older microversion.
00:36:22 brinzhang0 gmann: yeah, but improve it's error code seems friendly to end users
00:37:29 brinzhang0 but as you said, in the privous release, add new microversion is no much benefits
00:38:02 gmann it does not need microversion bump as it is error code improvement to existing error code only.
00:38:04 brinzhang0 how about add a NOTE or WARNING in the request api docs?
00:38:52 gmann yeah, that can be good. saying not to pass 'policies' as empty array.
00:39:02 brinzhang0 yes
00:40:00 brinzhang0 it's better than to improve the error from 500 to 400, after all it's in old release
00:41:40 gmann if you can push the doc change, i am good on that.
00:42:20 brinzhang0 gmann: it's my pleasure, later will do..
00:42:35 gmann brinzhang0: thanks
00:42:42 brinzhang0 np
01:33:20 openstackgerrit Brin Zhang proposed openstack/nova master: Add warning to os-server-groups POST api https://review.opendev.org/752133
01:34:17 brinzhang0 gmann: done by https://review.opendev.org/#/c/752133/
06:32:32 openstackgerrit wu.chunyang proposed openstack/nova master: remove python warnning from tox https://review.opendev.org/752190
06:50:13 gibi gmann: regarding https://bugs.launchpad.net/nova/+bug/1894966 I would only fix the error code to 500 -> 400 by enhancing the request validation
06:50:13 openstack Launchpad bug 1894966 in OpenStack Compute (nova) "Create servergroup failed with unexpected error" [Low,In progress] - Assigned to Brin Zhang (zhangbailin)
08:07:16 brinzhang_ gibi, gmann: I think that fix or the docs need to backport to the privous release, right?
08:07:31 gibi brinzhang_: yes that is good to be backported
08:07:44 gibi it is broken since the begining of time I guess
08:07:54 brinzhang_ yes
08:08:03 brinzhang_ so that we should target the bug to the stable branch
08:08:36 gibi yes please
08:08:46 brinzhang_ from v2.1, it's wrong
08:10:18 brinzhang_ gibi: bug 1894966 was backport to ocata, I think it's enough, please check
08:10:18 openstack bug 1894966 in OpenStack Compute (nova) "Create servergroup failed with unexpected error" [Low,In progress] https://launchpad.net/bugs/1894966 - Assigned to Brin Zhang (zhangbailin)
08:25:01 gibi brinzhang_: sure, it is OK. older than ocata branches are already marked end of life and deleted
08:25:27 brinzhang_ gibi: ack
08:28:50 nightmare_unreal I am writing a testcase for live_migration_abort feature but I keep getting this <module 'novaclient.v2.server_migrations' from '.tox/py38/lib/python3.8/site-packages/novaclient/v2/server_migrations.py'> does not have the attribute 'live_migration_abort'
08:28:55 nightmare_unreal any suggestions
08:29:05 nightmare_unreal it does exists that method
08:31:22 lyarwood nightmare_unreal: are you using the correct microversion in the test
08:31:52 nightmare_unreal i am using v2.79 I think minimum required is 2.24
08:32:16 nightmare_unreal https://www.irccloud.com/pastebin/t91I0E9V/abort%20test%20case
08:32:26 nightmare_unreal here I am doing something like this
08:33:42 lyarwood https://github.com/openstack/python-novaclient/blob/d3d88c29cb7b65f6c2a66405b0aa2e3306d7d3ea/novaclient/tests/unit/v2/test_server_migrations.py#L85-L92 looks there's already a test FWIW
08:40:53 nightmare_unreal ah it's for the osc-client
08:41:00 nightmare_unreal i am trying to bring this feature to osc
08:43:51 lyarwood nightmare_unreal: kk, I don;t work on osc but shouldn't you just wire up an actual request to abort the migration instead of calling python-novaclient?
08:44:16 lyarwood that reminds me I wanted to wire up evacuate in osc as well
08:45:23 nightmare_unreal hmm , but in the existing code there is already novaclient-object so it's essentially novaclient_obj.server_migrations.live_migration_abort(s, m)
08:45:32 nightmare_unreal but I will think around it :) . Thanks
08:47:39 lyarwood ignore me if there's code already calling it
09:00:20 kashyap nightmare_unreal: Reading your IRC nick may or may not induce stress in some people :D I love it, though
09:01:50 nightmare_unreal thanks kashyap , I had few comments on my IRC few times ( mostly positive) . I was young(still young) and loved games, anime
09:01:58 nightmare_unreal so I love that nick and using it
09:02:22 kashyap Haha, nod.
09:02:53 kashyap nightmare_unreal: It's particuarly _apt_ given the times ;-)
09:03:11 nightmare_unreal haha true :D
09:40:14 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883
09:51:15 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883
09:56:30 openstackgerrit Merged openstack/nova master: Allow tap interface with multiqueue https://review.opendev.org/748533
10:04:24 brinzhang_ stephenfin: about https://review.opendev.org/#/c/752133/1, you mean, we should change 500 to 400?
10:04:29 stephenfin yes
10:04:34 stephenfin gimme a sec, I have a patch
10:04:48 brinzhang_ yeah
10:14:29 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add regression test for bug 1894966 https://review.opendev.org/752210
10:14:29 openstack bug 1894966 in OpenStack Compute (nova) "Create servergroup failed with unexpected error" [Low,In progress] https://launchpad.net/bugs/1894966 - Assigned to Brin Zhang (zhangbailin)
10:14:29 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Set min, maxItems for server_group.policies field https://review.opendev.org/752211
10:14:35 stephenfin brinzhang_: gibi: ^
10:14:46 stephenfin That approach makes more sense to me, at least
10:16:34 gibi stephenfin: as I stated above I'm OK with both way, just documenting, or changing the return code to 400. gmann felt it is better just to document it
10:18:04 gibi gmann: ^^
10:18:50 stephenfin I consider this a better form of documentation
10:19:27 stephenfin In that the API will tell the user what they did wrong, as opposed to yielding some cryptic error that they must go Google for
10:19:31 stephenfin My 2c :)
10:19:48 gibi make sense
10:19:58 gibi I added gmann to the review
10:20:37 brinzhang_ it's ok, is it need to docs that the changes of this API?
10:22:36 brinzhang_ This may break the user's perception of existing create server_group API.
10:22:53 brinzhang_ but it's ok for me too.
10:30:05 stephenfin brinzhang_: Resolving a HTTP 5xx error does not require a microversion
10:30:25 stephenfin The idea being that a user shouldn't have to opt-in to non-broken behaviour
10:32:01 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906
10:32:01 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907
10:32:02 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908
10:32:18 stephenfin bauzas: Fixed the failing test in that first patch ^
10:32:36 sean-k-mooney its the scond branch in the flow chard https://docs.openstack.org/nova/pike/contributor/microversions.html
10:32:40 brinzhang_ stephenfin: I know, which way is ok forme
10:32:42 stephenfin I'm eager to get it merged because things keep changing under my feet /o\
10:32:43 bauzas stephenfin: will look at those later today
10:32:48 bauzas did a bug scrub
10:32:50 stephenfin thanks
10:34:28 brinzhang_ From the requirements of the manual, changing the API response requires adding microversion
10:34:57 gibi bauzas: can I take the bug lock?
10:35:01 gibi thanks for scrubbing
10:38:59 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'Migration' https://review.opendev.org/723572
10:39:00 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'InstancePCIRequest' https://review.opendev.org/723573
11:47:17 nightmare_unreal what can be the cause of tempest failures ? is it related to user patch or infrastructure/zuul issue ?
11:50:21 sean-k-mooney nightmare_unreal: both
11:50:35 sean-k-mooney normlly user patches
11:50:44 sean-k-mooney the jobs can fail for infra reasons

Earlier   Later